File: test_commandline.py

package info (click to toggle)
gromacs 2026~rc-1
  • links: PTS, VCS
  • area: main
  • in suites: experimental
  • size: 274,216 kB
  • sloc: xml: 3,831,143; cpp: 686,111; ansic: 75,300; python: 21,171; sh: 3,553; perl: 2,246; yacc: 644; fortran: 397; lisp: 265; makefile: 174; lex: 125; awk: 68; csh: 39
file content (415 lines) | stat: -rw-r--r-- 15,420 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
#
# This file is part of the GROMACS molecular simulation package.
#
# Copyright 2019- The GROMACS Authors
# and the project initiators Erik Lindahl, Berk Hess and David van der Spoel.
# Consult the AUTHORS/COPYING files and https://www.gromacs.org for details.
#
# GROMACS is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public License
# as published by the Free Software Foundation; either version 2.1
# of the License, or (at your option) any later version.
#
# GROMACS is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with GROMACS; if not, see
# https://www.gnu.org/licenses, or write to the Free Software Foundation,
# Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA.
#
# If you want to redistribute modifications to GROMACS, please
# consider that scientific software is very special. Version
# control is crucial - bugs must be traceable. We will be happy to
# consider code for inclusion in the official distribution, but
# derived work must not be called official GROMACS. Details are found
# in the README & COPYING files - if they are missing, get the
# official version at https://www.gromacs.org.
#
# To help us fund GROMACS development, we humbly ask that you cite
# the research papers on the package. Check out https://www.gromacs.org.

"""Tests for dynamically defined operations.

Test the command-line wrapping functionality in gmxapi.commandline. These
operation factories are written with user-facing tools and exercise a lot of
the high-level machinery of the package, effectively serving as integration
tests of the operation-building utilities in the modules depended on by
commandline.py.
"""
import logging
import os
import shutil
import stat
import tempfile
from pathlib import Path

import pytest

import gmxapi as gmx
import gmxapi.operation
from gmxapi import commandline
from gmxapi.testsupport import scoped_chdir

try:
    from mpi4py import MPI

    comm = MPI.COMM_WORLD
    rank_number = comm.Get_rank()
    comm_size = comm.Get_size()
except ImportError:
    comm = None
    rank_number = 0
    comm_size = 1
    rank_tag = ""
    MPI = None
else:
    rank_tag = "rank{}:".format(rank_number)


# if rank_number == 1:
#     import pydevd_pycharm
#     pydevd_pycharm.settrace('localhost', port=12345, stdoutToServer=True, stderrToServer=True)


def test_true_base(cleandir):
    """Test a command known to produce a return code of 0."""
    work_dir = cleandir
    if comm_size > 1:
        work_dir = comm.bcast(work_dir, root=0)
    with scoped_chdir(work_dir):
        command = shutil.which("true")
        kwargs = dict(command=[command], shell=False)
        if gmx.version.api_is_at_least(0, 4):
            kwargs["env"] = dict(os.environ)
        operation = commandline.cli(**kwargs)

        # Note: getitem not implemented.
        # assert 'stdout' in operation.output
        # assert 'stderr' in operation.output
        assert hasattr(operation.output, "stdout")
        assert hasattr(operation.output, "stderr")
        assert not hasattr(operation.output, "erroroutput")
        assert hasattr(operation.output, "returncode")

        operation.run()
        # assert operation.output.returncode.result() == 0
        assert operation.output.returncode.result() == 0


def test_false_explicit(cleandir):
    """Test a command known to produce a return code of 1."""
    command = shutil.which("false")
    kwargs = dict(command=[command], shell=False)
    if gmx.version.api_is_at_least(0, 4):
        kwargs["env"] = dict(os.environ)
    operation = commandline.cli(**kwargs)  # Explicitly run the operation.
    operation.run()
    assert operation.output.returncode.result() == 1


def test_false_implicit(cleandir):
    command = shutil.which("false")
    kwargs = dict(command=[command], shell=False)
    if gmx.version.api_is_at_least(0, 4):
        kwargs["env"] = dict(os.environ)
    operation = commandline.cli(**kwargs)
    # Allow the operation to be executed implicitly to satisfy data constraint.
    assert operation.output.returncode.result() == 1


def test_command_with_arguments(cleandir):
    """Test that cli() can wrap a command with arguments."""
    kwargs = dict(command=[shutil.which("echo"), "hi", "there"], shell=False)
    if gmx.version.api_is_at_least(0, 4):
        kwargs["env"] = dict(os.environ)
    operation = commandline.cli(**kwargs)
    assert operation.output.returncode.result() == 0


def test_command_with_input_files(cleandir):
    """Test handling of *input_file* arguments.

    Generate a file and provide it as a relative path to a simple command line tool.
    Confirm that the relative path (valid for the script working directory but not
    for the Task working directory) is correctly normalized to an absolute path.

    Check for #4827 regression.
    """
    with tempfile.NamedTemporaryFile(mode="w", delete=False) as fh:
        fh.write("hi\nthere\n")
        fh.flush()
    assert fh.closed
    actual_path = Path(fh.name).resolve()
    try:
        with open(actual_path, "r") as fh:
            num_lines = len(fh.readlines())
        relative_path = os.path.relpath(actual_path, start=cleandir)
        # Overload the input files facility to trigger path normalization.
        # `wc` implementations are fairly consistent as far as providing a
        # `-l` option and accepting a positional file argument.
        cmd = commandline.commandline_operation(
            executable="wc", input_files={"-l": relative_path}
        )
        # We want to find a relative path from the current directory that would
        # not resolve correctly from the generated Task directory. We will now
        # double-check that the relative path _would have_ caused the test to fail
        # if the absolute path conversion (#4827) were not working correctly.
        workdir = cmd.output.directory.result()
        assert not Path(workdir).joinpath(relative_path).exists()
        # Uncomment the following for additional debugging.
        # actual_relative_path = os.path.relpath(actual_path, start=workdir)
        # returncode = cmd.output.returncode.result()
        # error = cmd.output.stderr.result()

        # Check that the file whose lines we counted has the expected number of lines.
        output = cmd.output.stdout.result()
        # For `wc -l filename` on a 2-line file, we expect output
        # similar to "      2 filename\n".
        # Check the first non-whitespace field.
        assert output.split()[0] == str(num_lines)
    finally:
        os.unlink(actual_path)


def test_command_with_stdin(cleandir):
    """Test that cli() can handle string input."""
    stdin = "hi\nthere\n"
    subcommand = "{wc} -l | {grep} -q 2".format(
        wc=shutil.which("wc"), grep=shutil.which("grep")
    )

    kwargs = dict(command=["/bin/sh", "-c", subcommand], shell=False, stdin=stdin)
    if gmx.version.api_is_at_least(0, 4):
        kwargs["env"] = dict(os.environ)
    operation = commandline.cli(**kwargs)
    assert operation.output.returncode.result() == 0
    operation = commandline.commandline_operation(
        "/bin/sh", ["-c", subcommand], stdin=stdin
    )
    assert operation.output.returncode.result() == 0

    subcommand = "{wc} -l | {grep} -q 1".format(
        wc=shutil.which("wc"), grep=shutil.which("grep")
    )

    kwargs = dict(command=["/bin/sh", "-c", subcommand], shell=False, stdin=stdin)
    if gmx.version.api_is_at_least(0, 4):
        kwargs["env"] = dict(os.environ)
    operation = commandline.cli(**kwargs)
    assert operation.output.returncode.result() != 0
    operation = commandline.commandline_operation(
        "/bin/sh", ["-c", subcommand], stdin=stdin
    )
    assert operation.output.returncode.result() != 0


def test_true(cleandir):
    operation = commandline.commandline_operation(executable="true")
    # Note: getitem not implemented.
    # assert 'stdout' in operation.output
    # assert 'stderr' in operation.output
    assert not hasattr(operation.output, "erroroutput")
    assert hasattr(operation.output, "file")
    assert hasattr(operation.output, "stdout")
    assert hasattr(operation.output, "stderr")
    assert hasattr(operation.output, "returncode")
    assert operation.output.returncode.result() == 0


def test_false(cleandir):
    operation = commandline.commandline_operation(executable="false")
    assert operation.output.returncode.result() == 1


def test_echo(cleandir):
    operation = commandline.commandline_operation(
        executable="echo", arguments=["hi there"]
    )
    assert operation.output.stdout.result() == "hi there\n"
    assert operation.output.returncode.result() == 0


def test_file_dependency_chain(cleandir):
    """Test the command line wrapper input/output file handling.

    Operation output can be used as operation input.
    """
    file1 = os.path.join(cleandir, "input")
    file2 = os.path.join(cleandir, "output")

    # Make a shell script that acts like the type of tool we are wrapping.
    scriptname = os.path.join(cleandir, "clicommand.sh")
    with open(scriptname, "w") as fh:
        fh.write(
            "\n".join(
                [
                    "#!" + shutil.which("bash"),
                    "# Concatenate an input file and a string argument to an output file.",
                    "# Mock a utility with the tested syntax.",
                    '#     clicommand.sh "some words" -i inputfile -o outputfile',
                    "echo $1 | cat $3 - > $5\n",
                ]
            )
        )
    os.chmod(scriptname, stat.S_IRWXU)

    line1 = "first line"
    filewriter1 = gmx.commandline_operation(
        scriptname,
        arguments=[line1],
        input_files={"-i": os.devnull},
        output_files={"-o": file1},
    )
    assert isinstance(filewriter1.output, gmxapi.operation.DataProxyBase)
    assert filewriter1.output.ensemble_width == 1

    line2 = "second line"
    filewriter2 = gmx.commandline_operation(
        scriptname,
        arguments=[line2],
        input_files={"-i": filewriter1.output.file["-o"]},
        output_files={"-o": file2},
    )

    filewriter2.run()
    # Check that the files have the expected lines
    with open(filewriter1.output.file["-o"].result(), "r") as fh:
        lines = [text.rstrip() for text in fh]
    assert len(lines) == 1
    assert lines[0] == line1
    with open(filewriter2.output.file["-o"].result(), "r") as fh:
        lines = [text.rstrip() for text in fh]
    assert len(lines) == 2
    assert lines[0] == line1
    assert lines[1] == line2

    # Make sure that the temporary directory is not removed before all ranks have done
    # the file checks.
    if comm_size > 1:
        comm.barrier()


def test_file_dependency_ensemble_chain(cleandir):
    """Test the command line wrapper input/output file handling.

    Operation output can be used as operation input.
    """
    file1 = (os.path.join(cleandir, "input1"), os.path.join(cleandir, "input2"))
    file2 = "output"

    # Make a shell script that acts like the type of tool we are wrapping.
    scriptname = os.path.join(cleandir, "clicommand.sh")
    with open(scriptname, "w") as fh:
        fh.write(
            "\n".join(
                [
                    "#!" + shutil.which("bash"),
                    "# Concatenate an input file and a string argument to an output file.",
                    "# Mock a utility with the tested syntax.",
                    '#     clicommand.sh "some words" -i inputfile -o outputfile',
                    "echo $1 | cat $3 - > $5\n",
                ]
            )
        )
    os.chmod(scriptname, stat.S_IRWXU)

    line1 = ["first line A", "first line B"]
    filewriter1 = gmx.commandline_operation(
        scriptname,
        arguments=[[line] for line in line1],
        input_files={"-i": os.devnull},
        output_files=[{"-o": name} for name in file1],
    )
    assert isinstance(filewriter1.output, gmxapi.operation.DataProxyBase)
    assert filewriter1.output.ensemble_width == 2

    line2 = "second line"
    filewriter2 = gmx.commandline_operation(
        scriptname,
        arguments=[line2],
        input_files={"-i": filewriter1.output.file["-o"]},
        output_files={"-o": file2},
    )
    assert filewriter2.output.ensemble_width == 2
    filewriter2.run()

    # Check that the files have the expected lines
    for member in range(2):
        with open(filewriter1.output.file["-o"].result()[member], "r") as fh:
            lines = [text.rstrip() for text in fh]
        assert len(lines) == 1
        assert lines[0] == line1[member]

    outputs = filewriter2.output.file["-o"].result()
    assert len(outputs) == 2
    assert outputs[0] != outputs[1]
    for member in range(2):
        path = outputs[member]
        assert os.path.exists(path)
        with open(path, "r") as fh:
            lines = [text.rstrip() for text in fh]
            assert len(lines) == 2
            assert lines[0] == line1[member]
            assert lines[1] == line2
    # Make sure that the temporary directory is not removed before all ranks have done
    # the file checks.
    if comm_size > 1:
        comm.barrier()


def test_failure(cleandir):
    """The operation should not deliver file output if the subprocess fails."""
    file1 = os.path.join(cleandir, "input")
    file2 = os.path.join(cleandir, "output")

    # Make a shell script that acts like the type of tool we are wrapping.
    scriptname = os.path.join(cleandir, "clicommand.sh")
    with open(scriptname, "w") as fh:
        fh.write(
            "\n".join(
                [
                    "#!" + shutil.which("bash"),
                    "# Concatenate an input file and a string argument to an output file.",
                    "# Mock a utility with the tested syntax.",
                    '#     clicommand.sh "some words" -i inputfile -o outputfile',
                    "exit 1\n",
                ]
            )
        )
    os.chmod(scriptname, stat.S_IRWXU)

    filewriter1 = gmx.commandline_operation(
        scriptname, input_files={"-i": os.devnull}, output_files={"-o": file1}
    )

    filewriter2 = gmx.commandline_operation(
        scriptname,
        input_files={"-i": filewriter1.output.file["-o"]},
        output_files={"-o": file2},
    )

    with pytest.warns(UserWarning, match=r"Trouble getting .*"):
        # We expect this to generate errors, warnings, and log messages.
        # We assert the exception and warning, and suppress the logged error
        # to avoid misleading output from the test suite.

        class _Filter(logging.Filter):
            def filter(self, record: logging.LogRecord):
                if (
                    record.name == "gmxapi.operation"
                    and "Trouble getting" in record.msg
                ):
                    return 0
                else:
                    return 1

        _filter = _Filter()
        logging.getLogger("gmxapi.operation").addFilter(_filter)

        with pytest.raises(KeyError):
            filewriter2.run()

        logging.getLogger("gmxapi.operation").removeFilter(_filter)