1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446
|
/*
* Copyright (C) 2006 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.inject;
import static com.google.common.base.StandardSystemProperty.JAVA_SPECIFICATION_VERSION;
import static com.google.common.truth.Truth.assertThat;
import com.google.common.collect.Iterables;
import com.google.inject.internal.Annotations;
import com.google.inject.name.Names;
import com.google.inject.spi.Message;
import java.net.InetAddress;
import java.util.List;
import junit.framework.TestCase;
/** @author crazybob@google.com (Bob Lee) */
public class ImplicitBindingTest extends TestCase {
public void testCircularDependency() throws CreationException {
Injector injector = Guice.createInjector();
Foo foo = injector.getInstance(Foo.class);
assertSame(foo, foo.bar.foo);
}
static class Foo {
@Inject Bar bar;
}
static class Bar {
final Foo foo;
@Inject
public Bar(Foo foo) {
this.foo = foo;
}
}
public void testDefaultImplementation() {
Injector injector = Guice.createInjector();
I i = injector.getInstance(I.class);
i.go();
}
@ImplementedBy(IImpl.class)
interface I {
void go();
}
static class IImpl implements I {
@Override
public void go() {}
}
static class AlternateImpl implements I {
@Override
public void go() {}
}
public void testDefaultProvider() {
Injector injector = Guice.createInjector();
Provided provided = injector.getInstance(Provided.class);
provided.go();
}
public void testBindingOverridesImplementedBy() {
Injector injector =
Guice.createInjector(
new AbstractModule() {
@Override
protected void configure() {
bind(I.class).to(AlternateImpl.class);
}
});
assertEquals(AlternateImpl.class, injector.getInstance(I.class).getClass());
}
@ProvidedBy(ProvidedProvider.class)
interface Provided {
void go();
}
public void testNoImplicitBindingIsCreatedForAnnotatedKeys() {
try {
Guice.createInjector().getInstance(Key.get(I.class, Names.named("i")));
fail();
} catch (ConfigurationException expected) {
Asserts.assertContains(
expected.getMessage(),
String.format(
"No implementation for ImplicitBindingTest$I annotated with @Named(%s) was"
+ " bound.",
Annotations.memberValueString("value", "i")));
}
}
static class ProvidedProvider implements Provider<Provided> {
@Override
public Provided get() {
return new Provided() {
@Override
public void go() {}
};
}
}
/**
* When we're building the binding for A, we temporarily insert that binding to support circular
* dependencies. And so we can successfully create a binding for B. But later, when the binding
* for A ultimately fails, we need to clean up the dependent binding for B.
*
* <p>The test loops through linked bindings & bindings with constructor & member injections, to
* make sure that all are cleaned up and traversed. It also makes sure we don't touch explicit
* bindings.
*/
public void testCircularJitBindingsLeaveNoResidue() {
Injector injector =
Guice.createInjector(
new AbstractModule() {
@Override
protected void configure() {
bind(Valid.class);
bind(Valid2.class);
}
});
// Capture good bindings.
Binding<Valid> v1 = injector.getBinding(Valid.class);
Binding<Valid2> v2 = injector.getBinding(Valid2.class);
Binding<JitValid> jv1 = injector.getBinding(JitValid.class);
Binding<JitValid2> jv2 = injector.getBinding(JitValid2.class);
// Then validate that a whole series of invalid bindings are erased.
assertFailure(injector, Invalid.class);
assertFailure(injector, InvalidLinked.class);
assertFailure(injector, InvalidLinkedImpl.class);
assertFailure(injector, InvalidLinked2.class);
assertFailure(injector, InvalidLinked2Impl.class);
assertFailure(injector, InvalidProvidedBy.class);
assertFailure(injector, InvalidProvidedByProvider.class);
assertFailure(injector, InvalidProvidedBy2.class);
assertFailure(injector, InvalidProvidedBy2Provider.class);
assertFailure(injector, Invalid2.class);
// Validate we didn't do anything to the valid explicit bindings.
assertSame(v1, injector.getBinding(Valid.class));
assertSame(v2, injector.getBinding(Valid2.class));
// Validate that we didn't erase the valid JIT bindings
assertSame(jv1, injector.getBinding(JitValid.class));
assertSame(jv2, injector.getBinding(JitValid2.class));
}
private static void assertFailure(Injector injector, Class<?> clazz) {
try {
injector.getBinding(clazz);
fail("Shouldn't have been able to get binding of: " + clazz);
} catch (ConfigurationException expected) {
Message msg = Iterables.getOnlyElement(expected.getErrorMessages());
Asserts.assertContains(
msg.getMessage(),
"No implementation for " + InvalidInterface.class.getName() + " was bound.");
List<Object> sources = msg.getSources();
// Assert that the first item in the sources if the key for the class we're looking up,
// ensuring that each lookup is "new".
assertEquals(Key.get(clazz).toString(), sources.get(0).toString());
// Assert that the last item in each lookup contains the InvalidInterface class
Asserts.assertContains(
sources.get(sources.size() - 1).toString(), Key.get(InvalidInterface.class).toString());
}
}
static class Invalid {
@Inject Valid a;
@Inject JitValid b;
@Inject InvalidProvidedBy c;
@Inject
Invalid(InvalidLinked a) {}
@Inject
void foo(InvalidInterface a) {}
}
@ImplementedBy(InvalidLinkedImpl.class)
static interface InvalidLinked {}
static class InvalidLinkedImpl implements InvalidLinked {
@Inject InvalidLinked2 a;
}
@ImplementedBy(InvalidLinked2Impl.class)
static interface InvalidLinked2 {}
static class InvalidLinked2Impl implements InvalidLinked2 {
@Inject
InvalidLinked2Impl(Invalid2 a) {}
}
@ProvidedBy(InvalidProvidedByProvider.class)
static interface InvalidProvidedBy {}
static class InvalidProvidedByProvider implements Provider<InvalidProvidedBy> {
@Inject InvalidProvidedBy2 a;
@Override
public InvalidProvidedBy get() {
return null;
}
}
@ProvidedBy(InvalidProvidedBy2Provider.class)
static interface InvalidProvidedBy2 {}
static class InvalidProvidedBy2Provider implements Provider<InvalidProvidedBy2> {
@Inject Invalid2 a;
@Override
public InvalidProvidedBy2 get() {
return null;
}
}
static class Invalid2 {
@Inject Invalid a;
}
interface InvalidInterface {}
static class Valid {
@Inject Valid2 a;
}
static class Valid2 {}
static class JitValid {
@Inject JitValid2 a;
}
static class JitValid2 {}
/**
* Regression test for https://github.com/google/guice/issues/319
*
* <p>The bug is that a class that asks for a provider for itself during injection time, where any
* one of the other types required to fulfill the object creation was bound in a child
* constructor, explodes when the injected Provider is called.
*
* <p>It works just fine when the other types are bound in a main injector.
*/
public void testInstancesRequestingProvidersForThemselvesWithChildInjectors() {
final Module testModule =
new AbstractModule() {
@Override
protected void configure() {
bind(String.class).toProvider(TestStringProvider.class);
}
};
// Verify it works when the type is setup in the parent.
Injector parentSetupRootInjector = Guice.createInjector(testModule);
Injector parentSetupChildInjector = parentSetupRootInjector.createChildInjector();
assertEquals(
TestStringProvider.TEST_VALUE,
parentSetupChildInjector
.getInstance(RequiresProviderForSelfWithOtherType.class)
.getValue());
// Verify it works when the type is setup in the child, not the parent.
// If it still occurs, the bug will explode here.
Injector childSetupRootInjector = Guice.createInjector();
Injector childSetupChildInjector = childSetupRootInjector.createChildInjector(testModule);
assertEquals(
TestStringProvider.TEST_VALUE,
childSetupChildInjector.getInstance(RequiresProviderForSelfWithOtherType.class).getValue());
}
static class TestStringProvider implements Provider<String> {
static final String TEST_VALUE = "This is to verify it all works";
@Override
public String get() {
return TEST_VALUE;
}
}
static class RequiresProviderForSelfWithOtherType {
private final Provider<RequiresProviderForSelfWithOtherType> selfProvider;
private final String providedStringValue;
@Inject
RequiresProviderForSelfWithOtherType(
String providedStringValue, Provider<RequiresProviderForSelfWithOtherType> selfProvider) {
this.providedStringValue = providedStringValue;
this.selfProvider = selfProvider;
}
public String getValue() {
// Attempt to get another instance of ourself. This pattern
// is possible for recursive processing.
selfProvider.get();
return providedStringValue;
}
}
/**
* Ensure that when we cleanup failed JIT bindings, we don't break. The test here requires a
* sequence of JIT bindings:
*
* <ol>
* <li> A-> B
* <li> B -> C, A
* <li> C -> A, D
* <li> D not JITable
* </ol>
*
* <p>The problem was that C cleaned up A's binding and then handed control back to B, which tried
* to continue processing A.. but A was removed from the jitBindings Map, so it attempts to create
* a new JIT binding for A, but we haven't yet finished constructing the first JIT binding for A,
* so we get a recursive computation exception from ComputingConcurrentHashMap.
*
* <p>We also throw in a valid JIT binding, E, to guarantee that if something fails in this flow,
* it can be recreated later if it's not from a failed sequence.
*/
public void testRecursiveJitBindingsCleanupCorrectly() throws Exception {
Injector injector = Guice.createInjector();
try {
injector.getInstance(A.class);
fail("Expected failure");
} catch (ConfigurationException expected) {
assertThat(expected.getErrorMessages()).hasSize(1);
Asserts.assertContains(
expected.getMessage(), "No injectable constructor for type ImplicitBindingTest$D.");
}
// Assert that we've removed all the bindings.
assertNull(injector.getExistingBinding(Key.get(A.class)));
assertNull(injector.getExistingBinding(Key.get(B.class)));
assertNull(injector.getExistingBinding(Key.get(C.class)));
assertNull(injector.getExistingBinding(Key.get(D.class)));
// Confirm that we didn't prevent 'E' from working.
assertNotNull(injector.getBinding(Key.get(E.class)));
}
static class A {
@Inject
public A(B b) {}
}
static class B {
@Inject
public B(C c, A a) {}
}
static class C {
@Inject
public C(A a, D d, E e) {}
}
static class D {
public D(int i) {}
}
// Valid JITable binding
static class E {}
public void testProvidedByNonEmptyEnum() {
NonEmptyEnum cardSuit = Guice.createInjector().getInstance(NonEmptyEnum.class);
assertEquals(NonEmptyEnum.HEARTS, cardSuit);
}
public void testProvidedByEmptyEnum() {
EmptyEnum emptyEnumValue = Guice.createInjector().getInstance(EmptyEnum.class);
assertNull(emptyEnumValue);
}
@ProvidedBy(NonEmptyEnumProvider.class)
enum NonEmptyEnum {
HEARTS,
DIAMONDS,
CLUBS,
SPADES
}
static final class NonEmptyEnumProvider implements Provider<NonEmptyEnum> {
@Override
public NonEmptyEnum get() {
return NonEmptyEnum.HEARTS;
}
}
@ProvidedBy(EmptyEnumProvider.class)
enum EmptyEnum {}
static final class EmptyEnumProvider implements Provider<EmptyEnum> {
@Override
public EmptyEnum get() {
return null;
}
}
// An enum cannot be implemented by anything, so it should not be possible to have a successful
// binding when the enum is annotated with @ImplementedBy.
public void testImplementedByEnum() {
Injector injector = Guice.createInjector();
try {
injector.getInstance(EnumWithImplementedBy.class);
fail("Expected failure");
} catch (ConfigurationException expected) {
Message msg = Iterables.getOnlyElement(expected.getErrorMessages());
Asserts.assertContains(
msg.getMessage(),
"No implementation for " + EnumWithImplementedBy.class.getName() + " was bound.");
}
}
@ImplementedBy(EnumWithImplementedByEnum.class)
enum EnumWithImplementedBy {}
private static class EnumWithImplementedByEnum {}
public void testImplicitJdkBindings() {
Injector injector = Guice.createInjector();
// String has a public nullary constructor, so Guice will call it.
assertEquals("", injector.getInstance(String.class));
// InetAddress has a package private constructor. We probably shouldn't be calling it :(
if (Double.parseDouble(JAVA_SPECIFICATION_VERSION.value()) < 17) {
assertNotNull(injector.getInstance(InetAddress.class));
}
}
}
|