1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545
|
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE NamedFieldPuns #-}
{-# LANGUAGE GeneralizedNewtypeDeriving #-}
{-# LANGUAGE ApplicativeDo #-}
{-# LANGUAGE DeriveFunctor #-}
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE ViewPatterns #-}
{-# LANGUAGE DerivingVia #-}
{- | This module implements 'addHaddockToModule', which inserts Haddock
comments accumulated during parsing into the AST (#17544).
We process Haddock comments in two phases:
1. Parse the program (via the Happy parser in `Parser.y`), generating
an AST, and (quite separately) a list of all the Haddock comments
found in the file. More precisely, the Haddock comments are
accumulated in the `hdk_comments` field of the `PState`, the parser
state (see Lexer.x):
data PState = PState { ...
, hdk_comments :: [PsLocated HdkComment] }
Each of these Haddock comments has a `PsSpan`, which gives the `BufPos` of
the beginning and end of the Haddock comment.
2. Walk over the AST, attaching the Haddock comments to the correct
parts of the tree. This step is called `addHaddockToModule`, and is
implemented in this module.
See Note [Adding Haddock comments to the syntax tree].
This approach codifies an important principle:
The presence or absence of a Haddock comment should never change the parsing
of a program.
Alternative approaches that did not work properly:
1. Using 'RealSrcLoc' instead of 'BufPos'. This led to failures in presence
of {-# LANGUAGE CPP #-} and other sources of line pragmas. See documentation
on 'BufPos' (in GHC.Types.SrcLoc) for the details.
2. In earlier versions of GHC, the Haddock comments were incorporated into the
Parser.y grammar. The parser constructed the AST and attached comments to it in
a single pass. See Note [Old solution: Haddock in the grammar] for the details.
-}
module GHC.Parser.PostProcess.Haddock (addHaddockToModule) where
import GHC.Prelude hiding (mod)
import GHC.Hs
import GHC.Types.SrcLoc
import GHC.Driver.Session ( WarningFlag(..) )
import GHC.Utils.Outputable hiding ( (<>) )
import GHC.Data.Bag
import Data.Semigroup
import Data.Foldable
import Data.Traversable
import Data.Maybe
import Control.Monad
import Control.Monad.Trans.State.Strict
import Control.Monad.Trans.Reader
import Control.Monad.Trans.Writer
import Data.Functor.Identity
import Data.Coerce
import qualified Data.Monoid
import GHC.Parser.Lexer
import GHC.Utils.Misc (mergeListsBy, filterOut, mapLastM, (<&&>))
{- Note [Adding Haddock comments to the syntax tree]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
'addHaddock' traverses the AST in concrete syntax order, building a computation
(represented by HdkA) that reconstructs the AST but with Haddock comments
inserted in appropriate positions:
addHaddock :: HasHaddock a => a -> HdkA a
Consider this code example:
f :: Int -- ^ comment on argument
-> Bool -- ^ comment on result
In the AST, the "Int" part of this snippet is represented like this
(pseudo-code):
L (BufSpan 6 8) (HsTyVar "Int") :: LHsType GhcPs
And the comments are represented like this (pseudo-code):
L (BufSpan 11 35) (HdkCommentPrev "comment on argument")
L (BufSpan 46 69) (HdkCommentPrev "comment on result")
So when we are traversing the AST and 'addHaddock' is applied to HsTyVar "Int",
how does it know to associate it with "comment on argument" but not with
"comment on result"?
The trick is to look in the space between syntactic elements. In the example above,
the location range in which we search for HdkCommentPrev is as follows:
f :: Int████████████████████████
████Bool -- ^ comment on result
We search for comments after HsTyVar "Int" and until the next syntactic
element, in this case HsTyVar "Bool".
Ignoring the "->" allows us to accomodate alternative coding styles:
f :: Int -> -- ^ comment on argument
Bool -- ^ comment on result
Sometimes we also need to take indentation information into account.
Compare the following examples:
class C a where
f :: a -> Int
-- ^ comment on f
class C a where
f :: a -> Int
-- ^ comment on C
Notice how "comment on f" and "comment on C" differ only by indentation level.
Therefore, in order to know the location range in which the comments are applicable
to a syntactic elements, we need three nuggets of information:
1. lower bound on the BufPos of a comment
2. upper bound on the BufPos of a comment
3. minimum indentation level of a comment
This information is represented by the 'LocRange' type.
In order to propagate this information, we have the 'HdkA' applicative.
'HdkA' is defined as follows:
data HdkA a = HdkA (Maybe BufSpan) (HdkM a)
The first field contains a 'BufSpan', which represents the location
span taken by a syntactic element:
addHaddock (L bufSpan ...) = HdkA (Just bufSpan) ...
The second field, 'HdkM', is a stateful computation that looks up Haddock
comments in the specified location range:
HdkM a ≈
LocRange -- The allowed location range
-> [PsLocated HdkComment] -- Unallocated comments
-> (a, -- AST with comments inserted into it
[PsLocated HdkComment]) -- Leftover comments
The 'Applicative' instance for 'HdkA' is defined in such a way that the
location range of every computation is defined by its neighbours:
addHaddock aaa <*> addHaddock bbb <*> addHaddock ccc
Here, the 'LocRange' passed to the 'HdkM' computation of addHaddock bbb
is determined by the BufSpan recorded in addHaddock aaa and addHaddock ccc.
This is why it's important to traverse the AST in the order of the concrete
syntax. In the example above we assume that aaa, bbb, ccc are ordered by location:
* getBufSpan (getLoc aaa) < getBufSpan (getLoc bbb)
* getBufSpan (getLoc bbb) < getBufSpan (getLoc ccc)
Violation of this assumption would lead to bugs, and care must be taken to
traverse the AST correctly. For example, when dealing with class declarations,
we have to use 'flattenBindsAndSigs' to traverse it in the correct order.
-}
-- | Add Haddock documentation accumulated in the parser state
-- to a parsed HsModule.
--
-- Reports badly positioned comments when -Winvalid-haddock is enabled.
addHaddockToModule :: Located HsModule -> P (Located HsModule)
addHaddockToModule lmod = do
pState <- getPState
let all_comments = toList (hdk_comments pState)
initial_hdk_st = HdkSt all_comments []
(lmod', final_hdk_st) = runHdkA (addHaddock lmod) initial_hdk_st
hdk_warnings = collectHdkWarnings final_hdk_st
-- lmod': module with Haddock comments inserted into the AST
-- hdk_warnings: warnings accumulated during AST/comment processing
mapM_ reportHdkWarning hdk_warnings
return lmod'
reportHdkWarning :: HdkWarn -> P ()
reportHdkWarning (HdkWarnInvalidComment (L l _)) =
addWarning Opt_WarnInvalidHaddock (mkSrcSpanPs l) $
text "A Haddock comment cannot appear in this position and will be ignored."
reportHdkWarning (HdkWarnExtraComment (L l _)) =
addWarning Opt_WarnInvalidHaddock l $
text "Multiple Haddock comments for a single entity are not allowed." $$
text "The extraneous comment will be ignored."
collectHdkWarnings :: HdkSt -> [HdkWarn]
collectHdkWarnings HdkSt{ hdk_st_pending, hdk_st_warnings } =
map HdkWarnInvalidComment hdk_st_pending -- leftover Haddock comments not inserted into the AST
++ hdk_st_warnings
{- *********************************************************************
* *
* addHaddock: a family of functions that processes the AST *
* in concrete syntax order, adding documentation comments to it *
* *
********************************************************************* -}
-- HasHaddock is a convenience class for overloading the addHaddock operation.
-- Alternatively, we could define a family of monomorphic functions:
--
-- addHaddockSomeTypeX :: SomeTypeX -> HdkA SomeTypeX
-- addHaddockAnotherTypeY :: AnotherTypeY -> HdkA AnotherTypeY
-- addHaddockOneMoreTypeZ :: OneMoreTypeZ -> HdkA OneMoreTypeZ
--
-- But having a single name for all of them is just easier to read, and makes it clear
-- that they all are of the form t -> HdkA t for some t.
--
-- If you need to handle a more complicated scenario that doesn't fit this
-- pattern, it's always possible to define separate functions outside of this
-- class, as is done in case of e.g. addHaddockConDeclField.
--
-- See Note [Adding Haddock comments to the syntax tree].
class HasHaddock a where
addHaddock :: a -> HdkA a
instance HasHaddock a => HasHaddock [a] where
addHaddock = traverse addHaddock
-- -- | Module header comment
-- module M (
-- -- - Export list comment
-- Item1,
-- Item2,
-- -- - Export list comment
-- item3,
-- item4
-- ) where
--
instance HasHaddock (Located HsModule) where
addHaddock (L l_mod mod) = do
-- Step 1, get the module header documentation comment:
--
-- -- | Module header comment
-- module M where
--
-- Only do this when the module header exists.
headerDocs <-
for @Maybe (hsmodName mod) $ \(L l_name _) ->
extendHdkA l_name $ liftHdkA $ do
-- todo: register keyword location of 'module', see Note [Register keyword location]
docs <-
inLocRange (locRangeTo (getBufPos (srcSpanStart l_name))) $
takeHdkComments mkDocNext
selectDocString docs
-- Step 2, process documentation comments in the export list:
--
-- module M (
-- -- - Export list comment
-- Item1,
-- Item2,
-- -- - Export list comment
-- item3,
-- item4
-- ) where
--
-- Only do this when the export list exists.
hsmodExports' <- traverse @Maybe addHaddock (hsmodExports mod)
-- Step 3, register the import section to reject invalid comments:
--
-- import Data.Maybe
-- -- | rejected comment (cannot appear here)
-- import Data.Bool
--
traverse_ registerHdkA (hsmodImports mod)
-- Step 4, process declarations:
--
-- module M where
-- -- | Comment on D
-- data D = MkD -- ^ Comment on MkD
-- data C = MkC -- ^ Comment on MkC
-- -- ^ Comment on C
--
let layout_info = hsmodLayout mod
hsmodDecls' <- addHaddockInterleaveItems layout_info (mkDocHsDecl layout_info) (hsmodDecls mod)
pure $ L l_mod $
mod { hsmodExports = hsmodExports'
, hsmodDecls = hsmodDecls'
, hsmodHaddockModHeader = join @Maybe headerDocs }
-- Only for module exports, not module imports.
--
-- module M (a, b, c) where -- use on this [LIE GhcPs]
-- import I (a, b, c) -- do not use here!
--
-- Imports cannot have documentation comments anyway.
instance HasHaddock (Located [LIE GhcPs]) where
addHaddock (L l_exports exports) =
extendHdkA l_exports $ do
exports' <- addHaddockInterleaveItems NoLayoutInfo mkDocIE exports
registerLocHdkA (srcLocSpan (srcSpanEnd l_exports)) -- Do not consume comments after the closing parenthesis
pure $ L l_exports exports'
-- Needed to use 'addHaddockInterleaveItems' in 'instance HasHaddock (Located [LIE GhcPs])'.
instance HasHaddock (LIE GhcPs) where
addHaddock a = a <$ registerHdkA a
{- Add Haddock items to a list of non-Haddock items.
Used to process export lists (with mkDocIE) and declarations (with mkDocHsDecl).
For example:
module M where
-- | Comment on D
data D = MkD -- ^ Comment on MkD
data C = MkC -- ^ Comment on MkC
-- ^ Comment on C
In this case, we should produce four HsDecl items (pseudo-code):
1. DocD (DocCommentNext "Comment on D")
2. TyClD (DataDecl "D" ... [ConDeclH98 "MkD" ... (Just "Comment on MkD")])
3. TyClD (DataDecl "C" ... [ConDeclH98 "MkC" ... (Just "Comment on MkC")])
4. DocD (DocCommentPrev "Comment on C")
The inputs to addHaddockInterleaveItems are:
* layout_info :: LayoutInfo
In the example above, note that the indentation level inside the module is
2 spaces. It would be represented as layout_info = VirtualBraces 2.
It is used to delimit the search space for comments when processing
declarations. Here, we restrict indentation levels to >=(2+1), so that when
we look up comment on MkC, we get "Comment on MkC" but not "Comment on C".
* get_doc_item :: PsLocated HdkComment -> Maybe a
This is the function used to look up documentation comments.
In the above example, get_doc_item = mkDocHsDecl layout_info,
and it will produce the following parts of the output:
DocD (DocCommentNext "Comment on D")
DocD (DocCommentPrev "Comment on C")
* The list of items. These are the declarations that will be annotated with
documentation comments.
Before processing:
TyClD (DataDecl "D" ... [ConDeclH98 "MkD" ... Nothing])
TyClD (DataDecl "C" ... [ConDeclH98 "MkC" ... Nothing])
After processing:
TyClD (DataDecl "D" ... [ConDeclH98 "MkD" ... (Just "Comment on MkD")])
TyClD (DataDecl "C" ... [ConDeclH98 "MkC" ... (Just "Comment on MkC")])
-}
addHaddockInterleaveItems
:: forall a.
HasHaddock a
=> LayoutInfo
-> (PsLocated HdkComment -> Maybe a) -- Get a documentation item
-> [a] -- Unprocessed (non-documentation) items
-> HdkA [a] -- Documentation items & processed non-documentation items
addHaddockInterleaveItems layout_info get_doc_item = go
where
go :: [a] -> HdkA [a]
go [] = liftHdkA (takeHdkComments get_doc_item)
go (item : items) = do
docItems <- liftHdkA (takeHdkComments get_doc_item)
item' <- with_layout_info (addHaddock item)
other_items <- go items
pure $ docItems ++ item':other_items
with_layout_info :: HdkA a -> HdkA a
with_layout_info = case layout_info of
NoLayoutInfo -> id
ExplicitBraces -> id
VirtualBraces n ->
let loc_range = mempty { loc_range_col = ColumnFrom (n+1) }
in hoistHdkA (inLocRange loc_range)
instance HasHaddock (LHsDecl GhcPs) where
addHaddock ldecl =
extendHdkA (getLoc ldecl) $
traverse @Located addHaddock ldecl
-- Process documentation comments *inside* a declaration, for example:
--
-- data T = MkT -- ^ Comment on MkT (inside DataDecl)
-- f, g
-- :: Int -- ^ Comment on Int (inside TypeSig)
-- -> Bool -- ^ Comment on Bool (inside TypeSig)
--
-- Comments that relate to the entire declaration are processed elsewhere:
--
-- -- | Comment on T (not processed in this instance)
-- data T = MkT
--
-- -- | Comment on f, g (not processed in this instance)
-- f, g :: Int -> Bool
-- f = ...
-- g = ...
--
-- Such comments are inserted into the syntax tree as DocD declarations
-- by addHaddockInterleaveItems, and then associated with other declarations
-- in GHC.HsToCore.Docs (see DeclDocMap).
--
-- In this instance, we only process comments that relate to parts of the
-- declaration, not to the declaration itself.
instance HasHaddock (HsDecl GhcPs) where
-- Type signatures:
--
-- f, g
-- :: Int -- ^ Comment on Int
-- -> Bool -- ^ Comment on Bool
--
addHaddock (SigD _ (TypeSig _ names t)) = do
traverse_ registerHdkA names
t' <- addHaddock t
pure (SigD noExtField (TypeSig noExtField names t'))
-- Pattern synonym type signatures:
--
-- pattern MyPat
-- :: Bool -- ^ Comment on Bool
-- -> Maybe Bool -- ^ Comment on Maybe Bool
--
addHaddock (SigD _ (PatSynSig _ names t)) = do
traverse_ registerHdkA names
t' <- addHaddock t
pure (SigD noExtField (PatSynSig noExtField names t'))
-- Class method signatures and default signatures:
--
-- class C x where
-- method_of_c
-- :: Maybe x -- ^ Comment on Maybe x
-- -> IO () -- ^ Comment on IO ()
-- default method_of_c
-- :: Eq x
-- => Maybe x -- ^ Comment on Maybe x
-- -> IO () -- ^ Comment on IO ()
--
addHaddock (SigD _ (ClassOpSig _ is_dflt names t)) = do
traverse_ registerHdkA names
t' <- addHaddock t
pure (SigD noExtField (ClassOpSig noExtField is_dflt names t'))
-- Data/newtype declarations:
--
-- data T = MkT -- ^ Comment on MkT
-- A -- ^ Comment on A
-- B -- ^ Comment on B
--
-- data G where
-- -- | Comment on MkG
-- MkG :: A -- ^ Comment on A
-- -> B -- ^ Comment on B
-- -> G
--
-- newtype N = MkN { getN :: Natural } -- ^ Comment on N
-- deriving newtype (Eq {- ^ Comment on Eq N -})
-- deriving newtype (Ord {- ^ Comment on Ord N -})
--
addHaddock (TyClD _ decl)
| DataDecl { tcdLName, tcdTyVars, tcdFixity, tcdDataDefn = defn } <- decl
= do
registerHdkA tcdLName
defn' <- addHaddock defn
pure $
TyClD noExtField (DataDecl {
tcdDExt = noExtField,
tcdLName, tcdTyVars, tcdFixity,
tcdDataDefn = defn' })
-- Class declarations:
--
-- class C a where
-- -- | Comment on the first method
-- first_method :: a -> Bool
-- second_method :: a -> String
-- -- ^ Comment on the second method
--
addHaddock (TyClD _ decl)
| ClassDecl { tcdCExt = tcdLayout,
tcdCtxt, tcdLName, tcdTyVars, tcdFixity, tcdFDs,
tcdSigs, tcdMeths, tcdATs, tcdATDefs } <- decl
= do
registerHdkA tcdLName
-- todo: register keyword location of 'where', see Note [Register keyword location]
where_cls' <-
addHaddockInterleaveItems tcdLayout (mkDocHsDecl tcdLayout) $
flattenBindsAndSigs (tcdMeths, tcdSigs, tcdATs, tcdATDefs, [], [])
pure $
let (tcdMeths', tcdSigs', tcdATs', tcdATDefs', _, tcdDocs) = partitionBindsAndSigs where_cls'
decl' = ClassDecl { tcdCExt = tcdLayout
, tcdCtxt, tcdLName, tcdTyVars, tcdFixity, tcdFDs
, tcdSigs = tcdSigs'
, tcdMeths = tcdMeths'
, tcdATs = tcdATs'
, tcdATDefs = tcdATDefs'
, tcdDocs }
in TyClD noExtField decl'
-- Data family instances:
--
-- data instance D Bool where ... (same as data/newtype declarations)
-- data instance D Bool = ... (same as data/newtype declarations)
--
addHaddock (InstD _ decl)
| DataFamInstD { dfid_inst } <- decl
, DataFamInstDecl { dfid_eqn } <- dfid_inst
= do
dfid_eqn' <- case dfid_eqn of
HsIB _ (FamEqn { feqn_tycon, feqn_bndrs, feqn_pats, feqn_fixity, feqn_rhs })
-> do
registerHdkA feqn_tycon
feqn_rhs' <- addHaddock feqn_rhs
pure $
HsIB noExtField (FamEqn {
feqn_ext = noExtField,
feqn_tycon, feqn_bndrs, feqn_pats, feqn_fixity,
feqn_rhs = feqn_rhs' })
pure $ InstD noExtField (DataFamInstD {
dfid_ext = noExtField,
dfid_inst = DataFamInstDecl { dfid_eqn = dfid_eqn' } })
-- Type synonyms:
--
-- type T = Int -- ^ Comment on Int
--
addHaddock (TyClD _ decl)
| SynDecl { tcdLName, tcdTyVars, tcdFixity, tcdRhs } <- decl
= do
registerHdkA tcdLName
-- todo: register keyword location of '=', see Note [Register keyword location]
tcdRhs' <- addHaddock tcdRhs
pure $
TyClD noExtField (SynDecl {
tcdSExt = noExtField,
tcdLName, tcdTyVars, tcdFixity,
tcdRhs = tcdRhs' })
-- Foreign imports:
--
-- foreign import ccall unsafe
-- o :: Float -- ^ The input float
-- -> IO Float -- ^ The output float
--
addHaddock (ForD _ decl) = do
registerHdkA (fd_name decl)
fd_sig_ty' <- addHaddock (fd_sig_ty decl)
pure $ ForD noExtField (decl{ fd_sig_ty = fd_sig_ty' })
-- Other declarations
addHaddock d = pure d
-- The right-hand side of a data/newtype declaration or data family instance.
instance HasHaddock (HsDataDefn GhcPs) where
addHaddock defn@HsDataDefn{} = do
-- Register the kind signature:
-- data D :: Type -> Type where ...
-- data instance D Bool :: Type where ...
traverse_ @Maybe registerHdkA (dd_kindSig defn)
-- todo: register keyword location of '=' or 'where', see Note [Register keyword location]
-- Process the data constructors:
--
-- data T
-- = MkT1 Int Bool -- ^ Comment on MkT1
-- | MkT2 Char Int -- ^ Comment on MkT2
--
dd_cons' <- addHaddock (dd_cons defn)
-- Process the deriving clauses:
--
-- newtype N = MkN Natural
-- deriving (Eq {- ^ Comment on Eq N -})
-- deriving (Ord {- ^ Comment on Ord N -})
--
dd_derivs' <- addHaddock (dd_derivs defn)
pure $ defn { dd_cons = dd_cons',
dd_derivs = dd_derivs' }
-- Process the deriving clauses of a data/newtype declaration.
-- Not used for standalone deriving.
instance HasHaddock (HsDeriving GhcPs) where
addHaddock lderivs =
extendHdkA (getLoc lderivs) $
traverse @Located addHaddock lderivs
-- Process a single deriving clause of a data/newtype declaration:
--
-- newtype N = MkN Natural
-- deriving newtype (Eq {- ^ Comment on Eq N -})
-- deriving (Ord {- ^ Comment on Ord N -}) via Down N
--
-- Not used for standalone deriving.
instance HasHaddock (LHsDerivingClause GhcPs) where
addHaddock lderiv =
extendHdkA (getLoc lderiv) $
for @Located lderiv $ \deriv ->
case deriv of
HsDerivingClause { deriv_clause_strategy, deriv_clause_tys } -> do
let
-- 'stock', 'anyclass', and 'newtype' strategies come
-- before the clause types.
--
-- 'via' comes after.
--
-- See tests/.../T11768.hs
(register_strategy_before, register_strategy_after) =
case deriv_clause_strategy of
Nothing -> (pure (), pure ())
Just (L l (ViaStrategy _)) -> (pure (), registerLocHdkA l)
Just (L l _) -> (registerLocHdkA l, pure ())
register_strategy_before
deriv_clause_tys' <-
extendHdkA (getLoc deriv_clause_tys) $
traverse @Located addHaddock deriv_clause_tys
register_strategy_after
pure HsDerivingClause
{ deriv_clause_ext = noExtField,
deriv_clause_strategy,
deriv_clause_tys = deriv_clause_tys' }
-- Process a single data constructor declaration, which may come in one of the
-- following forms:
--
-- 1. H98-syntax PrefixCon:
-- data T =
-- MkT -- ^ Comment on MkT
-- Int -- ^ Comment on Int
-- Bool -- ^ Comment on Bool
--
-- 2. H98-syntax InfixCon:
-- data T =
-- Int -- ^ Comment on Int
-- :+ -- ^ Comment on (:+)
-- Bool -- ^ Comment on Bool
--
-- 3. H98-syntax RecCon:
-- data T =
-- MkT { int_field :: Int, -- ^ Comment on int_field
-- bool_field :: Bool } -- ^ Comment on bool_field
--
-- 4. GADT-syntax PrefixCon:
-- data T where
-- -- | Comment on MkT
-- MkT :: Int -- ^ Comment on Int
-- -> Bool -- ^ Comment on Bool
-- -> T
--
-- 5. GADT-syntax RecCon:
-- data T where
-- -- | Comment on MkT
-- MkT :: { int_field :: Int, -- ^ Comment on int_field
-- bool_field :: Bool } -- ^ Comment on bool_field
-- -> T
--
instance HasHaddock (LConDecl GhcPs) where
addHaddock (L l_con_decl con_decl) =
extendHdkA l_con_decl $
case con_decl of
ConDeclGADT { con_g_ext, con_names, con_forall, con_qvars, con_mb_cxt, con_args, con_res_ty } -> do
-- discardHasInnerDocs is ok because we don't need this info for GADTs.
con_doc' <- discardHasInnerDocs $ getConDoc (getLoc (head con_names))
con_args' <-
case con_args of
PrefixCon ts -> PrefixCon <$> addHaddock ts
RecCon (L l_rec flds) -> do
-- discardHasInnerDocs is ok because we don't need this info for GADTs.
flds' <- traverse (discardHasInnerDocs . addHaddockConDeclField) flds
pure $ RecCon (L l_rec flds')
InfixCon _ _ -> panic "ConDeclGADT InfixCon"
con_res_ty' <- addHaddock con_res_ty
pure $ L l_con_decl $
ConDeclGADT { con_g_ext, con_names, con_forall, con_qvars, con_mb_cxt,
con_doc = con_doc',
con_args = con_args',
con_res_ty = con_res_ty' }
ConDeclH98 { con_ext, con_name, con_forall, con_ex_tvs, con_mb_cxt, con_args } ->
addConTrailingDoc (srcSpanEnd l_con_decl) $
case con_args of
PrefixCon ts -> do
con_doc' <- getConDoc (getLoc con_name)
ts' <- traverse addHaddockConDeclFieldTy ts
pure $ L l_con_decl $
ConDeclH98 { con_ext, con_name, con_forall, con_ex_tvs, con_mb_cxt,
con_doc = con_doc',
con_args = PrefixCon ts' }
InfixCon t1 t2 -> do
t1' <- addHaddockConDeclFieldTy t1
con_doc' <- getConDoc (getLoc con_name)
t2' <- addHaddockConDeclFieldTy t2
pure $ L l_con_decl $
ConDeclH98 { con_ext, con_name, con_forall, con_ex_tvs, con_mb_cxt,
con_doc = con_doc',
con_args = InfixCon t1' t2' }
RecCon (L l_rec flds) -> do
con_doc' <- getConDoc (getLoc con_name)
flds' <- traverse addHaddockConDeclField flds
pure $ L l_con_decl $
ConDeclH98 { con_ext, con_name, con_forall, con_ex_tvs, con_mb_cxt,
con_doc = con_doc',
con_args = RecCon (L l_rec flds') }
-- Keep track of documentation comments on the data constructor or any of its
-- fields.
--
-- See Note [Trailing comment on constructor declaration]
type ConHdkA = WriterT HasInnerDocs HdkA
-- Does the data constructor declaration have any inner (non-trailing)
-- documentation comments?
--
-- Example when HasInnerDocs is True:
--
-- data X =
-- MkX -- ^ inner comment
-- Field1 -- ^ inner comment
-- Field2 -- ^ inner comment
-- Field3 -- ^ trailing comment
--
-- Example when HasInnerDocs is False:
--
-- data Y = MkY Field1 Field2 Field3 -- ^ trailing comment
--
-- See Note [Trailing comment on constructor declaration]
newtype HasInnerDocs = HasInnerDocs Bool
deriving (Semigroup, Monoid) via Data.Monoid.Any
-- Run ConHdkA by discarding the HasInnerDocs info when we have no use for it.
--
-- We only do this when processing data declarations that use GADT syntax,
-- because only the H98 syntax declarations have special treatment for the
-- trailing documentation comment.
--
-- See Note [Trailing comment on constructor declaration]
discardHasInnerDocs :: ConHdkA a -> HdkA a
discardHasInnerDocs = fmap fst . runWriterT
-- Get the documentation comment associated with the data constructor in a
-- data/newtype declaration.
getConDoc
:: SrcSpan -- Location of the data constructor
-> ConHdkA (Maybe LHsDocString)
getConDoc l =
WriterT $ extendHdkA l $ liftHdkA $ do
mDoc <- getPrevNextDoc l
return (mDoc, HasInnerDocs (isJust mDoc))
-- Add documentation comment to a data constructor field.
-- Used for PrefixCon and InfixCon.
addHaddockConDeclFieldTy
:: HsScaled GhcPs (LHsType GhcPs)
-> ConHdkA (HsScaled GhcPs (LHsType GhcPs))
addHaddockConDeclFieldTy (HsScaled mult (L l t)) =
WriterT $ extendHdkA l $ liftHdkA $ do
mDoc <- getPrevNextDoc l
return (HsScaled mult (mkLHsDocTy (L l t) mDoc),
HasInnerDocs (isJust mDoc))
-- Add documentation comment to a data constructor field.
-- Used for RecCon.
addHaddockConDeclField
:: LConDeclField GhcPs
-> ConHdkA (LConDeclField GhcPs)
addHaddockConDeclField (L l_fld fld) =
WriterT $ extendHdkA l_fld $ liftHdkA $ do
cd_fld_doc <- getPrevNextDoc l_fld
return (L l_fld (fld { cd_fld_doc }),
HasInnerDocs (isJust cd_fld_doc))
-- 1. Process a H98-syntax data constructor declaration in a context with no
-- access to the trailing documentation comment (by running the provided
-- ConHdkA computation).
--
-- 2. Then grab the trailing comment (if it exists) and attach it where
-- appropriate: either to the data constructor itself or to its last field,
-- depending on HasInnerDocs.
--
-- See Note [Trailing comment on constructor declaration]
addConTrailingDoc
:: SrcLoc -- The end of a data constructor declaration.
-- Any docprev comment past this point is considered trailing.
-> ConHdkA (LConDecl GhcPs)
-> HdkA (LConDecl GhcPs)
addConTrailingDoc l_sep =
hoistHdkA add_trailing_doc . runWriterT
where
add_trailing_doc
:: HdkM (LConDecl GhcPs, HasInnerDocs)
-> HdkM (LConDecl GhcPs)
add_trailing_doc m = do
(L l con_decl, HasInnerDocs has_inner_docs) <-
inLocRange (locRangeTo (getBufPos l_sep)) m
-- inLocRange delimits the context so that the inner computation
-- will not consume the trailing documentation comment.
case con_decl of
ConDeclH98{} -> do
trailingDocs <-
inLocRange (locRangeFrom (getBufPos l_sep)) $
takeHdkComments mkDocPrev
if null trailingDocs
then return (L l con_decl)
else do
if has_inner_docs then do
let mk_doc_ty :: HsScaled GhcPs (LHsType GhcPs)
-> HdkM (HsScaled GhcPs (LHsType GhcPs))
mk_doc_ty x@(HsScaled _ (L _ HsDocTy{})) =
-- Happens in the following case:
--
-- data T =
-- MkT
-- -- | Comment on SomeField
-- SomeField
-- -- ^ Another comment on SomeField? (rejected)
--
-- See tests/.../haddockExtraDocs.hs
x <$ reportExtraDocs trailingDocs
mk_doc_ty (HsScaled mult (L l' t)) = do
doc <- selectDocString trailingDocs
return $ HsScaled mult (mkLHsDocTy (L l' t) doc)
let mk_doc_fld :: LConDeclField GhcPs
-> HdkM (LConDeclField GhcPs)
mk_doc_fld x@(L _ (ConDeclField { cd_fld_doc = Just _ })) =
-- Happens in the following case:
--
-- data T =
-- MkT {
-- -- | Comment on SomeField
-- someField :: SomeField
-- } -- ^ Another comment on SomeField? (rejected)
--
-- See tests/.../haddockExtraDocs.hs
x <$ reportExtraDocs trailingDocs
mk_doc_fld (L l' con_fld) = do
doc <- selectDocString trailingDocs
return $ L l' (con_fld { cd_fld_doc = doc })
con_args' <- case con_args con_decl of
x@(PrefixCon []) -> x <$ reportExtraDocs trailingDocs
x@(RecCon (L _ [])) -> x <$ reportExtraDocs trailingDocs
PrefixCon ts -> PrefixCon <$> mapLastM mk_doc_ty ts
InfixCon t1 t2 -> InfixCon t1 <$> mk_doc_ty t2
RecCon (L l_rec flds) -> do
flds' <- mapLastM mk_doc_fld flds
return (RecCon (L l_rec flds'))
return $ L l (con_decl{ con_args = con_args' })
else do
con_doc' <- selectDocString (con_doc con_decl `mcons` trailingDocs)
return $ L l (con_decl{ con_doc = con_doc' })
_ -> panic "addConTrailingDoc: non-H98 ConDecl"
{- Note [Trailing comment on constructor declaration]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The trailing comment after a constructor declaration is associated with the
constructor itself when there are no other comments inside the declaration:
data T = MkT A B -- ^ Comment on MkT
data T = MkT { x :: A } -- ^ Comment on MkT
When there are other comments, the trailing comment applies to the last field:
data T = MkT -- ^ Comment on MkT
A -- ^ Comment on A
B -- ^ Comment on B
data T =
MkT { a :: A -- ^ Comment on a
, b :: B -- ^ Comment on b
, c :: C } -- ^ Comment on c
This makes the trailing comment context-sensitive. Example:
data T =
-- | comment 1
MkT Int Bool -- ^ comment 2
Here, "comment 2" applies to the Bool field.
But if we removed "comment 1", then "comment 2" would be apply to the data
constructor rather than its field.
All of this applies to H98-style data declarations only.
GADTSyntax data constructors don't have any special treatment for the trailing comment.
We implement this in two steps:
1. Process the data constructor declaration in a delimited context where the
trailing documentation comment is not visible. Delimiting the context is done
in addConTrailingDoc.
When processing the declaration, track whether the constructor or any of
its fields have a documentation comment associated with them.
This is done using WriterT HasInnerDocs, see ConHdkA.
2. Depending on whether HasInnerDocs is True or False, attach the
trailing documentation comment to the data constructor itself
or to its last field.
-}
instance HasHaddock a => HasHaddock (HsScaled GhcPs a) where
addHaddock (HsScaled mult a) = HsScaled mult <$> addHaddock a
instance HasHaddock (LHsSigWcType GhcPs) where
addHaddock (HsWC _ t) = HsWC noExtField <$> addHaddock t
instance HasHaddock (LHsSigType GhcPs) where
addHaddock (HsIB _ t) = HsIB noExtField <$> addHaddock t
-- Process a type, adding documentation comments to function arguments
-- and the result. Many formatting styles are supported.
--
-- my_function ::
-- forall a.
-- Eq a =>
-- Maybe a -> -- ^ Comment on Maybe a (function argument)
-- Bool -> -- ^ Comment on Bool (function argument)
-- String -- ^ Comment on String (the result)
--
-- my_function
-- :: forall a. Eq a
-- => Maybe a -- ^ Comment on Maybe a (function argument)
-- -> Bool -- ^ Comment on Bool (function argument)
-- -> String -- ^ Comment on String (the result)
--
-- my_function ::
-- forall a. Eq a =>
-- -- | Comment on Maybe a (function argument)
-- Maybe a ->
-- -- | Comment on Bool (function argument)
-- Bool ->
-- -- | Comment on String (the result)
-- String
--
-- This is achieved by simply ignoring (not registering the location of) the
-- function arrow (->).
instance HasHaddock (LHsType GhcPs) where
addHaddock (L l t) =
extendHdkA l $
case t of
-- forall a b c. t
HsForAllTy _ tele body -> do
registerLocHdkA (getForAllTeleLoc tele)
body' <- addHaddock body
pure $ L l (HsForAllTy noExtField tele body')
-- (Eq a, Num a) => t
HsQualTy _ lhs rhs -> do
registerHdkA lhs
rhs' <- addHaddock rhs
pure $ L l (HsQualTy noExtField lhs rhs')
-- arg -> res
HsFunTy u mult lhs rhs -> do
lhs' <- addHaddock lhs
rhs' <- addHaddock rhs
pure $ L l (HsFunTy u mult lhs' rhs')
-- other types
_ -> liftHdkA $ do
mDoc <- getPrevNextDoc l
return (mkLHsDocTy (L l t) mDoc)
{- *********************************************************************
* *
* HdkA: a layer over HdkM that propagates location information *
* *
********************************************************************* -}
-- See Note [Adding Haddock comments to the syntax tree].
--
-- 'HdkA' provides a way to propagate location information from surrounding
-- computations:
--
-- left_neighbour <*> HdkA inner_span inner_m <*> right_neighbour
--
-- Here, the following holds:
--
-- - the 'left_neighbour' will only see Haddock comments until 'bufSpanStart' of 'inner_span'
-- - the 'right_neighbour' will only see Haddock comments after 'bufSpanEnd' of 'inner_span'
-- - the 'inner_m' will only see Haddock comments between its 'left_neighbour' and its 'right_neighbour'
--
-- In other words, every computation:
--
-- * delimits the surrounding computations
-- * is delimited by the surrounding computations
--
-- Therefore, a 'HdkA' computation must be always considered in the context in
-- which it is used.
data HdkA a =
HdkA
!(Maybe BufSpan) -- Just b <=> BufSpan occupied by the processed AST element.
-- The surrounding computations will not look inside.
--
-- Nothing <=> No BufSpan (e.g. when the HdkA is constructed by 'pure' or 'liftHdkA').
-- The surrounding computations are not delimited.
!(HdkM a) -- The stateful computation that looks up Haddock comments and
-- adds them to the resulting AST node.
deriving (Functor)
instance Applicative HdkA where
HdkA l1 m1 <*> HdkA l2 m2 =
HdkA
(l1 <> l2) -- The combined BufSpan that covers both subcomputations.
--
-- The Semigroup instance for Maybe quite conveniently does the right thing:
-- Nothing <> b = b
-- a <> Nothing = a
-- Just a <> Just b = Just (a <> b)
(delim1 m1 <*> delim2 m2) -- Stateful computations are run in left-to-right order,
-- without any smart reordering strategy. So users of this
-- operation must take care to traverse the AST
-- in concrete syntax order.
-- See Note [Smart reordering in HdkA (or lack of thereof)]
--
-- Each computation is delimited ("sandboxed")
-- in a way that it doesn't see any Haddock
-- comments past the neighbouring AST node.
-- These delim1/delim2 are key to how HdkA operates.
where
-- Delimit the LHS by the location information from the RHS
delim1 = inLocRange (locRangeTo (fmap @Maybe bufSpanStart l2))
-- Delimit the RHS by the location information from the LHS
delim2 = inLocRange (locRangeFrom (fmap @Maybe bufSpanEnd l1))
pure a =
-- Return a value without performing any stateful computation, and without
-- any delimiting effect on the surrounding computations.
liftHdkA (pure a)
{- Note [Smart reordering in HdkA (or lack of thereof)]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When traversing the AST, the user must take care to traverse it in concrete
syntax order.
For example, when processing HsFunTy, it's important to get it right and write
it like so:
HsFunTy _ mult lhs rhs -> do
lhs' <- addHaddock lhs
rhs' <- addHaddock rhs
pure $ L l (HsFunTy noExtField mult lhs' rhs')
Rather than like so:
HsFunTy _ mult lhs rhs -> do
rhs' <- addHaddock rhs -- bad! wrong order
lhs' <- addHaddock lhs -- bad! wrong order
pure $ L l (HsFunTy noExtField mult lhs' rhs')
This is somewhat bug-prone, so we could try to fix this with some Applicative
magic. When we define (<*>) for HdkA, why not reorder the computations as
necessary? In pseudo-code:
a1 <*> a2 | a1 `before` a2 = ... normal processing ...
| otherwise = a1 <**> a2
While this trick could work for any two *adjacent* AST elements out of order
(as in HsFunTy example above), it would fail in more elaborate scenarios (e.g.
processing a list of declarations out of order).
If it's not obvious why this trick doesn't work, ponder this: it's a bit like trying to get
a sorted list by defining a 'smart' concatenation operator in the following manner:
a ?++ b | a <= b = a ++ b
| otherwise = b ++ a
At first glance it seems to work:
ghci> [1] ?++ [2] ?++ [3]
[1,2,3]
ghci> [2] ?++ [1] ?++ [3]
[1,2,3] -- wow, sorted!
But it actually doesn't:
ghci> [3] ?++ [1] ?++ [2]
[1,3,2] -- not sorted...
-}
-- Run a HdkA computation in an unrestricted LocRange. This is only used at the
-- top level to run the final computation for the entire module.
runHdkA :: HdkA a -> HdkSt -> (a, HdkSt)
runHdkA (HdkA _ m) = unHdkM m mempty
-- Let the neighbours know about an item at this location.
--
-- Consider this example:
--
-- class -- | peculiarly placed comment
-- MyClass a where
-- my_method :: a -> a
--
-- How do we know to reject the "peculiarly placed comment" instead of
-- associating it with my_method? Its indentation level matches.
--
-- But clearly, there's "MyClass a where" separating the comment and my_method.
-- To take it into account, we must register its location using registerLocHdkA
-- or registerHdkA.
--
-- See Note [Register keyword location].
-- See Note [Adding Haddock comments to the syntax tree].
registerLocHdkA :: SrcSpan -> HdkA ()
registerLocHdkA l = HdkA (getBufSpan l) (pure ())
-- Let the neighbours know about an item at this location.
-- A small wrapper over registerLocHdkA.
--
-- See Note [Adding Haddock comments to the syntax tree].
registerHdkA :: Located a -> HdkA ()
registerHdkA a = registerLocHdkA (getLoc a)
-- Modify the action of a HdkA computation.
hoistHdkA :: (HdkM a -> HdkM b) -> HdkA a -> HdkA b
hoistHdkA f (HdkA l m) = HdkA l (f m)
-- Lift a HdkM computation to HdkA.
liftHdkA :: HdkM a -> HdkA a
liftHdkA = HdkA mempty
-- Extend the declared location span of a 'HdkA' computation:
--
-- left_neighbour <*> extendHdkA l x <*> right_neighbour
--
-- The declared location of 'x' now includes 'l', so that the surrounding
-- computations 'left_neighbour' and 'right_neighbour' will not look for
-- Haddock comments inside the 'l' location span.
extendHdkA :: SrcSpan -> HdkA a -> HdkA a
extendHdkA l' (HdkA l m) = HdkA (getBufSpan l' <> l) m
{- *********************************************************************
* *
* HdkM: a stateful computation to associate *
* accumulated documentation comments with AST nodes *
* *
********************************************************************* -}
-- The state of 'HdkM' contains a list of pending Haddock comments. We go
-- over the AST, looking up these comments using 'takeHdkComments' and removing
-- them from the state. The remaining, un-removed ones are ignored with a
-- warning (-Winvalid-haddock). Also, using a state means we never use the same
-- Haddock twice.
--
-- See Note [Adding Haddock comments to the syntax tree].
newtype HdkM a = HdkM (ReaderT LocRange (State HdkSt) a)
deriving (Functor, Applicative, Monad)
-- | The state of HdkM.
data HdkSt =
HdkSt
{ hdk_st_pending :: [PsLocated HdkComment]
-- a list of pending (unassociated with an AST node)
-- Haddock comments, sorted by location: in ascending order of the starting 'BufPos'
, hdk_st_warnings :: [HdkWarn]
-- accumulated warnings (order doesn't matter)
}
-- | Warnings accumulated in HdkM.
data HdkWarn
= HdkWarnInvalidComment (PsLocated HdkComment)
| HdkWarnExtraComment LHsDocString
-- 'HdkM' without newtype wrapping/unwrapping.
type InlineHdkM a = LocRange -> HdkSt -> (a, HdkSt)
mkHdkM :: InlineHdkM a -> HdkM a
unHdkM :: HdkM a -> InlineHdkM a
mkHdkM = coerce
unHdkM = coerce
-- Restrict the range in which a HdkM computation will look up comments:
--
-- inLocRange r1 $
-- inLocRange r2 $
-- takeHdkComments ... -- Only takes comments in the (r1 <> r2) location range.
--
-- Note that it does not blindly override the range but tightens it using (<>).
-- At many use sites, you will see something along the lines of:
--
-- inLocRange (locRangeTo end_pos) $ ...
--
-- And 'locRangeTo' defines a location range from the start of the file to
-- 'end_pos'. This does not mean that we now search for every comment from the
-- start of the file, as this restriction will be combined with other
-- restrictions. Somewhere up the callstack we might have:
--
-- inLocRange (locRangeFrom start_pos) $ ...
--
-- The net result is that the location range is delimited by 'start_pos' on
-- one side and by 'end_pos' on the other side.
--
-- In 'HdkA', every (<*>) may restrict the location range of its
-- subcomputations.
inLocRange :: LocRange -> HdkM a -> HdkM a
inLocRange r (HdkM m) = HdkM (local (mappend r) m)
-- Take the Haddock comments that satisfy the matching function,
-- leaving the rest pending.
takeHdkComments :: forall a. (PsLocated HdkComment -> Maybe a) -> HdkM [a]
takeHdkComments f =
mkHdkM $
\(LocRange hdk_from hdk_to hdk_col) ->
\hdk_st ->
let
comments = hdk_st_pending hdk_st
(comments_before_range, comments') = break (is_after hdk_from) comments
(comments_in_range, comments_after_range) = span (is_before hdk_to <&&> is_indented hdk_col) comments'
(items, other_comments) = foldr add_comment ([], []) comments_in_range
remaining_comments = comments_before_range ++ other_comments ++ comments_after_range
hdk_st' = hdk_st{ hdk_st_pending = remaining_comments }
in
(items, hdk_st')
where
is_after StartOfFile _ = True
is_after (StartLoc l) (L l_comment _) = bufSpanStart (psBufSpan l_comment) >= l
is_before EndOfFile _ = True
is_before (EndLoc l) (L l_comment _) = bufSpanStart (psBufSpan l_comment) <= l
is_indented (ColumnFrom n) (L l_comment _) = srcSpanStartCol (psRealSpan l_comment) >= n
add_comment
:: PsLocated HdkComment
-> ([a], [PsLocated HdkComment])
-> ([a], [PsLocated HdkComment])
add_comment hdk_comment (items, other_hdk_comments) =
case f hdk_comment of
Just item -> (item : items, other_hdk_comments)
Nothing -> (items, hdk_comment : other_hdk_comments)
-- Get the docnext or docprev comment for an AST node at the given source span.
getPrevNextDoc :: SrcSpan -> HdkM (Maybe LHsDocString)
getPrevNextDoc l = do
let (l_start, l_end) = (srcSpanStart l, srcSpanEnd l)
before_t = locRangeTo (getBufPos l_start)
after_t = locRangeFrom (getBufPos l_end)
nextDocs <- inLocRange before_t $ takeHdkComments mkDocNext
prevDocs <- inLocRange after_t $ takeHdkComments mkDocPrev
selectDocString (nextDocs ++ prevDocs)
appendHdkWarning :: HdkWarn -> HdkM ()
appendHdkWarning e = HdkM (ReaderT (\_ -> modify append_warn))
where
append_warn hdk_st = hdk_st { hdk_st_warnings = e : hdk_st_warnings hdk_st }
selectDocString :: [LHsDocString] -> HdkM (Maybe LHsDocString)
selectDocString = select . filterOut (isEmptyDocString . unLoc)
where
select [] = return Nothing
select [doc] = return (Just doc)
select (doc : extra_docs) = do
reportExtraDocs extra_docs
return (Just doc)
reportExtraDocs :: [LHsDocString] -> HdkM ()
reportExtraDocs =
traverse_ (\extra_doc -> appendHdkWarning (HdkWarnExtraComment extra_doc))
{- *********************************************************************
* *
* Matching functions for extracting documentation comments *
* *
********************************************************************* -}
mkDocHsDecl :: LayoutInfo -> PsLocated HdkComment -> Maybe (LHsDecl GhcPs)
mkDocHsDecl layout_info a = mapLoc (DocD noExtField) <$> mkDocDecl layout_info a
mkDocDecl :: LayoutInfo -> PsLocated HdkComment -> Maybe LDocDecl
mkDocDecl layout_info (L l_comment hdk_comment)
| indent_mismatch = Nothing
| otherwise =
Just $ L (mkSrcSpanPs l_comment) $
case hdk_comment of
HdkCommentNext doc -> DocCommentNext doc
HdkCommentPrev doc -> DocCommentPrev doc
HdkCommentNamed s doc -> DocCommentNamed s doc
HdkCommentSection n doc -> DocGroup n doc
where
-- 'indent_mismatch' checks if the documentation comment has the exact
-- indentation level expected by the parent node.
--
-- For example, when extracting documentation comments between class
-- method declarations, there are three cases to consider:
--
-- 1. Indent matches (indent_mismatch=False):
-- class C a where
-- f :: a -> a
-- -- ^ doc on f
--
-- 2. Indented too much (indent_mismatch=True):
-- class C a where
-- f :: a -> a
-- -- ^ indent mismatch
--
-- 3. Indented too little (indent_mismatch=True):
-- class C a where
-- f :: a -> a
-- -- ^ indent mismatch
indent_mismatch = case layout_info of
NoLayoutInfo -> False
ExplicitBraces -> False
VirtualBraces n -> n /= srcSpanStartCol (psRealSpan l_comment)
mkDocIE :: PsLocated HdkComment -> Maybe (LIE GhcPs)
mkDocIE (L l_comment hdk_comment) =
case hdk_comment of
HdkCommentSection n doc -> Just $ L l (IEGroup noExtField n doc)
HdkCommentNamed s _doc -> Just $ L l (IEDocNamed noExtField s)
HdkCommentNext doc -> Just $ L l (IEDoc noExtField doc)
_ -> Nothing
where l = mkSrcSpanPs l_comment
mkDocNext :: PsLocated HdkComment -> Maybe LHsDocString
mkDocNext (L l (HdkCommentNext doc)) = Just $ L (mkSrcSpanPs l) doc
mkDocNext _ = Nothing
mkDocPrev :: PsLocated HdkComment -> Maybe LHsDocString
mkDocPrev (L l (HdkCommentPrev doc)) = Just $ L (mkSrcSpanPs l) doc
mkDocPrev _ = Nothing
{- *********************************************************************
* *
* LocRange: a location range *
* *
********************************************************************* -}
-- A location range for extracting documentation comments.
data LocRange =
LocRange
{ loc_range_from :: !LowerLocBound,
loc_range_to :: !UpperLocBound,
loc_range_col :: !ColumnBound }
instance Semigroup LocRange where
LocRange from1 to1 col1 <> LocRange from2 to2 col2 =
LocRange (from1 <> from2) (to1 <> to2) (col1 <> col2)
instance Monoid LocRange where
mempty = LocRange mempty mempty mempty
-- The location range from the specified position to the end of the file.
locRangeFrom :: Maybe BufPos -> LocRange
locRangeFrom (Just l) = mempty { loc_range_from = StartLoc l }
locRangeFrom Nothing = mempty
-- The location range from the start of the file to the specified position.
locRangeTo :: Maybe BufPos -> LocRange
locRangeTo (Just l) = mempty { loc_range_to = EndLoc l }
locRangeTo Nothing = mempty
-- Represents a predicate on BufPos:
--
-- LowerLocBound | BufPos -> Bool
-- --------------+-----------------
-- StartOfFile | const True
-- StartLoc p | (>= p)
--
-- The semigroup instance corresponds to (&&).
--
-- We don't use the BufPos -> Bool representation
-- as it would lead to redundant checks.
--
-- That is, instead of
--
-- (pos >= 20) && (pos >= 30) && (pos >= 40)
--
-- We'd rather only do the (>=40) check. So we reify the predicate to make
-- sure we only check for the most restrictive bound.
data LowerLocBound = StartOfFile | StartLoc !BufPos
instance Semigroup LowerLocBound where
StartOfFile <> l = l
l <> StartOfFile = l
StartLoc l1 <> StartLoc l2 = StartLoc (max l1 l2)
instance Monoid LowerLocBound where
mempty = StartOfFile
-- Represents a predicate on BufPos:
--
-- UpperLocBound | BufPos -> Bool
-- --------------+-----------------
-- EndOfFile | const True
-- EndLoc p | (<= p)
--
-- The semigroup instance corresponds to (&&).
--
-- We don't use the BufPos -> Bool representation
-- as it would lead to redundant checks.
--
-- That is, instead of
--
-- (pos <= 40) && (pos <= 30) && (pos <= 20)
--
-- We'd rather only do the (<=20) check. So we reify the predicate to make
-- sure we only check for the most restrictive bound.
data UpperLocBound = EndOfFile | EndLoc !BufPos
instance Semigroup UpperLocBound where
EndOfFile <> l = l
l <> EndOfFile = l
EndLoc l1 <> EndLoc l2 = EndLoc (min l1 l2)
instance Monoid UpperLocBound where
mempty = EndOfFile
-- | Represents a predicate on the column number.
--
-- ColumnBound | Int -> Bool
-- --------------+-----------------
-- ColumnFrom n | (>=n)
--
-- The semigroup instance corresponds to (&&).
--
newtype ColumnBound = ColumnFrom Int -- n >= GHC.Types.SrcLoc.leftmostColumn
instance Semigroup ColumnBound where
ColumnFrom n <> ColumnFrom m = ColumnFrom (max n m)
instance Monoid ColumnBound where
mempty = ColumnFrom leftmostColumn
{- *********************************************************************
* *
* AST manipulation utilities *
* *
********************************************************************* -}
mkLHsDocTy :: LHsType GhcPs -> Maybe LHsDocString -> LHsType GhcPs
mkLHsDocTy t Nothing = t
mkLHsDocTy t (Just doc) = L (getLoc t) (HsDocTy noExtField t doc)
getForAllTeleLoc :: HsForAllTelescope GhcPs -> SrcSpan
getForAllTeleLoc tele =
foldr combineSrcSpans noSrcSpan $
case tele of
HsForAllVis{ hsf_vis_bndrs } -> map getLoc hsf_vis_bndrs
HsForAllInvis { hsf_invis_bndrs } -> map getLoc hsf_invis_bndrs
-- | The inverse of 'partitionBindsAndSigs' that merges partitioned items back
-- into a flat list. Elements are put back into the order in which they
-- appeared in the original program before partitioning, using BufPos to order
-- them.
--
-- Precondition (unchecked): the input lists are already sorted.
flattenBindsAndSigs
:: (LHsBinds GhcPs, [LSig GhcPs], [LFamilyDecl GhcPs],
[LTyFamInstDecl GhcPs], [LDataFamInstDecl GhcPs], [LDocDecl])
-> [LHsDecl GhcPs]
flattenBindsAndSigs (all_bs, all_ss, all_ts, all_tfis, all_dfis, all_docs) =
-- 'cmpBufSpan' is safe here with the following assumptions:
--
-- - 'LHsDecl' produced by 'decl_cls' in Parser.y always have a 'BufSpan'
-- - 'partitionBindsAndSigs' does not discard this 'BufSpan'
mergeListsBy cmpBufSpan [
mapLL (\b -> ValD noExtField b) (bagToList all_bs),
mapLL (\s -> SigD noExtField s) all_ss,
mapLL (\t -> TyClD noExtField (FamDecl noExtField t)) all_ts,
mapLL (\tfi -> InstD noExtField (TyFamInstD noExtField tfi)) all_tfis,
mapLL (\dfi -> InstD noExtField (DataFamInstD noExtField dfi)) all_dfis,
mapLL (\d -> DocD noExtField d) all_docs
]
{- *********************************************************************
* *
* General purpose utilities *
* *
********************************************************************* -}
-- Cons an element to a list, if exists.
mcons :: Maybe a -> [a] -> [a]
mcons = maybe id (:)
-- Map a function over a list of located items.
mapLL :: (a -> b) -> [Located a] -> [Located b]
mapLL f = map (mapLoc f)
{- Note [Old solution: Haddock in the grammar]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In the past, Haddock comments were incorporated into the grammar (Parser.y).
This led to excessive complexity and duplication.
For example, here's the grammar production for types without documentation:
type : btype
| btype '->' ctype
To support Haddock, we had to also maintain an additional grammar production
for types with documentation on function arguments and function result:
typedoc : btype
| btype docprev
| docnext btype
| btype '->' ctypedoc
| btype docprev '->' ctypedoc
| docnext btype '->' ctypedoc
Sometimes handling documentation comments during parsing led to bugs (#17561),
and sometimes it simply made it hard to modify and extend the grammar.
Another issue was that sometimes Haddock would fail to parse code
that GHC could parse succesfully:
class BadIndent where
f :: a -> Int
-- ^ comment
g :: a -> Int
This declaration was accepted by ghc but rejected by ghc -haddock.
-}
{- Note [Register keyword location]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
At the moment, 'addHaddock' erroneously associates some comments with
constructs that are separated by a keyword. For example:
data Foo -- | Comment for MkFoo
where MkFoo :: Foo
The issue stems from the lack of location information for keywords. We could
utilize API Annotations for this purpose, but not without modification. For
example, API Annotations operate on RealSrcSpan, whereas we need BufSpan.
Also, there's work towards making API Annotations available in-tree (not in
a separate Map), see #17638. This change should make the fix very easy (it
is not as easy with the current design).
See also testsuite/tests/haddock/should_compile_flag_haddock/T17544_kw.hs
-}
|