1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
|
package project_test
import (
"context"
"crypto/x509"
"net/http"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/lxc/incus/v6/internal/server/auth"
"github.com/lxc/incus/v6/internal/server/certificate"
"github.com/lxc/incus/v6/internal/server/db"
"github.com/lxc/incus/v6/internal/server/db/cluster"
"github.com/lxc/incus/v6/internal/server/instance/instancetype"
"github.com/lxc/incus/v6/internal/server/project"
"github.com/lxc/incus/v6/internal/server/request"
"github.com/lxc/incus/v6/shared/api"
"github.com/lxc/incus/v6/shared/logger"
)
// If there's no limit configured on the project, the check passes.
func TestAllowInstanceCreation_NotConfigured(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
req := api.InstancesPost{
Name: "c1",
Type: api.InstanceTypeContainer,
}
err := project.AllowInstanceCreation(tx, "default", req)
assert.NoError(t, err)
}
// If a limit is configured and the current number of instances is below it, the check passes.
func TestAllowInstanceCreation_Below(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"limits.containers": "5"})
require.NoError(t, err)
_, err = cluster.CreateInstance(ctx, tx.Tx(), cluster.Instance{
Project: "p1",
Name: "c1",
Type: instancetype.Container,
Architecture: 1,
Node: "none",
})
require.NoError(t, err)
req := api.InstancesPost{
Name: "c2",
Type: api.InstanceTypeContainer,
}
err = project.AllowInstanceCreation(tx, "p1", req)
assert.NoError(t, err)
}
// If a limit is configured and it matches the current number of instances, the
// check fails.
func TestAllowInstanceCreation_Above(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"limits.containers": "1"})
require.NoError(t, err)
_, err = cluster.CreateInstance(ctx, tx.Tx(), cluster.Instance{
Project: "p1",
Name: "c1",
Type: instancetype.Container,
Architecture: 1,
Node: "none",
})
require.NoError(t, err)
req := api.InstancesPost{
Name: "c2",
Type: api.InstanceTypeContainer,
}
err = project.AllowInstanceCreation(tx, "p1", req)
assert.EqualError(t, err, `Reached maximum number of instances of type "container" in project "p1"`)
}
// If a limit is configured, but for a different instance type, the check
// passes.
func TestAllowInstanceCreation_DifferentType(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"limits.containers": "1"})
require.NoError(t, err)
_, err = cluster.CreateInstance(ctx, tx.Tx(), cluster.Instance{
Project: "p1",
Name: "vm1",
Type: instancetype.VM,
Architecture: 1,
Node: "none",
})
require.NoError(t, err)
req := api.InstancesPost{
Name: "c2",
Type: api.InstanceTypeContainer,
}
err = project.AllowInstanceCreation(tx, "p1", req)
assert.NoError(t, err)
}
// If a limit is configured, but the limit on instances is more
// restrictive, the check fails.
func TestAllowInstanceCreation_AboveInstances(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"limits.containers": "5", "limits.instances": "1"})
require.NoError(t, err)
_, err = cluster.CreateInstance(ctx, tx.Tx(), cluster.Instance{
Project: "p1",
Name: "c1",
Type: instancetype.Container,
Architecture: 1,
Node: "none",
})
require.NoError(t, err)
req := api.InstancesPost{
Name: "c2",
Type: api.InstanceTypeContainer,
}
err = project.AllowInstanceCreation(tx, "p1", req)
assert.EqualError(t, err, `Reached maximum number of instances in project "p1"`)
}
// If a direct targeting is blocked, the check fails.
func TestCheckClusterTargetRestriction_RestrictedTrue(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"restricted": "true", "restricted.cluster.target": "block"})
require.NoError(t, err)
dbProject, err := cluster.GetProject(ctx, tx.Tx(), "p1")
require.NoError(t, err)
p, err := dbProject.ToAPI(ctx, tx.Tx())
require.NoError(t, err)
req := &http.Request{}
authorizer, err := auth.LoadAuthorizer(context.Background(), auth.DriverTLS, logger.Log, &certificate.Cache{})
require.NoError(t, err)
err = project.CheckClusterTargetRestriction(authorizer, req, p, "n1")
assert.EqualError(t, err, "This project doesn't allow cluster member targeting")
}
// If a direct targeting is blocked but the user can override it, the check passes.
func TestCheckClusterTargetRestriction_RestrictedTrueWithOverride(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"restricted": "true", "restricted.cluster.target": "block"})
require.NoError(t, err)
dbProject, err := cluster.GetProject(ctx, tx.Tx(), "p1")
require.NoError(t, err)
p, err := dbProject.ToAPI(ctx, tx.Tx())
require.NoError(t, err)
req := &http.Request{
URL: &api.NewURL().Path("1.0", "instances").WithQuery("target", "node01").URL,
}
req = req.WithContext(context.WithValue(req.Context(), request.CtxProtocol, "tls"))
req = req.WithContext(context.WithValue(req.Context(), request.CtxUsername, "my-certificate-fingerprint"))
certificateCache := &certificate.Cache{}
// Setting the certificate and not projects means the certificate is not restricted and therefore the user is an
// admin that can override the cluster target restriction.
certificateCache.SetCertificates(map[certificate.Type]map[string]x509.Certificate{
certificate.TypeClient: {
"my-certificate-fingerprint": x509.Certificate{},
},
})
authorizer, err := auth.LoadAuthorizer(context.Background(), auth.DriverTLS, logger.Log, certificateCache)
require.NoError(t, err)
err = project.CheckClusterTargetRestriction(authorizer, req, p, "n1")
assert.Nil(t, err)
}
// If a direct targeting is allowed, the check passes.
func TestCheckClusterTargetRestriction_RestrictedFalse(t *testing.T) {
tx, cleanup := db.NewTestClusterTx(t)
defer cleanup()
ctx := context.Background()
id, err := cluster.CreateProject(ctx, tx.Tx(), cluster.Project{Name: "p1"})
require.NoError(t, err)
err = cluster.CreateProjectConfig(ctx, tx.Tx(), id, map[string]string{"restricted": "false", "restricted.cluster.target": "block"})
require.NoError(t, err)
dbProject, err := cluster.GetProject(ctx, tx.Tx(), "p1")
require.NoError(t, err)
p, err := dbProject.ToAPI(ctx, tx.Tx())
require.NoError(t, err)
req := &http.Request{}
authorizer, err := auth.LoadAuthorizer(context.Background(), auth.DriverTLS, logger.Log, &certificate.Cache{})
require.NoError(t, err)
err = project.CheckClusterTargetRestriction(authorizer, req, p, "n1")
assert.NoError(t, err)
}
|
