1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
|
package cluster_test
import (
"context"
"net/http"
"net/http/httptest"
"slices"
"strconv"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
incus "github.com/lxc/incus/v6/client"
"github.com/lxc/incus/v6/internal/server/cluster"
"github.com/lxc/incus/v6/internal/server/db"
"github.com/lxc/incus/v6/internal/server/node"
"github.com/lxc/incus/v6/internal/server/state"
localUtil "github.com/lxc/incus/v6/internal/server/util"
"github.com/lxc/incus/v6/shared/api"
localtls "github.com/lxc/incus/v6/shared/tls"
"github.com/lxc/incus/v6/shared/tls/tlstest"
)
// The returned notifier connects to all nodes.
func TestNewNotifier(t *testing.T) {
state, cleanup := state.NewTestState(t)
defer cleanup()
cert := tlstest.TestingKeyPair(t)
f := notifyFixtures{t: t, state: state}
defer f.Nodes(cert, 3)()
// Populate state.LocalConfig after nodes created above.
var err error
var nodeConfig *node.Config
err = state.DB.Node.Transaction(context.TODO(), func(ctx context.Context, tx *db.NodeTx) error {
nodeConfig, err = node.ConfigLoad(ctx, tx)
return err
})
require.NoError(t, err)
state.LocalConfig = nodeConfig
notifier, err := cluster.NewNotifier(state, cert, cert, cluster.NotifyAll)
require.NoError(t, err)
peers := make(chan string, 2)
hook := func(client incus.InstanceServer) error {
server, _, err := client.GetServer()
require.NoError(t, err)
peers <- server.Config["cluster.https_address"]
return nil
}
assert.NoError(t, notifier(hook))
addresses := make([]string, 2)
for i := range addresses {
select {
case addresses[i] = <-peers:
default:
}
}
require.NoError(t, err)
for i := range addresses {
assert.True(t, slices.Contains(addresses, f.Address(i+1)))
}
}
// Creating a new notifier fails if the policy is set to NotifyAll and one of
// the nodes is down.
func TestNewNotify_NotifyAllError(t *testing.T) {
state, cleanup := state.NewTestState(t)
defer cleanup()
cert := tlstest.TestingKeyPair(t)
f := notifyFixtures{t: t, state: state}
defer f.Nodes(cert, 3)()
f.Down(1)
// Populate state.LocalConfig after nodes created above.
var err error
var nodeConfig *node.Config
err = state.DB.Node.Transaction(context.TODO(), func(ctx context.Context, tx *db.NodeTx) error {
nodeConfig, err = node.ConfigLoad(ctx, tx)
return err
})
require.NoError(t, err)
state.LocalConfig = nodeConfig
notifier, err := cluster.NewNotifier(state, cert, cert, cluster.NotifyAll)
assert.Nil(t, notifier)
require.Error(t, err)
assert.Regexp(t, "peer node .+ is down", err.Error())
}
// Creating a new notifier does not fail if the policy is set to NotifyAlive
// and one of the nodes is down, however dead nodes are ignored.
func TestNewNotify_NotifyAlive(t *testing.T) {
state, cleanup := state.NewTestState(t)
defer cleanup()
cert := tlstest.TestingKeyPair(t)
f := notifyFixtures{t: t, state: state}
defer f.Nodes(cert, 3)()
f.Down(1)
// Populate state.LocalConfig after nodes created above.
var err error
var nodeConfig *node.Config
err = state.DB.Node.Transaction(context.TODO(), func(ctx context.Context, tx *db.NodeTx) error {
nodeConfig, err = node.ConfigLoad(ctx, tx)
return err
})
require.NoError(t, err)
state.LocalConfig = nodeConfig
notifier, err := cluster.NewNotifier(state, cert, cert, cluster.NotifyAlive)
assert.NoError(t, err)
i := 0
hook := func(client incus.InstanceServer) error {
i++
return nil
}
assert.NoError(t, notifier(hook))
assert.Equal(t, 1, i)
}
// Helper for setting fixtures for Notify tests.
type notifyFixtures struct {
t *testing.T
state *state.State
servers []*httptest.Server
}
// Spawn the given number of fake nodes, save in them in the database and
// return a cleanup function.
//
// The address of the first node spawned will be saved as local
// cluster.https_address.
func (h *notifyFixtures) Nodes(cert *localtls.CertInfo, n int) func() {
servers := make([]*httptest.Server, n)
for i := range n {
servers[i] = newRestServer(cert)
}
// Insert new entries in the nodes table of the cluster database.
err := h.state.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
for i := range n {
name := strconv.Itoa(i)
address := servers[i].Listener.Addr().String()
var err error
if i == 0 {
err = tx.BootstrapNode(name, address)
} else {
_, err = tx.CreateNode(name, address)
}
require.NoError(h.t, err)
}
return nil
})
require.NoError(h.t, err)
// Set the address in the config table of the node database.
err = h.state.DB.Node.Transaction(context.Background(), func(ctx context.Context, tx *db.NodeTx) error {
config, err := node.ConfigLoad(ctx, tx)
require.NoError(h.t, err)
address := servers[0].Listener.Addr().String()
values := map[string]string{"cluster.https_address": address}
_, err = config.Patch(values)
require.NoError(h.t, err)
return nil
})
require.NoError(h.t, err)
cleanup := func() {
for _, server := range servers {
server.Close()
}
}
h.servers = servers
return cleanup
}
// Return the network address of the i-th node.
func (h *notifyFixtures) Address(i int) string {
var address string
err := h.state.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
members, err := tx.GetNodes(ctx)
require.NoError(h.t, err)
address = members[i].Address
return nil
})
require.NoError(h.t, err)
return address
}
// Mark the i'th node as down.
func (h *notifyFixtures) Down(i int) {
err := h.state.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
members, err := tx.GetNodes(ctx)
require.NoError(h.t, err)
err = tx.SetNodeHeartbeat(members[i].Address, time.Now().Add(-time.Minute))
require.NoError(h.t, err)
return nil
})
require.NoError(h.t, err)
h.servers[i].Close()
}
// Returns a minimal stub for the REST API server, just realistic
// enough to make incus.ConnectIncus succeed.
func newRestServer(cert *localtls.CertInfo) *httptest.Server {
mux := http.NewServeMux()
server := httptest.NewUnstartedServer(mux)
server.TLS = localUtil.ServerTLSConfig(cert)
server.StartTLS()
mux.HandleFunc("/1.0/", func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
config := map[string]string{"cluster.https_address": server.Listener.Addr().String()}
metadata := api.ServerPut{Config: config}
_ = localUtil.WriteJSON(w, api.ResponseRaw{Metadata: metadata}, nil)
})
return server
}
|
