1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
|
package cluster_test
import (
"context"
"errors"
"fmt"
"io/fs"
"net/http"
"os"
"path/filepath"
"sync"
"testing"
"time"
"github.com/cowsql/go-cowsql/client"
"github.com/cowsql/go-cowsql/driver"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/lxc/incus/v6/internal/server/cluster"
"github.com/lxc/incus/v6/internal/server/db"
"github.com/lxc/incus/v6/internal/server/node"
"github.com/lxc/incus/v6/internal/server/state"
localtls "github.com/lxc/incus/v6/shared/tls"
"github.com/lxc/incus/v6/shared/tls/tlstest"
)
// A node can unblock other nodes that were waiting for a cluster upgrade to
// complete.
func TestNotifyUpgradeCompleted(t *testing.T) {
f := heartbeatFixture{t: t}
defer f.Cleanup()
gateway0 := f.Bootstrap()
gateway1 := f.Grow()
wg := sync.WaitGroup{}
wg.Add(1)
go func() {
gateway1.WaitUpgradeNotification()
wg.Done()
}()
state0 := f.State(gateway0)
// Populate state.LocalConfig after nodes created above.
var err error
var nodeConfig *node.Config
err = state0.DB.Node.Transaction(context.TODO(), func(ctx context.Context, tx *db.NodeTx) error {
nodeConfig, err = node.ConfigLoad(ctx, tx)
return err
})
require.NoError(t, err)
state0.LocalConfig = nodeConfig
serverCert0 := gateway0.ServerCert()
err = cluster.NotifyUpgradeCompleted(state0, serverCert0, serverCert0)
require.NoError(t, err)
wg.Wait()
}
// The task function checks if the node is out of date and runs whatever is in
// INCUS_CLUSTER_UPDATE if so.
func TestMaybeUpdate_Upgrade(t *testing.T) {
dir, err := os.MkdirTemp("", "")
require.NoError(t, err)
defer func() { _ = os.RemoveAll(dir) }()
// Create a stub upgrade script that just touches a stamp file.
stamp := filepath.Join(dir, "stamp")
script := filepath.Join(dir, "cluster-upgrade")
data := fmt.Appendf(nil, "#!/bin/sh\ntouch %s\n", stamp)
err = os.WriteFile(script, data, 0o755)
require.NoError(t, err)
state, cleanup := state.NewTestState(t)
defer cleanup()
_ = state.DB.Node.Transaction(context.Background(), func(ctx context.Context, tx *db.NodeTx) error {
nodes := []db.RaftNode{
{NodeInfo: client.NodeInfo{ID: 1, Address: "0.0.0.0:666"}},
{NodeInfo: client.NodeInfo{ID: 2, Address: "1.2.3.4:666"}},
}
err := tx.ReplaceRaftNodes(nodes)
require.NoError(t, err)
return nil
})
_ = state.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
id, err := tx.CreateNode("buzz", "1.2.3.4:666")
require.NoError(t, err)
node, err := tx.GetNodeByName(ctx, "buzz")
require.NoError(t, err)
version := node.Version()
version[0]++
err = tx.SetNodeVersion(id, version)
require.NoError(t, err)
return nil
})
_ = os.Setenv("INCUS_CLUSTER_UPDATE", script)
defer func() { _ = os.Unsetenv("INCUS_CLUSTER_UPDATE") }()
_ = cluster.MaybeUpdate(state)
_, err = os.Stat(stamp)
require.NoError(t, err)
}
// If the node is up-to-date, nothing is done.
func TestMaybeUpdate_NothingToDo(t *testing.T) {
dir, err := os.MkdirTemp("", "")
require.NoError(t, err)
defer func() { _ = os.RemoveAll(dir) }()
// Create a stub upgrade script that just touches a stamp file.
stamp := filepath.Join(dir, "stamp")
script := filepath.Join(dir, "cluster-upgrade")
data := fmt.Appendf(nil, "#!/bin/sh\ntouch %s\n", stamp)
err = os.WriteFile(script, data, 0o755)
require.NoError(t, err)
state, cleanup := state.NewTestState(t)
defer cleanup()
_ = os.Setenv("INCUS_CLUSTER_UPDATE", script)
defer func() { _ = os.Unsetenv("INCUS_CLUSTER_UPDATE") }()
_ = cluster.MaybeUpdate(state)
_, err = os.Stat(stamp)
require.True(t, errors.Is(err, fs.ErrNotExist))
}
func TestUpgradeMembersWithoutRole(t *testing.T) {
state, cleanup := state.NewTestState(t)
defer cleanup()
serverCert := tlstest.TestingKeyPair(t)
mux := http.NewServeMux()
server := newServer(serverCert, mux)
defer server.Close()
address := server.Listener.Addr().String()
setRaftRole(t, state.DB.Node, address)
state.ServerCert = func() *localtls.CertInfo { return serverCert }
gateway := newGateway(t, state.DB.Node, serverCert, state)
defer func() { _ = gateway.Shutdown() }()
for path, handler := range gateway.HandlerFuncs(nil, trustedCerts) {
mux.HandleFunc(path, handler)
}
var err error
require.NoError(t, state.DB.Cluster.Close())
store := gateway.NodeStore()
dial := gateway.DialFunc()
state.DB.Cluster, err = db.OpenCluster(context.Background(), "db.bin", store, address, "/unused/db/dir", 5*time.Second, driver.WithDialFunc(dial))
require.NoError(t, err)
gateway.Cluster = state.DB.Cluster
// Add a couple of members to the database.
var members []db.NodeInfo
err = state.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
_, err := tx.CreateNode("foo", "1.2.3.4")
require.NoError(t, err)
_, err = tx.CreateNode("bar", "5.6.7.8")
require.NoError(t, err)
members, err = tx.GetNodes(ctx)
require.NoError(t, err)
return nil
})
require.NoError(t, err)
err = cluster.UpgradeMembersWithoutRole(gateway, members)
require.NoError(t, err)
// The members have been added to the raft configuration.
nodes, err := gateway.RaftNodes()
require.NoError(t, err)
assert.Len(t, nodes, 3)
assert.Equal(t, uint64(1), nodes[0].ID)
assert.Equal(t, address, nodes[0].Address)
assert.Equal(t, uint64(2), nodes[1].ID)
assert.Equal(t, "1.2.3.4", nodes[1].Address)
assert.Equal(t, uint64(3), nodes[2].ID)
assert.Equal(t, "5.6.7.8", nodes[2].Address)
}
|
