1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
|
package main
import (
"context"
"encoding/json"
"errors"
"fmt"
"maps"
"net/http"
"net/url"
"strings"
"github.com/gorilla/mux"
incus "github.com/lxc/incus/v6/client"
internalInstance "github.com/lxc/incus/v6/internal/instance"
"github.com/lxc/incus/v6/internal/server/auth"
"github.com/lxc/incus/v6/internal/server/cluster"
clusterRequest "github.com/lxc/incus/v6/internal/server/cluster/request"
"github.com/lxc/incus/v6/internal/server/db"
dbCluster "github.com/lxc/incus/v6/internal/server/db/cluster"
"github.com/lxc/incus/v6/internal/server/db/operationtype"
deviceConfig "github.com/lxc/incus/v6/internal/server/device/config"
"github.com/lxc/incus/v6/internal/server/instance"
"github.com/lxc/incus/v6/internal/server/instance/instancetype"
"github.com/lxc/incus/v6/internal/server/operations"
"github.com/lxc/incus/v6/internal/server/project"
"github.com/lxc/incus/v6/internal/server/request"
"github.com/lxc/incus/v6/internal/server/response"
"github.com/lxc/incus/v6/internal/server/scriptlet"
"github.com/lxc/incus/v6/internal/server/state"
storagePools "github.com/lxc/incus/v6/internal/server/storage"
"github.com/lxc/incus/v6/internal/version"
"github.com/lxc/incus/v6/shared/api"
apiScriptlet "github.com/lxc/incus/v6/shared/api/scriptlet"
"github.com/lxc/incus/v6/shared/logger"
)
// swagger:operation POST /1.0/instances/{name} instances instance_post
//
// Rename or move/migrate an instance
//
// Renames, moves an instance between pools or migrates an instance to another server.
//
// The returned operation metadata will vary based on what's requested.
// For rename or move within the same server, this is a simple background operation with progress data.
// For migration, in the push case, this will similarly be a background
// operation with progress data, for the pull case, it will be a websocket
// operation with a number of secrets to be passed to the target server.
//
// ---
// consumes:
// - application/json
// produces:
// - application/json
// parameters:
// - in: query
// name: project
// description: Project name
// type: string
// example: default
// - in: body
// name: migration
// description: Migration request
// schema:
// $ref: "#/definitions/InstancePost"
// responses:
// "202":
// $ref: "#/responses/Operation"
// "400":
// $ref: "#/responses/BadRequest"
// "403":
// $ref: "#/responses/Forbidden"
// "500":
// $ref: "#/responses/InternalServerError"
func instancePost(d *Daemon, r *http.Request) response.Response {
s := d.State()
// Don't mess with instance while in setup mode.
<-d.waitReady.Done()
// Parse the request URL.
projectName := request.ProjectParam(r)
target := request.QueryParam(r, "target")
name, err := url.PathUnescape(mux.Vars(r)["name"])
if err != nil {
return response.SmartError(err)
}
// Quick checks.
if internalInstance.IsSnapshot(name) {
return response.BadRequest(errors.New("Invalid instance name"))
}
if target != "" && !s.ServerClustered {
return response.BadRequest(errors.New("Target only allowed when clustered"))
}
// Check if the server the instance is running on is currently online.
var sourceMemberInfo *db.NodeInfo
err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error {
// Load source node.
sourceAddress, err := tx.GetNodeAddressOfInstance(ctx, projectName, name)
if err != nil {
return fmt.Errorf("Failed to get address of instance's member: %w", err)
}
if sourceAddress == "" {
// Local node.
return nil
}
info, err := tx.GetNodeByAddress(ctx, sourceAddress)
if err != nil {
return fmt.Errorf("Failed to get source member for %q: %w", sourceAddress, err)
}
sourceMemberInfo = &info
return nil
})
if err != nil {
return response.SmartError(err)
}
// More checks.
if target == "" && sourceMemberInfo != nil && sourceMemberInfo.IsOffline(s.GlobalConfig.OfflineThreshold()) {
return response.BadRequest(errors.New("Can't perform action as server is currently offline"))
}
// Handle request forwarding.
if sourceMemberInfo != nil && sourceMemberInfo.IsOffline(s.GlobalConfig.OfflineThreshold()) {
// Current location of the instance isn't available and we've been asked to relocate it, forward to target.
resp := forwardedResponseIfTargetIsRemote(s, r)
if resp != nil {
return resp
}
} else if target == "" || sourceMemberInfo == nil || !sourceMemberInfo.IsOffline(s.GlobalConfig.OfflineThreshold()) {
// Forward the request to the instance's current location (if not local).
resp, err := forwardedResponseIfInstanceIsRemote(s, r, projectName, name)
if err != nil {
return response.SmartError(err)
}
if resp != nil {
return resp
}
}
// Parse the request.
req := api.InstancePost{}
err = json.NewDecoder(r.Body).Decode(&req)
if err != nil {
return response.BadRequest(err)
}
// Target instance properties.
instProject := projectName
instLocation := target
// Clear instance name if it's the same.
if req.Name != "" && req.Name == name {
req.Name = ""
}
// Validate the new target project (if provided).
if req.Project != "" {
// Confirm access to target project.
err := s.Authorizer.CheckPermission(r.Context(), r, auth.ObjectProject(req.Project), auth.EntitlementCanCreateInstances)
if err != nil {
return response.SmartError(err)
}
instProject = req.Project
}
// Validate the new instance name (if provided).
if req.Name != "" {
// Check the new instance name is valid.
err = instance.ValidName(req.Name, false)
if err != nil {
return response.BadRequest(err)
}
// Check that the new isn't already in use.
var id int
err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error {
// Check that the name isn't already in use.
id, _ = tx.GetInstanceID(ctx, instProject, req.Name)
return nil
})
if id > 0 {
return response.Conflict(fmt.Errorf("Name %q already in use", req.Name))
}
}
// Load the local instance.
inst, err := instance.LoadByProjectAndName(s, projectName, name)
if err != nil {
return response.SmartError(err)
}
// Handle simple instance renaming.
if !req.Migration {
run := func(op *operations.Operation) error {
inst.SetOperation(op)
return inst.Rename(req.Name, true)
}
resources := map[string][]api.URL{}
resources["instances"] = []api.URL{*api.NewURL().Path(version.APIVersion, "instances", name)}
op, err := operations.OperationCreate(s, projectName, operations.OperationClassTask, operationtype.InstanceRename, resources, nil, run, nil, nil, r)
if err != nil {
return response.InternalError(err)
}
return operations.OperationResponse(op)
}
// Start handling migrations.
if inst.IsSnapshot() {
return response.BadRequest(errors.New("Instance snapshots cannot be moved on their own"))
}
// Checks for running instances.
if inst.IsRunning() {
if req.Pool != "" || req.Project != "" || target != "" {
// Stateless migrations need the instance stopped.
if !req.Live {
return response.BadRequest(errors.New("Instance must be stopped to be moved statelessly"))
}
// Storage pool changes require a target flag.
if req.Pool != "" {
if inst.Type() != instancetype.VM {
return response.BadRequest(errors.New("Live storage pool changes aren't supported for containers"))
}
if !s.ServerClustered {
return response.BadRequest(errors.New("Live storage pool changes aren't supported on standalone systems"))
}
if target == "" {
return response.BadRequest(errors.New("Live storage pool changes require the VM be moved to another cluster member"))
}
}
// Project changes require a stopped instance.
if req.Project != "" {
return response.BadRequest(errors.New("Instance must be stopped to be moved across projects"))
}
// Name changes require a stopped instance.
if req.Name != "" {
return response.BadRequest(errors.New("Instance must be stopped to change their names"))
}
}
} else {
// Clear Live flag if instance isn't running.
req.Live = false
}
// Check for offline sources.
if sourceMemberInfo != nil && sourceMemberInfo.IsOffline(s.GlobalConfig.OfflineThreshold()) && (req.Pool != "" || req.Project != "" || req.Name != "") {
return response.BadRequest(errors.New("Instance server is currently offline"))
}
// When in a cluster, default to keeping current location.
if instLocation == "" && inst.Location() != "" {
instLocation = inst.Location()
}
// If clustered, consider a new location for the instance.
var targetMemberInfo *db.NodeInfo
var targetCandidates []db.NodeInfo
if s.ServerClustered && (target != "" || req.Project != "") {
err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error {
var targetGroupName string
// Load the target project.
p, err := dbCluster.GetProject(ctx, tx.Tx(), instProject)
if err != nil {
return err
}
targetProject, err := p.ToAPI(ctx, tx.Tx())
if err != nil {
return err
}
// Load the cluster members.
allMembers, err := tx.GetNodes(ctx)
if err != nil {
return fmt.Errorf("Failed getting cluster members: %w", err)
}
// Check if the current location is fine.
targetMemberInfo, _, err = project.CheckTarget(ctx, s.Authorizer, r, tx, targetProject, instLocation, allMembers)
if err == nil && targetMemberInfo != nil {
return nil
}
// If we must change location, validate access to requested member/group (if provided).
targetMemberInfo, targetGroupName, err = project.CheckTarget(ctx, s.Authorizer, r, tx, targetProject, target, allMembers)
if err != nil {
return err
}
// If no specific server, get a list of allowed candidates.
if targetMemberInfo == nil {
clusterGroupsAllowed := project.GetRestrictedClusterGroups(targetProject)
targetCandidates, err = tx.GetCandidateMembers(ctx, allMembers, []int{inst.Architecture()}, targetGroupName, clusterGroupsAllowed, s.GlobalConfig.OfflineThreshold())
if err != nil {
return err
}
}
return nil
})
if err != nil {
return response.SmartError(err)
}
// Run instance placement scriptlet if enabled.
if s.GlobalConfig.InstancesPlacementScriptlet() != "" {
// If a target was specified, limit the list of candidates to that target.
if targetMemberInfo != nil {
targetCandidates = []db.NodeInfo{*targetMemberInfo}
}
leaderAddress, err := s.Cluster.LeaderAddress()
if err != nil {
return response.InternalError(err)
}
// Load profiles.
profileNames := make([]string, 0, len(inst.Profiles()))
for _, profile := range inst.Profiles() {
profileNames = append(profileNames, profile.Name)
}
profiles := make([]api.Profile, 0, len(profileNames))
if len(profileNames) > 0 {
err = s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error {
profileFilters := make([]dbCluster.ProfileFilter, 0, len(profileNames))
for _, profileName := range profileNames {
profileFilters = append(profileFilters, dbCluster.ProfileFilter{
Project: &instProject,
Name: &profileName,
})
}
dbProfiles, err := dbCluster.GetProfiles(ctx, tx.Tx(), profileFilters...)
if err != nil {
return err
}
dbProfileConfigs, err := dbCluster.GetAllProfileConfigs(ctx, tx.Tx())
if err != nil {
return err
}
dbProfileDevices, err := dbCluster.GetAllProfileDevices(ctx, tx.Tx())
if err != nil {
return err
}
profilesByName := make(map[string]dbCluster.Profile, len(dbProfiles))
for _, dbProfile := range dbProfiles {
profilesByName[dbProfile.Name] = dbProfile
}
for _, profileName := range profileNames {
profile, found := profilesByName[profileName]
if !found {
return fmt.Errorf("Requested profile %q doesn't exist", profileName)
}
apiProfile, err := profile.ToAPI(ctx, tx.Tx(), dbProfileConfigs, dbProfileDevices)
if err != nil {
return err
}
profiles = append(profiles, *apiProfile)
}
return nil
})
if err != nil {
return response.SmartError(err)
}
}
// Prepare the placement scriptlet context.
req := apiScriptlet.InstancePlacement{
InstancesPost: api.InstancesPost{
Name: name,
Type: api.InstanceTypeAny,
InstancePut: api.InstancePut{
Config: db.ExpandInstanceConfig(inst.LocalConfig(), profiles),
Devices: db.ExpandInstanceDevices(deviceConfig.NewDevices(inst.LocalDevices().CloneNative()), profiles).CloneNative(),
Profiles: profileNames,
},
},
Project: instProject,
Reason: apiScriptlet.InstancePlacementReasonRelocation,
}
if targetMemberInfo == nil {
// Get a new target.
targetMemberInfo, err = scriptlet.InstancePlacementRun(r.Context(), logger.Log, s, &req, targetCandidates, leaderAddress)
if err != nil {
return response.BadRequest(fmt.Errorf("Failed instance placement scriptlet: %w", err))
}
} else {
// Validate the current target.
_, err = scriptlet.InstancePlacementRun(r.Context(), logger.Log, s, &req, targetCandidates, leaderAddress)
if err != nil {
return response.BadRequest(fmt.Errorf("Failed instance placement scriptlet: %w", err))
}
}
}
// If no member was selected yet, pick the member with the least number of instances.
if targetMemberInfo == nil {
var filteredCandidateMembers []db.NodeInfo
// The instance might already be placed on the node with least number of instances.
// Therefore remove it from the list of possible candidates if existent.
for _, candidateMember := range targetCandidates {
if candidateMember.Name != inst.Location() {
filteredCandidateMembers = append(filteredCandidateMembers, candidateMember)
}
}
if len(filteredCandidateMembers) == 0 {
return response.InternalError(errors.New("Couldn't find a cluster member for the instance"))
}
targetMemberInfo = &filteredCandidateMembers[0]
}
if targetMemberInfo.IsOffline(s.GlobalConfig.OfflineThreshold()) {
return response.BadRequest(errors.New("Target cluster member is offline"))
}
}
// If the user requested a specific server group, make sure we can have it recorded.
var targetGroupName string
after, ok := strings.CutPrefix(target, targetGroupPrefix)
if ok {
targetGroupName = after
}
// Check that we're not requested to move to the same location we're currently on.
if target != "" && targetMemberInfo.Name == inst.Location() {
return response.BadRequest(errors.New("Requested target server is the same as current server"))
}
// If the instance needs to move, make sure it doesn't have backups.
if targetMemberInfo != nil && targetMemberInfo.Name != inst.Location() {
// Check if instance has backups.
var backups []string
err := s.DB.Cluster.Transaction(r.Context(), func(ctx context.Context, tx *db.ClusterTx) error {
backups, err = tx.GetInstanceBackups(ctx, projectName, name)
return err
})
if err != nil {
err = fmt.Errorf("Failed to fetch instance's backups: %w", err)
return response.SmartError(err)
}
if len(backups) > 0 {
return response.BadRequest(errors.New("Instances with backups cannot be moved"))
}
}
// Server-side instance migration.
if req.Pool != "" || req.Project != "" || target != "" {
// Clear targetMemberInfo if no target change required.
if targetMemberInfo != nil && inst.Location() == targetMemberInfo.Name {
targetMemberInfo = nil
}
// Setup the instance move operation.
run := func(op *operations.Operation) error {
inst.SetOperation(op)
return migrateInstance(context.TODO(), s, inst, req, sourceMemberInfo, targetMemberInfo, targetGroupName, op)
}
resources := map[string][]api.URL{}
resources["instances"] = []api.URL{*api.NewURL().Path(version.APIVersion, "instances", name)}
op, err := operations.OperationCreate(s, projectName, operations.OperationClassTask, operationtype.InstanceMigrate, resources, nil, run, nil, nil, r)
if err != nil {
return response.InternalError(err)
}
return operations.OperationResponse(op)
}
// Cross-server instance migration.
ws, err := newMigrationSource(inst, req.Live, req.InstanceOnly, req.AllowInconsistent, "", "", req.Target)
if err != nil {
return response.InternalError(err)
}
resources := map[string][]api.URL{}
resources["instances"] = []api.URL{*api.NewURL().Path(version.APIVersion, "instances", name)}
run := func(op *operations.Operation) error {
return ws.do(op)
}
cancel := func(op *operations.Operation) error {
ws.disconnect()
return nil
}
if req.Target != nil {
// Push mode.
op, err := operations.OperationCreate(s, projectName, operations.OperationClassTask, operationtype.InstanceMigrate, resources, nil, run, nil, nil, r)
if err != nil {
return response.InternalError(err)
}
return operations.OperationResponse(op)
}
// Pull mode.
op, err := operations.OperationCreate(s, projectName, operations.OperationClassWebsocket, operationtype.InstanceMigrate, resources, ws.Metadata(), run, cancel, ws.Connect, r)
if err != nil {
return response.InternalError(err)
}
return operations.OperationResponse(op)
}
// Perform the server-side migration.
func migrateInstance(ctx context.Context, s *state.State, inst instance.Instance, req api.InstancePost, sourceMemberInfo *db.NodeInfo, targetMemberInfo *db.NodeInfo, targetGroupName string, op *operations.Operation) error {
// Load the instance storage pool.
sourcePool, err := storagePools.LoadByInstance(s, inst)
if err != nil {
return fmt.Errorf("Failed loading instance storage pool: %w", err)
}
// Check that we're not requested to move to the same storage pool we're currently use.
if req.Pool != "" && req.Pool == sourcePool.Name() {
return errors.New("Requested storage pool is the same as current pool")
}
// Get the DB volume type for the instance.
volType, err := storagePools.InstanceTypeToVolumeType(inst.Type())
if err != nil {
return err
}
volDBType, err := storagePools.VolumeTypeToDBType(volType)
if err != nil {
return err
}
// Handle migration of an instance away from an offline server (on shared storage).
if targetMemberInfo != nil && sourceMemberInfo != nil && sourceMemberInfo.IsOffline(s.GlobalConfig.OfflineThreshold()) && sourcePool.Driver().Info().Remote {
// Update the database records.
err = s.DB.Cluster.Transaction(context.TODO(), func(ctx context.Context, tx *db.ClusterTx) error {
err := tx.UpdateInstanceNode(ctx, inst.Project().Name, inst.Name(), inst.Name(), targetMemberInfo.Name, sourcePool.ID(), volDBType)
if err != nil {
return fmt.Errorf("Failed updating cluster member to %q for instance %q: %w", targetMemberInfo.Name, inst.Name(), err)
}
return nil
})
if err != nil {
return fmt.Errorf("Failed to relink instance database data: %w", err)
}
// Import the instance into the storage.
_, err = sourcePool.ImportInstance(inst, nil, nil)
if err != nil {
return fmt.Errorf("Failed creating mount point of instance on target node: %w", err)
}
// Perform any remaining instance rename.
if req.Name != "" {
err = inst.Rename(req.Name, true)
if err != nil {
return err
}
}
// Record the new group name if needed.
if targetGroupName != "" {
err = inst.VolatileSet(map[string]string{"volatile.cluster.group": targetGroupName})
if err != nil {
return err
}
}
return nil
}
// Save the original value of the "volatile.apply_template" config key,
// since we'll want to preserve it in the copied container.
instVolatileApplyTemplate := inst.LocalConfig()["volatile.apply_template"]
// Get the current instance info.
instInfoRaw, _, err := inst.Render()
if err != nil {
return fmt.Errorf("Failed getting source instance info: %w", err)
}
targetInstInfo, ok := instInfoRaw.(*api.Instance)
if !ok {
return fmt.Errorf("Unexpected result from source instance render: %w", err)
}
// Apply the config overrides.
maps.Copy(targetInstInfo.Config, req.Config)
// Apply the device overrides.
maps.Copy(targetInstInfo.Devices, req.Devices)
// Apply the profile overrides.
if req.Profiles != nil {
targetInstInfo.Profiles = req.Profiles
}
// Handle storage pool override.
if req.Pool != "" {
rootDevKey, rootDev, err := internalInstance.GetRootDiskDevice(inst.ExpandedDevices().CloneNative())
if err != nil {
return err
}
// Apply the override.
rootDev["pool"] = req.Pool
// Add the device to local config.
targetInstInfo.Devices[rootDevKey] = rootDev
}
// Handle local changes (name, project, storage).
// Handle the renames first.
if req.Name != "" {
err := inst.Rename(req.Name, true)
if err != nil {
return err
}
inst, err = instance.LoadByProjectAndName(s, inst.Project().Name, req.Name)
if err != nil {
return err
}
// Clear the rename part of the request.
req.Name = ""
}
// Handle pool and project moves for stopped instances.
if (req.Project != "" || req.Pool != "") && !req.Live {
// Get a local client.
args := &incus.ConnectionArgs{
SkipGetServer: true,
UserAgent: clusterRequest.UserAgentClient,
}
target, err := incus.ConnectIncusUnix(s.OS.GetUnixSocket(), args)
if err != nil {
return err
}
if targetMemberInfo != nil {
target = target.UseTarget(targetMemberInfo.Name)
} else if s.ServerClustered {
target = target.UseTarget(inst.Location())
}
targetProject := inst.Project().Name
if req.Project != "" {
targetProject = req.Project
}
target = target.UseProject(targetProject)
// Check if we have a root disk in local config.
_, _, err = internalInstance.GetRootDiskDevice(targetInstInfo.Devices)
if err != nil && req.Project != "" {
// If not and we're dealing with project copy, let's get one.
var newRootDev map[string]string
// Get current root disk.
currentRootDevKey, currentRootDev, err := internalInstance.GetRootDiskDevice(inst.ExpandedDevices().CloneNative())
if err != nil {
return err
}
// Load the profiles.
profiles := []api.Profile{}
err = s.DB.Cluster.Transaction(ctx, func(ctx context.Context, tx *db.ClusterTx) error {
rawProfiles, err := dbCluster.GetProfilesIfEnabled(ctx, tx.Tx(), targetProject, targetInstInfo.Profiles)
if err != nil {
return err
}
profileConfigs, err := dbCluster.GetAllProfileConfigs(ctx, tx.Tx())
if err != nil {
return err
}
profileDevices, err := dbCluster.GetAllProfileDevices(ctx, tx.Tx())
if err != nil {
return err
}
for _, profile := range rawProfiles {
apiProfile, err := profile.ToAPI(ctx, tx.Tx(), profileConfigs, profileDevices)
if err != nil {
return err
}
profiles = append(profiles, *apiProfile)
}
return nil
})
if err != nil {
return err
}
// Go through expected profiles and look for a root disk.
for _, profile := range profiles {
_, dev, err := internalInstance.GetRootDiskDevice(profile.Devices)
if err != nil {
continue
}
newRootDev = dev
break
}
// Check if root disk coming from profiles is suitable, if not, copy the current one.
if newRootDev == nil ||
newRootDev["pool"] != currentRootDev["pool"] ||
newRootDev["size"] != currentRootDev["size"] ||
newRootDev["size.state"] != currentRootDev["size.state"] {
targetInstInfo.Devices[currentRootDevKey] = currentRootDev
}
}
// Use a temporary instance name if needed.
targetInstName := inst.Name()
if req.Project == "" {
targetInstName, err = instance.MoveTemporaryName(inst)
if err != nil {
return err
}
}
// Connect the event handler.
_, err = target.GetEvents()
if err != nil {
return err
}
defer target.Disconnect()
// Create the target instance.
destOp, err := target.CreateInstance(api.InstancesPost{
Name: targetInstName,
InstancePut: targetInstInfo.Writable(),
Type: api.InstanceType(targetInstInfo.Type),
Source: api.InstanceSource{
Type: "copy",
Source: inst.Name(),
Project: inst.Project().Name,
InstanceOnly: req.InstanceOnly,
},
})
if err != nil {
return fmt.Errorf("Failed requesting instance create on destination: %w", err)
}
// Setup a progress handler.
handler := func(newOp api.Operation) {
_ = op.UpdateMetadata(newOp.Metadata)
}
_, err = destOp.AddHandler(handler)
if err != nil {
return err
}
// Wait for the migration to complete.
err = destOp.Wait()
if err != nil {
return fmt.Errorf("Instance move to destination failed: %w", err)
}
// Delete the source instance.
err = inst.Delete(true)
if err != nil {
return err
}
// If using a temporary name, rename it.
if targetInstName != inst.Name() {
op, err := target.RenameInstance(targetInstName, api.InstancePost{Name: inst.Name()})
if err != nil {
return err
}
err = op.Wait()
if err != nil {
return err
}
}
// Reload the instance.
inst, err = instance.LoadByProjectAndName(s, targetProject, inst.Name())
if err != nil {
return err
}
// Clear the pool and project part of the request.
req.Pool = ""
req.Project = ""
}
// Handle remote migrations (location and storage pool changes).
if targetMemberInfo != nil && inst.Location() != targetMemberInfo.Name {
// Get the client.
networkCert := s.Endpoints.NetworkCert()
target, err := cluster.Connect(targetMemberInfo.Address, networkCert, s.ServerCert(), nil, true)
if err != nil {
return fmt.Errorf("Failed to connect to destination server %q: %w", targetMemberInfo.Address, err)
}
target = target.UseProject(inst.Project().Name)
target = target.UseTarget(targetMemberInfo.Name)
// Get the source member info if missing.
if sourceMemberInfo == nil {
err := s.DB.Cluster.Transaction(ctx, func(ctx context.Context, tx *db.ClusterTx) error {
// Get the source member info.
srcMember, err := tx.GetNodeByName(ctx, inst.Location())
if err != nil {
return fmt.Errorf("Failed getting current cluster member of instance %q", inst.Name())
}
sourceMemberInfo = &srcMember
return nil
})
if err != nil {
return err
}
}
// Get the current instance snapshot list.
snapshots, err := inst.Snapshots()
if err != nil {
return fmt.Errorf("Failed getting source instance snapshots: %w", err)
}
// Setup a new migration source.
sourceMigration, err := newMigrationSource(inst, req.Live, false, req.AllowInconsistent, inst.Name(), req.Pool, nil)
if err != nil {
return fmt.Errorf("Failed setting up instance migration on source: %w", err)
}
run := func(_ *operations.Operation) error {
return sourceMigration.do(op)
}
cancel := func(op *operations.Operation) error {
sourceMigration.disconnect()
return nil
}
resources := map[string][]api.URL{}
resources["instances"] = []api.URL{*api.NewURL().Path(version.APIVersion, "instances", inst.Name())}
sourceOp, err := operations.OperationCreate(s, inst.Project().Name, operations.OperationClassWebsocket, operationtype.InstanceMigrate, resources, sourceMigration.Metadata(), run, cancel, sourceMigration.Connect, nil)
if err != nil {
return err
}
sourceOp.CopyRequestor(op)
// Start the migration source.
err = sourceOp.Start()
if err != nil {
return fmt.Errorf("Failed starting migration source operation: %w", err)
}
// Extract the migration secrets.
sourceSecrets := make(map[string]string, len(sourceMigration.conns))
for connName, conn := range sourceMigration.conns {
sourceSecrets[connName] = conn.Secret()
}
// Connect the event handler.
_, err = target.GetEvents()
if err != nil {
return err
}
defer target.Disconnect()
// Create the target instance.
destOp, err := target.CreateInstance(api.InstancesPost{
Name: inst.Name(),
InstancePut: targetInstInfo.Writable(),
Type: api.InstanceType(targetInstInfo.Type),
Source: api.InstanceSource{
Type: "migration",
Mode: "pull",
Operation: fmt.Sprintf("https://%s%s", sourceMemberInfo.Address, sourceOp.URL()),
Websockets: sourceSecrets,
Certificate: string(networkCert.PublicKey()),
Live: req.Live,
Source: inst.Name(),
},
})
if err != nil {
return fmt.Errorf("Failed requesting instance create on destination: %w", err)
}
// Setup a progress handler.
handler := func(newOp api.Operation) {
_ = op.UpdateMetadata(newOp.Metadata)
}
_, err = destOp.AddHandler(handler)
if err != nil {
return err
}
// Wait for the migration to complete.
err = sourceOp.Wait(context.Background())
if err != nil {
return fmt.Errorf("Instance move to destination failed on source: %w", err)
}
err = destOp.Wait()
if err != nil {
return fmt.Errorf("Instance move to destination failed: %w", err)
}
// Update the database post-migration.
err = s.DB.Cluster.Transaction(context.Background(), func(ctx context.Context, tx *db.ClusterTx) error {
// Update instance DB record to indicate its location on the new cluster member.
err = tx.UpdateInstanceNode(ctx, inst.Project().Name, inst.Name(), inst.Name(), targetMemberInfo.Name, sourcePool.ID(), volDBType)
if err != nil {
return fmt.Errorf("Failed updating cluster member to %q for instance %q: %w", targetMemberInfo.Name, inst.Name(), err)
}
id, err := dbCluster.GetInstanceID(ctx, tx.Tx(), inst.Project().Name, inst.Name())
if err != nil {
return fmt.Errorf("Failed to get ID of moved instance: %w", err)
}
// Set the cluster group record if needed.
if targetGroupName != "" {
err = tx.DeleteInstanceConfigKey(ctx, id, "volatile.cluster.group")
if err != nil {
return fmt.Errorf("Failed to remove volatile.cluster.group config key: %w", err)
}
err = tx.CreateInstanceConfig(ctx, int(id), map[string]string{"volatile.cluster.group": targetGroupName})
if err != nil {
return fmt.Errorf("Failed to set volatile.apply_template config key: %w", err)
}
}
// Restore the original value of "volatile.apply_template".
err = tx.DeleteInstanceConfigKey(ctx, id, "volatile.apply_template")
if err != nil {
return fmt.Errorf("Failed to remove volatile.apply_template config key: %w", err)
}
if instVolatileApplyTemplate != "" {
config := map[string]string{
"volatile.apply_template": instVolatileApplyTemplate,
}
err = tx.CreateInstanceConfig(ctx, int(id), config)
if err != nil {
return fmt.Errorf("Failed to set volatile.apply_template config key: %w", err)
}
}
return nil
})
if err != nil {
return err
}
// Cleanup instance paths on source member if using remote shared storage
// and there was no storage pool change.
if sourcePool.Driver().Info().Remote && req.Pool == "" {
err = sourcePool.CleanupInstancePaths(inst, nil)
if err != nil {
return fmt.Errorf("Failed cleaning up instance paths on source member: %w", err)
}
} else {
// Delete the instance on source member if pool isn't remote shared storage.
// We cannot use the normal delete process, as that would remove the instance DB record.
// So instead we need to delete just the local storage volume(s) for the instance.
snapshotCount := len(snapshots)
for k := range snapshots {
// Delete the snapshots in reverse order.
k = snapshotCount - 1 - k
err = sourcePool.DeleteInstanceSnapshot(snapshots[k], nil)
if err != nil {
return fmt.Errorf("Failed delete instance snapshot %q on source member: %w", snapshots[k].Name(), err)
}
}
err = sourcePool.DeleteInstance(inst, nil)
if err != nil {
return fmt.Errorf("Failed deleting instance on source member: %w", err)
}
}
}
return nil
}
|