1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430
|
package device
import (
"errors"
"fmt"
"slices"
"sync"
"github.com/lxc/incus/v6/internal/linux"
deviceConfig "github.com/lxc/incus/v6/internal/server/device/config"
pcidev "github.com/lxc/incus/v6/internal/server/device/pci"
"github.com/lxc/incus/v6/internal/server/instance"
"github.com/lxc/incus/v6/internal/server/instance/instancetype"
"github.com/lxc/incus/v6/shared/resources"
"github.com/lxc/incus/v6/shared/revert"
"github.com/lxc/incus/v6/shared/util"
)
// sriovMu is used to lock concurrent GPU allocations.
var sriovMu sync.Mutex
type gpuSRIOV struct {
deviceCommon
}
// validateConfig checks the supplied config for correctness.
func (d *gpuSRIOV) validateConfig(instConf instance.ConfigReader) error {
if !instanceSupported(instConf.Type(), instancetype.VM) {
return ErrUnsupportedDevType
}
requiredFields := []string{}
optionalFields := []string{
// gendoc:generate(entity=devices, group=gpu_sriov, key=vendorid)
//
// ---
// type: string
// required: no
// shortdesc: The vendor ID of the parent GPU device
"vendorid",
// gendoc:generate(entity=devices, group=gpu_sriov, key=productid)
//
// ---
// type: string
// required: no
// shortdesc: The product ID of the parent GPU device
"productid",
// gendoc:generate(entity=devices, group=gpu_sriov, key=id)
//
// ---
// type: string
// required: no
// shortdesc: The DRM card ID of the parent GPU device
"id",
// gendoc:generate(entity=devices, group=gpu_sriov, key=pci)
//
// ---
// type: string
// required: no
// shortdesc: The PCI address of the parent GPU device
"pci",
}
err := d.config.Validate(gpuValidationRules(requiredFields, optionalFields))
if err != nil {
return err
}
if d.config["pci"] != "" {
for _, field := range []string{"id", "productid", "vendorid"} {
if d.config[field] != "" {
return fmt.Errorf(`Cannot use %q when "pci" is set`, field)
}
}
d.config["pci"] = pcidev.NormaliseAddress(d.config["pci"])
}
if d.config["id"] != "" {
for _, field := range []string{"pci", "productid", "vendorid"} {
if d.config[field] != "" {
return fmt.Errorf(`Cannot use %q when "id" is set`, field)
}
}
}
return nil
}
// validateEnvironment checks the runtime environment for correctness.
func (d *gpuSRIOV) validateEnvironment() error {
if d.inst.Type() == instancetype.VM && util.IsTrue(d.inst.ExpandedConfig()["migration.stateful"]) {
return errors.New("GPU devices cannot be used when migration.stateful is enabled")
}
return validatePCIDevice(d.config["pci"])
}
// Start is run when the device is added to the instance.
func (d *gpuSRIOV) Start() (*deviceConfig.RunConfig, error) {
err := d.validateEnvironment()
if err != nil {
return nil, err
}
runConf := deviceConfig.RunConfig{}
saveData := make(map[string]string)
// Make sure that vfio-pci is loaded.
err = linux.LoadModule("vfio-pci")
if err != nil {
return nil, fmt.Errorf("Error loading %q module: %w", "vfio-pci", err)
}
// Get global SR-IOV lock to prevent concurrent allocations of the VF.
sriovMu.Lock()
defer sriovMu.Unlock()
// Get SRIOV VF.
parentPCIAddress, vfID, err := d.getVF()
if err != nil {
return nil, err
}
vfPCIDev, err := d.setupSriovParent(parentPCIAddress, vfID, saveData)
if err != nil {
return nil, err
}
err = d.volatileSet(saveData)
if err != nil {
return nil, err
}
runConf.GPUDevice = append(runConf.GPUDevice, []deviceConfig.RunConfigItem{
{Key: "devName", Value: d.name},
{Key: "pciSlotName", Value: vfPCIDev.SlotName},
}...)
return &runConf, nil
}
// getVF returns the parent PCI address and VF id for a matching GPU.
func (d *gpuSRIOV) getVF() (string, int, error) {
// List all the GPUs.
gpus, err := resources.GetGPU()
if err != nil {
return "", -1, err
}
// If NUMA restricted, build up a list of nodes.
var numaNodeSet []int64
var numaNodeSetFallback []int64
numaNodes := d.inst.ExpandedConfig()["limits.cpu.nodes"]
if numaNodes != "" {
if numaNodes == "balanced" {
numaNodes = d.inst.ExpandedConfig()["volatile.cpu.nodes"]
}
// Parse the NUMA restriction.
numaNodeSet, err = resources.ParseNumaNodeSet(numaNodes)
if err != nil {
return "", -1, err
}
// List all the CPUs.
cpus, err := resources.GetCPU()
if err != nil {
return "", -1, err
}
// Get list of socket IDs from the list of NUMA nodes.
numaSockets := make([]uint64, 0, len(cpus.Sockets))
for _, cpuSocket := range cpus.Sockets {
if slices.Contains(numaSockets, cpuSocket.Socket) {
continue
}
for _, cpuCore := range cpuSocket.Cores {
found := false
for _, cpuThread := range cpuCore.Threads {
if slices.Contains(numaNodeSet, int64(cpuThread.NUMANode)) {
numaSockets = append(numaSockets, cpuSocket.Socket)
found = true
break
}
}
if found {
break
}
}
}
// Get the list of NUMA nodes from the socket list.
numaNodeSetFallback = []int64{}
for _, cpuSocket := range cpus.Sockets {
if !slices.Contains(numaSockets, cpuSocket.Socket) {
continue
}
for _, cpuCore := range cpuSocket.Cores {
for _, cpuThread := range cpuCore.Threads {
if !slices.Contains(numaNodeSetFallback, int64(cpuThread.NUMANode)) {
numaNodeSetFallback = append(numaNodeSetFallback, int64(cpuThread.NUMANode))
}
}
}
}
}
// Locate a suitable VF from the least loaded suitable card.
var pciAddress string
var vfID int
var cardTotal int
var cardAvailable int
cardNUMA := -1
for _, gpu := range gpus.Cards {
// Skip any cards that are not selected.
if !gpuSelected(d.Config(), gpu) {
continue
}
// Skip any card without SR-IOV.
if gpu.SRIOV == nil {
continue
}
// Find available VFs.
vfs := []int{}
for id, vf := range gpu.SRIOV.VFs {
if vf.Driver == "" {
vfs = append(vfs, id)
}
}
// Skip if no available VFs.
if len(vfs) == 0 {
continue
}
// Handle NUMA.
if numaNodeSet != nil {
// Switch to current card if it matches our main NUMA node and existing card doesn't.
if !slices.Contains(numaNodeSet, int64(cardNUMA)) && slices.Contains(numaNodeSet, int64(gpu.NUMANode)) {
pciAddress = gpu.PCIAddress
vfID = vfs[0]
cardAvailable = len(vfs)
cardTotal = int(gpu.SRIOV.CurrentVFs)
cardNUMA = int(gpu.NUMANode)
continue
}
// Skip current card if we already have a card matching our main NUMA node and this card doesn't.
if slices.Contains(numaNodeSet, int64(cardNUMA)) && !slices.Contains(numaNodeSet, int64(gpu.NUMANode)) {
continue
}
// Switch to current card if it matches a fallback NUMA node and existing card doesn't.
if !slices.Contains(numaNodeSetFallback, int64(cardNUMA)) && slices.Contains(numaNodeSetFallback, int64(gpu.NUMANode)) {
pciAddress = gpu.PCIAddress
vfID = vfs[0]
cardAvailable = len(vfs)
cardTotal = int(gpu.SRIOV.CurrentVFs)
cardNUMA = int(gpu.NUMANode)
continue
}
// Skip current card if we already have a card matching a fallback NUMA node and this card isn't on the main or fallback node.
if slices.Contains(numaNodeSetFallback, int64(cardNUMA)) && !slices.Contains(numaNodeSetFallback, int64(gpu.NUMANode)) && !slices.Contains(numaNodeSet, int64(gpu.NUMANode)) {
continue
}
}
// Prioritize less busy cards.
if pciAddress == "" || (float64(len(vfs))/float64(gpu.SRIOV.CurrentVFs)) > (float64(cardAvailable)/float64(cardTotal)) {
pciAddress = gpu.PCIAddress
vfID = vfs[0]
cardAvailable = len(vfs)
cardTotal = int(gpu.SRIOV.CurrentVFs)
cardNUMA = int(gpu.NUMANode)
continue
}
}
// Check if any physical GPU was found to match.
if pciAddress == "" {
return "", -1, errors.New("Couldn't find a matching GPU with available VFs")
}
return pciAddress, vfID, nil
}
// setupSriovParent configures a SR-IOV virtual function (VF) device on parent and stores original properties of
// the physical device into voltatile for restoration on detach. Returns VF PCI device info.
func (d *gpuSRIOV) setupSriovParent(parentPCIAddress string, vfID int, volatile map[string]string) (pcidev.Device, error) {
reverter := revert.New()
defer reverter.Fail()
volatile["last_state.pci.parent"] = parentPCIAddress
volatile["last_state.vf.id"] = fmt.Sprintf("%d", vfID)
volatile["last_state.created"] = "false" // Indicates don't delete device at stop time.
// Get VF device's PCI Slot Name so we can unbind and rebind it from the host.
vfPCIDev, err := d.getVFDevicePCISlot(parentPCIAddress, volatile["last_state.vf.id"])
if err != nil {
return vfPCIDev, err
}
// Unbind VF device from the host so that the settings will take effect when we rebind it.
err = pcidev.DeviceUnbind(vfPCIDev)
if err != nil {
return vfPCIDev, err
}
reverter.Add(func() { _ = pcidev.DeviceProbe(vfPCIDev) })
// Register VF device with vfio-pci driver so it can be passed to VM.
err = pcidev.DeviceDriverOverride(vfPCIDev, "vfio-pci")
if err != nil {
return vfPCIDev, err
}
// Record original driver used by VF device for restore.
volatile["last_state.pci.driver"] = vfPCIDev.Driver
reverter.Success()
return vfPCIDev, nil
}
// getVFDevicePCISlot returns the PCI slot name for a PCI virtual function device.
func (d *gpuSRIOV) getVFDevicePCISlot(parentPCIAddress string, vfID string) (pcidev.Device, error) {
ueventFile := fmt.Sprintf("/sys/bus/pci/devices/%s/virtfn%s/uevent", parentPCIAddress, vfID)
pciDev, err := pcidev.ParseUeventFile(ueventFile)
if err != nil {
return pciDev, err
}
return pciDev, nil
}
// Stop is run when the device is removed from the instance.
func (d *gpuSRIOV) Stop() (*deviceConfig.RunConfig, error) {
runConf := deviceConfig.RunConfig{
PostHooks: []func() error{d.postStop},
}
return &runConf, nil
}
// postStop is run after the device is removed from the instance.
func (d *gpuSRIOV) postStop() error {
defer func() {
_ = d.volatileSet(map[string]string{
"last_state.created": "",
"last_state.vf.id": "",
"last_state.pci.driver": "",
"last_state.pci.parent": "",
})
}()
v := d.volatileGet()
err := d.restoreSriovParent(v)
if err != nil {
return err
}
return nil
}
// restoreSriovParent restores SR-IOV parent device settings when removed from an instance using the
// volatile data that was stored when the device was first added with setupSriovParent().
func (d *gpuSRIOV) restoreSriovParent(volatile map[string]string) error {
// Nothing to do if we don't know the original device name or the VF ID.
if volatile["last_state.pci.parent"] == "" || volatile["last_state.vf.id"] == "" || (d.config["pci"] == "" && d.config["id"] == "" && d.config["vendorid"] == "" && d.config["productid"] == "") {
return nil
}
reverter := revert.New()
defer reverter.Fail()
// Get VF device's PCI info so we can unbind and rebind it from the host.
vfPCIDev, err := d.getVFDevicePCISlot(volatile["last_state.pci.parent"], volatile["last_state.vf.id"])
if err != nil {
return err
}
// Unbind VF device from the host so that the restored settings will take effect when we rebind it.
err = pcidev.DeviceUnbind(vfPCIDev)
if err != nil {
return err
}
if d.inst.Type() == instancetype.VM {
// Before we bind the device back to the host, ensure we restore the original driver info as it
// should be currently set to vfio-pci.
err = pcidev.DeviceSetDriverOverride(vfPCIDev, volatile["last_state.pci.driver"])
if err != nil {
return err
}
}
// However we return from this function, we must try to rebind the VF so its not orphaned.
// The OS won't let an already bound device be bound again so is safe to call twice.
reverter.Add(func() { _ = pcidev.DeviceProbe(vfPCIDev) })
// Bind VF device onto the host so that the settings will take effect.
err = pcidev.DeviceProbe(vfPCIDev)
if err != nil {
return err
}
reverter.Success()
return nil
}
|