1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531
|
#!/usr/bin/env python3
# pylint: disable=C0301,R0902,R0912,R0913,R0914,R0915,R1702
# SPDX-License-Identifier: (GPL-2.0 OR MIT)
## Copyright (C) 2023 Intel Corporation ##
## Author: Mauro Carvalho Chehab <mchehab@kernel.org> ##
"""Import contents of a XLS file into testplan documentation."""
import argparse
import copy
import json
import os
import re
import sys
from openpyxl import load_workbook
from test_list import TestList
#
# FillTests class definition
#
class FillTests(TestList):
"""
Fill documentation source code test comments from a spreadsheet.
"""
def __init__(self, config_path, verbose):
self.tests = {}
self.spreadsheet_data = {}
self.verbose = verbose
self.update_fields = []
# Read current documentation
TestList.__init__(self, config_path)
self.orig_doc = copy.deepcopy(self.doc)
self.testname_regex = re.compile(r'^\s*(igt@[^\n\@]+)\@?(\S*)\s*')
self.key_has_wildcard = re.compile(r'\%?arg\[(\d+)\]')
self.field_re = re.compile(r"(" + '|'.join(self.field_list.keys()) + r'):\s*(.*)', re.I)
for test in self.doc: # pylint: disable=C0206
fname = self.doc[test]["File"]
name = re.sub(r'.*/', '', fname)
name = re.sub(r'\.[\w+]$', '', name)
name = "igt@" + name
subtest_array = self.expand_subtest(fname, name, test, True, True, True)
for subtest_dict in subtest_array:
name = subtest_dict["_summary_"]
del subtest_dict["_summary_"]
match = self.testname_regex.match(name)
if not match:
sys.exit(f"Error: can't parse {name}")
testname = match.group(1)
if match.group(2):
subtest = match.group(2)
else:
subtest = ''
if testname not in self.tests:
self.tests[testname] = {}
self.tests[testname]["subtests"] = {}
self.tests[testname]["Test"] = test
self.tests[testname]["File"] = fname
self.tests[testname]["subtests"][subtest] = subtest_dict
for field, item in self.props.items():
if "sublevel" in item["_properties_"]:
update = item["_properties_"].get("update-from-file")
if update:
continue
self.update_fields.append(field)
def add_field(self, dic, field, value):
"""
Add a value to a field, alphabetically sorting it.
"""
if field in dic and dic[field] != '':
fields = sorted(dic[field].split(", "))
fields.append(value)
value = ", ".join(sorted(fields))
dic[field] = value
def process_spreadsheet_sheet(self, sheet):
"""
Convert a single sheet into a dictionary.
Please notice that an empty row means to ignore the rest of the
sheet.
"""
column_list = []
for cell in sheet[1]:
column_list.append(cell.value)
for row in range(2, sheet.max_row + 1):
if sheet[row][0].value is None:
print(f"Ignoring sheet after A{row} row, as test name is empty")
return
if not isinstance(sheet[row][0].value, str):
print(f"Ignoring A{row} row on {sheet.title}: test name is not a string: {sheet[row][0].value}")
continue
test_name = sheet[row][0].value.strip()
if not re.match(r'^igt\@', test_name):
print(f"Ignoring A{row} row on {sheet.title}: not a valid test name: {test_name}")
continue
if test_name not in self.spreadsheet_data:
self.spreadsheet_data[test_name] = {}
i = 1
for col in range(2, sheet.max_column + 1):
val = sheet.cell(row=row, column=col).value
if val:
if isinstance(val, str):
val = val.strip()
self.spreadsheet_data[test_name][column_list[i]] = val
i += 1
def read_spreadsheet_file(self, fname, sheets):
"""
Read a XLS file, processing all sheets and returing a dict with
all lines from all sheets altogether.
"""
# Iterate the loop to read the cell values
wb = load_workbook(filename=fname)
# Handle first "normal" sheets
for sheet in wb:
if sheets and sheet.title not in sheets:
continue
self.process_spreadsheet_sheet(sheet)
return self.spreadsheet_data
def change_value(self, content, test, subtest, line, field, value):
"""
Change the contents of a source file to update its documentation.
"""
if test:
line = 0
while True:
line += 1
if line >= len(content):
break
file_line = content[line]
match = re.match(r'^\s*\* ?TEST:\s*(.*)', file_line)
if match:
break
line += 1
current_field = None
found_line = None
i = line
while True:
i += 1
if i >= len(content):
break
file_line = content[i]
if re.match(r'^\s*\*\/\s*$', file_line):
break
file_line = re.sub(r'^\s*\* ?', '', file_line)
match = re.match(r'^SUBTESTS?:\s*(.*)', file_line)
if match:
if subtest and match.group(1) != subtest:
break
if test:
break
match = re.match(r'^TEST:\s*(.*)', file_line)
if match:
break
match = re.match(r'arg\[(\d+)\]:\s*(.*)', file_line)
if match:
break
match = re.match(r'\@(\S+):\s*(.*)', file_line)
if match:
break
match = re.match(r'arg\[(\d+)\]\.values:\s*(.*)', file_line)
if match:
break
match = re.match(self.field_re, file_line)
if match:
current_field = self.field_list[match.group(1).lower()]
if current_field != field:
continue
found_line = i
# Handle continuation lines
if current_field:
match = re.match(r'\s+(.*)', file_line)
if match:
if current_field != field:
continue
content[i] = ""
if i > len(content):
if test:
print(f"Warning: coun't find doc string for test {subtest}, field {field}")
else:
print(f"Warning: coun't find doc string for subtest {subtest}, field {field} on line {line}")
return
if found_line:
if value != "":
content[found_line] = f' * {field}: {value}\n'
else:
content[found_line] = ""
return
if value != "":
if i > 2 and re.match(r'\s*\*\s*$', content[i - 1]):
i -= 1
content.insert(i, f' * {field}: {value}\n')
def parse_spreadsheet(self, fname, sheets=None):
"""
Convert a spreadsheet file into a recursive dictionary.
It assumes that the first column at the parsed sheets will contain
an IGT test name in the format:
igt@<testname>@<subtest>
And the other columns will have the field name at the first line.
On success, it will return a dictionary with this format:
self.tests[testname]["subtests"][subtest][field] = value
"""
if not os.path.isfile(fname):
print(f'Warning: {fname} not found. Skipping spreadsheet parser')
return
data = self.read_spreadsheet_file(fname, sheets)
for test, row in sorted(data.items()):
match = self.testname_regex.match(test)
if not match:
sys.exit(f"Error: can't parse {test}")
testname = match.group(1)
if match.group(2):
subtest = match.group(2)
else:
subtest = ''
if testname not in self.tests:
print(f"Warning: {testname} file is not present at JSON config file.")
continue
if subtest not in self.tests[testname]["subtests"]:
self.tests[testname]["subtests"][subtest] = {}
for key, value in row.items():
self.tests[testname]["subtests"][subtest][key] = value
def simplify_doc_strings(self):
"""
Group common properties at TEST level if all subtests have identical
values for such property.
"""
print("Handling common information on test from subtests")
for testname in self.tests: # pylint: disable=C0206
# Get common properties
common = {}
test_nr = self.tests[testname].get("Test")
for key, value in self.doc[test_nr].items():
# Ignore description when checking common fields
if key.lower() == "description":
continue
if key in self.update_fields:
common[key] = value
# Step 1: verify common items
first = True
for subtest in sorted(list(self.tests[testname]["subtests"].keys())):
if subtest.count("@") > 1:
print(f"Warning: don't simplify dynamic subtest: {testname}{subtest}")
continue
# Store common items
subtest_fields = sorted(self.tests[testname]["subtests"][subtest].keys())
for k in subtest_fields:
# Ignore description when checking common fields
if k.lower() == "description":
continue
# Ignore internal fields
if k not in self.update_fields:
continue
val = self.tests[testname]["subtests"][subtest][k]
val = val.strip()
val = re.sub(r" +", " ", val)
val = re.sub(r"([^\.])\s?\n\s*([A-Z])", r"\1.\n\2", val)
self.tests[testname]["subtests"][subtest][k] = val
if first and val != '':
common[k] = val
else:
if k not in common:
continue
if common[k] != val:
del common[k]
first = False
# Remove keys that aren't common to all subtests
for k in list(common.keys()):
if k not in subtest_fields:
del common[k]
# Step 2: drop common items from subtests
for subtest, fields in list(self.tests[testname]["subtests"].items()):
for k, val in list(fields.items()):
if k not in common:
continue
if val == common[k]:
self.tests[testname]["subtests"][subtest][k] = ""
# Step 3: store the modified common properties
for k, val in common.items():
self.doc[test_nr][k] = val
def update_test_file(self, testname):
"""
Update a C source file using the contents of self.tests as
the source of data to be filled at the igt_doc documentation
comments.
"""
try:
sourcename = self.tests[testname]["File"]
with open(sourcename, 'r', encoding='utf8') as in_fp:
content = in_fp.read().splitlines(True)
except EnvironmentError:
sys.exit(f'Failed to read {sourcename}')
try:
test_nr = self.tests[testname]["Test"]
# Update common fields
doc_content = self.orig_doc[test_nr]
fields = set(self.doc[test_nr].keys()) | set(doc_content.keys())
for field in sorted(fields):
if field not in self.update_fields:
continue
value = self.doc[test_nr].get(field, "")
doc_value = doc_content.get(field, "")
if doc_value == value:
continue
self.change_value(content, True, testname, 0, field, value)
# Update subtest fields
for subtest, subtest_content in sorted(self.tests[testname]["subtests"].items()):
if "line" not in subtest_content:
print(f"Warning: didn't find where {subtest} is documented.")
continue
subtest_nr = subtest_content['subtest_nr']
if subtest_nr not in self.doc[test_nr]["subtest"]:
if self.verbose:
print(f"Error: missing subtest {subtest_nr} at {self.doc[test_nr]['subtest']}")
else:
print(f"Warning: test {testname}, subtest {subtest} is not documented.")
continue
line = self.doc[test_nr]["_subtest_line_"][subtest_nr]
doc_content = self.orig_doc[test_nr]["subtest"][subtest_nr]
fields = set(subtest_content.keys()) | set(doc_content.keys())
for field in sorted(fields):
if field not in self.update_fields:
continue
value = subtest_content.get(field, "")
doc_value = doc_content.get(field, "")
# Handling wildcards is not easy. Let's just skip those
if self.key_has_wildcard.search(doc_value):
print(f"Warning: {subtest} field {field} has wildcards. Skipping it.")
continue
if doc_value == value:
if self.verbose > 1:
print(f"{testname}@{subtest} field {field}: Value unchanged: {value}. Ignoring it")
continue
if value == self.doc[test_nr].get(field, ""):
if self.verbose:
print(f"{testname}@{subtest} field {field}: Value matches common field. Ignoring it")
continue
if self.verbose > 0:
print(f"Update {testname}@{subtest} field {field} on line {line}:")
print(f" Change from {doc_value} to {value}")
# Just in case, handle continuation lines
value = re.sub(r"\n", "\n * ", value)
self.change_value(content, False, subtest, line, field, value)
# Update line numbers after insert
skip = True
for sub, sub_content in sorted(self.tests[testname]["subtests"].items()):
if sub == subtest:
skip = False
continue
if skip:
continue
sub_line = sub_content['line']
if sub_line >= line:
sub_content['line'] += 1
except EnvironmentError as err:
sys.exit(f'Error: {err}')
# Write changes
try:
if self.verbose > 1:
print(f"Writing to {sourcename}")
with open(sourcename, 'w', encoding='utf8') as out_fp:
out_fp.write("".join(content))
except EnvironmentError:
print(f'Failed to write to {sourcename}')
def update_test_files(self):
"""
Populate all test files with the documentation from self.tests.
"""
if self.verbose == 0:
print("Update source files")
for testname in self.tests:
self.update_test_file(testname)
######
# Main
######
def main():
"""Main program"""
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument("--config", required=True,
help="JSON file describing the test plan template")
parser.add_argument("--xls",
help="Input XLS file.")
parser.add_argument("--sheets", nargs="*",
help="Input only some specific sheets from the XLS file.")
parser.add_argument('--ignore-lists', action='store_false', default=True,
help='Ignore fields that are updated via test lists')
parser.add_argument("--store-json", action="store_true",
help="Generate JSON files with documentation. Useful for debugging purposes.")
parser.add_argument("--simplify", action="store_true",
help="Run a simplify logic to cleanup TEST common fields.")
parser.add_argument('-v', '--verbose', action='count', default=0)
parse_args = parser.parse_args()
fill_test = FillTests(parse_args.config, parse_args.verbose)
if parse_args.xls:
fill_test.parse_spreadsheet(parse_args.xls, parse_args.sheets)
if parse_args.simplify:
fill_test.simplify_doc_strings()
if "store_json" in parse_args:
print("Generating fill_test.json debug file")
with open("fill_test.json", "w", encoding='utf8') as write_file:
json.dump(fill_test.tests, write_file, indent=4)
print("Generating doc.json debug file")
with open("doc.json", "w", encoding='utf8') as write_file:
json.dump(fill_test.doc, write_file, indent=4)
fill_test.update_test_files()
if __name__ == '__main__':
main()
|