1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
|
// SPDX-License-Identifier: MIT
/*
* Copyright © 2022 Igalia S.L.
*/
#include "igt.h"
#include "igt_v3d.h"
#include "igt_syncobj.h"
/* One tenth of a second */
#define SHORT_TIME_NSEC 100000000ull
#define NSECS_PER_SEC 1000000000ull
static uint64_t
gettime_ns(void)
{
struct timespec current;
clock_gettime(CLOCK_MONOTONIC, ¤t);
return (uint64_t)current.tv_sec * NSECS_PER_SEC + current.tv_nsec;
}
static uint64_t
short_timeout(void)
{
return gettime_ns() + SHORT_TIME_NSEC;
}
igt_main
{
int fd;
igt_fixture
fd = drm_open_driver(DRIVER_V3D);
igt_describe("Make sure a submission cannot be accepted with a pad different than zero.");
igt_subtest("bad-pad") {
struct drm_v3d_submit_cl submit = {
.pad = 1
};
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, &submit, EINVAL);
}
igt_describe("Make sure a submission cannot be accepted with invalid flags.");
igt_subtest("bad-flag") {
struct drm_v3d_submit_cl submit = {
.flags = 0xaa
};
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, &submit, EINVAL);
}
igt_describe("Make sure a submission cannot be accepted if the extensions "
"handle is invalid.");
igt_subtest("bad-extension") {
struct drm_v3d_submit_cl submit = {
.flags = DRM_V3D_SUBMIT_EXTENSION,
.extensions = 0ULL
};
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, &submit, EINVAL);
}
igt_describe("Make sure a submission cannot be accepted if the BO handle is invalid.");
igt_subtest("bad-bo") {
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
job->submit->bo_handles = 0ULL;
job->submit->bo_handle_count = 1;
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, EFAULT);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Make sure a submission cannot be accepted if the perfmon id is invalid.");
igt_subtest("bad-perfmon") {
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_PERFMON));
job->submit->perfmon_id = 1;
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, ENOENT);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Make sure a submission cannot be accepted if the in-sync is not signaled.");
igt_subtest("bad-in-sync") {
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
job->submit->in_sync_rcl = syncobj_create(fd, 0);
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, EINVAL);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Make sure that the multisync pad is zero.");
igt_subtest("bad-multisync-pad") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT));
ms.pad = 1;
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
job->submit->extensions = to_user_pointer(&ms);
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, EINVAL);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Make sure that the multisync extension id exists.");
igt_subtest("bad-multisync-extension") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT));
ms.base.id = 0;
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
job->submit->extensions = to_user_pointer(&ms);
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, EINVAL);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Make sure that the multisync out-sync is valid.");
igt_subtest("bad-multisync-out-sync") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT));
igt_v3d_set_multisync(&ms, V3D_RENDER);
ms.out_sync_count = 1;
ms.out_syncs = 0ULL;
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
job->submit->extensions = to_user_pointer(&ms);
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, EFAULT);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Make sure that the multisync in-sync is valid.");
igt_subtest("bad-multisync-in-sync") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT));
igt_v3d_set_multisync(&ms, V3D_RENDER);
ms.in_sync_count = 1;
ms.in_syncs = 0ULL;
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
job->submit->extensions = to_user_pointer(&ms);
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit, EFAULT);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Test a valid submission without syncobj.");
igt_subtest("valid-submission") {
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Test a valid submission with a single out-sync.");
igt_subtest("single-out-sync") {
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
job->submit->out_sync = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
igt_assert(syncobj_wait(fd, &job->submit->out_sync, 1,
INT64_MAX, 0, NULL));
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Test a valid submission with a single in-sync.");
igt_subtest("single-in-sync") {
struct v3d_cl_job *job1 = igt_v3d_noop_job(fd);
struct v3d_cl_job *job2 = igt_v3d_noop_job(fd);
uint32_t out_sync;
out_sync = syncobj_create(fd, 0);
job1->submit->in_sync_rcl = out_sync;
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, job1->submit, EINVAL);
job2->submit->out_sync = out_sync;
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job2->submit);
igt_assert(syncobj_wait(fd, &job2->submit->out_sync, 1,
INT64_MAX, 0, NULL));
job1->submit->in_sync_rcl = out_sync;
job1->submit->out_sync = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job1->submit);
igt_assert(syncobj_wait(fd, &job1->submit->out_sync, 1,
INT64_MAX, 0, NULL));
igt_v3d_free_cl_job(fd, job1);
igt_v3d_free_cl_job(fd, job2);
}
igt_describe("Test a valid submission with flush cache.");
igt_subtest("simple-flush-cache") {
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
job->submit->flags = DRM_V3D_SUBMIT_CL_FLUSH_CACHE;
if (!igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_CACHE_FLUSH)) {
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, &job->submit, EINVAL);
} else {
job->submit->out_sync = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
igt_assert(syncobj_wait(fd, &job->submit->out_sync, 1,
INT64_MAX, 0, NULL));
}
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Test a valid submission with a multisync without syncobjs.");
igt_subtest("valid-multisync-submission") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
if (!igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT)) {
do_ioctl_err(fd, DRM_IOCTL_V3D_SUBMIT_CL, &job->submit, EINVAL);
} else {
igt_v3d_set_multisync(&ms, V3D_RENDER);
job->submit->extensions = to_user_pointer(&ms);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
}
igt_v3d_free_cl_job(fd, job);
}
igt_describe("Test a valid submission with a multiple out-syncs.");
igt_subtest("multisync-out-syncs") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
struct drm_v3d_sem *out_syncs;
int i;
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT));
igt_v3d_set_multisync(&ms, V3D_RENDER);
ms.out_sync_count = 4;
out_syncs = malloc(ms.out_sync_count * sizeof(*out_syncs));
for (i = 0; i < ms.out_sync_count; i++)
out_syncs[i].handle = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
ms.out_syncs = to_user_pointer(out_syncs);
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
job->submit->extensions = to_user_pointer(&ms);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
for (i = 0; i < ms.out_sync_count; i++)
igt_assert(syncobj_wait(fd, &out_syncs[i].handle, 1, INT64_MAX, 0, NULL));
igt_v3d_free_cl_job(fd, job);
free(out_syncs);
}
igt_describe("Make sure that the multisync extension is preferred over "
"the single syncobjs.");
igt_subtest("multi-and-single-sync") {
struct drm_v3d_multi_sync ms = { };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
struct drm_v3d_sem *out_syncs;
int i;
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_MULTISYNC_EXT));
igt_v3d_set_multisync(&ms, V3D_RENDER);
ms.out_sync_count = 1;
out_syncs = malloc(ms.out_sync_count * sizeof(*out_syncs));
for (i = 0; i < ms.out_sync_count; i++)
out_syncs[i].handle = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
ms.out_syncs = to_user_pointer(out_syncs);
job->submit->flags = DRM_V3D_SUBMIT_EXTENSION;
job->submit->extensions = to_user_pointer(&ms);
job->submit->out_sync = syncobj_create(fd, 0);
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
for (i = 0; i < ms.out_sync_count; i++)
igt_assert(syncobj_wait(fd, &out_syncs[i].handle, 1, INT64_MAX, 0, NULL));
/*
* The multisync extension should be prioritized over the single syncobjs.
* So, the job->submit->out_sync should stay not signaled.
*/
igt_assert_eq(syncobj_wait_err(fd, &job->submit->out_sync, 1, INT64_MAX, 0),
-EINVAL);
igt_v3d_free_cl_job(fd, job);
free(out_syncs);
}
igt_describe("Test the implicit order of the submission to the CL queue.");
igt_subtest("multiple-job-submission") {
const uint32_t num_jobs = 10;
struct v3d_cl_job **jobs = NULL;
int i;
jobs = malloc(num_jobs * sizeof(*jobs));
for (i = 0; i < num_jobs; i++) {
jobs[i] = igt_v3d_noop_job(fd);
jobs[i]->submit->out_sync = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
}
for (i = 0; i < num_jobs; i++)
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, jobs[i]->submit);
igt_assert(syncobj_wait(fd, &jobs[num_jobs - 1]->submit->out_sync, 1,
short_timeout(), 0, NULL));
/*
* If the last job is signaled, then all the previous jobs should
* already signaled, to assure the implicit synchronization.
*/
for (i = 0; i < num_jobs; i++) {
igt_assert(syncobj_wait(fd, &jobs[i]->submit->out_sync, 1, 0, 0, NULL));
igt_v3d_free_cl_job(fd, jobs[i]);
}
free(jobs);
}
igt_describe("Test the coherency of creation/destruction of a perfmon attached to a job.");
igt_subtest("job-perfmon") {
uint8_t counters[] = { V3D_PERFCNT_L2T_TMU_READS,
V3D_PERFCNT_L2T_CLE_READS,
V3D_PERFCNT_L2T_VCD_READS,
V3D_PERFCNT_L2T_TMUCFG_READS };
struct v3d_cl_job *job = igt_v3d_noop_job(fd);
uint32_t id;
igt_require(igt_v3d_get_param(fd, DRM_V3D_PARAM_SUPPORTS_PERFMON));
id = igt_v3d_perfmon_create(fd, ARRAY_SIZE(counters), counters);
job->submit->out_sync = syncobj_create(fd, DRM_SYNCOBJ_CREATE_SIGNALED);
job->submit->perfmon_id = id;
do_ioctl(fd, DRM_IOCTL_V3D_SUBMIT_CL, job->submit);
igt_assert(syncobj_wait(fd, &job->submit->out_sync, 1,
INT64_MAX, 0, NULL));
igt_v3d_perfmon_get_values(fd, job->submit->perfmon_id);
igt_v3d_free_cl_job(fd, job);
igt_v3d_perfmon_get_values(fd, id);
igt_v3d_perfmon_destroy(fd, id);
}
igt_fixture
drm_close_driver(fd);
}
|
