1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
|
/*========================== begin_copyright_notice ============================
Copyright (C) 2020-2021 Intel Corporation
SPDX-License-Identifier: MIT
============================= end_copyright_notice ===========================*/
#include "Compiler/Optimizer/OpenCLPasses/TransformUnmaskedFunctionsPass.h"
#include "GenISAIntrinsics/GenIntrinsics.h"
#include "Compiler/IGCPassSupport.h"
#include "Compiler/CodeGenPublic.h"
#include "Compiler/MetaDataApi/MetaDataApi.h"
#include "Compiler/MetaDataApi/IGCMetaDataHelper.h"
#include "Compiler/CISACodeGen/GenCodeGenModule.h"
#include "common/LLVMWarningsPush.hpp"
#include "llvm/Config/llvm-config.h"
#include "llvm/IR/Module.h"
#include "llvm/IR/Function.h"
#include "llvm/ADT/SetVector.h"
#include "llvmWrapper/IR/Constant.h"
#include "llvmWrapper/IR/InstrTypes.h"
#include "llvmWrapper/Transforms/Utils/Cloning.h"
#include "common/LLVMWarningsPop.hpp"
#include "Probe/Assertion.h"
using namespace llvm;
using namespace IGC;
using namespace IGC::IGCMD;
// This pass scans the code for functions marked with 'unmasked' annotations.
// When an unmaksed function is detected each of its basic blocks is makred
// with UnmaskedRegionBegin and UnmaskedRegionEnd intrinsics. Those intrinsics
// are later used by EmitVISA pass to mark all instructions in between with
// NoMask attribute.
//
// This pass must be called early, before any inlining to work correctly.
// This pass will fail compilation if non-uniform control flow is detected.
#define PASS_FLAG "transform-unmasked"
#define PASS_DESCRIPTION "Handle unmaksed functions."
#define PASS_CFG_ONLY false
#define PASS_ANALYSIS false
IGC_INITIALIZE_PASS_BEGIN(TransformUnmaskedFunctionsPass, PASS_FLAG, PASS_DESCRIPTION, PASS_CFG_ONLY, PASS_ANALYSIS)
IGC_INITIALIZE_PASS_END(TransformUnmaskedFunctionsPass, PASS_FLAG, PASS_DESCRIPTION, PASS_CFG_ONLY, PASS_ANALYSIS)
char TransformUnmaskedFunctionsPass::ID = 0;
TransformUnmaskedFunctionsPass::TransformUnmaskedFunctionsPass()
: FunctionPass(ID)
, MMD(nullptr)
{
}
static void annotateUnmaskedCallSite(CallInst *CI) {
IRBuilder<> builder(CI);
Module* M = CI->getModule();
Function* unmaskedBegin = GenISAIntrinsic::getDeclaration(M, GenISAIntrinsic::GenISA_UnmaskedRegionBegin);
Function* unmaskedEnd = GenISAIntrinsic::getDeclaration(M, GenISAIntrinsic::GenISA_UnmaskedRegionEnd);
builder.CreateCall(unmaskedBegin);
builder.SetInsertPoint(CI->getNextNonDebugInstruction());
builder.CreateCall(unmaskedEnd);
}
static void annotateUnmaskedBasicBlock(BasicBlock *BB) {
IRBuilder<> builder(&*BB->begin());
Module* M = BB->getModule();
Function* unmaskedBegin = GenISAIntrinsic::getDeclaration(M, GenISAIntrinsic::GenISA_UnmaskedRegionBegin);
Function* unmaskedEnd = GenISAIntrinsic::getDeclaration(M, GenISAIntrinsic::GenISA_UnmaskedRegionEnd);
builder.CreateCall(unmaskedBegin);
builder.SetInsertPoint(BB->getTerminator());
builder.CreateCall(unmaskedEnd);
}
struct TrivialUniformity {
static TrivialUniformity Unifrom() {
return { UNIFORM, "" };
}
static TrivialUniformity NonUnifrom(const std::string &reason) {
return { NONUNIFORM, reason };
}
static TrivialUniformity FormalArgument() {
return { FORMAL_ARG, "" };
}
static TrivialUniformity PhiResult() {
return { PHI_RESULT, "" };
}
enum {
UNIFORM, NONUNIFORM, FORMAL_ARG, PHI_RESULT
} kind;
std::string reason;
};
using UniformityCache = DenseMap<const Value*, TrivialUniformity>;
static TrivialUniformity checkValue(const Value* Val, UniformityCache* Cache);
static bool isFunctionTriviallyUniform(const Function* F, TrivialUniformity* outResult, UniformityCache *Cache);
static TrivialUniformity mergeUnifromity(TrivialUniformity a, TrivialUniformity b) {
if (a.kind == TrivialUniformity::NONUNIFORM || b.kind == TrivialUniformity::NONUNIFORM) {
return TrivialUniformity::NonUnifrom(a.reason + " " + b.reason);
}
if (a.kind == TrivialUniformity::FORMAL_ARG || b.kind == TrivialUniformity::FORMAL_ARG) {
return TrivialUniformity::FormalArgument();
}
/* note: && instead of ||*/
if (a.kind == TrivialUniformity::PHI_RESULT && b.kind == TrivialUniformity::PHI_RESULT) {
return TrivialUniformity::PhiResult();
}
return TrivialUniformity::Unifrom();
}
/* Allow only simple conversions. In case of other functions user should
* rewrite the kernel. */
static const char* KnownPrefixes[] = {
"__builtin_spirv_OpSConvert",
"__builtin_spirv_OpUConvert",
"__spirv_SConvert",
"__spirv_UConvert",
};
static bool isKnownUniformLibraryFunction(const Function* F) {
if (F == nullptr) {
return false;
}
for (const char *prefix : KnownPrefixes) {
if (F->getName().contains(prefix))
return true;
}
return false;
}
static TrivialUniformity checkCallInst(const CallInst* CI, UniformityCache *Cache) {
const Function* F = CI->getCalledFunction();
if (F == nullptr) { /* indirect call */
return TrivialUniformity::Unifrom();
}
if (F->isDeclaration() && isKnownUniformLibraryFunction(CI->getCalledFunction()) == false) {
const std::string name = CI->getCalledFunction()->getName().str();
return TrivialUniformity::NonUnifrom("Expression depends on function result "
"that isn't a known uniform function: '" + name + "'.");
}
TrivialUniformity result = TrivialUniformity::Unifrom();
isFunctionTriviallyUniform(F, &result, Cache);
if (result.kind == TrivialUniformity::FORMAL_ARG) {
/* If uniformity of the function depends on a formal argument, check if all actual arguments are uniform: */
result = TrivialUniformity::Unifrom();
const size_t count = IGCLLVM::getNumArgOperands(CI);
for (size_t i = 0; i < count; ++i) {
result = mergeUnifromity(result, checkValue(CI->getArgOperand(i), Cache));
if (result.kind == TrivialUniformity::NONUNIFORM) {
return result;
}
}
}
return result;
}
static TrivialUniformity checkValue(const Value *Val, UniformityCache *Cache) {
if (isa<Argument>(Val)) {
return TrivialUniformity::FormalArgument();
}
if (isa<Constant>(Val) || isa<BasicBlock>(Val)) { /* Assume constants to be uniform. */
return TrivialUniformity::Unifrom();
}
if (!isa<Instruction>(Val) && !isa<Operator>(Val)) { /* The check supports only instructions and opeators. */
return TrivialUniformity::NonUnifrom("Unexpected IR value type.");
}
auto cached = Cache->find(Val);
if (cached != Cache->end()) {
return cached->second;
}
TrivialUniformity result = TrivialUniformity::Unifrom();
/* Check instruction uniformity: */
if (const CallInst * CI = dyn_cast<CallInst>(Val)) {
result = checkCallInst(CI, Cache);
} else if (const PHINode *PI = dyn_cast<PHINode>(Val)) {
/* insert temporary PHI_RESULT to break any potential cycles */
Cache->insert(std::make_pair(Val, TrivialUniformity::PhiResult()));
const size_t count = PI->getNumOperands();
for (size_t i = 0; i < count; i++) {
result = mergeUnifromity(result, checkValue(PI->getOperand(i), Cache));
if (result.kind == TrivialUniformity::NONUNIFORM) {
break;
}
}
/* override temporary value with the actual result */
Cache->insert(std::make_pair(Val, result));
} else {
const User *U = dyn_cast<User>(Val);
IGC_ASSERT_MESSAGE(U, "Expected instruction or operator.");
const size_t count = U->getNumOperands();
for (size_t i = 0; i < count; i++) {
result = mergeUnifromity(result, checkValue(U->getOperand(i), Cache));
if (result.kind == TrivialUniformity::NONUNIFORM) {
break;
}
}
}
Cache->insert(std::make_pair(Val, result));
return result;
}
static bool isFunctionTriviallyUniform(const Function* F, TrivialUniformity *outResult, UniformityCache *Cache) {
TrivialUniformity result = TrivialUniformity::Unifrom();
for (const BasicBlock &BB : *F) {
const Instruction *I = BB.getTerminator();
result = mergeUnifromity(result, checkValue(I, Cache));
if (result.kind == TrivialUniformity::NONUNIFORM) {
break;
}
}
if (outResult) {
*outResult = result;
}
return result.kind == TrivialUniformity::UNIFORM;
}
bool TransformUnmaskedFunctionsPass::runOnFunction(llvm::Function& F)
{
if (!F.hasFnAttribute("sycl-unmasked"))
return false;
UniformityCache Cache;
TrivialUniformity result;
if (isFunctionTriviallyUniform(&F, &result, &Cache) == false) {
std::stringstream stream;
stream << "\nDetected non-uniform control flow inside unmasked function '"
<< F.getName().str() << "': '" << result.reason << "'\n";
std::string errorMessage = stream.str();
getAnalysis<CodeGenContextWrapper>().getCodeGenContext()->EmitError(errorMessage.c_str(), &F);
}
F.removeFnAttr(llvm::Attribute::AlwaysInline);
F.addFnAttr(llvm::Attribute::NoInline);
for (User *U : F.users()) {
if (CallInst* CI = dyn_cast<CallInst>(U)) {
if (CI->hasFnAttr(llvm::Attribute::AlwaysInline)) {
IGCLLVM::removeFnAttr(CI, llvm::Attribute::AlwaysInline);
}
IGCLLVM::addFnAttr(CI, llvm::Attribute::NoInline);
}
}
return true;
}
#define IPASS_FLAG "inline-unmasked"
#define IPASS_DESCRIPTION "Handle unmaksed functions."
#define IPASS_CFG_ONLY false
#define IPASS_ANALYSIS false
IGC_INITIALIZE_PASS_BEGIN(InlineUnmaskedFunctionsPass, IPASS_FLAG, IPASS_DESCRIPTION, IPASS_CFG_ONLY, IPASS_ANALYSIS)
IGC_INITIALIZE_PASS_END(InlineUnmaskedFunctionsPass, IPASS_FLAG, IPASS_DESCRIPTION, IPASS_CFG_ONLY, IPASS_ANALYSIS)
char InlineUnmaskedFunctionsPass::ID = 0;
InlineUnmaskedFunctionsPass::InlineUnmaskedFunctionsPass()
: ModulePass(ID)
, MMD(nullptr)
{
}
bool InlineUnmaskedFunctionsPass::runOnModule(llvm::Module& M)
{
MMD = getAnalysis<MetaDataUtilsWrapper>().getModuleMetaData();
CodeGenContext* pContext = getAnalysis<CodeGenContextWrapper>().getCodeGenContext();
IGCMD::MetaDataUtils* pMdUtils = getAnalysis<MetaDataUtilsWrapper>().getMetaDataUtils();
if (IGC_IS_FLAG_ENABLED(LateInlineUnmaskedFunc)) {
// Clear function groups to safely remove functions later
auto m_FGA = getAnalysisIfAvailable<GenXFunctionGroupAnalysis>();
if( m_FGA ) {
m_FGA->clear();
}
}
// There is a case in Embree where two iterations of inlining is
// required. Consider such a case:
// F: ... call F1 ...
// F1: ... call F2 ...
// F2: ...
// There are two call sites here. If F1 is inlined first then
// call to F2 is cloned and there are two calls to F2 after F1
// inlining. And only one call to F2 is collected in 'Calls'
// vector during first iteration.
bool changed = false;
do {
llvm::SmallSetVector<Function *, 16> Funcs;
for (Function& F : M) {
if (F.hasFnAttribute("sycl-unmasked")) {
Funcs.insert(&F);
}
}
if (Funcs.size() == 0)
break;
changed = true;
auto& FuncMD = pContext->getModuleMetaData()->FuncMD;
llvm::SmallSetVector<CallInst *, 16> Calls;
for (Function *F : Funcs) {
F->removeFnAttr(llvm::Attribute::NoInline);
F->addFnAttr(llvm::Attribute::AlwaysInline);
F->setLinkage(llvm::GlobalValue::InternalLinkage);
auto Iter = pMdUtils->findFunctionsInfoItem(F);
if (Iter != pMdUtils->end_FunctionsInfo()) {
pMdUtils->eraseFunctionsInfoItem(Iter);
}
if (FuncMD.find(F) != FuncMD.end()) {
FuncMD.erase(F);
}
for (User *U : F->users()) {
if (auto *CB = dyn_cast<CallInst>(U)) {
if (CB->getCalledFunction() == F) {
Calls.insert(CB);
annotateUnmaskedCallSite(CB);
}
}
}
}
llvm::InlineFunctionInfo IFI;
for (auto *CB : Calls)
IGCLLVM::InlineFunction(CB, IFI);
for (Function *F : Funcs) {
F->removeDeadConstantUsers();
if (F->isDefTriviallyDead())
F->eraseFromParent();
}
} while (changed);
if (changed) {
pMdUtils->save(*pContext->getLLVMContext());
// The module has functions with unmasked region(s). Keep this info
// for later optimizations tuning (at least disabling).
pContext->m_instrTypes.hasUnmaskedRegion = true;
}
return changed;
}
|