1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432
|
/*========================== begin_copyright_notice ============================
Copyright (C) 2023-2024 Intel Corporation
SPDX-License-Identifier: MIT
============================= end_copyright_notice ===========================*/
//===----------------------------------------------------------------------===//
// GenXClobberChecker
//===----------------------------------------------------------------------===//
//
// Read access to GENX_VOLATILE global (a global value having "genx_volatile"
// attribute) is signified by genx.vload(@GENX_VOLATILE_GLOBAL*) and a
// user (most of the time rdregion, but can be anything including genx.vstore or
// even a phi (the case is known after simplifycfg pass merging genx.vloads
// users)). In VC BE semantics during VISA code generation
// genx.vload(@GENX_VOLATILE_GLOBAL*) IR value does not constitute any VISA
// instruction by itself, instead it signifies a register address of an object
// (simd/vector/matrix) pinned in the register file. The VISA instruction is
// generated from the genx.vload user (or a broader bale sourcing it). The VISA
// instruction therefore appears at the program text position of a genx.vload
// user (or a broader bale sourcing it) and not the position of a genx.vload
// intrinsic itself. During VC BE or standard LLVM optimizations a user
// instruction (or a broader bale) can be transformed in a way that results in a
// position "after" genx.vstore to the same GENX_VOLATILE variable, becoming
// potentially clobbered by it. This situation must be avoided both in VC BE and
// standard LLVM optimizations. Although we do control VC BE optimizations
// codebase the issue is subtle and potentially reappearent. VC BE optimizations
// use genx::isSafeTo<...>CheckAVLoadKill<...> API to avoid the abovementioned
// situation during transformations performed. Cases when standard LLVM
// optimizations break the intended VC BE semantics resulting in clobbering are
// also known (e.g. mem2reg before allowed users subset for genx.vload was
// defined (see genx::isAGVLoadForbiddenUser(...) routine and
// GenXLegalizeGVLoadUses pass)).
//
// This pass implements the checker (available under -check-gv-clobbering=true
// option, turned on by default in Debug build) introduced late in pipeline. It
// is used to identify situations when we have used the potentially clobbered
// GENX_VOLATILE value.
//
// The checker warning about potential clobbering means that some optimization
// pass has overlooked the aspect of genx.vload/genx.vstore semantics described
// above and must be fixed to take it into account by utilizing
// genx::isSafeTo<...>CheckAVLoadKill<...>(...) API.
//
//-------------------------------
// Simplified example, pseudocode:
//-------------------------------
// GENX_VOLATILE g = EXPECTED_VALUE
// funN() { g = UNEXPECTED_VALUE }
// fun1() { funN() }
// kernel () {
// cpy = g // Copy the value of g.
// fun1() // Either store down function call changes g
// g = UNEXPECTED_VALUE // or store in the same function.
// use(cpy) // cpy == EXPECTED_VALUE; use should see the copied value,
// // ... including any control flow cases.
// }
// }
//===----------------------------------------------------------------------===//
//
// To instantly identify the optimization pass at which problematic situation
// occurs this pass can be used as a standalone tool (under an opt utility)
// by checking intermediate IR dumps acquired with the usage of
// -vc-dump-ir-split -vc-dump-ir-before-pass='*' -vc-dump-ir-after-pass='*'
// compiler options and/or IGC_ShaderDumpEnable="1".
//
//===----------------------------------------------------------------------===//
//
// How to run the checker on individual IR dump (for individual options see
// options descriptions below in this file:
//
// {code}
// opt \
// -load <PATH_TO_libVCBackendPlugin.so> \
// -enable-new-pm=0 \
// -check-gv-clobbering=1 \
// -check-gv-clobbering-try-fixup=0 \
// -check-gv-clobbering-chk-with-bales=0 \
// -check-gv-clobbering-standalone-mode=1 \
// -check-gv-clobbering-abort-on-detection=0 \
// -check-gv-clobbering-collect-kill-call-sites=0 \
// -GenXGVClobberChecker \
// -march=genx64 \
// -mtriple=spir64-unknown-unknown \
// -mcpu=Gen9 \
// -disable-output \
// -S \
// <YOUR_LLVM_IR_DUMP.ll>
// {code}
//
#include "GenXBaling.h"
#include "GenXLiveness.h"
#include "GenXTargetMachine.h"
#include "GenXUtil.h"
#include "vc/Support/GenXDiagnostic.h"
#include <llvm/CodeGen/TargetPassConfig.h>
#include <llvm/InitializePasses.h>
#include <llvm/Transforms/Utils/Local.h>
#include <unordered_map>
#define DEBUG_TYPE "GENX_CLOBBER_CHECKER"
using namespace llvm;
using namespace genx;
static cl::opt<bool> CheckGVClobbOpt_CollectKillCallSites(
"check-gv-clobbering-collect-kill-call-sites", cl::init(false), cl::Hidden,
cl::desc("With this option enabled make it more precise by collecting "
"user function call sites that can result in clobbering of a "
"particular global volatile value "
"and account only for those when checking corresponding gvload. "
"This reduces false positive probability for particular program "
"text, but hides potential "
"problems in optimization passes."));
static cl::opt<bool> CheckGVClobbOpt_StandaloneMode(
"check-gv-clobbering-standalone-mode", cl::init(false), cl::Hidden,
cl::desc(
"For use out of pipeline as a standalone utility under opt command."));
static cl::opt<bool> CheckGVClobbOpt_ChkWithBales(
"check-gv-clobbering-chk-with-bales",
cl::init(!CheckGVClobbOpt_StandaloneMode), cl::Hidden,
cl::desc("If true, detects \"vload -> vstore -> (vload's users bales "
"heads)\" cases. In \"standalone\" mode shall spawn standalone "
"baling analysis."
"WARNING: not every IR is baling-ready, so turning this option "
"in standalone mode while checking intermediate IR states can "
"fail. If so, do not use this in standalone mode runs. "
"Detects \"vload -> vstore -> (vload's users)\" when false"));
static cl::opt<bool> CheckGVClobbOpt_TryFixup(
"check-gv-clobbering-try-fixup", cl::init(false), cl::Hidden,
cl::desc("Try to fixup simple cases if clobbering detected."));
static cl::opt<bool> CheckGVClobbOpt_AbortOnDetection(
"check-gv-clobbering-abort-on-detection", cl::init(false), cl::Hidden,
cl::desc("Abort execution if potential clobbering detected."));
namespace {
class GenXGVClobberChecker : public ModulePass,
public IDMixin<GenXGVClobberChecker> {
private:
GenXBaling *Baling = nullptr;
GenXLiveness *Liveness = nullptr;
llvm::DenseMap<const Function *, GenXBaling *> BalingPerFunc;
llvm::DenseMap<const Function *, GenXLiveness *> LivenessPerFunc;
llvm::SmallPtrSet<const BasicBlock *, 2> PhiUserExcludeBlocksOnCfgTraversal;
StringRef DbgPrefix = "[gvload clobber checker] ";
bool checkGVClobberingByInterveningStore(
Instruction *const LI,
const llvm::SmallVector<const Instruction *, 8> *const SIs);
using CallSitesPerFunctionT =
llvm::DenseMap<const Function *,
llvm::SmallVector<const Instruction *, 8>>;
void collectKillCallSites(
const Function *Func,
GenXGVClobberChecker::CallSitesPerFunctionT &CallSitesPerFunction);
public:
explicit GenXGVClobberChecker() : ModulePass(ID) {}
StringRef getPassName() const override {
return "GenX GV clobber checker/fixup";
}
void getAnalysisUsage(AnalysisUsage &AU) const override {
if (CheckGVClobbOpt_StandaloneMode) {
if (CheckGVClobbOpt_ChkWithBales) {
AU.addRequired<TargetPassConfig>();
AU.addRequired<DominatorTreeWrapperPass>();
}
} else {
AU.addRequired<GenXModule>();
AU.addRequired<FunctionGroupAnalysis>();
AU.addRequired<GenXGroupBalingWrapper>();
AU.addRequired<GenXLivenessWrapper>();
}
AU.setPreservesAll();
}
bool runOnModule(Module &) override;
};
} // namespace
namespace llvm {
void initializeGenXGVClobberCheckerPass(PassRegistry &);
} // namespace llvm
INITIALIZE_PASS_BEGIN(GenXGVClobberChecker, "GenXGVClobberChecker",
"GenX global volatile clobbering checker", false, false)
if (CheckGVClobbOpt_StandaloneMode) {
if (CheckGVClobbOpt_ChkWithBales) {
INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
INITIALIZE_PASS_DEPENDENCY(TargetPassConfig)
}
} else {
INITIALIZE_PASS_DEPENDENCY(GenXModule)
INITIALIZE_PASS_DEPENDENCY(FunctionGroupAnalysis)
INITIALIZE_PASS_DEPENDENCY(GenXGroupBalingWrapper)
INITIALIZE_PASS_DEPENDENCY(GenXLivenessWrapper)
}
INITIALIZE_PASS_END(GenXGVClobberChecker, "GenXGVClobberChecker",
"GenX global volatile clobbering checker", false, false)
ModulePass *llvm::createGenXGVClobberCheckerPass() {
initializeGenXGVClobberCheckerPass(*PassRegistry::getPassRegistry());
return new GenXGVClobberChecker();
}
bool GenXGVClobberChecker::checkGVClobberingByInterveningStore(
Instruction *const LI,
const llvm::SmallVector<const Instruction *, 8> *const SIs) {
auto CheckUserInst = [&](Instruction *UI) -> bool {
// TODO: this is an exceptional case. Maybe change GenXArgIndirectionWrapper
// logic not to produce such an unused bitcasts.
if (UI->hasNUses(0) /*llvm::isInstructionTriviallyDead(UI) is more expensive
and not necessary for our usecase. */
&& isa<BitCastInst>(UI)) {
LLVM_DEBUG(
dbgs()
<< "Skipping " << *UI
<< " a trivially dead bitcast coming from GenXArgIndirectionWrapper "
"as not a real use of vload result.\n");
return false;
}
if (isa<PHINode>(UI)) {
vc::diagnose(
LI->getContext(), DbgPrefix,
"PHI node as an immediate vload user found, this will "
"result with phicopy insertion during GenXCoalescing resulting "
"in additional register pressure, whereas the initial intent was to "
"have no additional copies of the value being loaded.",
DS_Warning, vc::WarningName::Generic);
PhiUserExcludeBlocksOnCfgTraversal.clear();
for (const auto &V : cast<PHINode>(UI)->incoming_values())
if (auto *I = dyn_cast<Instruction>(V.get()))
PhiUserExcludeBlocksOnCfgTraversal.insert(I->getParent());
}
const auto *SI = genx::getAVLoadKillOrNull(
LI, UI, false, true, nullptr,
isa<PHINode>(UI) ? &PhiUserExcludeBlocksOnCfgTraversal : nullptr, SIs);
if (!SI)
return false;
vc::diagnose(LI->getContext(), DbgPrefix,
"found a vstore intervening before value usage ", DS_Warning,
vc::WarningName::Generic, UI);
vc::diagnose(LI->getContext(), "...", "intervening vstore", DS_Warning,
vc::WarningName::Generic, SI);
LLVM_DEBUG(dbgs() << DbgPrefix << "Found intervening vstore: " << *SI
<< "\n"
<< DbgPrefix << "Affected vload: " << *LI << "\n"
<< DbgPrefix << "User: " << *UI << "\n"
<< DbgPrefix << "\n");
if (CheckGVClobbOpt_TryFixup) {
if (GenXIntrinsic::isRdRegion(UI) &&
isa<Constant>(
UI->getOperand(GenXIntrinsic::GenXRegion::RdIndexOperandNum))) {
UI->moveAfter(LI);
if (!Baling || !Liveness)
vc::diagnose(LI->getContext(), DbgPrefix,
"Either Baling or Liveness analysis results are not "
"available",
DS_Warning, vc::WarningName::Generic, UI);
if (Baling && Baling->isBaled(UI))
Baling->unbale(UI);
if (Liveness) {
if (Liveness->getLiveRangeOrNull(UI))
Liveness->removeValue(UI);
auto *LR = Liveness->getOrCreateLiveRange(UI);
LR->setCategory(Liveness->getLiveRangeOrNull(LI)->getCategory());
LR->setLogAlignment(
Liveness->getLiveRangeOrNull(LI)->getLogAlignment());
}
return true;
}
vc::diagnose(LI->getContext(), DbgPrefix,
"fixup is only possible for rdregion with constant "
"offsets as it has single input from vload and "
"can be easily moved back to it, however current case is "
"more complex.",
DS_Warning, vc::WarningName::Generic, UI);
}
return CheckGVClobbOpt_AbortOnDetection;
};
if (!CheckGVClobbOpt_StandaloneMode) {
Baling = BalingPerFunc[LI->getFunction()];
if (CheckGVClobbOpt_TryFixup)
Liveness = LivenessPerFunc[LI->getFunction()];
}
bool Detected = false;
for (const auto &U : LI->users()) {
Detected |= CheckUserInst(
CheckGVClobbOpt_ChkWithBales
? Baling->getBaleHead(cast<Instruction>(U))
: cast<Instruction>(U));
}
return Detected;
};
void GenXGVClobberChecker::collectKillCallSites(
const Function *Func,
GenXGVClobberChecker::CallSitesPerFunctionT &CallSitesPerFunction) {
llvm::SmallPtrSet<const Function *, 4> VisitedFuncs;
llvm::SmallVector<const Function *, 32> Stack;
Stack.push_back(Func);
while (!Stack.empty()) {
auto *CurrFunc = Stack.pop_back_val();
if (llvm::find(VisitedFuncs, CurrFunc) != VisitedFuncs.end())
continue;
VisitedFuncs.insert(CurrFunc);
for (const auto &FuncUser : CurrFunc->users()) {
if (isa<CallBase>(FuncUser)) {
auto *Call = cast<Instruction>(FuncUser);
CallSitesPerFunction[Call->getFunction()].push_back(Call);
Stack.push_back(Call->getFunction());
}
}
}
};
bool GenXGVClobberChecker::runOnModule(Module &M) {
llvm::SetVector<Instruction *> Loads;
std::unordered_map<const Value *, CallSitesPerFunctionT> KillCallSites;
if (CheckGVClobbOpt_CollectKillCallSites)
LLVM_DEBUG(dbgs() << DbgPrefix
<< "Checking in non-strict mode (matching as potentially "
"clobbering only "
"call sites that can result in gvstore to the related "
"global volatile value).\n");
if (CheckGVClobbOpt_AbortOnDetection)
LLVM_DEBUG(dbgs() << DbgPrefix << "Aborting if potential clobbering.\n");
if (CheckGVClobbOpt_StandaloneMode) {
if (CheckGVClobbOpt_ChkWithBales) {
LLVM_DEBUG(dbgs() << DbgPrefix
<< "Instantiating local baling info helper.\n");
vc::diagnose(
M.getContext(), DbgPrefix,
"WARNING: not every IR is baling-ready, so turning this option "
"in standalone mode while checking intermediate IR states can "
"fail. If so, do not use this in standalone mode runs.",
DS_Warning, vc::WarningName::Generic);
Baling = new GenXBaling(BalingKind::BK_Analysis,
&getAnalysis<TargetPassConfig>()
.getTM<GenXTargetMachine>()
.getGenXSubtarget());
bool BalingChangedCode = false;
for (auto &F : M) {
if (F.isDeclaration())
continue;
BalingChangedCode |= Baling->processFunction(
F, getAnalysis<DominatorTreeWrapperPass>(F).getDomTree());
}
if (BalingChangedCode)
vc::diagnose(M.getContext(), DbgPrefix,
"Baling analysis has changed the original code.",
DS_Warning, vc::WarningName::Generic);
} else {
LLVM_DEBUG(dbgs() << DbgPrefix << "Checking with no baling info.\n");
}
} else {
auto &FGA = getAnalysis<FunctionGroupAnalysis>();
auto &LivenessFGWrapper = getAnalysis<GenXLivenessWrapper>();
for (const auto &F : M) {
if (F.isDeclaration())
continue;
LivenessPerFunc[&F] =
&LivenessFGWrapper.getFGPassImpl(FGA.getAnyGroup(&F));
if (CheckGVClobbOpt_ChkWithBales)
BalingPerFunc[&F] =
&getAnalysis<GenXGroupBalingWrapper>().getFGPassImpl(
FGA.getAnyGroup(&F));
}
}
for (const auto &G : M.globals()) {
if (!G.hasAttribute(genx::FunctionMD::GenXVolatile))
continue;
for (const auto *V : genx::peelBitCastsGetUsers(&G)) {
if (const auto *I = dyn_cast<Instruction>(V)) {
if (genx::isAVLoad(I))
Loads.insert(const_cast<Instruction *>(
I)); // Loads can be modified further if fixup mode is enabled, so
// we are intentionally storing a pointer to non-const load
// here.
else if (CheckGVClobbOpt_CollectKillCallSites && genx::isAVStore(I))
collectKillCallSites(I->getFunction(), KillCallSites[&G]);
}
}
}
if (Loads.empty())
return false;
bool ChangedOrNeedToAbort = false;
for (auto &LI : Loads)
ChangedOrNeedToAbort |= checkGVClobberingByInterveningStore(
LI, CheckGVClobbOpt_CollectKillCallSites
? &KillCallSites[genx::getBitCastedValue(LI->getOperand(0))]
[LI->getFunction()]
: nullptr);
if (CheckGVClobbOpt_AbortOnDetection && ChangedOrNeedToAbort) {
dbgs() << "\n[WARNING] Aborting on potential global volatile clobbering, "
"as requested.\n";
std::abort();
}
if (CheckGVClobbOpt_ChkWithBales && CheckGVClobbOpt_StandaloneMode)
delete Baling;
return ChangedOrNeedToAbort;
}
|