1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678
|
/*========================== begin_copyright_notice ============================
Copyright (C) 2017-2021 Intel Corporation
SPDX-License-Identifier: MIT
============================= end_copyright_notice ===========================*/
#include <tuple>
#include "Assertions.h"
#include "BuildIR.h"
#include "common.h"
#include "ifcvt.h"
using namespace vISA;
namespace {
const unsigned FullyConvertibleMaxInsts = 5;
const unsigned PartialConvertibleMaxInsts = 3;
enum IfConvertKind {
FullConvert,
// Both 'if' and 'else' (if present) branches could be predicated.
PartialIfConvert,
// If both 'if' and 'else' branches are present, but only 'if' branch
// could be predicated.
PartialElseConvert
// If both 'if' and 'else' branches are present, but only 'else' branch
// could be predicated.
// For the later two cases, it's potentially beneficial to convert the
// original 'if-else-fi' into 'if-fi' following predicated the other
// part. For example,
//
// if (pred) {
// BB1;
// } else {
// BB2;
// } endif
//
// If BB2 cannot be converted (PartialIfConverted), we could convert it
// into
//
// (pred) BB1;
// if (-pred) {
// BB2;
// } endif
//
// Ofc, BB1 may need to be very smaller to really improve the final
// performance.
};
// If-convertible.
struct IfConvertible {
IfConvertKind kind;
G4_Predicate *pred;
G4_BB *head;
G4_BB *succIf;
G4_BB *succElse;
G4_BB *tail;
IfConvertible(IfConvertKind k, G4_Predicate *p, G4_BB *h, G4_BB *s0,
G4_BB *s1, G4_BB *t)
: kind(k), pred(p), head(h), succIf(s0), succElse(s1), tail(t) {}
};
// Trivial if-conversion.
class IfConverter {
FlowGraph &fg;
/// getSinglePredecessor - Get the single predecessor or null
/// otherwise.
G4_BB *getSinglePredecessor(G4_BB *BB, G4_BB *If) const {
if (BB->Preds.size() != 1) {
if (BB->Preds.size() == 2) {
if (BB->Preds.front() == If)
return BB->Preds.back();
if (BB->Preds.back() == If)
return BB->Preds.front();
}
return nullptr;
}
return BB->Preds.front();
}
/// getSingleSuccessor - Get the single successor or null
/// otherwise.
G4_BB *getSingleSuccessor(G4_BB *BB, G4_BB *Else) const {
if (BB->Succs.size() != 1) {
if (BB->Succs.size() == 2) {
if (BB->Succs.front() == Else)
return BB->Succs.back();
if (BB->Succs.back() == Else)
return BB->Succs.front();
}
return nullptr;
}
return BB->Succs.front();
}
/// getEMaskBits() -
unsigned getEMaskBits(unsigned maskOffset, unsigned execSize) const {
uint64_t Val = ((uint64_t)1 << execSize) - 1;
return (uint32_t)(Val << maskOffset);
}
/// getnnerMostIf - If the given BB is the head of an innermost IF
/// block, return its condition, 'if' branch and 'else' branch (if any)
/// and tail, i.e.,
///
/// H H
/// / \ / |
/// 'if' 'else' or 'if' |
/// \ / \ |
/// T T
/// Otherwise, return all null pointers.
///
/// TODO: Add 'goto' support as CFG structurization is currently all or
/// nothing.
std::tuple<G4_INST * /* last instruction in head, i.e. 'if' */,
G4_BB * /* if */, G4_BB * /* else */, G4_BB * /* tail */>
getInnermostIfBlock(G4_BB *BB) const {
// Such BB should already be recognized as structural IF statement.
if (BB->empty())
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
G4_INST *last = BB->back();
// Skip if there's 'NoMask' on that (possible) conditional branch.
if (last->getMaskOption() & InstOpt_WriteEnable)
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
// Check whether it's 'if' or 'goto'.
G4_opcode op = last->opcode();
if (op != G4_if) {
if (op != G4_goto)
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
// Extra checks for 'goto'.
// Skip if there's no predicate.
if (!last->getPredicate())
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
// Skip backward goto.
if (last->isFlowControl() && last->asCFInst()->isBackward())
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
// Skip if there's no exactly 2 successors.
if (BB->Succs.size() != 2)
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
}
vISA_ASSERT(BB->Succs.size() == 2,
"'if' should have exactly two successors!");
vISA_ASSERT(last->getPredicate(), "'if' or 'goto' should be conditional!");
G4_BB *s0 = BB->Succs.front(); // if-block
G4_BB *s1 = BB->Succs.back(); // else-block
G4_BB *t0 = getSingleSuccessor(s0, s1);
if (!t0) {
// The innermost 'if' branch should have only one
// successor.
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
}
// It also needs to have a single predecessor.
if (!getSinglePredecessor(s0, s1))
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
if (t0 == s1) {
// 'if-fi'
VISA_DEBUG(std::cout << "Found an innermost if-fi block at"
<< " BB" << BB->getId() << " with branch BB"
<< s0->getId() << " and tail BB" << t0->getId() << '\n');
return std::make_tuple(last, s0, nullptr, t0);
}
G4_BB *t1 = getSingleSuccessor(s1, s0);
if (!t1 || t0 != t1) {
// The innermost 'else' branch should have only one common
// successor from the 'if' branch.
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
}
// It also needs to have a single predecessor.
if (!getSinglePredecessor(s1, s0))
return std::make_tuple(nullptr, nullptr, nullptr, nullptr);
VISA_DEBUG(std::cout << "Found an innermost if-else-fi block at"
<< " BB" << BB->getId() << " with branches {"
<< "BB" << s0->getId() << ", BB" << s1->getId()
<< "} and tail BB" << t0->getId() << '\n');
// 'if-else-fi'
return std::make_tuple(last, s0, s1, t0);
}
/// isPredictable - Check whether the given instruction 'I' could be
/// predicated using the predicate from the specified 'if' instruction.
bool isPredictable(G4_INST *I, G4_INST *ifInst) const {
// Already predicated.
if (I->getPredicate()) {
// NOTE: It's not the responsibility of this routine to check
// special cases where an already predicated instruction could be
// predicated again.
return false;
}
// With cond modifier.
if (I->getCondMod()) {
// When condition modifier is present, we cannot predicate due to
// 1) the flag register is used as both predicate and condmod flag;
// 2) the update to flag register is guarded by EMask only. The
// behavior is different from regular predicated insts.
return false;
}
G4_opcode op = I->opcode();
switch (G4_Inst_Table[op].instType) {
case InstTypeMov:
switch (op) {
case G4_mov:
case G4_movi:
case G4_smov:
break;
case G4_sel:
case G4_csel:
default:
return false;
}
break;
case InstTypeArith:
case InstTypeLogic:
case InstTypeVector:
break;
case InstTypeCompare:
case InstTypeFlow:
case InstTypeMisc:
// TODO: G4_send, G4_sendc, G4_sends, and G4_sendsc need
// investigating whether they are profitable to be predicated.
case InstTypePseudoLogic:
case InstTypeReserved:
default:
return false;
}
unsigned maskOpt = I->getMaskOption();
// Skip 'NoMask' so far as it requires further investigation.
// TODO: When 'NoMask' is present, we could convert them to
// (+P.any) or (-P.all) depending on 'if' or 'else' branch. E.g.,
//
// (+P) if (16) (-P) if (16)
// mov (1) V0 V1 {NoMask} or mov (1) V0 V1 {NoMask}
// endif (16) endif (16)
//
//
// could be converted into
//
// (+P.any) mov (1) V0 V1 {NoMask} or
// (-P.all) mov (1) V0 V1 {NoMask}
if (maskOpt & InstOpt_WriteEnable)
return false;
[[maybe_unused]] unsigned ifMaskOpt = ifInst->getMaskOption();
vISA_ASSERT((ifMaskOpt & InstOpt_WriteEnable) == 0,
"Unexpected 'NoMask' in 'if' emask.");
unsigned maskBits = getEMaskBits(I->getMaskOffset(), I->getExecSize());
unsigned ifMaskBits =
getEMaskBits(ifInst->getMaskOffset(), ifInst->getExecSize());
// Skip if emask bits in 'if' cannot cover the one from the given
// instruction.
if ((~ifMaskBits) & maskBits)
return false;
return true;
}
// isFlagClearingFollowedByGoto - Check if the current instruction is
// the flag clearing instruction followed by a goto using that flag.
bool isFlagClearingFollowedByGoto(G4_INST *I, G4_BB *BB) const {
// Skip if it's not the second to the last instruction, which
// should be a 'goto' with predicate.
if (BB->size() <= 1)
return false;
auto iter = BB->rbegin();
G4_INST *last = *iter++;
if (I != *iter)
return false;
if (last->opcode() != G4_goto)
return false;
G4_Predicate *pred = last->getPredicate();
if (!pred)
return false;
// Skip non-mov instructions.
if (I->opcode() != G4_mov)
return false;
// Source should be zero.
G4_Operand *src = I->getSrc(0);
if (!src->isImm() || !src->asImm()->isZero())
return false;
// Dst should be a flag register.
G4_Operand *dst = I->getDst();
if (!dst->isFlag())
return false;
if (dst->getTopDcl() != pred->getTopDcl())
return false;
// Dst should be used in that goto instruction as the predicate.
return true;
}
/// getPredictableInsts - Return the total number of instructions if
/// all instruction in the given BB is predictable. Otherwise, return
/// 0.
unsigned getPredictableInsts(G4_BB *BB, G4_INST *ifInst) const {
vISA_ASSERT(ifInst->opcode() == G4_if || ifInst->opcode() == G4_goto,
"Either 'if' or 'goto' is expected!");
bool isGoto = (ifInst->opcode() == G4_goto);
unsigned sum = 0;
for (auto *I : *BB) {
G4_opcode op = I->opcode();
// Ignore G4_label
if (op == G4_label) {
vISA_ASSERT(I == BB->front(),
"'label' should be the first instruction!");
continue;
}
// Ignore G4_else
if (isGoto) {
if (op == G4_join) {
vISA_ASSERT(BB->size() > 1 && I == (*++BB->begin()),
"'join' should be the second instruction!");
continue;
}
if (op == G4_goto) {
vISA_ASSERT(I == BB->back(),
"'goto' should be the last instruction!");
continue;
}
if (isFlagClearingFollowedByGoto(I, BB)) {
vISA_ASSERT(BB->size() > 1 && I == (*++BB->rbegin()),
"flag clearing should be the second to last"
" instruction!");
continue;
}
} else {
if (op == G4_else) {
vISA_ASSERT(I == BB->back(),
"'else' should be the last instruction!");
continue;
}
}
if (!isPredictable(I, ifInst)) {
return 0;
}
++sum;
}
return sum;
}
/// reversePredicate - Reverse the predicate state.
void reversePredicate(G4_Predicate *pred) const {
G4_PredState state = pred->getState();
switch (state) {
case PredState_Plus:
state = PredState_Minus;
break;
case PredState_Minus:
state = PredState_Plus;
break;
default:
break;
}
pred->setState(state);
}
/// An alternative to c++11 standard 'std::to_string' but does not
/// require c++11. 'T' should be restricted to integer types by using
/// 'enable_if' to avoid breaking broken c++ support on some platforms.
template <typename T> std::string toString(T v) const {
std::ostringstream oss;
oss << v;
return oss.str();
}
void fullConvert(IfConvertible &);
void partialConvert(IfConvertible &);
public:
IfConverter(FlowGraph &g) : fg(g) {}
void analyze(std::vector<IfConvertible> &);
void convert(IfConvertible &IC) {
switch (IC.kind) {
case FullConvert:
fullConvert(IC);
break;
default:
partialConvert(IC);
break;
}
}
};
} // End anonymous namespace
void IfConverter::analyze(std::vector<IfConvertible> &list) {
for (auto *BB : fg) {
G4_INST *ifInst;
G4_BB *s0, *s1, *t;
std::tie(ifInst, s0, s1, t) = getInnermostIfBlock(BB);
if (!ifInst) {
// Skip non-innermost if.
continue;
}
if (t && (t->isEndWithCall() || (t->getLastOpcode() == G4_return))) {
continue;
}
vASSERT(s0);
// Conservatively skip if BB is set with G4_BB_KEEP_TYPE
if ((t && (t->getBBType() & G4_BB_KEEP_TYPE)) ||
((s0->getBBType() & G4_BB_KEEP_TYPE)) ||
(s1 && (s1->getBBType() & G4_BB_KEEP_TYPE))) {
continue;
}
G4_Predicate *pred = ifInst->getPredicate();
unsigned n0 = getPredictableInsts(s0, ifInst);
unsigned n1 = s1 ? getPredictableInsts(s1, ifInst) : 0;
if (s1) {
if (((n0 > 0) && (n0 < FullyConvertibleMaxInsts)) &&
((n1 > 0) && (n1 < FullyConvertibleMaxInsts))) {
// Both 'if' and 'else' are profitable to be if-converted.
list.push_back(IfConvertible(FullConvert, pred, BB, s0, s1, t));
} else if ((n0 > 0) && (n0 < PartialConvertibleMaxInsts)) {
// Only 'if' is profitable to be converted.
list.push_back(IfConvertible(PartialIfConvert, pred, BB, s0, s1, t));
} else if ((n1 > 0) && (n1 < PartialConvertibleMaxInsts)) {
// Only 'else' is profitable to be converted.
list.push_back(IfConvertible(PartialElseConvert, pred, BB, s0, s1, t));
}
} else if ((n0 > 0) && (n0 < FullyConvertibleMaxInsts)) {
list.push_back(IfConvertible(FullConvert, pred, BB, s0, nullptr, t));
}
}
}
void IfConverter::fullConvert(IfConvertible &IC) {
G4_Predicate &pred = *IC.pred;
G4_BB *head = IC.head;
G4_BB *tail = IC.tail;
G4_BB *s0 = IC.succIf;
G4_BB *s1 = IC.succElse;
INST_LIST_ITER pos = std::prev(head->end());
G4_opcode op = (*pos)->opcode();
vISA_ASSERT(op == G4_if || op == G4_goto,
"Convertible if is not started with 'if' or 'goto'!");
bool isGoto = (op == G4_goto);
// Skip tail merging if tail has other incoming edge(s).
bool doTailMerging = (tail->Preds.size() == 2);
// forward goto's behavior is platform dependent
bool needReversePredicateForGoto = (isGoto && fg.builder->gotoJumpOnTrue());
// Merge predicated 'if' into header.
for (/* EMPTY */; !s0->empty(); s0->pop_front()) {
auto I = s0->front();
G4_opcode op = I->opcode();
if (op == G4_label)
continue;
if (isGoto && s1) {
// Have both s0 and s1, goto in s0 can be
// removed always.
if (op == G4_goto)
continue;
if (isFlagClearingFollowedByGoto(I, s0))
continue;
} else {
if (op == G4_else)
continue;
// If there is a goto, its target must be tail.
// If merging is done, we must remove goto as its
// target is gone.
if (doTailMerging && op == G4_goto)
continue;
}
/* Predicate instructions if it's not goto-style or it's not
* neither goto nor its flag clearing instruction */
if (!isGoto || !(op == G4_goto || isFlagClearingFollowedByGoto(I, s0))) {
// Negative predicate instructions if needed.
if (needReversePredicateForGoto) {
G4_Predicate *negPred = fg.builder->createPredicate(pred);
reversePredicate(negPred);
I->setPredicate(negPred);
} else {
I->setPredicate(fg.builder->createPredicate(pred));
}
}
head->insertBefore(pos, I);
}
s0->markEmpty(fg.builder);
// Merge predicated 'else' into header.
if (s1) {
// Reverse the flag controling whether the predicate needs reversing.
needReversePredicateForGoto = !needReversePredicateForGoto;
for (/* EMPTY */; !s1->empty(); s1->pop_front()) {
auto I = s1->front();
G4_opcode op = I->opcode();
if (op == G4_label)
continue;
if (op == G4_join)
continue;
// If there is a goto, its target must be tail.
// If merging is done, we must remove goto as its
// target is gone.
if (doTailMerging && op == G4_goto)
continue;
/* Predicate instructions if it's not goto-style or it's not
* neither goto nor its flag clearing instruction */
if (!isGoto || !(op == G4_goto || isFlagClearingFollowedByGoto(I, s1))) {
// Negative predicate instructions if needed.
if (needReversePredicateForGoto) {
G4_Predicate *negPred = fg.builder->createPredicate(pred);
reversePredicate(negPred);
I->setPredicate(negPred);
} else {
I->setPredicate(fg.builder->createPredicate(pred));
}
}
head->insertBefore(pos, I);
}
s1->markEmpty(fg.builder);
}
// Remove 'if' instruction in head.
head->erase(pos);
if (!doTailMerging)
return;
// Remove 'label' and 'endif'/'join' instructions in tail.
vISA_ASSERT(tail->front()->opcode() == G4_label,
"BB is not started with 'label'!");
tail->pop_front();
vISA_ASSERT(tail->front()->opcode() == G4_endif ||
tail->front()->opcode() == G4_join,
"Convertible if is not ended with 'endif'!");
tail->pop_front();
// Merge head and tail to get more code scheduling chance.
head->splice(head->end(), tail);
tail->markEmpty(fg.builder);
}
void IfConverter::partialConvert(IfConvertible &IC) {
// TODO: Add partial if-conversion support.
}
void runIfCvt(FlowGraph &fg) {
IfConverter converter(fg);
std::vector<IfConvertible> ifList;
converter.analyze(ifList);
// FIXME: The convertible 'if's are traversed with assumption that BBs are
// already ordered in topological order so that, once we merge head & tail
// blocks, we won't break the remaining convertible 'if's to be converted.
for (auto II = ifList.rbegin(), IE = ifList.rend(); II != IE; ++II) {
converter.convert(*II);
}
// Run additional transforms from 'sel' to 'mov' if one of the source
// operands is equal to the destination.
for (G4_BB *BB : fg) {
for (auto BI = BB->begin(), BE = BB->end(); BI != BE; ++BI) {
G4_INST *I = *BI;
if (I->opcode() != G4_sel || !I->getPredicate() || I->getCondMod())
continue;
auto compareOperand = [](G4_DstRegRegion *A, G4_Operand *B,
unsigned ExecSize,
const IR_Builder &IRB) -> G4_CmpRelation {
G4_CmpRelation Res = A->compareOperand(B, IRB);
if ((A->isAreg() && A->isFlag()) || (B->isAreg() && B->isFlag()) ||
(A->isAreg() && A->isAccReg()) || (B->isAreg() && B->isAccReg())) {
// compareOperand() not working for flag physical registers.
return Rel_disjoint;
}
if (Res != Rel_interfere)
return Res;
if (!A->isIndirect() || !B->isIndirect())
return Res;
if (A->getHorzStride() != 1)
return Res;
// Extra check if both are indirect register accesses.
G4_VarBase *BaseA = A->getBase();
G4_VarBase *BaseB = B->getBase();
if (!BaseA || !BaseB || BaseA != BaseB || !BaseA->isRegVar())
return Res;
if (!B->isSrcRegRegion())
return Res;
G4_SrcRegRegion *S = B->asSrcRegRegion();
if (!S->getRegion()->isContiguous(ExecSize))
return Res;
if (A->getRegOff() != S->getRegOff() ||
A->getSubRegOff() != S->getSubRegOff())
return Res;
if (A->getAddrImm() != S->getAddrImm())
return Res;
return Rel_eq;
};
unsigned ExSz = I->getExecSize();
G4_DstRegRegion *Dst = I->getDst();
G4_Operand *Src0 = I->getSrc(0);
G4_Operand *Src1 = I->getSrc(1);
int OpndIdx = -1;
if (compareOperand(Dst, Src0, ExSz, *fg.builder) == Rel_eq &&
Src0->isSrcRegRegion() &&
Src0->asSrcRegRegion()->getModifier() == Mod_src_undef)
OpndIdx = 0;
else if (compareOperand(Dst, Src1, ExSz, *fg.builder) == Rel_eq &&
Src1->isSrcRegRegion() &&
Src1->asSrcRegRegion()->getModifier() == Mod_src_undef)
OpndIdx = 1;
if (OpndIdx >= 0) {
// If dst is equal to one of operands of 'sel', that
// 'sel' could be transformed into a predicated 'mov',
// i.e.,
//
// transforms
//
// (+p) sel dst, src0, src1
//
// into
//
// (+p) mov dst, src0 if dst == src1
//
// or
//
// (-p) mov dst, src1 if dst == src0
//
if (OpndIdx == 0) {
// Inverse predicate.
G4_Predicate *Pred = I->getPredicate();
G4_PredState State = Pred->getState();
State = (State == PredState_Plus) ? PredState_Minus : PredState_Plus;
Pred->setState(State);
// Swap source operands.
I->setSrc(Src1, 0);
I->setSrc(Src0, 1);
}
I->setOpcode(G4_mov);
I->setSrc(nullptr, 1);
}
}
}
}
// vim:ts=4:sw=4:et:
|