1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
|
//
// This file is part of j4-dmenu-desktop.
//
// j4-dmenu-desktop is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// j4-dmenu-desktop is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with j4-dmenu-desktop. If not, see <http://www.gnu.org/licenses/>.
//
#include <catch2/catch_message.hpp>
#include <catch2/catch_test_macros.hpp>
#include <errno.h>
#include <stdlib.h>
#include <string.h>
#include <string>
#include <sys/types.h>
#include <sys/wait.h>
#include <unistd.h>
// IWYU pragma: no_include <vector>
#include "generated/tests_config.hh"
#include "Application.hh"
#include "CMDLineAssembler.hh"
#include "FieldCodes.hh"
#include "LineReader.hh"
#include "LocaleSuffixes.hh"
#include "Utilities.hh"
// This function will pass the string to the shell, the shell will unquote and
// expand it and it will return the split arguments.
// NOTE: This could be merged with ShellUnquote.sh
static stringlist_t getshell(const std::vector<std::string> &args) {
int pipefd[2];
if (pipe(pipefd) == -1) {
WARN("Unable to create pipe: " << strerror(errno));
return {};
}
pid_t pid;
switch (pid = fork()) {
case -1:
WARN("Unable to fork: " << strerror(errno));
return {};
case 0:
dup2(pipefd[1], STDOUT_FILENO);
close(pipefd[0]);
close(pipefd[1]);
close(STDIN_FILENO);
std::string joined_args = CMDLineAssembly::convert_argv_to_string(args);
execl("/bin/sh", "/bin/sh", "-c",
((std::string) "printf '%s\\0' " + joined_args).c_str(),
(char *)NULL);
_exit(1);
}
close(pipefd[1]);
int status;
waitpid(pid, &status, 0);
if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {
WARN("Couldn't execute shell.");
close(pipefd[0]);
return {};
}
char buf[512];
ssize_t len;
len = read(pipefd[0], buf, sizeof buf - 1);
close(pipefd[0]);
stringlist_t result = split(std::string(buf, len), '\0');
if (result.back().empty())
result.pop_back();
return result;
}
TEST_CASE("Tests proper handling of special characters",
"[ApplicationRunner]") {
LocaleSuffixes ls("en_US");
LineReader liner;
Application app(TEST_FILES "applications/gimp.desktop", liner, ls, {});
auto args = CMDLineAssembly::convert_exec_to_command(app.exec);
expand_field_codes(args, app, R"--(@#$%^&*}{)(\)--");
auto result = getshell(args);
stringlist_t cmp({"gimp-2.8", R"--(@#$%^&*}{)(\)--"});
REQUIRE(result == cmp);
}
TEST_CASE("Test field codes", "[ApplicationRunner]") {
LocaleSuffixes ls("en_US");
LineReader liner;
Application app(TEST_FILES "applications/field_codes.desktop", liner, ls,
{});
auto args = CMDLineAssembly::convert_exec_to_command(app.exec);
expand_field_codes(args, app, "arg1 arg2\\ arg3");
auto result = getshell(args);
stringlist_t cmp({"true", "--name=%c", "--location",
TEST_FILES "applications/field_codes.desktop", "arg1",
"arg2\\", "arg3"});
REQUIRE(result == cmp);
}
TEST_CASE("Regression test for issue #18, %c was not escaped",
"[ApplicationRunner]") {
LocaleSuffixes ls("en_US");
LineReader liner;
Application app(TEST_FILES "applications/caption.desktop", liner, ls, {});
auto args = CMDLineAssembly::convert_exec_to_command(app.exec);
expand_field_codes(args, app, "");
auto result = getshell(args);
stringlist_t cmp({"1234", "--caption", "Regression Test 18"});
REQUIRE(result == cmp);
}
|
