1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
|
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>FindBugs Report</title>
<style type="text/css">
.tablerow0 {
background: #EEEEEE;
}
.tablerow1 {
background: white;
}
.detailrow0 {
background: #EEEEEE;
}
.detailrow1 {
background: white;
}
.tableheader {
background: #b9b9fe;
font-size: larger;
}
.tablerow0:hover, .tablerow1:hover {
background: #aaffaa;
}
.priority-1 {
color: red;
font-weight: bold;
}
.priority-2 {
color: orange;
font-weight: bold;
}
.priority-3 {
color: green;
font-weight: bold;
}
.priority-4 {
color: blue;
font-weight: bold;
}
</style>
<script type="text/javascript">
function toggleRow(elid) {
if (document.getElementById) {
element = document.getElementById(elid);
if (element) {
if (element.style.display == 'none') {
element.style.display = 'block';
//window.status = 'Toggle on!';
} else {
element.style.display = 'none';
//window.status = 'Toggle off!';
}
}
}
}
</script>
</head>
<body>
<h1>
<a href="http://findbugs.sourceforge.net">FindBugs</a> Report</h1>
<h2>Project Information</h2>
<p>Project:
</p>
<p>FindBugs version: 3.0.1</p>
<p>Code analyzed:</p>
<ul>
<li>/home/kredel/jas/edu/jas/</li>
</ul>
<p>
<br/>
<br/>
</p>
<h2>Metrics</h2>
<p>113838 lines of code analyzed,
in 1016 classes,
in 16 packages.</p>
<table width="500" cellpadding="5" cellspacing="2">
<tr class="tableheader">
<th align="left">Metric</th>
<th align="right">Total</th>
<th align="right">Density*</th>
</tr>
<tr class="tablerow0">
<td>High Priority Warnings</td>
<td align="right">1</td>
<td align="right">0.01</td>
</tr>
<tr class="tablerow1">
<td>Medium Priority Warnings</td>
<td align="right">37</td>
<td align="right">0.33</td>
</tr>
<tr class="$totalClass">
<td>
<b>Total Warnings</b>
</td>
<td align="right">
<b>38</b>
</td>
<td align="right">
<b>0.33</b>
</td>
</tr>
</table>
<p>
<i>(* Defects per Thousand lines of non-commenting source statements)</i>
</p>
<p>
<br/>
<br/>
</p>
<h2>Contents</h2>
<ul>
<li>
<a href="#Warnings_BAD_PRACTICE">Bad practice Warnings</a>
</li>
<li>
<a href="#Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a>
</li>
<li>
<a href="#Warnings_STYLE">Dodgy code Warnings</a>
</li>
<li>
<a href="#Details">Details</a>
</li>
</ul>
<h1>Summary</h1>
<table width="500" cellpadding="5" cellspacing="2">
<tr class="tableheader">
<th align="left">Warning Type</th>
<th align="right">Number</th>
</tr>
<tr class="tablerow0">
<td>
<a href="#Warnings_BAD_PRACTICE">Bad practice Warnings</a>
</td>
<td align="right">22</td>
</tr>
<tr class="tablerow1">
<td>
<a href="#Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a>
</td>
<td align="right">1</td>
</tr>
<tr class="tablerow0">
<td>
<a href="#Warnings_STYLE">Dodgy code Warnings</a>
</td>
<td align="right">15</td>
</tr>
<tr class="tablerow1">
<td>
<b>Total</b>
</td>
<td align="right">
<b>38</b>
</td>
</tr>
</table>
<h1>Warnings</h1>
<p>Click on a warning row to see full context information.</p>
<h2>
<a name="Warnings_BAD_PRACTICE">Bad practice Warnings</a>
</h2>
<table class="warningtable" width="100%" cellspacing="0">
<tr class="tableheader">
<th align="left">Code</th>
<th align="left">Warning</th>
</tr>
<tr class="tablerow1" onclick="toggleRow('N65548');">
<td>
<span class="priority-1">Nm</span>
</td>
<td>The class name edu.jas.application.FactorFactory shadows the simple name of the superclass edu.jas.ufd.FactorFactory</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N65548" style="display: none;">
<a href="#NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)</a>
<br/>In class edu.jas.application.FactorFactory<br/>In class edu.jas.ufd.FactorFactory<br/>At FactorFactory.java:[lines 66-212]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N65595');">
<td>
<span class="priority-2">Nm</span>
</td>
<td>The method name edu.jas.application.GBAlgorithmBuilder.Arri() doesn't start with a lower case letter</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N65595" style="display: none;">
<a href="#NM_METHOD_NAMING_CONVENTION">Bug type NM_METHOD_NAMING_CONVENTION (click for details)</a>
<br/>In class edu.jas.application.GBAlgorithmBuilder<br/>In method edu.jas.application.GBAlgorithmBuilder.Arri()<br/>At GBAlgorithmBuilder.java:[lines 523-536]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N65711');">
<td>
<span class="priority-2">OS</span>
</td>
<td>edu.jas.application.RunGB.getReader(String) may fail to close stream</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N65711" style="display: none;">
<a href="#OS_OPEN_STREAM">Bug type OS_OPEN_STREAM (click for details)</a>
<br/>In class edu.jas.application.RunGB<br/>In method edu.jas.application.RunGB.getReader(String)<br/>Need to close java.util.zip.ZipFile <br/>At RunGB.java:[line 489]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N67185');">
<td>
<span class="priority-2">RV</span>
</td>
<td>edu.jas.poly.PolynomialComparator.compare(GenPolynomial, GenPolynomial) negates the return value of edu.jas.poly.GenPolynomial.compareTo(GenPolynomial)</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N67185" style="display: none;">
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a>
<br/>In class edu.jas.poly.PolynomialComparator<br/>In method edu.jas.poly.PolynomialComparator.compare(GenPolynomial, GenPolynomial)<br/>Called method edu.jas.poly.GenPolynomial.compareTo(GenPolynomial)<br/>Return value of edu.jas.poly.GenPolynomial.compareTo(GenPolynomial) of type int<br/>At PolynomialComparator.java:[line 51]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N67511');">
<td>
<span class="priority-2">RV</span>
</td>
<td>edu.jas.poly.TermOrder$11.compare(ExpVector, ExpVector) negates the return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N67511" style="display: none;">
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a>
<br/>In class edu.jas.poly.TermOrder$11<br/>In method edu.jas.poly.TermOrder$11.compare(ExpVector, ExpVector)<br/>Called method edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)<br/>Return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector) of type int<br/>At TermOrder.java:[line 292]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N67589');">
<td>
<span class="priority-2">RV</span>
</td>
<td>edu.jas.poly.TermOrder$71.compare(ExpVector, ExpVector) negates the return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N67589" style="display: none;">
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a>
<br/>In class edu.jas.poly.TermOrder$71<br/>In method edu.jas.poly.TermOrder$71.compare(ExpVector, ExpVector)<br/>Called method edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)<br/>Return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector) of type int<br/>At TermOrder.java:[line 1316]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N67667');">
<td>
<span class="priority-2">RV</span>
</td>
<td>edu.jas.poly.Word.gradInvlexCompareTo(Word) negates the return value of edu.jas.poly.Word.compareTo(Word)</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N67667" style="display: none;">
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a>
<br/>In class edu.jas.poly.Word<br/>In method edu.jas.poly.Word.gradInvlexCompareTo(Word)<br/>Called method edu.jas.poly.Word.compareTo(Word)<br/>Return value of edu.jas.poly.Word.compareTo(Word) of type int<br/>At Word.java:[line 553]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66352');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.fd.SGCDParallelProxy is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66352" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.fd.SGCDParallelProxy<br/>At SGCDParallelProxy.java:[lines 34-646]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66561');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GBProxy is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66561" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GBProxy<br/>At GBProxy.java:[lines 28-165]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66596');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GroebnerBaseDistributedEC is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66596" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GroebnerBaseDistributedEC<br/>At GroebnerBaseDistributedEC.java:[lines 44-470]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66631');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GroebnerBaseDistributedHybridEC is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66631" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GroebnerBaseDistributedHybridEC<br/>At GroebnerBaseDistributedHybridEC.java:[lines 46-546]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66701');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GroebnerBaseParallel is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66701" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GroebnerBaseParallel<br/>At GroebnerBaseParallel.java:[lines 39-281]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66666');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GroebnerBaseParIter is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66666" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GroebnerBaseParIter<br/>At GroebnerBaseParIter.java:[lines 40-331]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66736');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GroebnerBaseSeqPairDistributed is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66736" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GroebnerBaseSeqPairDistributed<br/>At GroebnerBaseSeqPairDistributed.java:[lines 44-385]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66771');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.GroebnerBaseSeqPairParallel is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66771" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.GroebnerBaseSeqPairParallel<br/>At GroebnerBaseSeqPairParallel.java:[lines 36-267]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66806');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.SGBProxy is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66806" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.SGBProxy<br/>At SGBProxy.java:[lines 28-314]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66841');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.SolvableGroebnerBaseParallel is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66841" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.SolvableGroebnerBaseParallel<br/>At SolvableGroebnerBaseParallel.java:[lines 36-354]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66876');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gb.SolvableGroebnerBaseSeqPairParallel is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66876" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gb.SolvableGroebnerBaseSeqPairParallel<br/>At SolvableGroebnerBaseSeqPairParallel.java:[lines 39-346]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66911');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gbufd.GroebnerBasePseudoParallel is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66911" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gbufd.GroebnerBasePseudoParallel<br/>At GroebnerBasePseudoParallel.java:[lines 45-279]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66946');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.gbufd.GroebnerBasePseudoRecParallel is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66946" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.gbufd.GroebnerBasePseudoRecParallel<br/>At GroebnerBasePseudoRecParallel.java:[lines 46-350]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N67033');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.poly.GenPolynomial is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N67033" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.poly.GenPolynomial<br/>At GenPolynomial.java:[lines 47-2487]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N67753');">
<td>
<span class="priority-2">SnVI</span>
</td>
<td>edu.jas.ufd.GCDProxy is Serializable; consider declaring a serialVersionUID</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N67753" style="display: none;">
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a>
<br/>In class edu.jas.ufd.GCDProxy<br/>At GCDProxy.java:[lines 30-583]</p>
</td>
</tr>
</table>
<h2>
<a name="Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a>
</h2>
<table class="warningtable" width="100%" cellspacing="0">
<tr class="tableheader">
<th align="left">Code</th>
<th align="left">Warning</th>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66981');">
<td>
<span class="priority-2">MS</span>
</td>
<td>edu.jas.kern.ComputerThreads.NO_THREADS isn't final and can't be protected from malicious code </td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66981" style="display: none;">
<a href="#MS_CANNOT_BE_FINAL">Bug type MS_CANNOT_BE_FINAL (click for details)</a>
<br/>In class edu.jas.kern.ComputerThreads<br/>Field edu.jas.kern.ComputerThreads.NO_THREADS<br/>At ComputerThreads.java:[line 42]</p>
</td>
</tr>
</table>
<h2>
<a name="Warnings_STYLE">Dodgy code Warnings</a>
</h2>
<table class="warningtable" width="100%" cellspacing="0">
<tr class="tableheader">
<th align="left">Code</th>
<th align="left">Warning</th>
</tr>
<tr class="tablerow1" onclick="toggleRow('N65777');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial)</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N65777" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.application.SolvableLocalResidueRing<br/>In method edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalResidueRing.java:[line 123]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N65864');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial, GenPolynomial)</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N65864" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.application.SolvableLocalResidueRing<br/>In method edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalResidueRing.java:[line 132]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N65951');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalRing.create(GenPolynomial)</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N65951" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.application.SolvableLocalRing<br/>In method edu.jas.application.SolvableLocalRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalRing.java:[line 121]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66038');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalRing.create(GenPolynomial, GenPolynomial)</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66038" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.application.SolvableLocalRing<br/>In method edu.jas.application.SolvableLocalRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalRing.java:[line 130]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66125');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableResidueRing.create(GenPolynomial)</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66125" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.application.SolvableResidueRing<br/>In method edu.jas.application.SolvableResidueRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableResidueRing.java:[line 124]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66212');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableResidueRing.create(GenPolynomial, GenPolynomial)</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66212" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.application.SolvableResidueRing<br/>In method edu.jas.application.SolvableResidueRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableResidueRing.java:[line 136]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66387');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.fd.SolvableQuotientRing.create(GenPolynomial)</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66387" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.fd.SolvableQuotientRing<br/>In method edu.jas.fd.SolvableQuotientRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableQuotientRing.java:[line 81]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N66474');">
<td>
<span class="priority-2">BC</span>
</td>
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.fd.SolvableQuotientRing.create(GenPolynomial, GenPolynomial)</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N66474" style="display: none;">
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a>
<br/>In class edu.jas.fd.SolvableQuotientRing<br/>In method edu.jas.fd.SolvableQuotientRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableQuotientRing.java:[line 90]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N67271');">
<td>
<span class="priority-2">BC</span>
</td>
<td>instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.evalAsRightRecursivePolynomial(), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N67271" style="display: none;">
<a href="#BC_VACUOUS_INSTANCEOF">Bug type BC_VACUOUS_INSTANCEOF (click for details)</a>
<br/>In class edu.jas.poly.RecSolvablePolynomial<br/>In method edu.jas.poly.RecSolvablePolynomial.evalAsRightRecursivePolynomial()<br/>Actual type edu.jas.poly.RecSolvablePolynomial<br/>Expected edu.jas.poly.RecSolvablePolynomial<br/>At RecSolvablePolynomial.java:[line 764]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N67351');">
<td>
<span class="priority-2">BC</span>
</td>
<td>instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.isRightRecursivePolynomial(GenSolvablePolynomial), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N67351" style="display: none;">
<a href="#BC_VACUOUS_INSTANCEOF">Bug type BC_VACUOUS_INSTANCEOF (click for details)</a>
<br/>In class edu.jas.poly.RecSolvablePolynomial<br/>In method edu.jas.poly.RecSolvablePolynomial.isRightRecursivePolynomial(GenSolvablePolynomial)<br/>Actual type edu.jas.poly.RecSolvablePolynomial<br/>Expected edu.jas.poly.RecSolvablePolynomial<br/>At RecSolvablePolynomial.java:[line 806]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N67431');">
<td>
<span class="priority-2">BC</span>
</td>
<td>instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.rightRecursivePolynomial(), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N67431" style="display: none;">
<a href="#BC_VACUOUS_INSTANCEOF">Bug type BC_VACUOUS_INSTANCEOF (click for details)</a>
<br/>In class edu.jas.poly.RecSolvablePolynomial<br/>In method edu.jas.poly.RecSolvablePolynomial.rightRecursivePolynomial()<br/>Actual type edu.jas.poly.RecSolvablePolynomial<br/>Expected edu.jas.poly.RecSolvablePolynomial<br/>At RecSolvablePolynomial.java:[line 723]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N65648');">
<td>
<span class="priority-2">DB</span>
</td>
<td>edu.jas.application.RingFactoryTokenizer.nextCoefficientRing() uses the same code for two branches</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N65648" style="display: none;">
<a href="#DB_DUPLICATE_BRANCHES">Bug type DB_DUPLICATE_BRANCHES (click for details)</a>
<br/>In class edu.jas.application.RingFactoryTokenizer<br/>In method edu.jas.application.RingFactoryTokenizer.nextCoefficientRing()<br/>At RingFactoryTokenizer.java:[line 471]<br/>At RingFactoryTokenizer.java:[line 473]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N67068');">
<td>
<span class="priority-2">DB</span>
</td>
<td>edu.jas.poly.GenPolynomialTokenizer.nextCoefficientRing() uses the same code for two branches</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N67068" style="display: none;">
<a href="#DB_DUPLICATE_BRANCHES">Bug type DB_DUPLICATE_BRANCHES (click for details)</a>
<br/>In class edu.jas.poly.GenPolynomialTokenizer<br/>In method edu.jas.poly.GenPolynomialTokenizer.nextCoefficientRing()<br/>At GenPolynomialTokenizer.java:[line 826]<br/>At GenPolynomialTokenizer.java:[line 828]</p>
</td>
</tr>
<tr class="tablerow0" onclick="toggleRow('N67131');">
<td>
<span class="priority-2">SF</span>
</td>
<td>Switch statement found in edu.jas.poly.GenPolynomialTokenizer.nextPolynomial() where one case falls through to the next case</td>
</tr>
<tr class="detailrow0">
<td/>
<td>
<p id="N67131" style="display: none;">
<a href="#SF_SWITCH_FALLTHROUGH">Bug type SF_SWITCH_FALLTHROUGH (click for details)</a>
<br/>In class edu.jas.poly.GenPolynomialTokenizer<br/>In method edu.jas.poly.GenPolynomialTokenizer.nextPolynomial()<br/>At GenPolynomialTokenizer.java:[lines 329-332]</p>
</td>
</tr>
<tr class="tablerow1" onclick="toggleRow('N66299');">
<td>
<span class="priority-2">UCF</span>
</td>
<td>Useless control flow in edu.jas.fd.GCDLeftRightTest.testBaseQR()</td>
</tr>
<tr class="detailrow1">
<td/>
<td>
<p id="N66299" style="display: none;">
<a href="#UCF_USELESS_CONTROL_FLOW">Bug type UCF_USELESS_CONTROL_FLOW (click for details)</a>
<br/>In class edu.jas.fd.GCDLeftRightTest<br/>In method edu.jas.fd.GCDLeftRightTest.testBaseQR()<br/>At GCDLeftRightTest.java:[line 591]</p>
</td>
</tr>
</table>
<h1>
<a name="Details">Details</a>
</h1>
<h2>
<a name="BC_VACUOUS_INSTANCEOF">BC_VACUOUS_INSTANCEOF: instanceof will always return true</a>
</h2>
<p>
This instanceof test will always return true (unless the value being tested is null).
Although this is safe, make sure it isn't
an indication of some misunderstanding or some other logic error.
If you really want to test the value for being null, perhaps it would be clearer to do
better to do a null test rather than an instanceof test.
</p>
<h2>
<a name="BC_UNCONFIRMED_CAST">BC_UNCONFIRMED_CAST: Unchecked/unconfirmed cast</a>
</h2>
<p>
This cast is unchecked, and not all instances of the type casted from can be cast to
the type it is being cast to. Check that your program logic ensures that this
cast will not fail.
</p>
<h2>
<a name="DB_DUPLICATE_BRANCHES">DB_DUPLICATE_BRANCHES: Method uses the same code for two branches</a>
</h2>
<p>
This method uses the same code to implement two branches of a conditional branch.
Check to ensure that this isn't a coding mistake.
</p>
<h2>
<a name="MS_CANNOT_BE_FINAL">MS_CANNOT_BE_FINAL: Field isn't final and can't be protected from malicious code</a>
</h2>
<p>
A mutable static field could be changed by malicious code or
by accident from another package.
Unfortunately, the way the field is used doesn't allow
any easy fix to this problem.</p>
<h2>
<a name="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">NM_SAME_SIMPLE_NAME_AS_SUPERCLASS: Class names shouldn't shadow simple name of superclass</a>
</h2>
<p> This class has a simple name that is identical to that of its superclass, except
that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
This can be exceptionally confusing, create lots of situations in which you have to look at import statements
to resolve references and creates many
opportunities to accidentally define methods that do not override methods in their superclasses.
</p>
<h2>
<a name="NM_METHOD_NAMING_CONVENTION">NM_METHOD_NAMING_CONVENTION: Method names should start with a lower case letter</a>
</h2>
<p>
Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized.
</p>
<h2>
<a name="OS_OPEN_STREAM">OS_OPEN_STREAM: Method may fail to close stream</a>
</h2>
<p> The method creates an IO stream object, does not assign it to any
fields, pass it to other methods that might close it,
or return it, and does not appear to close
the stream on all paths out of the method. This may result in
a file descriptor leak. It is generally a good
idea to use a <code>finally</code> block to ensure that streams are
closed.</p>
<h2>
<a name="RV_NEGATING_RESULT_OF_COMPARETO">RV_NEGATING_RESULT_OF_COMPARETO: Negating the result of compareTo()/compare()</a>
</h2>
<p> This code negatives the return value of a compareTo or compare method.
This is a questionable or bad programming practice, since if the return
value is Integer.MIN_VALUE, negating the return value won't
negate the sign of the result. You can achieve the same intended result
by reversing the order of the operands rather than by negating the results.
</p>
<h2>
<a name="SF_SWITCH_FALLTHROUGH">SF_SWITCH_FALLTHROUGH: Switch statement found where one case falls through to the next case</a>
</h2>
<p> This method contains a switch statement where one case branch will fall through to the next case.
Usually you need to end this case with a break or return.</p>
<h2>
<a name="SE_NO_SERIALVERSIONID">SE_NO_SERIALVERSIONID: Class is Serializable, but doesn't define serialVersionUID</a>
</h2>
<p> This class implements the <code>Serializable</code> interface, but does
not define a <code>serialVersionUID</code> field.
A change as simple as adding a reference to a .class object
will add synthetic fields to the class,
which will unfortunately change the implicit
serialVersionUID (e.g., adding a reference to <code>String.class</code>
will generate a static field <code>class$java$lang$String</code>).
Also, different source code to bytecode compilers may use different
naming conventions for synthetic variables generated for
references to class objects or inner classes.
To ensure interoperability of Serializable across versions,
consider adding an explicit serialVersionUID.</p>
<h2>
<a name="UCF_USELESS_CONTROL_FLOW">UCF_USELESS_CONTROL_FLOW: Useless control flow</a>
</h2>
<p> This method contains a useless control flow statement, where
control flow continues onto the same place regardless of whether or not
the branch is taken. For example,
this is caused by having an empty statement
block for an <code>if</code> statement:</p>
<pre>
if (argv.length == 0) {
// TODO: handle this case
}
</pre>
</body>
</html>
|
