File: fix_code_style.sh

package info (click to toggle)
kalkun 0.8.3.2-1
  • links: PTS, VCS
  • area: main
  • in suites: trixie
  • size: 7,340 kB
  • sloc: php: 30,659; javascript: 30,443; sql: 961; sh: 766; xml: 105; makefile: 40
file content (410 lines) | stat: -rwxr-xr-x 15,574 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
#!/bin/bash

set -e

# Usage:
#   ./fix_code_style.sh git-co
#
#         Run & commit each php-cs-fix/phpcbf config individually
#
#   ./fix_code_style.sh git-diff
#
#         Run the fix and save diff to file. This won't commit anything.
#         The branch has to be clean before proceeding and changes will be restored.
#
#   ./fix_code_style.sh strict
#
#         Only show the changes that should be done to have strict_comparison
#         operator everywhere.
#
#   ./fix_code_style.sh
#
#         Apply the fixes to the project (changes won't be commited)
#
#
#
#   /!\ THIS MUST BE RUN FROM THE ROOT DIR OF THE PROJECT
#
#

VENDOR_DIR="utils/vendor"

if [[ "$1" == "git-co" ]]; then
  DO_GIT_COMMIT=1
  DO_GIT_DIFF=0
elif [[ "$1" == "git-diff" ]]; then
  if [[ $(git diff --stat) != '' ]]; then
    echo "git is dirty. Stopping."
    exit
  fi
  DO_GIT_COMMIT=0
  DO_GIT_DIFF=1
elif [[ "$1" == "strict" ]]; then
  STRICT_COMPARISON=1
  DO_GIT_COMMIT=0
  DO_GIT_DIFF=0
else
  DO_GIT_COMMIT=0
  DO_GIT_DIFF=0
fi

CS_FIXER_CONF_DIR=utils/php-cs-fixer-configs
CS_RULESSET_DIR=utils/phpcs-rules
TMPDIR=$(mktemp -d)

if [[ -v GITHUB_ACTIONS ]]; then
    DIFF_OUTPUT_DIR="."
else
    DIFF_OUTPUT_DIR="$TMPDIR"
fi

# Check if we have to run php-cs-fixer with PHP_CS_FIXER_IGNORE_ENV=1
set +e
${VENDOR_DIR}/bin/php-cs-fixer
EXIT_CODE=$?
set -e
if [ $EXIT_CODE = 1 ]; then
    export PHP_CS_FIXER_IGNORE_ENV=1
fi

############### Check for strict STRICT_COMPARISON operator #########

if [[ "$STRICT_COMPARISON" == "1" ]]; then
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --allow-risky=yes --dry-run --diff --config "$CS_FIXER_CONF_DIR/php-cs-fixer-5-strict_comparison.php" > "$DIFF_OUTPUT_DIR/code_style_check-strict_comparison.diff"
    EXIT_CODE=$?
    if [ $EXIT_CODE -eq 8 ] || [ $EXIT_CODE -eq 4 ]; then
        # 4 - Some files have invalid syntax (only in dry-run mode).
        # 8 - Some files need fixing (only in dry-run mode).
        if [[ -v GITHUB_ACTIONS ]]; then
            head -n200 "$DIFF_OUTPUT_DIR/code_style_check-strict_comparison.diff"
        fi
        echo
        echo "_____________________"
        echo " CODE NEEDS FIXING ! "
        echo "‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾"
        echo "Some code doesn't use strict_comparison operators."
        echo "Please double-check and apply the required changes."
        echo
        echo "Full diff file is '$DIFF_OUTPUT_DIR/code_style_check-strict_comparison.diff'"
        if [[ -v GITHUB_ACTIONS ]]; then
            echo "The first 200 lines of the diff are shown above."
            echo "You can find the full diff in the artifacts."
        fi
    else
        echo
        echo "_______________________________________________________"
        echo " Code uses strict comparison operators where expected. "
        echo "‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾"
        rm "$DIFF_OUTPUT_DIR/code_style_check-strict_comparison.diff"
    fi
    echo "php-cs-fixer exited with exit-code: $EXIT_CODE"
    exit $EXIT_CODE
fi


############### Beautify HTML/JS/CSS of *.php in views #########
# This requires js-beautify/html-beautify
# On debian, package is 'node-js-beautify'
# This in voluntarily placed before PHP check

if command -v html-beautify >/dev/null ; then
    echo "Beautifying HTML/JS/CSS style..."
    while IFS= read -r -d '' file; do
        html-beautify \
            --replace \
            --indent-with-tabs \
            --templating=php \
            --end-with-newline=true \
            --brace-style=collapse \
            --newline-between-rules=false \
            --space-around-combinator=true \
            --space-around-selector-separator=true \
            --indent-scripts=normal \
            "$file"
    done <  <(find application/views/js_init application/views/main -name "*.php" -print0 && \
                find media/css -maxdepth 1 -name "*.css" -print0 )

    PLUGIN_VIEWS=$(find application/plugins -type d -name views)
    while IFS= read -r -d '' file; do
        html-beautify \
            --replace \
            --indent-with-tabs \
            --templating=php \
            --end-with-newline=true \
            --brace-style=collapse \
            --newline-between-rules=false \
            --space-around-combinator=true \
            --space-around-selector-separator=true \
            --indent-scripts=normal \
            "$file"
    done <  <(find $PLUGIN_VIEWS -name "*.php" -print0)
fi
if [ $DO_GIT_COMMIT -eq 1 ]; then
    git add application
    if ! git diff --cached --exit-code > /dev/null; then
        git commit -m "[AUTO: html-beautify] Beautify HTML/JS/CSS in views"
    fi
fi


# Configure phpcs (add CodeIgniter standard to phpcs)
${VENDOR_DIR}/bin/phpcs --config-set installed_paths ${VENDOR_DIR}/ise/php-codingstandards-codeigniter/CodeIgniter

############ Various change to harmonize code  #########

# Remove old useless CI1/CI2 end of document comments
grep -lr "/\* Location" application/ | while IFS= read -r file; do
    sed -i "/\* Location/d" "$file"
done
grep -lr "/\* End of file" application/ | while IFS= read -r file; do
    sed -i "/\* End of file/d" "$file"
done
if [ $DO_GIT_COMMIT -eq 1 ]; then
    git add application
    if ! git diff --cached --exit-code > /dev/null; then
        git commit -m "[AUTO] Remove trailing CI1-CI2 comments

These are useless in CI3 and coding style doesn't mention them anymore
(as opposed to CI2 user guide in which they were mentionned)."
    fi
fi

# Add missing index.html files in each directory
# https://codeigniter.com/userguide3/general/security.html?highlight=index%20html#hide-your-files
# CodeIgniter will have an index.html file in all of its directories in an attempt
# to hide some of this data, but have it in mind that this is not enough to prevent a serious attacker.
#find application/ -type d -exec cp -a ${VENDOR_DIR}/codeigniter/framework/application/index.html '{}' \;
find application/ -type d '!' -exec test -e "{}/index.html" ';' -exec cp -a ${VENDOR_DIR}/codeigniter/framework/application/index.html '{}' \;
find media/ -type d '!' -exec test -e "{}/index.html" ';' -exec cp -a ${VENDOR_DIR}/codeigniter/framework/application/index.html '{}' \;
if [ $DO_GIT_COMMIT -eq 1 ]; then
    git add "application/**index.html"
    git add "media/**index.html"
    if ! git diff --cached --exit-code > /dev/null; then
        git commit -m "[AUTO] Add missing protective index.html"
    fi
fi

# Replace old formatted php header to keep '<?php' opening tag alone on first line
OLD_CI_HEADER=$(find application/ -name "*.php" -exec head -n1 '{}' \; | grep BASEPATH | grep "^<?php" | sort -u)
if [[ "$OLD_CI_HEADER" != "" ]] ; then
    while IFS= read -r -d '' file; do
        while IFS= read -r line; do
            sed -i "s,$line,<?php\ndefined('BASEPATH') OR exit('No direct script access allowed');," "$file"
        done <<< "$OLD_CI_HEADER"
    done <   <(find application -name "*.php" -print0)
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add "application/"
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO] Replace old formatted php header to keep opening tag alone on first line

This also makes the header in line with the CI3 standards."
        fi
    fi
fi
unset OLD_CI_HEADER

############# PHP CS Fixer (with a little bit of PHP_CodeSniffer) #############

if [ $DO_GIT_DIFF -eq 0 ]; then

    # Correct spaces, end of line, tabs, indentation...
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-0-spaces.php"

    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] spaces...

encoding
indentation_type
line_ending
no_trailing_whitespace
no_whitespace_in_blank_line
single_blank_line_at_eof
no_trailing_whitespace_in_comment
array_indentation
no_whitespace_before_comma_in_array
whitespace_after_comma_in_array
trim_array_spaces
no_spaces_around_offset"
        fi
    fi

     # linebreak_after_opening_tag
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-9-linebreak_after_opening_tag.php"
     # no_closing_tag
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-8-no_closing_tag.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] no_closing_tag, linebreak_after_opening_tag"
        fi
    fi

    # single_quote
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-1-single_quote.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] single_quote"
        fi
    fi

    # method_argument_space
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-6-method_argument_space.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] method_argument_space

'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline']"
        fi
    fi

    # explicit_string_variable
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-7-explicit_string_variable.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] explicit_string_variable"
        fi
    fi

    # operator spacing (except some config files)
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-11-operator.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] operator & parenthesis spacing

'not_operator_with_space' => true,
'no_spaces_inside_parenthesis' => true,
    We use 'no_spaces_inside_parenthesis' with not_operator_with_space
    to be sure notation remains correct for CI3 style guidelines

'object_operator_without_whitespace' => true,
'operator_linebreak' => [ 'only_booleans' => true ],
'standardize_not_equals' => true,
'ternary_operator_spaces' => true,
'unary_operator_spaces' => true,
'binary_operator_spaces' => true,"
        fi
    fi

    # constant_case  TRUE, FALSE
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-3-constant_case.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] constant_case

'constant_case' => [ 'case' => 'upper'], //TRUE, FALSE..."
        fi
    fi

    # single_line_comment_style
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-10-single_line_comment_style.php"
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        git commit -m "[AUTO: PHP-CS-Fixer] single_line_comment_style"
    fi

    # no_alternative_syntax (EXCEPT views)
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-12-no_alternative_syntax.php"
    # braces & control_structure_continuation_position & no_alternative_syntax
    ${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots --config "$CS_FIXER_CONF_DIR/php-cs-fixer-4-braces.php"
    # Run phpcs immediately with sniffs=Generic.Classes.OpeningBraceSameLine to fix
    # php-cs-fixer not inline with what we want
    ${VENDOR_DIR}/bin/phpcbf -p --standard="$CS_RULESSET_DIR/ruleset.xml" --sniffs=Generic.Classes.OpeningBraceSameLine || true
    if [ $DO_GIT_COMMIT -eq 1 ]; then
        git add application
        if ! git diff --cached --exit-code > /dev/null; then
            git commit -m "[AUTO: PHP-CS-Fixer] braces, no_alt_syntax and related...

PHP-CS-Fixer:
'braces' => [ 'position_after_control_structures' => 'next'],
'control_structure_continuation_position' => [ 'position' => 'next_line'],
'no_alternative_syntax' => true,

PHP Code Sniffer:
Restore opening braces on same line as Class definition"
        fi
    fi

fi


# Rerun php-cs-fixer with all fixes + the fix on classes opening braces
${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots
${VENDOR_DIR}/bin/phpcbf -p --standard="$CS_RULESSET_DIR/ruleset.xml" --sniffs=Generic.Classes.OpeningBraceSameLine || true
if [ $DO_GIT_COMMIT -eq 1 ]; then
    git add application
    if ! git diff --cached --exit-code > /dev/null; then
        git commit -m "[AUTO: PHP-CS-Fixer] EMPTY?"
    fi
fi


# Process also the scripts directory
${VENDOR_DIR}/bin/php-cs-fixer fix -v --show-progress=dots scripts
${VENDOR_DIR}/bin/phpcbf -p --standard="$CS_RULESSET_DIR/ruleset.xml" --sniffs=Generic.Classes.OpeningBraceSameLine scripts || true
if [ $DO_GIT_COMMIT -eq 1 ]; then
    git add scripts
    if ! git diff --cached --exit-code > /dev/null; then
        git commit -m "[AUTO: PHP-CS-Fixer] scripts directory"
    fi
fi


############# PHP_CodeSniffer #############
# First we check the errors
${VENDOR_DIR}/bin/phpcs -p -s --standard="$CS_RULESSET_DIR/ruleset.xml" 2>&1 | tee "$TMPDIR/phpcs.log"
# Then we fix them
${VENDOR_DIR}/bin/phpcbf -p --standard="$CS_RULESSET_DIR/ruleset.xml" 2>&1 | tee "$TMPDIR/phpcbf.log"
if [ $DO_GIT_COMMIT -eq 1 ]; then
    git add application
    if ! git diff --cached --exit-code > /dev/null; then
        git commit -m "[AUTO: CodeSniffer] Fixes to fit to to CI3 coding style"
    fi
fi

if [[ $DO_GIT_DIFF -eq 1 ]]; then
    git diff --exit-code > "$DIFF_OUTPUT_DIR/code_style_check.diff"
    DIFF_EXIT_CODE=$?
    git checkout .
    if [[ $DIFF_EXIT_CODE -ne 0 ]]; then
        if [[ -v GITHUB_ACTIONS ]]; then
            head -n200 "$DIFF_OUTPUT_DIR/code_style_check.diff"
        fi
        echo
        echo "_____________________"
        echo " CODE NEEDS FIXING ! "
        echo "‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾"
        echo "The code doesn't respect the coding guidelines."
        echo "Please double-check and apply the required changes."
        echo
        echo "Full diff file is '$DIFF_OUTPUT_DIR/code_style_check.diff'"
        if [[ -v GITHUB_ACTIONS ]]; then
            echo "The first 200 lines of the diff are shown above."
            echo "You can find the full diff in the artifacts."
        fi
        EXIT_STATUS=1
    else
        echo
        echo "___________________________"
        echo " Code Respects Guidelines. "
        echo "‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾"
        rm "$DIFF_OUTPUT_DIR/code_style_check.diff"
    fi
fi

# Check the views for any errors
# Disabled for now
#${VENDOR_DIR}/bin/phpcs -p -s --standard="$CS_RULESSET_DIR/ruleset-views.xml" 2>&1 | tee "$TMPDIR/phpcs-views.log"
#grep "| ERROR" phpcs-views.log | cut -d '|' -f 3- | sort | uniq -c
#grep "| WARNING" phpcs-views.log | cut -d '|' -f 3- | sort | uniq -c
#

if [ -v EXIT_STATUS ]; then
    exit $EXIT_STATUS
fi