1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580
|
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
/// @file
/// @brief Here lives the tests that only apply to QtQuick
#define NOMINMAX
#include "kddockwidgets/KDDockWidgets.h"
#include "qtquick/Platform.h"
#include "qtquick/views/TitleBar.h"
#include "qtquick/views/DockWidget.h"
#include "qtquick/views/MainWindow.h"
#include "qtquick/views/FloatingWindow.h"
#include "core/MDILayout.h"
#include "core/views/MainWindowViewInterface.h"
#include "core/MainWindow.h"
#include "core/Window_p.h"
#include "core/Platform.h"
#include "../utils.h"
#ifdef KDDW_HAS_SPDLOG
#include "../fatal_logger.h"
#endif
#include <QtTest/QTest>
#include <QQmlApplicationEngine>
#include <QQmlContext>
using namespace KDDockWidgets;
using namespace KDDockWidgets::Tests;
using namespace KDDockWidgets::Core;
class TestQtQuick : public QObject
{
Q_OBJECT
public Q_SLOTS:
void initTestCase();
void cleanupTestCase();
private Q_SLOTS:
void tst_restoreRestoresMainWindowPosition();
void tst_hoverShowsDropIndicators();
void tst_titlebarNumDockWidgetsChanged();
void tst_effectiveVisibilityBug();
/// Tests a situation where DockWidgetInstantiator::isFloatingChanged wasn't being emitted (#350)
void tst_isFloatingIsEmitted();
void tst_shutdownCrash();
void tst_childQmlContext();
void tst_focusBetweenTabs();
void tst_setPersistentCentralView();
void tst_mdiFixedSize();
void tst_affinities();
void tst_deleteDockWidget();
void tst_setViewFactory();
void tst_quickWindowCreationCallback();
};
void TestQtQuick::initTestCase()
{
KDDockWidgets::Core::Platform::instance()->installMessageHandler();
}
void TestQtQuick::cleanupTestCase()
{
KDDockWidgets::Core::Platform::instance()->uninstallMessageHandler();
}
void TestQtQuick::tst_restoreRestoresMainWindowPosition()
{
// Tests the ApplicationWindow {} case
QQmlApplicationEngine engine(":/main2.qml");
const auto mainWindows = DockRegistry::self()->mainwindows();
QCOMPARE(mainWindows.size(), 1);
MainWindow *mainWindow = mainWindows.first();
QVERIFY(mainWindow->isVisible());
QCOMPARE(mainWindow->pos(), QPoint(0, 0));
Window::Ptr window = mainWindow->view()->window();
LayoutSaver saver;
const QByteArray saved = saver.serializeLayout();
const QPoint originalPos = window->framePosition();
const QPoint newPos = originalPos + QPoint(200, 200);
window->setFramePosition(newPos);
QCOMPARE(window->framePosition(), newPos);
QVERIFY(saver.restoreLayout(saved));
QCOMPARE(window->framePosition(), originalPos);
delete mainWindow;
}
void TestQtQuick::tst_hoverShowsDropIndicators()
{
// For QtQuick on Windows, there was a bug where drop indicators wouldn't be shown if
// MainWindowBase wasn't the root item.
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main2.qml");
const auto mainWindows = DockRegistry::self()->mainwindows();
QCOMPARE(mainWindows.size(), 1);
MainWindow *m = mainWindows.first();
m->window()->window()->setFramePosition(QPoint(500, 800));
auto dock0 = createDockWidget(
"dock0", Platform::instance()->tests_createView({ true, {}, QSize(400, 400) }));
auto floatingDockWidget =
createDockWidget("floatingDockWidget",
Platform::instance()->tests_createView({ true, {}, QSize(400, 400) }));
m->addDockWidget(dock0, Location_OnLeft);
const QPoint mainWindowCenterPos = m->mapToGlobal(m->geometry().center());
QTest::qWait(100);
auto fw = floatingDockWidget->floatingWindow();
dragFloatingWindowTo(fw, mainWindowCenterPos);
QCOMPARE(dock0->dptr()->group()->dockWidgetCount(), 2);
}
void TestQtQuick::tst_titlebarNumDockWidgetsChanged()
{
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main2.qml");
auto dock0 = createDockWidget(
"dock0", Platform::instance()->tests_createView({ true, {}, QSize(400, 400) }));
const auto mainWindows = DockRegistry::self()->mainwindows();
MainWindow *m = mainWindows.first();
m->window()->window()->setFramePosition(QPoint(500, 800));
m->addDockWidget(dock0, Location_OnLeft);
auto tb = dock0->titleBar();
auto tbView = static_cast<QtQuick::TitleBar *>(tb->view());
int numSignalEmittions = 0;
connect(tbView, &QtQuick::TitleBar::numDockWidgetsChanged,
[&numSignalEmittions] { numSignalEmittions++; });
auto dock1 = createDockWidget(
"dock1", Platform::instance()->tests_createView({ true, {}, QSize(400, 400) }));
dock0->addDockWidgetAsTab(dock1);
QVERIFY(numSignalEmittions > 0);
}
void TestQtQuick::tst_isFloatingIsEmitted()
{
{
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main350.qml");
auto dw4 = DockRegistry::self()->dockByName("dock4");
auto dw5 = DockRegistry::self()->dockByName("dock5");
QVERIFY(dw4);
QVERIFY(dw5);
dw4->setFloating(true);
dw5->addDockWidgetToContainingWindow(dw4, KDDockWidgets::Location_OnLeft);
dw4->titleBar()->onFloatClicked();
QVERIFY(dw4->isFloating());
auto mw = DockRegistry::self()->mainWindowByName("MyWindowName-1");
QVERIFY(mw);
auto floatingDropArea = dw4->floatingWindow()->multiSplitter();
QVERIFY(floatingDropArea);
// Add to main window again and make sure signal was emitted
bool signalReceived = false;
dw4->d->isFloatingChanged.connect([&signalReceived] {
signalReceived = true;
});
QVERIFY(dw4->isFloating());
QVERIFY(dw4->floatAction()->isChecked());
mw->dropArea()->addMultiSplitter(floatingDropArea, KDDockWidgets::Location_OnLeft);
QVERIFY(!dw4->isFloating());
QVERIFY(!dw4->floatAction()->isChecked());
QVERIFY(signalReceived);
}
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
QTest::qWait(1);
}
void TestQtQuick::tst_shutdownCrash()
{
// Currently failing only on Windows.
// Tests a crash where Core::DockWidget would be referenced while being destroyed
// EnsureTopLevelsDeleted e;
// QQmlApplicationEngine engine(":/main2.qml");
// auto guestView = Platform::instance()->tests_createView({ true, {}, QSize(400, 400) });
// auto dock1 = createDockWidget("dock1", guestView);
// QQuickItem *dockWidgeItem = QtCommon::View_qt::asQQuickItem(dock1->view());
// QVERIFY(dockWidgeItem);
// Core::Group *group = dock1->dptr()->group();
// delete dockWidgeItem;
// delete group;
// // 1 event loop for DelayedDelete. Avoids LSAN warnings.
// Platform::instance()->tests_wait(1);
}
void TestQtQuick::tst_childQmlContext()
{
// Tests that guest items can have a separate QML context
EnsureTopLevelsDeleted e;
{
QQmlApplicationEngine engine(":/main2.qml");
auto dock1 = new QtQuick::DockWidget("dock1");
auto dock2 = new QtQuick::DockWidget("dock2");
auto dock3 = new QtQuick::DockWidget("dock3");
auto dock4 = new QtQuick::DockWidget("dock4");
const auto defaultPropertyValue = QVariant(0);
const auto overriddenPropertyValue = QVariant(1);
QQmlContext *rootContext = plat()->qmlEngine()->rootContext();
rootContext->setContextProperty("_ctxProperty", defaultPropertyValue);
auto mw = DockRegistry::self()->mainWindowByName("MyWindowName-1");
QVERIFY(mw);
mw->addDockWidget(dock1->asDockWidgetController(), KDDockWidgets::Location_OnRight);
mw->addDockWidget(dock2->asDockWidgetController(), KDDockWidgets::Location_OnRight);
mw->addDockWidget(dock3->asDockWidgetController(), KDDockWidgets::Location_OnRight);
mw->addDockWidget(dock4->asDockWidgetController(), KDDockWidgets::Location_OnRight);
auto guestItem1 = new QQuickItem(dock1);
dock1->setGuestItem(guestItem1);
dock2->setGuestItem(":/MyRectangle.qml");
dock3->setGuestItem(":/MyRectangle.qml");
QQmlContext subContext(rootContext);
subContext.setContextProperty("_ctxProperty", overriddenPropertyValue);
dock4->setGuestItem(":/MyRectangle.qml", &subContext);
QVERIFY(dock2->dockWidget()->guestView().get());
auto guestItem2 = dock2->guestItem();
QVERIFY(guestItem2);
auto guestItem3 = dock3->guestItem();
QVERIFY(guestItem3);
auto guestItem4 = dock4->guestItem();
QVERIFY(guestItem4);
QQmlContext *guestContext1 = QtQuick::qmlContextFor(guestItem1);
QQmlContext *guestContext2 = QtQuick::qmlContextFor(guestItem2);
QQmlContext *guestContext3 = QtQuick::qmlContextFor(guestItem3);
QQmlContext *guestContext4 = QtQuick::qmlContextFor(guestItem4);
QVERIFY(guestContext1);
QVERIFY(guestContext2);
QVERIFY(guestContext3);
QVERIFY(guestContext4);
QVERIFY(guestContext1 != guestContext2);
QVERIFY(guestContext1 != guestContext3);
QVERIFY(guestContext2 != guestContext3);
QCOMPARE(guestContext4->parentContext(), &subContext);
QVERIFY(rootContext != guestContext1);
QVERIFY(rootContext != guestContext2);
QVERIFY(guestContext1->parentContext() == rootContext);
QVERIFY(guestContext2->parentContext() == rootContext);
QVERIFY(guestContext3->parentContext() == rootContext);
QCOMPARE(guestItem3->property("someValue"), defaultPropertyValue);
QCOMPARE(guestItem4->property("someValue"), overriddenPropertyValue);
delete dock1->dockWidget()->dptr()->group();
delete dock2->dockWidget()->dptr()->group();
delete dock3->dockWidget()->dptr()->group();
delete dock4->dockWidget()->dptr()->group();
}
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
QTest::qWait(1);
}
void TestQtQuick::tst_focusBetweenTabs()
{
EnsureTopLevelsDeleted e;
KDDockWidgets::Config::self().setFlags(KDDockWidgets::Config::Flag_TitleBarIsFocusable);
QQmlApplicationEngine engine;
engine.rootContext()->setContextProperty("_kddwDockRegistry", DockRegistry::self());
engine.load(":/main_tst_focusBetweenTabs.qml");
auto dock1 = DockRegistry::self()->dockByName("dock1");
auto dock2 = DockRegistry::self()->dockByName("dock2");
auto dock3 = DockRegistry::self()->dockByName("dock3");
auto floatingDock = DockRegistry::self()->dockByName("floatingDock");
dock1->view()->rootView()->activateWindow();
QTest::qWait(2000);
dock1->dptr()->group()->focus();
QVERIFY(dock1->isFocused());
QVERIFY(!dock2->isFocused());
QVERIFY(!dock3->isFocused());
QVERIFY(!floatingDock->isFocused());
auto view1 = QtCommon::View_qt::asQQuickItem(dock1->view());
auto view2 = QtCommon::View_qt::asQQuickItem(dock2->view());
auto view3 = QtCommon::View_qt::asQQuickItem(dock3->view());
auto floatingDockView = QtCommon::View_qt::asQQuickItem(floatingDock->view());
// Refocus these, as they were unfocused due to reparenting:
auto field1 = view1->findChild<QQuickItem *>("field1");
auto field2 = view2->findChild<QQuickItem *>("field2");
auto field3 = view3->findChild<QQuickItem *>("field3");
auto floatingDockField = floatingDockView->findChild<QQuickItem *>("floatingDockField");
field2->setFocus(true);
field3->setFocus(true);
floatingDockField->setFocus(true);
QVERIFY(dock1->isFocused());
QVERIFY(!dock2->isFocused());
QVERIFY(!dock3->isFocused());
// All 4 have focus, but only #1 has active focus
QVERIFY(field1->hasActiveFocus());
QVERIFY(!field2->hasActiveFocus());
QVERIFY(!field3->hasActiveFocus());
QVERIFY(!floatingDockField->hasActiveFocus());
QVERIFY(field1->hasFocus());
QVERIFY(field2->hasFocus());
QVERIFY(field3->hasFocus());
QVERIFY(floatingDockField->hasFocus());
dock2->dptr()->group()->focus();
// Dock3, the current tab, has focus now
QVERIFY(!field1->hasActiveFocus());
QVERIFY(!field2->hasActiveFocus());
QVERIFY(field3->hasActiveFocus());
QVERIFY(field1->hasFocus());
QVERIFY(field2->hasFocus());
QVERIFY(field3->hasFocus());
// A mouse event instead of these 2 lines would do as well
dock2->setAsCurrentTab();
dock2->dptr()->group()->focus();
QVERIFY(field1->hasFocus());
QVERIFY(field2->hasFocus());
QVERIFY(field3->hasFocus());
QVERIFY(!field1->hasActiveFocus());
QVERIFY(field2->hasActiveFocus());
QVERIFY(!field3->hasActiveFocus());
// Now test if clicking on the dock1 titlebar also forwards focus
auto tb = dock1->titleBar()->view();
Tests::clickOn(tb->mapToGlobal({ 10, 10 }), tb);
QVERIFY(field1->hasFocus());
QVERIFY(field2->hasFocus());
QVERIFY(field3->hasFocus());
QVERIFY(field1->hasActiveFocus());
QVERIFY(!field2->hasActiveFocus());
QVERIFY(!field3->hasActiveFocus());
// Now test titlebar of a floating window
floatingDock->view()->rootView()->activateWindow();
QVERIFY(Platform::instance()->tests_waitForWindowActive(floatingDock->view()->window(), 1000));
auto floatingTb = floatingDock->titleBar()->view();
Tests::clickOn(floatingTb->mapToGlobal({ 10, 10 }), floatingTb);
Platform::instance()->tests_wait(1000);
QVERIFY(field1->hasFocus());
QVERIFY(field2->hasFocus());
QVERIFY(field3->hasFocus());
QVERIFY(floatingDockField->hasFocus());
QVERIFY(floatingDockField->hasActiveFocus());
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
Platform::instance()
->tests_wait(1);
}
void TestQtQuick::tst_setPersistentCentralView()
{
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main_persistentCentralWidget.qml");
const auto mainWindows = DockRegistry::self()->mainwindows();
QCOMPARE(mainWindows.size(), 1);
auto mainWindow = mainWindows.first();
static_cast<QtQuick::MainWindow *>(mainWindow->view())->setPersistentCentralView(":/MyRectangle2.qml");
Core::Layout *layout = mainWindow->layout();
auto rootItem = layout->rootItem();
QCOMPARE(rootItem->count_recursive(), 1);
QCOMPARE(mainWindow->size(), rootItem->size());
}
void TestQtQuick::tst_mdiFixedSize()
{
// Tests that the mdi group is fixed size if the dock widget is fixed size
EnsureTopLevelsDeleted e;
auto m = createMainWindow(Size(800, 500), MainWindowOption_MDI);
const int fixedWidth = 201;
auto dock0 = createDockWidget(
"dock0", Platform::instance()->tests_createView({ true, {}, Size(fixedWidth, 400) }));
dock0->view()->setFixedWidth(fixedWidth);
m->layout()->asMDILayout()->addDockWidget(dock0, Point(0, 0), {});
m->view()->resize(1000, 1000);
QCOMPARE(dock0->view()->minimumWidth(), fixedWidth);
QCOMPARE(dock0->view()->maxSizeHint().width(), fixedWidth);
QVERIFY(dock0->isFixedWidth());
Group *group = dock0->dptr()->group();
QVERIFY(group->isMDI());
QVERIFY(group->isFixedWidth());
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
Platform::instance()
->tests_wait(1);
}
void TestQtQuick::tst_affinities()
{
// Tests that the QML API for affinites works
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main465.qml");
const auto dockingAreas = DockRegistry::self()->mainDockingAreas();
QCOMPARE(dockingAreas.size(), 1);
auto dockingArea = dockingAreas.first();
QCOMPARE(dockingArea->affinities(), QVector<QString>({ "affinity_one", "affinity_two" }));
auto dock1 = DockRegistry::self()->dockByName("dock1");
auto dock2 = DockRegistry::self()->dockByName("dock2");
QVERIFY(dock1);
QVERIFY(dock2);
QCOMPARE(dock1->affinities(), QVector<QString>({ "affinity_one", "affinity_two" }));
QVERIFY(dock2->affinities().isEmpty());
}
void TestQtQuick::tst_deleteDockWidget()
{
// Tests that we can delete a dock widget directly
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main465.qml"); // or any other main.qml
auto dock0 = createDockWidget(
"dock0", Platform::instance()->tests_createView({}));
dock0->show();
delete dock0->view();
// 1 event loop iteration so we don't have memory leaks
QTest::qWait(1);
}
void TestQtQuick::tst_effectiveVisibilityBug()
{
// When saving layout state, we should not store QQuickItem::isVisible(), as that is not the real
// "isVisible", as it might depend on the parent being visible or not.
// The correct property to store is QQuickItemPrivate::explicitVisible, and not
// QQuickItemPrivate::effectiveVisible;
//
// See issue #343
QByteArray serialized;
{
EnsureTopLevelsDeleted e;
// This main .qml has the DropArea wrapped into an Item with visible: false
QQmlApplicationEngine engine(":/main343.qml");
LayoutSaver saver;
serialized = saver.serializeLayout();
QVERIFY(!serialized.isEmpty());
}
EnsureTopLevelsDeleted e;
// This main .qml has the DropArea wrapped into an Item with visible: true
// restoring should restore the DropArea with visible true
QQmlApplicationEngine engine(":/main343_2.qml");
LayoutSaver restorer;
QVERIFY(restorer.restoreLayout(serialized));
const auto mainWindows = DockRegistry::self()->mainwindows();
QCOMPARE(mainWindows.size(), 1);
QVERIFY(mainWindows.first()->isVisible());
}
void TestQtQuick::tst_setViewFactory()
{
// Tests that setting a view factory will refresh the context property
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main2.qml");
QQmlContext *rootContext = plat()->qmlEngine()->rootContext();
QCOMPARE(rootContext->contextProperty("_kddw_widgetFactory").value<QObject *>(), Config::self().viewFactory());
// now change view factory:
auto newFactory = Platform::instance()->createDefaultViewFactory();
Config::self().setViewFactory(newFactory);
QCOMPARE(rootContext->contextProperty("_kddw_widgetFactory").value<QObject *>(), newFactory);
}
void TestQtQuick::tst_quickWindowCreationCallback()
{
EnsureTopLevelsDeleted e;
QQmlApplicationEngine engine(":/main2.qml");
int callCount = 0;
auto onWindowCreated = [&](QQuickView *window, QtQuick::MainWindow *parent) -> void {
Q_UNUSED(window);
Q_UNUSED(parent);
callCount++;
};
QtQuick::FloatingWindow::setQuickWindowCreationCallback(onWindowCreated);
auto dock0 = createDockWidget(
"dock0", Platform::instance()->tests_createView({ true, {}, QSize(400, 400) }));
dock0->setFloating(true);
QCOMPARE(callCount, 1);
QtQuick::FloatingWindow::setQuickWindowCreationCallback(nullptr);
}
int main(int argc, char *argv[])
{
#ifdef KDDW_HAS_SPDLOG
FatalLogger::create();
#endif
// Might be disabled by env var
const auto frontends = Platform::frontendTypes();
if (std::find(frontends.cbegin(), frontends.cend(), FrontendType::QtQuick) == frontends.cend())
return 0;
Core::Platform::tests_initPlatform(argc, argv, KDDockWidgets::FrontendType::QtQuick);
TestQtQuick test;
const int exitCode = QTest::qExec(&test, argc, argv);
Core::Platform::tests_deinitPlatform();
return exitCode;
}
#include "tst_qtquick.moc"
|