1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
|
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "utils.h"
#include "Config.h"
#include "core/Position_p.h"
#include "core/WindowBeingDragged_p.h"
#include "core/LayoutSaver_p.h"
#include "core/layouting/Item_p.h"
#include "core/ViewFactory.h"
#include "core/MDILayout.h"
#include "core/DropArea.h"
#include "core/MainWindow.h"
#include "core/DockWidget.h"
#include "core/Separator.h"
#include "core/TabBar.h"
#include "core/Stack.h"
#include "core/SideBar.h"
#include "core/Platform.h"
#include <QTest>
using namespace KDDockWidgets;
using namespace KDDockWidgets::Core;
using namespace KDDockWidgets::Tests;
class TestDocks : public QObject
{
Q_OBJECT
private Q_SLOTS:
void tst_invalidLayoutAfterRestore();
void tst_setFloatingWhenSideBySide();
void tst_dockWindowWithTwoSideBySideFramesIntoCenter();
void tst_dockWindowWithTwoSideBySideFramesIntoRight();
void tst_dockWindowWithTwoSideBySideFramesIntoLeft();
void tst_keepLast();
};
void TestDocks::tst_invalidLayoutAfterRestore()
{
EnsureTopLevelsDeleted e;
auto m = createMainWindow();
auto dock1 = createDockWidget("dock1", Platform::instance()->tests_createView({ true }));
auto dock2 = createDockWidget("dock2", Platform::instance()->tests_createView({ true }));
auto dock3 = createDockWidget("dock3", Platform::instance()->tests_createView({ true }));
auto dropArea = m->dropArea();
Core::DropArea *layout = dropArea;
// Stack 1, 2, 3
m->addDockWidget(dock1, Location_OnLeft);
m->addDockWidget(dock2, Location_OnRight);
m->addDockWidget(dock3, Location_OnRight);
WAIT_FOR_RESIZE(layout);
const int oldContentsWidth = layout->layoutWidth();
auto f1 = dock1->dptr()->group();
dock3->close();
dock2->close();
dock1->close();
QVERIFY(Platform::instance()->tests_waitForDeleted(f1));
dock3->open();
QVERIFY(dock3->titleBar()->isVisible());
dock2->open();
dock1->open();
WAIT_FOR_EVENT(m.get(), Event::LayoutRequest); // So MainWindow min
// size is updated
Item *item1 = layout->itemForGroup(dock1->dptr()->group());
Item *item3 = layout->itemForGroup(dock3->dptr()->group());
Item *item4 = dropArea->centralFrame();
QVERIFY(item1);
QVERIFY(item3);
QVERIFY(item4);
QCOMPARE(layout->count(), 4);
QCOMPARE(layout->placeholderCount(), 0);
// Detach dock2
ObjectGuard<Core::Group> f2 = dock2->dptr()->group();
f2->detachTab(dock2);
QVERIFY(!f2.data());
QTest::qWait(200);
auto fw2 = dock2->floatingWindow();
QCOMPARE(layout->view()->minSize().width(),
2 * Item::layoutSpacing + item1->minSize().width() + item3->minSize().width()
+ item4->minSize().width());
// Drop left of dock3
layout->addWidget(fw2->dropArea()->view(), Location_OnLeft, dock3->dptr()->group()->layoutItem());
QVERIFY(Platform::instance()->tests_waitForDeleted(fw2));
QCOMPARE(layout->layoutWidth(), oldContentsWidth);
layout->checkSanity();
}
void TestDocks::tst_setFloatingWhenSideBySide()
{
// Tests DockWidget::setFloating(false|true) when side-by-side (it should put it where it was)
EnsureTopLevelsDeleted e;
{
// 1. Create a MainWindow with two docked dock-widgets, then float the first one.
auto m = createMainWindow();
auto dock1 = createDockWidget("dock1", Platform::instance()->tests_createView({ true }));
auto dock2 = createDockWidget("dock2", Platform::instance()->tests_createView({ true }));
m->addDockWidget(dock1, KDDockWidgets::Location_OnLeft);
m->addDockWidget(dock2, KDDockWidgets::Location_OnRight);
ObjectGuard<Core::Group> group1 = dock1->dptr()->group();
dock1->setFloating(true);
QVERIFY(dock1->isFloating());
auto fw = dock1->floatingWindow();
QVERIFY(fw);
// 2. Put it back, via setFloating(). It should return to its place.
dock1->setFloating(false);
QVERIFY(!dock1->isFloating());
QVERIFY(!dock1->isTabbed());
}
{
// 2. Tests a case where restoring a dock widget wouldn't make it use all its available
// space
auto m = createMainWindow(Size(800, 500), MainWindowOption_None);
auto dock1 = createDockWidget("dock1", Platform::instance()->tests_createView({ true }));
auto dock2 = createDockWidget("dock2", Platform::instance()->tests_createView({ true }));
auto dock3 = createDockWidget("dock3", Platform::instance()->tests_createView({ true }));
auto dropArea = m->dropArea();
Core::DropArea *layout = dropArea;
m->addDockWidget(dock1, KDDockWidgets::Location_OnLeft);
m->addDockWidget(dock2, KDDockWidgets::Location_OnRight);
m->addDockWidget(dock3, KDDockWidgets::Location_OnRight);
auto f2 = dock2->dptr()->group();
Item *item2 = layout->itemForGroup(f2);
QVERIFY(item2);
dock2->close();
dock3->close();
WAIT_FOR_DELETED(f2);
dock2->open();
WAIT_FOR_RESIZE(dock2->view());
QCOMPARE(item2->geometry(), dock2->dptr()->group()->view()->geometry());
layout->checkSanity();
}
}
void TestDocks::tst_dockWindowWithTwoSideBySideFramesIntoCenter()
{
EnsureTopLevelsDeleted e;
KDDockWidgets::Config::self().setInternalFlags(KDDockWidgets::Config::InternalFlag_NoAeroSnap);
KDDockWidgets::Config::self().setFlags({});
auto m = createMainWindow();
auto fw = createFloatingWindow();
auto dock2 = createDockWidget("doc2");
nestDockWidget(dock2, fw->dropArea(), nullptr, KDDockWidgets::Location_OnLeft);
QCOMPARE(fw->groups().size(), 2);
QVERIFY(fw->dropArea()->checkSanity());
auto fw2 = createFloatingWindow();
fw2->view()->move(fw->x() + fw->width() + 100, fw->y());
// QtQuick is a bit more async than QWidgets. Wait for the move.
WAIT_FOR_EVENT(fw2->view()->window(), Event::Move);
auto da2 = fw2->dropArea();
const Point dragDestPos = da2->mapToGlobal(da2->rect().center());
dragFloatingWindowTo(fw, dragDestPos);
QVERIFY(fw2->dropArea()->checkSanity());
QCOMPARE(fw2->groups().size(), 1);
auto f2 = fw2->groups().constFirst();
// run one event loop, needed by flutter
QTest::qWait(1);
QCOMPARE(f2->dockWidgetCount(), 3);
}
void TestDocks::tst_dockWindowWithTwoSideBySideFramesIntoRight()
{
EnsureTopLevelsDeleted e;
auto fw = createFloatingWindow();
fw->view()->move(50, 50);
auto dock2 = createDockWidget("doc2");
nestDockWidget(dock2, fw->dropArea(), nullptr,
KDDockWidgets::Location_OnTop); // No we stack on top, unlike in previous test
QCOMPARE(fw->groups().size(), 2);
auto fw2 = createFloatingWindow();
fw2->view()->move(fw->x() + fw->width() + 100, fw->y());
QTest::qWait(1000);
dragFloatingWindowTo(fw, fw2->dropArea(), DropLocation_Right); // Outer right instead of Left
// run one event loop, needed by flutter
QTest::qWait(1000);
QCOMPARE(fw2->groups().size(), 3);
QVERIFY(fw2->dropArea()->checkSanity());
}
void TestDocks::tst_dockWindowWithTwoSideBySideFramesIntoLeft()
{
EnsureTopLevelsDeleted e;
auto fw = createFloatingWindow();
QTest::qWait(1000);
fw->view()->move(200, 200);
fw->setObjectName("fw1");
auto dock2 = createDockWidget("doc2");
nestDockWidget(dock2, fw->dropArea(), nullptr, KDDockWidgets::Location_OnLeft);
QCOMPARE(fw->groups().size(), 2);
auto fw2 = createFloatingWindow();
fw2->setObjectName("fw2");
fw2->view()->move(fw->x() + fw->width() + 100, fw->y());
QVERIFY(fw2->dropArea()->checkSanity());
QTest::qWait(1000);
dragFloatingWindowTo(fw, fw2->dropArea(), DropLocation_Left);
// run one event loop, needed by flutter
QTest::qWait(1000);
QCOMPARE(fw2->groups().size(), 3);
QVERIFY(fw2->dropArea()->checkSanity());
}
void TestDocks::tst_keepLast()
{
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
QTest::qWait(1);
}
#define KDDW_TEST_NAME TestDocks
#include "test_main_qt.h"
#include "tst_docks_slow2.moc"
|
