1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322
|
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "utils.h"
#include "Config.h"
#include "core/LayoutSaver_p.h"
#include "core/Position_p.h"
#include "core/WindowBeingDragged_p.h"
#include "core/layouting/Item_p.h"
#include "core/ViewFactory.h"
#include "core/Action.h"
#include "core/DropArea.h"
#include "core/MainWindow.h"
#include "core/DockWidget.h"
#include "core/DockWidget_p.h"
#include "core/Separator.h"
#include "core/TabBar.h"
#include "core/Stack.h"
#include "core/SideBar.h"
#include "core/Platform.h"
#include <QTest>
using namespace KDDockWidgets;
using namespace KDDockWidgets::Core;
using namespace KDDockWidgets::Tests;
class TestDocks : public QObject
{
Q_OBJECT
private Q_SLOTS:
void tst_dockWidgetGetsFocusWhenDocked();
void tst_closeShowWhenNoCentralFrame();
void tst_close();
void tst_positionWhenShown();
void tst_keepLast();
};
void TestDocks::tst_dockWidgetGetsFocusWhenDocked()
{
EnsureTopLevelsDeleted e;
KDDockWidgets::Config::self().setFlags(KDDockWidgets::Config::Flag_TitleBarIsFocusable);
// We drag dw2 onto dw2 and drop it
auto dw1 = Config::self()
.viewFactory()
->createDockWidget("1")
->asDockWidgetController();
auto dw2 = Config::self()
.viewFactory()
->createDockWidget("2")
->asDockWidgetController();
auto le1 = Platform::instance()->tests_createFocusableView({ true });
auto le2 = Platform::instance()->tests_createFocusableView({ true });
dw1->setGuestView(le1->asWrapper());
dw2->setGuestView(le2->asWrapper());
dw1->open();
dw2->open();
QTest::qWait(200);
auto fw1 = dw1->floatingWindow();
ObjectGuard<Core::FloatingWindow> fw2 = dw2->floatingWindow();
// Focus dock widget 1 first
QVERIFY(!dw1->isFocused());
dw1->window()->activateWindow();
dw2->window()->move(100, 100);
KDBindings::ScopedConnection con = dw1->d->isFocusedChanged.connect([dw1](bool focused) {
QVERIFY(focused == dw1->isFocused());
});
le1->setFocus(Qt::MouseFocusReason);
QTest::qWait(200);
QVERIFY(dw1->isFocused());
QVERIFY(fw1->view()->isActiveWindow());
dragFloatingWindowTo(fw2, fw1->dropArea(), DropLocation_Left);
WAIT_FOR_EVENT(fw1, Event::WindowActivate);
/// We dropped into floating window 1, it should still be active
QVERIFY(fw1->view()->isActiveWindow());
// DockWidget 2 was dropped, it should now be focused
QVERIFY(!dw1->isFocused());
QVERIFY(dw2->isFocused());
delete fw1;
delete fw2;
}
void TestDocks::tst_closeShowWhenNoCentralFrame()
{
EnsureTopLevelsDeleted e;
// Tests a crash I got when hiding and showing and no central group
auto m = createMainWindow(Size(800, 500), MainWindowOption_None); // Remove central group
ObjectGuard<Core::DockWidget> dock1 =
createDockWidget("1", Platform::instance()->tests_createView({ true }));
m->addDockWidget(dock1, Location_OnLeft);
dock1->close();
m->layout()->checkSanity();
QVERIFY(!dock1->dptr()->group());
QVERIFY(!Platform::instance()->tests_waitForDeleted(dock1)); // It was being deleted due to a
// bug
QVERIFY(dock1);
dock1->open();
m->layout()->checkSanity();
}
void TestDocks::tst_close()
{
EnsureTopLevelsDeleted e;
// 1.0 Call QWidget::close() on QDockWidget
auto dock1 = createDockWidget("doc1");
auto toggleAction = dock1->toggleAction();
QVERIFY(toggleAction->isChecked());
QVERIFY(dock1->isFloating());
QVERIFY(dock1->isVisible());
QVERIFY(dock1->floatingWindow());
QVERIFY(dock1->close());
QVERIFY(!dock1->isVisible());
QVERIFY(!dock1->window()->controller()->isVisible());
QVERIFY(dock1->window()->equals(dock1->view()));
QVERIFY(!toggleAction->isChecked());
// 1.1 Reshow with show()
dock1->open();
auto fw = dock1->floatingWindow();
QVERIFY(fw);
QVERIFY(fw->isVisible());
QVERIFY(toggleAction->isChecked());
QVERIFY(!dock1->view()->isExplicitlyHidden());
QVERIFY(!dock1->view()->isExplicitlyHidden());
QVERIFY(dock1->isVisible());
QVERIFY(dock1->window()->equals(fw->view()));
QVERIFY(toggleAction->isChecked());
// 1.2 Reshow with toggleAction instead
QVERIFY(dock1->close());
QVERIFY(!toggleAction->isChecked());
QVERIFY(!dock1->isVisible());
toggleAction->setChecked(true);
QVERIFY(dock1->isVisible());
// 1.3 Use hide() instead
auto fw1 = dock1->floatingWindow();
QVERIFY(fw1);
dock1->close();
QVERIFY(Platform::instance()->tests_waitForDeleted(fw1));
QVERIFY(!dock1->isVisible());
QVERIFY(!dock1->window()->controller()->isVisible());
QVERIFY(dock1->window()->equals(dock1->view()));
QVERIFY(!toggleAction->isChecked());
// 1.4 close a FloatingWindow, via DockWidget::close
ObjectGuard<Core::FloatingWindow> window = dock1->dptr()->morphIntoFloatingWindow();
ObjectGuard<Core::Group> group1 = dock1->dptr()->group();
QVERIFY(dock1->isVisible());
QVERIFY(dock1->window()->controller()->isVisible());
QVERIFY(group1->isVisible());
QVERIFY(dock1->window()->equals(window->view()));
QVERIFY(dock1->close());
QVERIFY(!dock1->dptr()->group());
QVERIFY(Platform::instance()->tests_waitForDeleted(group1));
QVERIFY(Platform::instance()->tests_waitForDeleted(window));
// 1.5 close a FloatingWindow, via FloatingWindow::close
dock1->open();
window = dock1->dptr()->morphIntoFloatingWindow();
group1 = dock1->dptr()->group();
QVERIFY(dock1->isVisible());
QVERIFY(dock1->window()->controller()->isVisible());
QVERIFY(group1->isVisible());
QVERIFY(dock1->window()->equals(window->view()));
QVERIFY(window->view()->close());
QVERIFY(!dock1->dptr()->group());
QVERIFY(Platform::instance()->tests_waitForDeleted(group1));
QVERIFY(Platform::instance()->tests_waitForDeleted(window));
// 1.6 Check if space is reclaimed after closing left dock
Core::DockWidget *centralDock = nullptr;
Core::DockWidget *leftDock = nullptr;
Core::DockWidget *rightDock = nullptr;
auto mainwindow = createSimpleNestedMainWindow(¢ralDock, &leftDock, &rightDock);
auto da = mainwindow->dropArea();
QVERIFY(da->checkSanity());
QCOMPARE(leftDock->dptr()->group()->view()->x(), 0);
QCOMPARE(centralDock->dptr()->group()->view()->x(),
leftDock->dptr()->group()->view()->geometry().right() + Item::layoutSpacing + 1);
QCOMPARE(rightDock->dptr()->group()->view()->x(),
centralDock->dptr()->group()->view()->geometry().right() + Item::layoutSpacing
+ 1);
leftDock->close();
QTest::qWait(250);
QCOMPARE(centralDock->dptr()->group()->view()->x(), 0);
QCOMPARE(rightDock->dptr()->group()->view()->x(),
centralDock->dptr()->group()->view()->geometry().right() + Item::layoutSpacing
+ 1);
rightDock->close();
QTest::qWait(250);
Margins margins = mainwindow->centerWidgetMargins();
QCOMPARE(centralDock->dptr()->group()->view()->width(),
mainwindow->width() - 0 * 2 - margins.left() - margins.right());
delete leftDock;
delete rightDock;
delete centralDock;
// 1.9 Close tabbed dock, side docks will maintain their position
mainwindow = createSimpleNestedMainWindow(¢ralDock, &leftDock, &rightDock);
const int leftX = leftDock->dptr()->group()->view()->x();
const int rightX = rightDock->dptr()->group()->view()->x();
centralDock->close();
QCOMPARE(leftDock->dptr()->group()->view()->x(), leftX);
QCOMPARE(rightDock->dptr()->group()->view()->x(), rightX);
delete leftDock;
delete rightDock;
delete centralDock;
delete dock1;
// 2. Test that closing the single group of a main window doesn't close the main window itself
{
auto m = createMainWindow(Size(800, 500), MainWindowOption_None); // Remove central group
ObjectGuard<MainWindow> mainWindowPtr = m.get();
dock1 = createDockWidget("hello");
m->addDockWidget(dock1, Location_OnLeft);
// 2.2 Closing should not close the main window
dock1->close();
QVERIFY(mainWindowPtr.data());
delete dock1;
}
// 2.1 Test closing the group instead
{
auto m = createMainWindow(Size(800, 500), MainWindowOption_None); // Remove central group
ObjectGuard<MainWindow> mainWindowPtr = m.get();
dock1 = createDockWidget("hello");
m->addDockWidget(dock1, Location_OnLeft);
// 2.2 Closing should not close the main window
dock1->dptr()->group()->titleBar()->onCloseClicked();
QVERIFY(mainWindowPtr.data());
QVERIFY(mainWindowPtr->isVisible());
delete dock1;
}
// 2.2 Repeat, but with a central group
{
auto m = createMainWindow(Size(800, 500));
ObjectGuard<MainWindow> mainWindowPtr = m.get();
dock1 = createDockWidget("hello");
m->addDockWidget(dock1, Location_OnLeft);
// 2.2 Closing should not close the main window
dock1->dptr()->group()->titleBar()->onCloseClicked();
QVERIFY(mainWindowPtr.data());
QVERIFY(mainWindowPtr->isVisible());
delete dock1;
}
}
void TestDocks::tst_positionWhenShown()
{
// Tests that when showing a dockwidget it shows in the same position as before
EnsureTopLevelsDeleted e;
auto window = createMainWindow();
auto dock1 = newDockWidget("1");
dock1->open();
QTest::qWait(1000); // Wait for group to settle
const Point desiredPos = Point(100, 100);
dock1->view()->window()->setFramePosition(desiredPos);
QTest::qWait(1000); // Wait for group to settle
QCOMPARE(dock1->view()->window()->framePosition(), desiredPos);
dock1->close();
dock1->open();
QCOMPARE(dock1->view()->window()->framePosition(), desiredPos);
// Cleanup
window->layout()->checkSanity();
dock1->destroyLater();
QVERIFY(Platform::instance()->tests_waitForDeleted(dock1));
}
void TestDocks::tst_keepLast()
{
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
QTest::qWait(1);
}
#define KDDW_TEST_NAME TestDocks
#include "test_main_qt.h"
#include "tst_docks_slow3.moc"
|