1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
|
/*
This file is part of KDDockWidgets.
SPDX-FileCopyrightText: 2019 Klarälvdalens Datakonsult AB, a KDAB Group company <info@kdab.com>
Author: Sérgio Martins <sergio.martins@kdab.com>
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only
Contact KDAB at <info@kdab.com> for commercial licensing options.
*/
#include "utils.h"
#include "Config.h"
#include "core/LayoutSaver_p.h"
#include "core/Position_p.h"
#include "core/ObjectGuard_p.h"
#include "core/WindowBeingDragged_p.h"
#include "core/layouting/Item_p.h"
#include "core/ViewFactory.h"
#include "core/MDILayout.h"
#include "core/DropArea.h"
#include "core/MainWindow.h"
#include "core/DockWidget.h"
#include "core/DockWidget_p.h"
#include "core/Separator.h"
#include "core/TabBar.h"
#include "core/Stack.h"
#include "core/SideBar.h"
#include "core/Platform.h"
#include <QTest>
using namespace KDDockWidgets;
using namespace KDDockWidgets::Core;
using namespace KDDockWidgets::Tests;
class TestDocks : public QObject
{
Q_OBJECT
private Q_SLOTS:
void tst_dock2FloatingWidgetsTabbed();
void tst_restoreSimple();
void tst_restoreSimplest();
void tst_keepLast();
};
void TestDocks::tst_dock2FloatingWidgetsTabbed()
{
EnsureTopLevelsDeleted e;
if (KDDockWidgets::usesNativeTitleBar())
return; // Unit-tests can't drag via tab, yet
auto dock1 = createDockWidget("doc1");
auto fw1 = dock1->floatingWindow();
fw1->view()->setGeometry(Rect(500, 500, 400, 400));
QVERIFY(dock1);
ObjectGuard<Core::Group> group1 = dock1->dptr()->group();
auto titlebar1 = fw1->titleBar();
auto dock2 = createDockWidget("doc2");
QVERIFY(dock1->isFloating());
QVERIFY(dock2->isFloating());
Point finalPoint = dock2->window()->geometry().center() + Point(7, 7);
drag(titlebar1->view(), titlebar1->mapToGlobal(Point(5, 5)), finalPoint, ButtonAction_Press);
// It morphed into a FloatingWindow
ObjectGuard<Core::Group> group2 = dock2->dptr()->group();
if (!dock2->floatingWindow()) {
KDDW_WARN("dock2->floatingWindow()={}", ( void * )(dock2->floatingWindow()));
QVERIFY(false);
}
QVERIFY(group2);
QCOMPARE(group2->dockWidgetCount(), 1);
releaseOn(finalPoint, titlebar1->view());
QCOMPARE(group2->dockWidgetCount(), 2); // 2.2 Frame has 2 widgets when one is dropped
QVERIFY(Platform::instance()->tests_waitForDeleted(group1));
// 2.3 Detach tab1 to empty space
Point globalPressPos = dragPointForWidget(group2.data(), 0);
Core::TabBar *tabBar = group2->stack()->tabBar();
QVERIFY(tabBar);
drag(tabBar->view(), globalPressPos,
group2->view()->d->windowGeometry().bottomRight() + Point(10, 10));
QCOMPARE(group2->dockWidgetCount(), 1);
QVERIFY(dock1->floatingWindow());
// 2.4 Drag the first dock over the second
group1 = dock1->dptr()->group();
group2 = dock2->dptr()->group();
fw1 = dock1->floatingWindow();
globalPressPos = fw1->titleBar()->mapToGlobal(Point(100, 5));
finalPoint = dock2->window()->geometry().center() + Point(7, 7);
drag(fw1->titleBar()->view(), globalPressPos, finalPoint);
QCOMPARE(group2->dockWidgetCount(), 2);
// 2.5 Detach and drop to the same place, should tab again
globalPressPos = dragPointForWidget(group2.data(), 0);
tabBar = group2->stack()->tabBar();
finalPoint = dock2->window()->geometry().center() + Point(7, 7);
drag(tabBar->view(), globalPressPos, finalPoint);
QCOMPARE(group2->dockWidgetCount(), 2);
// 2.6 Drag the tabbed group over a 3rd floating window
auto dock3 = createDockWidget("doc3");
QTest::qWait(1000); // Test is flaky otherwise
auto fw2 = dock2->floatingWindow();
finalPoint = dock3->window()->geometry().center() + Point(7, 7);
drag(fw2->titleBar()->view(), group2->mapToGlobal(Point(10, 10)), finalPoint);
QVERIFY(Platform::instance()->tests_waitForDeleted(group1));
QVERIFY(Platform::instance()->tests_waitForDeleted(group2));
QVERIFY(dock3->dptr()->group());
QCOMPARE(dock3->dptr()->group()->dockWidgetCount(), 3);
auto fw3 = dock3->floatingWindow();
QVERIFY(fw3);
QVERIFY(fw3->dropArea()->checkSanity());
// 2.7 Drop the window into a MainWindow
{
auto m = createMainWindow();
m->show();
m->view()->setGeometry(Rect(500, 300, 300, 300));
QVERIFY(!dock3->isFloating());
auto fw3 = dock3->floatingWindow();
drag(fw3->titleBar()->view(), dock3->window()->mapToGlobal(Point(10, 10)),
m->geometry().center());
QVERIFY(!dock3->isFloating());
QVERIFY(dock3->window()->equals(m->view()));
QCOMPARE(dock3->dptr()->group()->dockWidgetCount(), 3);
QVERIFY(m->dropArea()->checkSanity());
delete dock1;
delete dock2;
delete dock3;
QVERIFY(Platform::instance()->tests_waitForDeleted(group2));
QVERIFY(Platform::instance()->tests_waitForDeleted(fw3));
}
}
void TestDocks::tst_restoreSimple()
{
EnsureTopLevelsDeleted e;
// Tests restoring a very simple layout, composed of just 1 docked widget
auto m = createMainWindow(Size(800, 500), MainWindowOption_None);
auto layout = m->multiSplitter();
auto dock1 = createDockWidget("one", Platform::instance()->tests_createFocusableView({ true }));
auto dock2 = createDockWidget("two", Platform::instance()->tests_createFocusableView({ true }));
auto dock3 =
createDockWidget("three", Platform::instance()->tests_createFocusableView({ true }));
m->addDockWidget(dock1, Location_OnTop);
// Dock2 floats at 150,150
const Point dock2FloatingPoint = Point(150, 150);
dock2->view()->window()->setFramePosition(dock2FloatingPoint);
QVERIFY(dock2->isVisible());
QTest::qWait(1000); // Wait for group to settle
const Point dock3FloatingPoint = Point(200, 200);
dock3->view()->window()->setFramePosition(dock3FloatingPoint);
dock3->close();
LayoutSaver saver;
QVERIFY(saver.saveToFile(QStringLiteral("layout_tst_restoreSimple.json")));
auto f1 = dock1->dptr()->group();
dock2->window()->move(Point(0, 0)); // Move *after* we saved.
dock3->window()->move(Point(0, 0)); // Move *after* we saved.
dock1->close();
dock2->close();
QVERIFY(!dock2->isVisible());
QCOMPARE(layout->count(), 1);
QVERIFY(Platform::instance()->tests_waitForDeleted(f1));
QCOMPARE(layout->placeholderCount(), 1);
QCOMPARE(DockRegistry::self()->floatingWindows().size(), 0);
QVERIFY(saver.restoreFromFile(QStringLiteral("layout_tst_restoreSimple.json")));
QVERIFY(layout->checkSanity());
QCOMPARE(layout->count(), 1);
QCOMPARE(layout->placeholderCount(), 0);
QVERIFY(dock1->isVisible());
QCOMPARE(saver.restoredDockWidgets().size(), 3);
// Test a crash I got:
dock1->setFloating(true);
QVERIFY(layout->checkSanity());
dock1->setFloating(false);
auto fw2 = dock2->floatingWindow();
QVERIFY(fw2);
QVERIFY(fw2->isVisible());
QVERIFY(fw2->view()->isRootView());
QCOMPARE(fw2->view()->window()->framePosition(), dock2FloatingPoint);
QVERIFY(fw2->view()->window()->transientParent());
QVERIFY(m->view()->window()->equals(fw2->view()->window()->transientParent()));
QVERIFY(dock2->isFloating());
QVERIFY(dock2->isVisible());
QVERIFY(!dock3->isVisible()); // Remains closed
QVERIFY(dock3->view()->parentView() == nullptr);
dock3->open();
dock3->dptr()->morphIntoFloatingWindow(); // as it would take 1 event loop. Do it now so we can
// compare already.
QTest::qWait(300);
QCOMPARE(dock3->view()->window()->framePosition(), dock3FloatingPoint);
}
void TestDocks::tst_restoreSimplest()
{
EnsureTopLevelsDeleted e;
// Tests restoring a very simple layout, composed of just 1 docked widget
auto m = createMainWindow(Size(800, 500), MainWindowOption_None);
auto layout = m->multiSplitter();
auto dock1 = createDockWidget("one", Platform::instance()->tests_createFocusableView({ true }));
m->addDockWidget(dock1, Location_OnTop);
LayoutSaver saver;
QVERIFY(saver.saveToFile(QStringLiteral("layout_tst_restoreSimplest.json")));
QTest::qWait(300);
QVERIFY(layout->checkSanity());
QVERIFY(saver.restoreFromFile(QStringLiteral("layout_tst_restoreSimplest.json")));
QVERIFY(layout->checkSanity());
}
void TestDocks::tst_keepLast()
{
// 1 event loop for DelayedDelete. Avoids LSAN warnings.
QTest::qWait(1);
}
#define KDDW_TEST_NAME TestDocks
#include "test_main_qt.h"
#include "tst_docks_slow4.moc"
|
