1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
|
/*
SPDX-FileCopyrightText: 2022 Eric Jiang
SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
*/
#include "test_utils.hpp"
// test specific headers
#include "scopes/colorscopes/colorconstants.h"
#include "scopes/colorscopes/vectorscopegenerator.h"
#include "scopes/colorscopes/waveformgenerator.h"
#include "scopes/colorscopes/rgbparadegenerator.h"
#include "scopes/colorscopes/histogramgenerator.h"
// test for a bug where pixels were assumed to be RGB which was not true on
// Windows, resulting in red and blue switched. BUG: 453149
// Multiple scopes are affected, including vectorscope and waveform
TEST_CASE("Colorscope RGB/BGR handling")
{
// create a fully red image
QImage inputImage(480, 320, QImage::Format_RGB32);
inputImage.fill(Qt::red);
QImage bgrInputImage = inputImage.convertToFormat(QImage::Format_BGR30);
QSize scopeSize{256, 256};
qreal scalingFactor = 1.0;
SECTION("Vectorscope handles both RGB and BGR")
{
VectorscopeGenerator vectorscope{};
QImage rgbScope = vectorscope.calculateVectorscope(scopeSize, scalingFactor, inputImage, 1, VectorscopeGenerator::PaintMode::PaintMode_Green2,
VectorscopeGenerator::ColorSpace::ColorSpace_YUV, false, 7);
QImage bgrScope = vectorscope.calculateVectorscope(scopeSize, scalingFactor, bgrInputImage, 1, VectorscopeGenerator::PaintMode::PaintMode_Green2,
VectorscopeGenerator::ColorSpace::ColorSpace_YUV, false, 7);
// both of these should be equivalent, since the vectorscope should
// handle different pixel formats
CHECK(rgbScope == bgrScope);
}
SECTION("Waveform handles both RGB and BGR")
{
WaveformGenerator waveform{};
QImage rgbScope =
waveform.calculateWaveform(scopeSize, scalingFactor, inputImage, WaveformGenerator::PaintMode::PaintMode_Yellow, false, ITURec::Rec_709, 3);
QImage bgrScope =
waveform.calculateWaveform(scopeSize, scalingFactor, bgrInputImage, WaveformGenerator::PaintMode::PaintMode_Yellow, false, ITURec::Rec_709, 3);
CHECK(rgbScope == bgrScope);
}
SECTION("RGB Parade handles both RGB and BGR")
{
RGBParadeGenerator rgb{};
QImage rgbScope = rgb.calculateRGBParade(scopeSize, scalingFactor, inputImage, RGBParadeGenerator::PaintMode::PaintMode_RGB, false, false, 3);
QImage bgrScope = rgb.calculateRGBParade(scopeSize, scalingFactor, bgrInputImage, RGBParadeGenerator::PaintMode::PaintMode_RGB, false, false, 3);
CHECK(rgbScope == bgrScope);
}
SECTION("Histogram handles both RGB and BGR")
{
const auto ALL_COMPONENTS = HistogramGenerator::Components::ComponentR |
HistogramGenerator::Components::ComponentG |
HistogramGenerator::Components::ComponentB;
HistogramGenerator hist{};
QImage rgbScope = hist.calculateHistogram(scopeSize, scalingFactor, inputImage, ALL_COMPONENTS, ITURec::Rec_709, false, false, 3);
QImage bgrScope = hist.calculateHistogram(scopeSize, scalingFactor, bgrInputImage, ALL_COMPONENTS, ITURec::Rec_709, false, false, 3);
CHECK(rgbScope == bgrScope);
}
}
|
