1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
|
/*
SPDX-FileCopyrightText: 2007 Dukju Ahn <dukjuahn@gmail.com>
SPDX-License-Identifier: GPL-2.0-or-later
*/
#include "svnjobbase.h"
#include <QStandardItemModel>
#include <KPasswordDialog>
#include <KLocalizedString>
#include <KMessageBox>
#include <ThreadWeaver/QObjectDecorator>
#include <interfaces/icore.h>
#include <interfaces/iplugincontroller.h>
#include <interfaces/iplugin.h>
#include <outputview/ioutputview.h>
#include "svninternaljobbase.h"
#include "svnssldialog.h"
SvnJobBase::SvnJobBase( KDevSvnPlugin* parent, KDevelop::OutputJob::OutputJobVerbosity verbosity )
: VcsJob( parent, verbosity ), m_part( parent ),
m_status( KDevelop::VcsJob::JobNotStarted )
{
setCapabilities( KJob::Killable );
setTitle( QStringLiteral("Subversion") );
}
SvnJobBase::~SvnJobBase()
{
}
void SvnJobBase::startInternalJob()
{
auto job = internalJob();
connect( job.data(), &SvnInternalJobBase::failed,
this, &SvnJobBase::internalJobFailed, Qt::QueuedConnection );
connect( job.data(), &SvnInternalJobBase::done,
this, &SvnJobBase::internalJobDone, Qt::QueuedConnection );
connect( job.data(), &SvnInternalJobBase::started,
this, &SvnJobBase::internalJobStarted, Qt::QueuedConnection );
// add as shared pointer
// the signals "done" & "failed" are emitted when the queue and the executor still
// have and use a reference to the job, in the execution thread.
// As the this parent job will be deleted in the main/other thread
// (due to deleteLater() being called on it in the KJob::exec())
// and the ThreadWeaver queue will release the last reference to the passed
// JobInterface pointer only after the JobInterface::execute() method has been left,
// the internal threaded job thus needs to get shared memory management via the QSharedPointer.
m_part->jobQueue()->stream() << job;
}
bool SvnJobBase::doKill()
{
internalJob()->kill();
m_status = VcsJob::JobCanceled;
return true;
}
KDevelop::VcsJob::JobStatus SvnJobBase::status() const
{
return m_status;
}
void SvnJobBase::askForLogin( const QString& realm )
{
qCDebug(PLUGIN_SVN) << "login";
KPasswordDialog dlg( nullptr, KPasswordDialog::ShowUsernameLine | KPasswordDialog::ShowKeepPassword );
dlg.setPrompt( i18n("Enter Login for: %1", realm ) );
if (dlg.exec()) { // krazy:exclude=crashy
internalJob()->m_login_username = dlg.username();
internalJob()->m_login_password = dlg.password();
internalJob()->m_maySave = dlg.keepPassword();
} else {
internalJob()->m_login_username.clear();
internalJob()->m_login_password.clear();
}
internalJob()->m_guiSemaphore.release( 1 );
}
void SvnJobBase::showNotification( const QString& path, const QString& msg )
{
Q_UNUSED(path);
outputMessage(msg);
}
void SvnJobBase::askForCommitMessage()
{
qCDebug(PLUGIN_SVN) << "commit msg";
internalJob()->m_guiSemaphore.release( 1 );
}
void SvnJobBase::askForSslServerTrust( const QStringList& failures, const QString& host,
const QString& print, const QString& from,
const QString& until, const QString& issuer,
const QString& realm )
{
qCDebug(PLUGIN_SVN) << "servertrust";
SvnSSLTrustDialog dlg;
dlg.setCertInfos( host, print, from, until, issuer, realm, failures );
if( dlg.exec() == QDialog::Accepted )
{
qCDebug(PLUGIN_SVN) << "accepted with:" << dlg.useTemporarily();
if( dlg.useTemporarily() )
{
internalJob()->m_trustAnswer = svn::ContextListener::ACCEPT_TEMPORARILY;
}else
{
internalJob()->m_trustAnswer = svn::ContextListener::ACCEPT_PERMANENTLY;
}
}else
{
qCDebug(PLUGIN_SVN) << "didn't accept";
internalJob()->m_trustAnswer = svn::ContextListener::DONT_ACCEPT;
}
internalJob()->m_guiSemaphore.release( 1 );
}
void SvnJobBase::askForSslClientCert( const QString& realm )
{
KMessageBox::information( nullptr, realm );
qCDebug(PLUGIN_SVN) << "clientrust";
internalJob()->m_guiSemaphore.release( 1 );
}
void SvnJobBase::askForSslClientCertPassword( const QString& )
{
qCDebug(PLUGIN_SVN) << "clientpw";
internalJob()->m_guiSemaphore.release( 1 );
}
void SvnJobBase::internalJobStarted()
{
qCDebug(PLUGIN_SVN) << "job started" << static_cast<void*>(internalJob().data());
m_status = KDevelop::VcsJob::JobRunning;
}
void SvnJobBase::internalJobDone()
{
qCDebug(PLUGIN_SVN) << "job done" << internalJob();
if ( m_status == VcsJob::JobFailed ) {
// see: https://bugs.kde.org/show_bug.cgi?id=273759
// this gets also called when the internal job failed
// then the emit result in internalJobFailed might trigger
// a nested event loop (i.e. error dialog)
// during that the internalJobDone gets called and triggers
// deleteLater and eventually deletes this job
// => havoc
//
// catching this state here works but I don't like it personally...
return;
}
outputMessage(i18n("Completed"));
if( m_status != VcsJob::JobCanceled ) {
m_status = KDevelop::VcsJob::JobSucceeded;
}
emitResult();
}
void SvnJobBase::internalJobFailed()
{
qCDebug(PLUGIN_SVN) << "job failed" << internalJob();
setError( 255 );
QString msg = internalJob()->errorMessage();
if( !msg.isEmpty() )
setErrorText( i18n( "Error executing Job:\n%1", msg ) );
outputMessage(errorText());
qCDebug(PLUGIN_SVN) << "Job failed";
if( m_status != VcsJob::JobCanceled )
{
m_status = KDevelop::VcsJob::JobFailed;
}
emitResult();
}
KDevelop::IPlugin* SvnJobBase::vcsPlugin() const
{
return m_part;
}
void SvnJobBase::outputMessage(const QString& message)
{
if (!model()) return;
if (verbosity() == KDevelop::OutputJob::Silent) return;
auto *m = qobject_cast<QStandardItemModel*>(model());
QStandardItem *previous = m->item(m->rowCount()-1);
// TODO: 564123a06239a0fa68ef95e693d7f40c72039585 introduced the check below, originally as
// (message == "." && previous && previous->text().contains(QRegExp("\\.+"))), and explained it:
// > Be smart when showing the svn output. When it says "." on committing each file,
// > append it to the "." on the previous line (just like svn command does).
// The original regex condition actually checks whether a dot character is present in previous->text()
// and is equivalent to the current check previous->text().contains(dot). A possible original intention
// was to check whether previous->text() consists entirely of dots (anchored regex), which can be implemented
// more efficiently via std::all_of(), optionally combined with a string emptiness check. Or perhaps
// the intention was to check whether previous->text() ends with dots, i.e. previous->text().endsWith(dot).
// This code needs to be tested in action and the check probably should be fixed.
constexpr QLatin1Char dot{'.'};
if (message == dot && previous && previous->text().contains(dot))
previous->setText(previous->text() + message);
else
m->appendRow(new QStandardItem(message));
KDevelop::IPlugin* i = KDevelop::ICore::self()->pluginController()->pluginForExtension(QStringLiteral("org.kdevelop.IOutputView"));
if( i )
{
auto* view = i->extension<KDevelop::IOutputView>();
if( view )
{
view->raiseOutput( outputId() );
}
}
}
#include "moc_svnjobbase.cpp"
|
