1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791
|
/* This file is part of KDevelop
Copyright 2012 Olivier de Gaalon <olivier.jg@gmail.com>
2014 David Stevens <dgedstevens@gmail.com>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License version 2 as published by the Free Software Foundation.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
#include "test_assistants.h"
#include "codegen/clangrefactoring.h"
#include <QtTest/QtTest>
#include <QTemporaryDir>
#include <ktexteditor/view.h>
#include <ktexteditor/document.h>
#include <tests/autotestshell.h>
#include <tests/testcore.h>
#include <tests/testfile.h>
#include <util/foregroundlock.h>
#include <interfaces/idocumentcontroller.h>
#include <interfaces/ilanguagecontroller.h>
#include <interfaces/iplugincontroller.h>
#include <interfaces/isourceformattercontroller.h>
#include <language/assistant/staticassistant.h>
#include <language/assistant/staticassistantsmanager.h>
#include <language/assistant/renameaction.h>
#include <language/assistant/renameassistant.h>
#include <language/backgroundparser/backgroundparser.h>
#include <language/duchain/duchain.h>
#include <language/duchain/duchainlock.h>
#include <language/duchain/duchainutils.h>
#include <language/codegen/coderepresentation.h>
#include <shell/documentcontroller.h>
#include <clang-c/Index.h>
using namespace KDevelop;
using namespace KTextEditor;
QTEST_MAIN(TestAssistants)
ForegroundLock *globalTestLock = 0;
StaticAssistantsManager *staticAssistantsManager() { return Core::self()->languageController()->staticAssistantsManager(); }
void TestAssistants::initTestCase()
{
QLoggingCategory::setFilterRules(QStringLiteral(
"*.debug=false\n"
"default.debug=true\n"
"kdevelop.plugins.clang.debug=true\n"
));
QVERIFY(qputenv("KDEV_DISABLE_PLUGINS", "kdevcppsupport"));
QVERIFY(qputenv("KDEV_CLANG_DISPLAY_DIAGS", "1"));
AutoTestShell::init({QStringLiteral("kdevclangsupport"), QStringLiteral("kdevproblemreporter")});
TestCore::initialize();
DUChain::self()->disablePersistentStorage();
Core::self()->languageController()->backgroundParser()->setDelay(0);
Core::self()->sourceFormatterController()->disableSourceFormatting(true);
CodeRepresentation::setDiskChangesForbidden(true);
globalTestLock = new ForegroundLock;
}
void TestAssistants::cleanupTestCase()
{
Core::self()->cleanup();
delete globalTestLock;
globalTestLock = 0;
}
static QUrl createFile(const QString& fileContents, QString extension, int id)
{
static QTemporaryDir tempDirA;
Q_ASSERT(tempDirA.isValid());
static QDir dirA(tempDirA.path());
QFile file(dirA.filePath(QString::number(id) + extension));
file.open(QIODevice::WriteOnly | QIODevice::Text);
file.write(fileContents.toUtf8());
file.close();
return QUrl::fromLocalFile(file.fileName());
}
class Testbed
{
public:
enum TestDoc
{
HeaderDoc,
CppDoc
};
enum IncludeBehavior
{
NoAutoInclude,
AutoInclude,
};
Testbed(const QString& headerContents, const QString& cppContents, IncludeBehavior include = AutoInclude)
: m_includeBehavior(include)
{
static int i = 0;
int id = i;
++i;
m_headerDocument.url = createFile(headerContents,".h",id);
m_headerDocument.textDoc = openDocument(m_headerDocument.url);
QString preamble;
if (include == AutoInclude)
preamble = QStringLiteral("#include \"%1\"\n").arg(m_headerDocument.url.toLocalFile());
m_cppDocument.url = createFile(preamble + cppContents,".cpp",id);
m_cppDocument.textDoc = openDocument(m_cppDocument.url);
}
~Testbed()
{
Core::self()->documentController()->documentForUrl(m_cppDocument.url)->textDocument();
Core::self()->documentController()->documentForUrl(m_cppDocument.url)->close(KDevelop::IDocument::Discard);
Core::self()->documentController()->documentForUrl(m_headerDocument.url)->close(KDevelop::IDocument::Discard);
}
void changeDocument(TestDoc which, Range where, const QString& what, bool waitForUpdate = false)
{
TestDocument document;
if (which == CppDoc)
{
document = m_cppDocument;
if (m_includeBehavior == AutoInclude) {
where = Range(where.start().line() + 1, where.start().column(),
where.end().line() + 1, where.end().column()); //The include adds a line
}
}
else {
document = m_headerDocument;
}
// we must activate the document, otherwise we cannot find the correct active view
auto kdevdoc = ICore::self()->documentController()->documentForUrl(document.url);
QVERIFY(kdevdoc);
ICore::self()->documentController()->activateDocument(kdevdoc);
auto view = ICore::self()->documentController()->activeTextDocumentView();
QCOMPARE(view->document(), document.textDoc);
view->setSelection(where);
view->removeSelectionText();
view->setCursorPosition(where.start());
view->insertText(what);
QCoreApplication::processEvents();
if (waitForUpdate) {
DUChain::self()->waitForUpdate(IndexedString(document.url), KDevelop::TopDUContext::AllDeclarationsAndContexts);
}
}
QString documentText(TestDoc which)
{
if (which == CppDoc)
{
//The CPP document text shouldn't include the autogenerated include line
QString text = m_cppDocument.textDoc->text();
return m_includeBehavior == AutoInclude ? text.mid(text.indexOf("\n") + 1) : text;
}
else
return m_headerDocument.textDoc->text();
}
QString includeFileName() const
{
return m_headerDocument.url.toLocalFile();
}
KTextEditor::Document *document(TestDoc which) const
{
return Core::self()->documentController()->documentForUrl(
which == CppDoc ? m_cppDocument.url : m_headerDocument.url)->textDocument();
}
private:
struct TestDocument {
QUrl url;
Document *textDoc;
};
Document* openDocument(const QUrl& url)
{
Core::self()->documentController()->openDocument(url);
DUChain::self()->waitForUpdate(IndexedString(url), KDevelop::TopDUContext::AllDeclarationsAndContexts);
return Core::self()->documentController()->documentForUrl(url)->textDocument();
}
IncludeBehavior m_includeBehavior;
TestDocument m_headerDocument;
TestDocument m_cppDocument;
};
/**
* A StateChange describes an insertion/deletion/replacement and the expected result
**/
struct StateChange
{
StateChange(){};
StateChange(Testbed::TestDoc document, const Range& range, const QString& newText, const QString& result)
: document(document)
, range(range)
, newText(newText)
, result(result)
{
}
Testbed::TestDoc document;
Range range;
QString newText;
QString result;
};
Q_DECLARE_METATYPE(StateChange)
Q_DECLARE_METATYPE(QList<StateChange>)
void TestAssistants::testRenameAssistant_data()
{
QTest::addColumn<QString>("fileContents");
QTest::addColumn<QString>("oldDeclarationName");
QTest::addColumn<QList<StateChange> >("stateChanges");
QTest::addColumn<QString>("finalFileContents");
QTest::newRow("Prepend Text")
<< "int foo(int i)\n { i = 0; return i; }"
<< "i"
<< QList<StateChange>{
StateChange(Testbed::CppDoc, Range(0,12,0,12), "u", "ui"),
StateChange(Testbed::CppDoc, Range(0,13,0,13), "z", "uzi"),
}
<< "int foo(int uzi)\n { uzi = 0; return uzi; }";
QTest::newRow("Append Text")
<< "int foo(int i)\n { i = 0; return i; }"
<< "i"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,13,0,13), "d", "id"))
<< "int foo(int id)\n { id = 0; return id; }";
QTest::newRow("Replace Text")
<< "int foo(int i)\n { i = 0; return i; }"
<< "i"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,12,0,13), "u", "u"))
<< "int foo(int u)\n { u = 0; return u; }";
QTest::newRow("Paste Replace")
<< "int foo(int abg)\n { abg = 0; return abg; }"
<< "abg"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,12,0,15), "abcdefg", "abcdefg"))
<< "int foo(int abcdefg)\n { abcdefg = 0; return abcdefg; }";
QTest::newRow("Paste Insert")
<< "int foo(int abg)\n { abg = 0; return abg; }"
<< "abg"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,14,0,14), "cdef", "abcdefg"))
<< "int foo(int abcdefg)\n { abcdefg = 0; return abcdefg; }";
QTest::newRow("Letter-by-Letter Prepend")
<< "int foo(int i)\n { i = 0; return i; }"
<< "i"
<< (QList<StateChange>()
<< StateChange(Testbed::CppDoc, Range(0,12,0,12), "a", "ai")
<< StateChange(Testbed::CppDoc, Range(0,13,0,13), "b", "abi")
<< StateChange(Testbed::CppDoc, Range(0,14,0,14), "c", "abci")
)
<< "int foo(int abci)\n { abci = 0; return abci; }";
QTest::newRow("Letter-by-Letter Insert")
<< "int foo(int abg)\n { abg = 0; return abg; }"
<< "abg"
<< (QList<StateChange>()
<< StateChange(Testbed::CppDoc, Range(0,14,0,14), "c", "abcg")
<< StateChange(Testbed::CppDoc, Range(0,15,0,15), "d", "abcdg")
<< StateChange(Testbed::CppDoc, Range(0,16,0,16), "e", "abcdeg")
<< StateChange(Testbed::CppDoc, Range(0,17,0,17), "f", "abcdefg")
)
<< "int foo(int abcdefg)\n { abcdefg = 0; return abcdefg; }";
}
ProblemPointer findStaticAssistantProblem(const QVector<ProblemPointer>& problems)
{
const auto renameProblemIt = std::find_if(problems.cbegin(), problems.cend(), [](const ProblemPointer& p) {
return dynamic_cast<const StaticAssistantProblem*>(p.constData());
});
if (renameProblemIt != problems.cend())
return *renameProblemIt;
return {};
}
void TestAssistants::testRenameAssistant()
{
QFETCH(QString, fileContents);
Testbed testbed("", fileContents);
const auto document = testbed.document(Testbed::CppDoc);
QVERIFY(document);
QExplicitlySharedDataPointer<IAssistant> assistant;
QFETCH(QString, oldDeclarationName);
QFETCH(QList<StateChange>, stateChanges);
foreach(StateChange stateChange, stateChanges)
{
testbed.changeDocument(Testbed::CppDoc, stateChange.range, stateChange.newText, true);
DUChainReadLocker lock;
auto topCtx = DUChain::self()->chainForDocument(document->url());
QVERIFY(topCtx);
const auto problem = findStaticAssistantProblem(DUChainUtils::allProblemsForContext(topCtx));
if (problem)
assistant = problem->solutionAssistant();
if (stateChange.result.isEmpty()) {
QVERIFY(!assistant || !assistant->actions().size());
} else {
qWarning() << assistant.data() << stateChange.result;
QVERIFY(assistant && assistant->actions().size());
RenameAction *r = qobject_cast<RenameAction*>(assistant->actions().first().data());
QCOMPARE(r->oldDeclarationName(), oldDeclarationName);
QCOMPARE(r->newDeclarationName(), stateChange.result);
}
}
if (assistant && assistant->actions().size()) {
assistant->actions().first()->execute();
}
QFETCH(QString, finalFileContents);
QCOMPARE(testbed.documentText(Testbed::CppDoc), finalFileContents);
}
void TestAssistants::testRenameAssistantUndoRename()
{
Testbed testbed("", "int foo(int i)\n { i = 0; return i; }");
testbed.changeDocument(Testbed::CppDoc, Range(0,13,0,13), "d", true);
const auto document = testbed.document(Testbed::CppDoc);
QVERIFY(document);
DUChainReadLocker lock;
auto topCtx = DUChain::self()->chainForDocument(document->url());
QVERIFY(topCtx);
auto firstProblem = findStaticAssistantProblem(DUChainUtils::allProblemsForContext(topCtx));
QVERIFY(firstProblem);
auto assistant = firstProblem->solutionAssistant();
QVERIFY(assistant);
QVERIFY(assistant->actions().size() > 0);
RenameAction *r = qobject_cast<RenameAction*>(assistant->actions().first().data());
qWarning() << topCtx->problems() << assistant->actions().first().data() << assistant->actions().size();
QVERIFY(r);
// now rename the variable back to its original identifier
testbed.changeDocument(Testbed::CppDoc, Range(0,13,0,14), "");
// there should be no assistant anymore
QVERIFY(!assistant || assistant->actions().isEmpty());
}
const QString SHOULD_ASSIST = "SHOULD_ASSIST"; //An assistant will be visible
const QString NO_ASSIST = "NO_ASSIST"; //No assistant visible
void TestAssistants::testSignatureAssistant_data()
{
QTest::addColumn<QString>("headerContents");
QTest::addColumn<QString>("cppContents");
QTest::addColumn<QList<StateChange> >("stateChanges");
QTest::addColumn<QString>("finalHeaderContents");
QTest::addColumn<QString>("finalCppContents");
QTest::newRow("change_argument_type")
<< "class Foo {\nint bar(int a, char* b, int c = 10); \n};"
<< "int Foo::bar(int a, char* b, int c)\n{ a = c; b = new char; return a + *b; }"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(1,8,1,11), "char", SHOULD_ASSIST))
<< "class Foo {\nint bar(char a, char* b, int c = 10); \n};"
<< "int Foo::bar(char a, char* b, int c)\n{ a = c; b = new char; return a + *b; }";
QTest::newRow("prepend_arg_header")
<< "class Foo { void bar(int i); };"
<< "void Foo::bar(int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(0, 21, 0, 21), "char c, ", SHOULD_ASSIST))
<< "class Foo { void bar(char c, int i); };"
<< "void Foo::bar(char c, int i)\n{}";
QTest::newRow("prepend_arg_cpp")
<< "class Foo { void bar(int i); };"
<< "void Foo::bar(int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0, 14, 0, 14), "char c, ", SHOULD_ASSIST))
<< "class Foo { void bar(char c, int i); };"
<< "void Foo::bar(char c, int i)\n{}";
QTest::newRow("change_default_parameter")
<< "class Foo {\nint bar(int a, char* b, int c = 10); \n};"
<< "int Foo::bar(int a, char* b, int c)\n{ a = c; b = new char; return a + *b; }"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(1,29,1,34), "", NO_ASSIST))
<< "class Foo {\nint bar(int a, char* b, int c); \n};"
<< "int Foo::bar(int a, char* b, int c)\n{ a = c; b = new char; return a + *b; }";
QTest::newRow("change_function_type")
<< "class Foo {\nint bar(int a, char* b, int c = 10); \n};"
<< "int Foo::bar(int a, char* b, int c)\n{ a = c; b = new char; return a + *b; }"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,0,0,3), "char", SHOULD_ASSIST))
<< "class Foo {\nchar bar(int a, char* b, int c = 10); \n};"
<< "char Foo::bar(int a, char* b, int c)\n{ a = c; b = new char; return a + *b; }";
QTest::newRow("swap_args_definition_side")
<< "class Foo {\nint bar(int a, char* b, int c = 10); \n};"
<< "int Foo::bar(int a, char* b, int c)\n{ a = c; b = new char; return a + *b; }"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,13,0,28), "char* b, int a,", SHOULD_ASSIST))
<< "class Foo {\nint bar(char* b, int a, int c = 10); \n};"
<< "int Foo::bar(char* b, int a, int c)\n{ a = c; b = new char; return a + *b; }";
// see https://bugs.kde.org/show_bug.cgi?id=299393
// actually related to the whitespaces in the header...
QTest::newRow("change_function_constness")
<< "class Foo {\nvoid bar(const Foo&) const;\n};"
<< "void Foo::bar(const Foo&) const\n{}"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0,25,0,31), "", SHOULD_ASSIST))
<< "class Foo {\nvoid bar(const Foo&);\n};"
<< "void Foo::bar(const Foo&)\n{}";
// see https://bugs.kde.org/show_bug.cgi?id=356179
QTest::newRow("keep_static_cpp")
<< "class Foo { static void bar(int i); };"
<< "void Foo::bar(int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0, 19, 0, 19), ", char c", SHOULD_ASSIST))
<< "class Foo { static void bar(int i, char c); };"
<< "void Foo::bar(int i, char c)\n{}";
QTest::newRow("keep_static_header")
<< "class Foo { static void bar(int i); };"
<< "void Foo::bar(int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(0, 33, 0, 33), ", char c", SHOULD_ASSIST))
<< "class Foo { static void bar(int i, char c); };"
<< "void Foo::bar(int i, char c)\n{}";
// see https://bugs.kde.org/show_bug.cgi?id=356178
QTest::newRow("keep_default_args_cpp_before")
<< "class Foo { void bar(bool b, int i = 0); };"
<< "void Foo::bar(bool b, int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0, 14, 0, 14), "char c, ", SHOULD_ASSIST))
<< "class Foo { void bar(char c, bool b, int i = 0); };"
<< "void Foo::bar(char c, bool b, int i)\n{}";
QTest::newRow("keep_default_args_cpp_after")
<< "class Foo { void bar(bool b, int i = 0); };"
<< "void Foo::bar(bool b, int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0, 27, 0, 27), ", char c", SHOULD_ASSIST))
<< "class Foo { void bar(bool b, int i = 0, char c = {} /* TODO */); };"
<< "void Foo::bar(bool b, int i, char c)\n{}";
QTest::newRow("keep_default_args_header_before")
<< "class Foo { void bar(bool b, int i = 0); };"
<< "void Foo::bar(bool b, int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(0, 29, 0, 29), "char c = 'A', ", SHOULD_ASSIST))
<< "class Foo { void bar(bool b, char c = 'A', int i = 0); };"
<< "void Foo::bar(bool b, char c, int i)\n{}";
QTest::newRow("keep_default_args_header_after")
<< "class Foo { void bar(bool b, int i = 0); };"
<< "void Foo::bar(bool b, int i)\n{}"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(0, 38, 0, 38), ", char c = 'A'", SHOULD_ASSIST))
<< "class Foo { void bar(bool b, int i = 0, char c = 'A'); };"
<< "void Foo::bar(bool b, int i, char c)\n{}";
// see https://bugs.kde.org/show_bug.cgi?id=355356
QTest::newRow("no_retval_on_ctor")
<< "class Foo { Foo(); };"
<< "Foo::Foo()\n{}"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(0, 16, 0, 16), "char c", SHOULD_ASSIST))
<< "class Foo { Foo(char c); };"
<< "Foo::Foo(char c)\n{}";
// see https://bugs.kde.org/show_bug.cgi?id=298511
QTest::newRow("change_return_type_header")
<< "struct Foo { int bar(); };"
<< "int Foo::bar()\n{}"
<< (QList<StateChange>() << StateChange(Testbed::HeaderDoc, Range(0, 13, 0, 16), "char", SHOULD_ASSIST))
<< "struct Foo { char bar(); };"
<< "char Foo::bar()\n{}";
QTest::newRow("change_return_type_impl")
<< "struct Foo { int bar(); };"
<< "int Foo::bar()\n{}"
<< (QList<StateChange>() << StateChange(Testbed::CppDoc, Range(0, 0, 0, 3), "char", SHOULD_ASSIST))
<< "struct Foo { char bar(); };"
<< "char Foo::bar()\n{}";
}
void TestAssistants::testSignatureAssistant()
{
QFETCH(QString, headerContents);
QFETCH(QString, cppContents);
Testbed testbed(headerContents, cppContents);
QExplicitlySharedDataPointer<IAssistant> assistant;
QFETCH(QList<StateChange>, stateChanges);
foreach (StateChange stateChange, stateChanges)
{
testbed.changeDocument(stateChange.document, stateChange.range, stateChange.newText, true);
const auto document = testbed.document(stateChange.document);
QVERIFY(document);
DUChainReadLocker lock;
auto topCtx = DUChain::self()->chainForDocument(document->url());
QVERIFY(topCtx);
const auto problem = findStaticAssistantProblem(DUChainUtils::allProblemsForContext(topCtx));
if (problem) {
assistant = problem->solutionAssistant();
}
if (stateChange.result == SHOULD_ASSIST) {
#if CINDEX_VERSION_MINOR < 35
QEXPECT_FAIL("change_function_type", "Clang sees that return type of out-of-line definition differs from that in the declaration and won't parse the code...", Abort);
QEXPECT_FAIL("change_return_type_impl", "Clang sees that return type of out-of-line definition differs from that in the declaration and won't include the function's AST and thus we never get updated about the new return type...", Abort);
#endif
QVERIFY(assistant && !assistant->actions().isEmpty());
} else {
QVERIFY(!assistant || assistant->actions().isEmpty());
}
}
if (assistant && !assistant->actions().isEmpty())
assistant->actions().first()->execute();
QFETCH(QString, finalHeaderContents);
QFETCH(QString, finalCppContents);
QCOMPARE(testbed.documentText(Testbed::HeaderDoc), finalHeaderContents);
QCOMPARE(testbed.documentText(Testbed::CppDoc), finalCppContents);
}
enum UnknownDeclarationAction
{
NoUnknownDeclarationAction = 0x0,
ForwardDecls = 0x1,
MissingInclude = 0x2
};
Q_DECLARE_FLAGS(UnknownDeclarationActions, UnknownDeclarationAction)
Q_DECLARE_METATYPE(UnknownDeclarationActions)
void TestAssistants::testUnknownDeclarationAssistant_data()
{
QTest::addColumn<QString>("headerContents");
QTest::addColumn<QString>("globalText");
QTest::addColumn<QString>("functionText");
QTest::addColumn<UnknownDeclarationActions>("actions");
QTest::newRow("unincluded_struct") << "struct test{};" << "" << "test"
<< UnknownDeclarationActions(ForwardDecls | MissingInclude);
QTest::newRow("forward_declared_struct") << "struct test{};" << "struct test;" << "test *f; f->"
<< UnknownDeclarationActions(MissingInclude);
QTest::newRow("unknown_struct") << "" << "" << "test"
<< UnknownDeclarationActions();
QTest::newRow("not a class type") << "void test();" << "" << "test"
<< UnknownDeclarationActions();
}
void TestAssistants::testUnknownDeclarationAssistant()
{
QFETCH(QString, headerContents);
QFETCH(QString, globalText);
QFETCH(QString, functionText);
QFETCH(UnknownDeclarationActions, actions);
static const auto cppContents = QStringLiteral("%1\nvoid f_u_n_c_t_i_o_n() {\n}");
Testbed testbed(headerContents, cppContents.arg(globalText), Testbed::NoAutoInclude);
const auto document = testbed.document(Testbed::CppDoc);
QVERIFY(document);
const int line = document->lines() - 1;
testbed.changeDocument(Testbed::CppDoc, Range(line, 0, line, 0), functionText, true);
DUChainReadLocker lock;
auto topCtx = DUChain::self()->chainForDocument(document->url());
QVERIFY(topCtx);
const auto problems = topCtx->problems();
if (actions == NoUnknownDeclarationAction) {
QVERIFY(!problems.isEmpty());
return;
}
auto firstProblem = problems.first();
auto assistant = firstProblem->solutionAssistant();
QVERIFY(assistant);
const auto assistantActions = assistant->actions();
QStringList actionDescriptions;
for (auto action: assistantActions) {
actionDescriptions << action->description();
}
{
const bool hasForwardDecls =
actionDescriptions.contains(QObject::tr("Forward declare as 'struct'")) ||
actionDescriptions.contains(QObject::tr("Forward declare as 'class'"));
QCOMPARE(hasForwardDecls, static_cast<bool>(actions & ForwardDecls));
}
{
auto fileName = testbed.includeFileName();
fileName = fileName.mid(fileName.lastIndexOf('/') + 1);
const auto description = QObject::tr("Insert \'%1\'")
.arg(QStringLiteral("#include \"%1\"").arg(fileName));
const bool hasMissingInclude = actionDescriptions.contains(description);
QCOMPARE(hasMissingInclude, static_cast<bool>(actions & MissingInclude));
}
}
void TestAssistants::testMoveIntoSource()
{
QFETCH(QString, origHeader);
QFETCH(QString, origImpl);
QFETCH(QString, newHeader);
QFETCH(QString, newImpl);
QFETCH(QualifiedIdentifier, id);
TestFile header(origHeader, "h");
TestFile impl("#include \"" + header.url().byteArray() + "\"\n" + origImpl, "cpp", &header);
{
TopDUContext* headerCtx = nullptr;
{
DUChainReadLocker lock;
headerCtx = DUChain::self()->chainForDocument(header.url());
}
// Here is a problem: when launching tests one by one, we can reuse the same tmp file for headers.
// But because of document chain for header wasn't unloaded properly in previous run we reuse it here
// Therefore when using headerCtx->findDeclarations below we find declarations from the previous launch -> tests fail
if (headerCtx) {
// TODO: Investigate why this chain doesn't get updated when parsing source file
DUChainWriteLocker lock;
DUChain::self()->removeDocumentChain(headerCtx);
}
}
impl.parse(KDevelop::TopDUContext::AllDeclarationsContextsAndUses);
QVERIFY(impl.waitForParsed());
IndexedDeclaration declaration;
{
DUChainReadLocker lock;
auto headerCtx = DUChain::self()->chainForDocument(header.url());
QVERIFY(headerCtx);
auto decls = headerCtx->findDeclarations(id);
Q_ASSERT(!decls.isEmpty());
declaration = IndexedDeclaration(decls.first());
QVERIFY(declaration.isValid());
}
CodeRepresentation::setDiskChangesForbidden(false);
ClangRefactoring refactoring;
QCOMPARE(refactoring.moveIntoSource(declaration), QString());
CodeRepresentation::setDiskChangesForbidden(true);
QCOMPARE(header.fileContents(), newHeader);
QVERIFY(impl.fileContents().endsWith(newImpl));
}
void TestAssistants::testMoveIntoSource_data()
{
QTest::addColumn<QString>("origHeader");
QTest::addColumn<QString>("origImpl");
QTest::addColumn<QString>("newHeader");
QTest::addColumn<QString>("newImpl");
QTest::addColumn<QualifiedIdentifier>("id");
const QualifiedIdentifier fooId("foo");
QTest::newRow("globalfunction") << QString("int foo()\n{\n int i = 0;\n return 0;\n}\n")
<< QString()
<< QString("int foo();\n")
<< QString("\nint foo()\n{\n int i = 0;\n return 0;\n}\n")
<< fooId;
QTest::newRow("staticfunction") << QString("static int foo()\n{\n int i = 0;\n return 0;\n}\n")
<< QString()
<< QString("static int foo();\n")
<< QString("\nint foo()\n{\n int i = 0;\n return 0;\n}\n")
<< fooId;
QTest::newRow("funcsameline") << QString("int foo() {\n int i = 0;\n return 0;\n}\n")
<< QString()
<< QString("int foo();\n")
<< QString("\nint foo() {\n int i = 0;\n return 0;\n}\n")
<< fooId;
QTest::newRow("func-comment") << QString("int foo()\n/* foobar */ {\n int i = 0;\n return 0;\n}\n")
<< QString()
<< QString("int foo()\n/* foobar */;\n")
<< QString("\nint foo() {\n int i = 0;\n return 0;\n}\n")
<< fooId;
QTest::newRow("func-comment2") << QString("int foo()\n/*asdf*/\n{\n int i = 0;\n return 0;\n}\n")
<< QString()
<< QString("int foo()\n/*asdf*/;\n")
<< QString("\nint foo()\n{\n int i = 0;\n return 0;\n}\n")
<< fooId;
const QualifiedIdentifier aFooId("a::foo");
QTest::newRow("class-method") << QString("class a {\n int foo(){\n return 0;\n }\n};\n")
<< QString()
<< QString("class a {\n int foo();\n};\n")
<< QString("\nint a::foo() {\n return 0;\n }\n")
<< aFooId;
QTest::newRow("class-method-const") << QString("class a {\n int foo() const\n {\n return 0;\n }\n};\n")
<< QString()
<< QString("class a {\n int foo() const;\n};\n")
<< QString("\nint a::foo() const\n {\n return 0;\n }\n")
<< aFooId;
QTest::newRow("class-method-const-sameline") << QString("class a {\n int foo() const{\n return 0;\n }\n};\n")
<< QString()
<< QString("class a {\n int foo() const;\n};\n")
<< QString("\nint a::foo() const {\n return 0;\n }\n")
<< aFooId;
QTest::newRow("elaborated-type") << QString("namespace NS{class C{};} class a {\nint foo(const NS::C c) const{\nreturn 0;\n}\n};\n")
<< QString()
<< QString("namespace NS{class C{};} class a {\nint foo(const NS::C c) const;\n};\n")
<< QString("\nint a::foo(const NS::C c) const {\nreturn 0;\n}\n")
<< aFooId;
QTest::newRow("add-into-namespace") << QString("namespace NS{class a {\nint foo() const {\nreturn 0;\n}\n};\n}")
<< QString("namespace NS{\n}")
<< QString("namespace NS{class a {\nint foo() const;\n};\n}")
<< QString("namespace NS{\n\nint a::foo() const {\nreturn 0;\n}\n}")
<< QualifiedIdentifier("NS::a::foo");
QTest::newRow("class-template-parameter")
<< QString(R"(
namespace first {
template <typename T>
class Test{};
namespace second {
template <typename T>
class List;
}
class MoveIntoSource
{
public:
void f(const second::List<const volatile Test<first::second::List<int*>>*>& param){}
};}
)")
<< QString("")
<< QString(R"(
namespace first {
template <typename T>
class Test{};
namespace second {
template <typename T>
class List;
}
class MoveIntoSource
{
public:
void f(const second::List<const volatile Test<first::second::List<int*>>*>& param);
};}
)")
<< QString("namespace first {\nvoid MoveIntoSource::f(const first::second::List< const volatile first::Test< first::second::List< int* > >* >& param) {}}\n\n")
<< QualifiedIdentifier("first::MoveIntoSource::f");
QTest::newRow("move-unexposed-type")
<< QString("namespace std { template<typename _CharT> class basic_string; \ntypedef basic_string<char> string;}\n void move(std::string i){}")
<< QString("")
<< QString("namespace std { template<typename _CharT> class basic_string; \ntypedef basic_string<char> string;}\n void move(std::string i);")
<< QString("void move(std::string i) {}\n")
<< QualifiedIdentifier("move");
QTest::newRow("move-constructor")
<< QString("class Class{Class(){}\n};")
<< QString("")
<< QString("class Class{Class();\n};")
<< QString("Class::Class() {}\n")
<< QualifiedIdentifier("Class::Class");
}
|