1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566
|
/*
* Copyright 2014 Jørgen Kvalsvik <lycantrophe@lavabit.com>
* Copyright 2014 Kevin Funk <kfunk@kde.org>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of
* the License or (at your option) version 3 or any later version
* accepted by the membership of KDE e.V. (or its successor approved
* by the membership of KDE e.V.), which shall act as a proxy
* defined in Section 14 of version 3 of the license.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
#include "unknowndeclarationproblem.h"
#include "clanghelpers.h"
#include "parsesession.h"
#include "../util/clangdebug.h"
#include "../util/clangutils.h"
#include "../util/clangtypes.h"
#include "../clangsettings/clangsettingsmanager.h"
#include <interfaces/icore.h>
#include <interfaces/iprojectcontroller.h>
#include <interfaces/iproject.h>
#include <language/duchain/persistentsymboltable.h>
#include <language/duchain/aliasdeclaration.h>
#include <language/duchain/classdeclaration.h>
#include <language/duchain/parsingenvironment.h>
#include <language/duchain/topducontext.h>
#include <language/duchain/duchainlock.h>
#include <language/duchain/duchainutils.h>
#include <custom-definesandincludes/idefinesandincludesmanager.h>
#include <project/projectmodel.h>
#include <util/path.h>
#include <KLocalizedString>
#include <QDir>
#include <QRegularExpression>
#include <algorithm>
using namespace KDevelop;
namespace {
/** Under some conditions, such as when looking up suggestions
* for the undeclared namespace 'std' we will get an awful lot
* of suggestions. This parameter limits how many suggestions
* will pop up, as rarely more than a few will be relevant anyways
*
* Forward declaration suggestions are included in this number
*/
const int maxSuggestions = 5;
/**
* We don't want anything from the bits directory -
* we'd rather prefer forwarding includes, such as <vector>
*/
bool isBlacklisted(const QString& path)
{
if (ClangHelpers::isSource(path))
return true;
// Do not allow including directly from the bits directory.
// Instead use one of the forwarding headers in other directories, when possible.
if (path.contains( QLatin1String("bits") ) && path.contains(QLatin1String("/include/c++/")))
return true;
return false;
}
QStringList scanIncludePaths( const QString& identifier, const QDir& dir, int maxDepth = 3 )
{
if (!maxDepth) {
return {};
}
QStringList candidates;
const auto path = dir.absolutePath();
if( isBlacklisted( path ) ) {
return {};
}
const QStringList nameFilters = {identifier, identifier + QLatin1String(".*")};
const auto& files = dir.entryList(nameFilters, QDir::Files);
for (const auto& file : files) {
if (identifier.compare(file, Qt::CaseInsensitive) == 0 || ClangHelpers::isHeader(file)) {
const QString filePath = path + QLatin1Char('/') + file;
clangDebug() << "Found candidate file" << filePath;
candidates.append( filePath );
}
}
maxDepth--;
const auto& subdirs = dir.entryList(QDir::Dirs | QDir::NoDotAndDotDot);
for (const auto& subdir : subdirs) {
candidates += scanIncludePaths( identifier, QDir{ path + QLatin1Char('/') + subdir }, maxDepth );
}
return candidates;
}
/**
* Find files in dir that match the given identifier. Matches common C++ header file extensions only.
*/
QStringList scanIncludePaths( const QualifiedIdentifier& identifier, const KDevelop::Path::List& includes )
{
const auto stripped_identifier = identifier.last().toString();
QStringList candidates;
for( const auto& include : includes ) {
candidates += scanIncludePaths( stripped_identifier, QDir{ include.toLocalFile() } );
}
std::sort( candidates.begin(), candidates.end() );
candidates.erase( std::unique( candidates.begin(), candidates.end() ), candidates.end() );
return candidates;
}
/**
* Determine how much path is shared between two includes.
* boost/tr1/unordered_map
* boost/tr1/unordered_set
* have a shared path of 2 where
* boost/tr1/unordered_map
* boost/vector
* have a shared path of 1
*/
int sharedPathLevel(const QString& a, const QString& b)
{
int shared = -1;
for(auto x = a.begin(), y = b.begin(); *x == *y && x != a.end() && y != b.end() ; ++x, ++y ) {
if( *x == QDir::separator() ) {
++shared;
}
}
return shared;
}
/**
* Try to find a proper include position from the DUChain:
*
* look at existing imports (i.e. #include's) and find a fitting
* file with the same/similar path to the new include file and use that
*
* TODO: Implement a fallback scheme
*/
KDevelop::DocumentRange includeDirectivePosition(const KDevelop::Path& source, const QString& includeFile)
{
static const QRegularExpression mocFilenameExpression(QStringLiteral("(moc_[^\\/\\\\]+\\.cpp$|\\.moc$)") );
DUChainReadLocker lock;
const TopDUContext* top = DUChainUtils::standardContextForUrl( source.toUrl() );
if( !top ) {
clangDebug() << "unable to find standard context for" << source.toLocalFile() << "Creating null range";
return KDevelop::DocumentRange::invalid();
}
int line = -1;
// look at existing #include statements and re-use them
int currentMatchQuality = -1;
const auto& importedParentContexts = top->importedParentContexts();
for (const auto& import : importedParentContexts) {
const auto importFilename = import.context(top)->url().str();
const int matchQuality = sharedPathLevel( importFilename , includeFile );
if( matchQuality < currentMatchQuality ) {
continue;
}
const auto match = mocFilenameExpression.match(importFilename);
if (match.hasMatch()) {
clangDebug() << "moc file detected in" << source.toUrl().toDisplayString() << ":" << importFilename << "-- not using as include insertion location";
continue;
}
line = import.position.line + 1;
currentMatchQuality = matchQuality;
}
if( line == -1 ) {
/* Insert at the top of the document */
return {IndexedString(source.pathOrUrl()), {0, 0, 0, 0}};
}
return {IndexedString(source.pathOrUrl()), {line, 0, line, 0}};
}
KDevelop::DocumentRange forwardDeclarationPosition(const QualifiedIdentifier& identifier, const KDevelop::Path& source)
{
DUChainReadLocker lock;
const TopDUContext* top = DUChainUtils::standardContextForUrl( source.toUrl() );
if( !top ) {
clangDebug() << "unable to find standard context for" << source.toLocalFile() << "Creating null range";
return KDevelop::DocumentRange::invalid();
}
if (!top->findDeclarations(identifier).isEmpty()) {
// Already forward-declared
return KDevelop::DocumentRange::invalid();
}
int line = std::numeric_limits< int >::max();
const auto& localDeclarations = top->localDeclarations();
for (const auto decl : localDeclarations) {
line = std::min( line, decl->range().start.line );
}
if( line == std::numeric_limits< int >::max() ) {
return KDevelop::DocumentRange::invalid();
}
// We want it one line above the first declaration
line = std::max( line - 1, 0 );
return {IndexedString(source.pathOrUrl()), {line, 0, line, 0}};
}
/**
* Iteratively build all levels of the current scope. A (missing) type anywhere
* can be arbitrarily namespaced, so we create the permutations of possible
* nestings of namespaces it can currently be in,
*
* TODO: add detection of namespace aliases, such as 'using namespace KDevelop;'
*
* namespace foo {
* namespace bar {
* function baz() {
* type var;
* }
* }
* }
*
* Would give:
* foo::bar::baz::type
* foo::bar::type
* foo::type
* type
*/
QVector<KDevelop::QualifiedIdentifier> findPossibleQualifiedIdentifiers( const QualifiedIdentifier& identifier, const KDevelop::Path& file, const KDevelop::CursorInRevision& cursor )
{
DUChainReadLocker lock;
const TopDUContext* top = DUChainUtils::standardContextForUrl( file.toUrl() );
if( !top ) {
clangDebug() << "unable to find standard context for" << file.toLocalFile() << "Not creating duchain candidates";
return {};
}
const auto* context = top->findContextAt( cursor );
if( !context ) {
clangDebug() << "No context found at" << cursor;
return {};
}
QVector<KDevelop::QualifiedIdentifier> declarations{ identifier };
auto scopes = context->scopeIdentifier();
declarations.reserve(declarations.size() + scopes.count());
for (; !scopes.isEmpty(); scopes.pop()) {
declarations.append( scopes + identifier );
}
clangDebug() << "Possible declarations:" << declarations;
return declarations;
}
}
QStringList UnknownDeclarationProblem::findMatchingIncludeFiles(const QVector<Declaration*>& declarations)
{
DUChainReadLocker lock;
QStringList candidates;
for (const auto decl: declarations) {
// skip declarations that don't belong to us
const auto& file = decl->topContext()->parsingEnvironmentFile();
if (!file || file->language() != ParseSession::languageString()) {
continue;
}
if( dynamic_cast<KDevelop::AliasDeclaration*>( decl ) ) {
continue;
}
if( decl->isForwardDeclaration() ) {
continue;
}
const auto filepath = decl->url().toUrl().toLocalFile();
if( !isBlacklisted( filepath ) ) {
candidates << filepath;
clangDebug() << "Adding" << filepath << "determined from candidate" << decl->toString();
}
const auto& importers = file->importers();
for (const auto& importer : importers) {
if( importer->imports().count() != 1 && !isBlacklisted( filepath ) ) {
continue;
}
if( importer->topContext()->localDeclarations().count() ) {
continue;
}
const auto filePath = importer->url().toUrl().toLocalFile();
if( isBlacklisted( filePath ) ) {
continue;
}
/* This file is a forwarder, such as <vector>
* <vector> does not actually implement the functions, but include other headers that do
* we prefer this to other headers
*/
candidates << filePath;
clangDebug() << "Adding forwarder file" << filePath << "to the result set";
}
}
std::sort( candidates.begin(), candidates.end() );
candidates.erase( std::unique( candidates.begin(), candidates.end() ), candidates.end() );
clangDebug() << "Candidates: " << candidates;
return candidates;
}
namespace {
/**
* Takes a filepath and the include paths and determines what directive to use.
*/
ClangFixit directiveForFile( const QString& includefile, const KDevelop::Path::List& includepaths, const KDevelop::Path& source )
{
const auto sourceFolder = source.parent();
const Path canonicalFile( QFileInfo( includefile ).canonicalFilePath() );
QString shortestDirective;
bool isRelative = false;
// we can include the file directly
if (sourceFolder == canonicalFile.parent()) {
shortestDirective = canonicalFile.lastPathSegment();
isRelative = true;
} else {
// find the include directive with the shortest length
for( const auto& includePath : includepaths ) {
QString relative = includePath.relativePath( canonicalFile );
if( relative.startsWith( QLatin1String("./") ) )
relative.remove(0, 2);
if( shortestDirective.isEmpty() || relative.length() < shortestDirective.length() ) {
shortestDirective = relative;
isRelative = includePath == sourceFolder;
}
}
}
if( shortestDirective.isEmpty() ) {
// Item not found in include path
return {};
}
const auto range = DocumentRange(IndexedString(source.pathOrUrl()), includeDirectivePosition(source, canonicalFile.lastPathSegment()));
if( !range.isValid() ) {
clangDebug() << "unable to determine valid position for" << includefile << "in" << source.pathOrUrl();
return {};
}
QString directive;
if( isRelative ) {
directive = QStringLiteral("#include \"%1\"").arg(shortestDirective);
} else {
directive = QStringLiteral("#include <%1>").arg(shortestDirective);
}
return ClangFixit{directive + QLatin1Char('\n'), range, i18n("Insert \'%1\'", directive)};
}
KDevelop::Path::List includePaths( const KDevelop::Path& file )
{
// Find project's custom include paths
const auto source = file.toLocalFile();
const auto item = ICore::self()->projectController()->projectModel()->itemForPath( KDevelop::IndexedString( source ) );
return IDefinesAndIncludesManager::manager()->includes(item);
}
/**
* Return a list of header files viable for inclusions. All elements will be unique
*/
QStringList includeFiles(const QualifiedIdentifier& identifier, const QVector<Declaration*>& declarations, const KDevelop::Path& file)
{
const auto includes = includePaths( file );
if( includes.isEmpty() ) {
clangDebug() << "Include path is empty";
return {};
}
const auto candidates = UnknownDeclarationProblem::findMatchingIncludeFiles(declarations);
if( !candidates.isEmpty() ) {
// If we find a candidate from the duchain we don't bother scanning the include paths
return candidates;
}
return scanIncludePaths(identifier, includes);
}
/**
* Construct viable forward declarations for the type name.
*/
ClangFixits forwardDeclarations(const QVector<Declaration*>& matchingDeclarations, const Path& source)
{
DUChainReadLocker lock;
ClangFixits fixits;
for (const auto decl : matchingDeclarations) {
const auto qid = decl->qualifiedIdentifier();
if (qid.count() > 1) {
// TODO: Currently we're not able to determine what is namespaces, class names etc
// and makes a suitable forward declaration, so just suggest "vanilla" declarations.
continue;
}
const auto range = forwardDeclarationPosition(qid, source);
if (!range.isValid()) {
continue; // do not know where to insert
}
if (const auto classDecl = dynamic_cast<ClassDeclaration*>(decl)) {
const auto name = qid.last().toString();
switch (classDecl->classType()) {
case ClassDeclarationData::Class:
fixits += {
QLatin1String("class ") + name + QLatin1String(";\n"), range,
i18n("Forward declare as 'class'")
};
break;
case ClassDeclarationData::Struct:
fixits += {
QLatin1String("struct ") + name + QLatin1String(";\n"), range,
i18n("Forward declare as 'struct'")
};
break;
default:
break;
}
}
}
return fixits;
}
/**
* Search the persistent symbol table for matching declarations for identifiers @p identifiers
*/
QVector<Declaration*> findMatchingDeclarations(const QVector<QualifiedIdentifier>& identifiers)
{
DUChainReadLocker lock;
QVector<Declaration*> matchingDeclarations;
matchingDeclarations.reserve(identifiers.size());
for (const auto& declaration : identifiers) {
clangDebug() << "Considering candidate declaration" << declaration;
const IndexedDeclaration* declarations;
uint declarationCount;
PersistentSymbolTable::self().declarations( declaration , declarationCount, declarations );
for (uint i = 0; i < declarationCount; ++i) {
// Skip if the declaration is invalid or if it is an alias declaration -
// we want the actual declaration (and its file)
if (auto decl = declarations[i].declaration()) {
matchingDeclarations << decl;
}
}
}
return matchingDeclarations;
}
ClangFixits fixUnknownDeclaration( const QualifiedIdentifier& identifier, const KDevelop::Path& file, const KDevelop::DocumentRange& docrange )
{
ClangFixits fixits;
const CursorInRevision cursor{docrange.start().line(), docrange.start().column()};
const auto possibleIdentifiers = findPossibleQualifiedIdentifiers(identifier, file, cursor);
const auto matchingDeclarations = findMatchingDeclarations(possibleIdentifiers);
if (ClangSettingsManager::self()->assistantsSettings().forwardDeclare) {
const auto& forwardDeclareFixits = forwardDeclarations(matchingDeclarations, file);
for (const auto& fixit : forwardDeclareFixits) {
fixits << fixit;
if (fixits.size() == maxSuggestions) {
return fixits;
}
}
}
const auto includefiles = includeFiles(identifier, matchingDeclarations, file);
if (includefiles.isEmpty()) {
// return early as the computation of the include paths is quite expensive
return fixits;
}
const auto includepaths = includePaths( file );
clangDebug() << "found include paths for" << file << ":" << includepaths;
/* create fixits for candidates */
for( const auto& includeFile : includefiles ) {
const auto fixit = directiveForFile( includeFile, includepaths, file /* UP */ );
if (!fixit.range.isValid()) {
clangDebug() << "unable to create directive for" << includeFile << "in" << file.toLocalFile();
continue;
}
fixits << fixit;
if (fixits.size() == maxSuggestions) {
return fixits;
}
}
return fixits;
}
QString symbolFromDiagnosticSpelling(const QString& str)
{
/* in all error messages the symbol is in in the first pair of quotes */
const auto split = str.split( QLatin1Char('\'') );
auto symbol = split.value( 1 );
if( str.startsWith( QLatin1String("No member named") ) ) {
symbol = split.value( 3 ) + QLatin1String("::") + split.value( 1 );
}
return symbol;
}
}
UnknownDeclarationProblem::UnknownDeclarationProblem(CXDiagnostic diagnostic, CXTranslationUnit unit)
: ClangProblem(diagnostic, unit)
{
setSymbol(QualifiedIdentifier(symbolFromDiagnosticSpelling(description())));
}
void UnknownDeclarationProblem::setSymbol(const QualifiedIdentifier& identifier)
{
m_identifier = identifier;
}
IAssistant::Ptr UnknownDeclarationProblem::solutionAssistant() const
{
const Path path(finalLocation().document.str());
const auto fixits = allFixits() + fixUnknownDeclaration(m_identifier, path, finalLocation());
return IAssistant::Ptr(new ClangFixitAssistant(fixits));
}
|