1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
|
/*
This file is part of the KDE libraries
SPDX-FileCopyrightText: 2009 David Faure <faure@kde.org>
SPDX-License-Identifier: LGPL-2.0-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
*/
#include "testguiclient.h"
#include "testxmlguiwindow.h"
#ifdef WITH_QTDBUS
#include <QDBusConnection>
#endif
#include <QDir>
#include <QFile>
#include <QFileInfo>
#include <QSignalSpy>
#include <QStandardPaths>
#include <QTest>
#include <KConfig>
#include <KConfigGroup>
#include <KIconLoader>
#include <KSharedConfig>
#include <kmainwindow.h>
#include <ktoolbar.h>
// We use the data types below in a QVariant, so Q_DECLARE_METATYPE is needed for them.
Q_DECLARE_METATYPE(Qt::MouseButton)
Q_DECLARE_METATYPE(Qt::MouseButtons)
Q_DECLARE_METATYPE(Qt::KeyboardModifiers)
// Ensure everything uses test paths, including stuff run before main, such as the KdePlatformThemePlugin
void enableTestMode()
{
QStandardPaths::setTestModeEnabled(true);
}
Q_CONSTRUCTOR_FUNCTION(enableTestMode)
class tst_KToolBar : public QObject
{
Q_OBJECT
public Q_SLOTS:
void initTestCase();
void cleanupTestCase();
void init();
void cleanup();
private Q_SLOTS:
void ktoolbar();
void testIconSizeNoXmlGui_data();
void testIconSizeNoXmlGui();
void testIconSizeXmlGui_data();
void testIconSizeXmlGui();
void testToolButtonStyleNoXmlGui_data();
void testToolButtonStyleNoXmlGui();
void testToolButtonStyleXmlGui_data();
void testToolButtonStyleXmlGui();
void testToolBarPosition();
void testXmlGuiSwitching();
void testKAuthorizedDisableToggleAction();
Q_SIGNALS:
void signalAppearanceChanged();
protected:
bool eventFilter(QObject *watched, QEvent *event) override;
private:
void changeGlobalToolButtonStyleSetting(const QString &, const QString &);
void deleteGlobalToolButtonStyleSetting();
QByteArray m_xml;
bool m_showWasCalled;
};
QTEST_MAIN(tst_KToolBar)
static void copy_dir(const QString &from, const QDir &to)
{
QDir src = QDir(from);
QDir dest = QDir(to.filePath(src.dirName()));
to.mkpath(src.dirName());
const auto fileInfos = src.entryInfoList(QDir::Dirs | QDir::Files | QDir::NoDotAndDotDot);
for (const QFileInfo &fileInfo : fileInfos) {
if (fileInfo.isDir()) {
copy_dir(fileInfo.filePath(), dest);
} else {
QFile::copy(fileInfo.filePath(), dest.filePath(fileInfo.fileName()));
}
}
}
// This will be called before the first test function is executed.
// It is only called once.
void tst_KToolBar::initTestCase()
{
// start with a clean place to put data
QDir testDataDir = QDir(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation));
QVERIFY(testDataDir.absolutePath().contains(QLatin1String("qttest")));
testDataDir.removeRecursively();
testDataDir.mkpath(QStringLiteral("."));
// setup action restriction so we can test whether this actually disables some functionality
KConfigGroup actionRestrictions(KSharedConfig::openConfig(), QStringLiteral("KDE Action Restrictions"));
actionRestrictions.writeEntry("action/options_show_toolbar", false);
// copy a minimal icon theme to where KIconTheme will find it, in case oxygen-icons is not
// installed
copy_dir(QFINDTESTDATA("icons"), testDataDir);
m_xml =
"<?xml version = '1.0'?>\n"
"<!DOCTYPE gui SYSTEM \"kpartgui.dtd\">\n"
"<gui version=\"1\" name=\"foo\" >\n"
"<MenuBar>\n"
"</MenuBar>\n"
"<ToolBar name=\"mainToolBar\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"<ToolBar name=\"otherToolBar\" position=\"bottom\" iconText=\"TextUnderIcon\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"<ToolBar name=\"cleanToolBar\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"<ToolBar name=\"hiddenToolBar\" hidden=\"true\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"<ToolBar name=\"secondHiddenToolBar\" hidden=\"true\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"<ToolBar iconSize=\"32\" name=\"bigToolBar\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"<ToolBar iconSize=\"32\" name=\"bigUnchangedToolBar\">\n"
" <Action name=\"go_up\"/>\n"
"</ToolBar>\n"
"</gui>\n";
qRegisterMetaType<Qt::MouseButtons>("Qt::MouseButtons");
qRegisterMetaType<Qt::KeyboardModifiers>("Qt::KeyboardModifiers");
}
// This will be called after the last test function is executed.
// It is only called once.
void tst_KToolBar::cleanupTestCase()
{
QDir testDataDir = QDir(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation));
QDir testIconsDir = QDir(testDataDir.absoluteFilePath(QStringLiteral("icons")));
QVERIFY(testIconsDir.absolutePath().contains(QLatin1String("qttest")));
testIconsDir.removeRecursively();
}
// This will be called before each test function is executed.
void tst_KToolBar::init()
{
}
// This will be called after every test function.
void tst_KToolBar::cleanup()
{
QFile::remove(QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + QStringLiteral("/tst_KToolBar"));
deleteGlobalToolButtonStyleSetting();
}
void tst_KToolBar::ktoolbar()
{
KMainWindow kmw;
// Creating a KToolBar directly
KToolBar bar(&kmw);
QCOMPARE(bar.mainWindow(), &kmw);
// Asking KMainWindow for a KToolBar (more common)
KToolBar *mainToolBar = kmw.toolBar(QStringLiteral("mainToolBar"));
QCOMPARE(mainToolBar->mainWindow(), &kmw);
}
Q_DECLARE_METATYPE(KConfigGroup)
void tst_KToolBar::testIconSizeNoXmlGui_data()
{
QTest::addColumn<int>("iconSize");
QTest::newRow("16") << 16;
QTest::newRow("22") << 22;
QTest::newRow("32") << 32;
QTest::newRow("64") << 64;
}
void tst_KToolBar::testIconSizeNoXmlGui()
{
QFETCH(int, iconSize);
KConfig config(QStringLiteral("tst_KToolBar"));
KConfigGroup group(&config, QStringLiteral("group"));
{
KMainWindow kmw;
KToolBar *mainToolBar = kmw.toolBar(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBar(QStringLiteral("otherToolBar"));
// Default settings (applied by applyAppearanceSettings)
QCOMPARE(mainToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::MainToolbar));
QCOMPARE(otherToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::Toolbar));
// check the actual values - update this if kicontheme's defaults are changed
QCOMPARE(KIconLoader::global()->currentSize(KIconLoader::MainToolbar), 22);
QCOMPARE(KIconLoader::global()->currentSize(KIconLoader::Toolbar), 22);
// Changing settings for a given toolbar, as user
mainToolBar->setIconDimensions(iconSize);
otherToolBar->setIconDimensions(iconSize);
// Save settings
kmw.saveMainWindowSettings(group);
// was it the default value?
if (iconSize == KIconLoader::global()->currentSize(KIconLoader::MainToolbar)) {
QCOMPARE(group.groupList().count(), 0); // nothing to save
QVERIFY(!group.group(QStringLiteral("Toolbar mainToolBar")).hasKey("IconSize"));
} else {
QCOMPARE(group.groupList().count(), 2); // two subgroups (one for each toolbar)
QVERIFY(group.group(QStringLiteral("Toolbar mainToolBar")).hasKey("IconSize"));
}
}
{
// Recreate, load, compare.
KMainWindow kmw;
KToolBar *mainToolBar = kmw.toolBar(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBar(QStringLiteral("otherToolBar"));
KToolBar *cleanToolBar = kmw.toolBar(QStringLiteral("cleanToolBar"));
QCOMPARE(mainToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::MainToolbar));
QCOMPARE(otherToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::Toolbar));
QCOMPARE(cleanToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::Toolbar));
kmw.applyMainWindowSettings(group);
QCOMPARE(mainToolBar->iconSize().width(), iconSize);
QCOMPARE(otherToolBar->iconSize().width(), iconSize);
QCOMPARE(cleanToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::Toolbar)); // unchanged
}
}
void tst_KToolBar::testIconSizeXmlGui_data()
{
QTest::addColumn<int>("iconSize"); // set by user and saved to KConfig
// When the user chose a specific size for the toolbar (!= its default size), the new kde-global size isn't applied to that toolbar.
// So, only in case the toolbar was at iconSize already, and there was no setting in xml, we end up with kdeGlobal being used:
QTest::newRow("16") << 16;
QTest::newRow("22") << 22;
QTest::newRow("32") << 32;
QTest::newRow("64") << 64;
}
void tst_KToolBar::testIconSizeXmlGui()
{
QFETCH(int, iconSize);
KConfig config(QStringLiteral("tst_KToolBar"));
KConfigGroup group(&config, QStringLiteral("group"));
{
TestXmlGuiWindow kmw(m_xml, "tst_ktoolbar.rc");
kmw.createActions(QStringList() << QStringLiteral("go_up"));
kmw.createGUI();
KToolBar *mainToolBar = kmw.toolBarByName(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBarByName(QStringLiteral("otherToolBar"));
KToolBar *cleanToolBar = kmw.toolBarByName(QStringLiteral("cleanToolBar"));
KToolBar *bigToolBar = kmw.toolBarByName(QStringLiteral("bigToolBar"));
KToolBar *bigUnchangedToolBar = kmw.toolBarByName(QStringLiteral("bigUnchangedToolBar"));
// Default settings (applied by applyAppearanceSettings)
QCOMPARE(mainToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::MainToolbar));
QCOMPARE(otherToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::Toolbar));
// check the actual values - update this if kicontheme's defaults are changed
QCOMPARE(mainToolBar->iconSize().width(), 22);
QCOMPARE(otherToolBar->iconSize().width(), 22);
QCOMPARE(cleanToolBar->iconSize().width(), 22);
QCOMPARE(bigToolBar->iconSize().width(), 32);
QCOMPARE(bigUnchangedToolBar->iconSize().width(), 32);
// Changing settings for a given toolbar, as user (to test the initial report in #168480)
mainToolBar->setIconDimensions(iconSize);
otherToolBar->setIconDimensions(iconSize);
bigToolBar->setIconDimensions(iconSize);
// Save settings
kmw.saveMainWindowSettings(group);
// was it the default size? (for the main toolbar, we only check that one)
const bool usingDefaultSize = iconSize == KIconLoader::global()->currentSize(KIconLoader::MainToolbar);
if (usingDefaultSize) {
QVERIFY(!group.groupList().contains(QLatin1String("Toolbar mainToolBar")));
QVERIFY(!group.group(QStringLiteral("Toolbar mainToolBar")).hasKey("IconSize"));
} else {
QVERIFY(group.group(QStringLiteral("Toolbar mainToolBar")).hasKey("IconSize"));
}
}
}
Q_DECLARE_METATYPE(Qt::ToolButtonStyle)
void tst_KToolBar::testToolButtonStyleNoXmlGui_data()
{
QTest::addColumn<Qt::ToolButtonStyle>("toolButtonStyle");
QTest::newRow("Qt::ToolButtonIconOnly") << Qt::ToolButtonIconOnly;
QTest::newRow("Qt::ToolButtonTextOnly") << Qt::ToolButtonTextOnly;
QTest::newRow("Qt::ToolButtonTextBesideIcon") << Qt::ToolButtonTextBesideIcon;
QTest::newRow("Qt::ToolButtonTextUnderIcon") << Qt::ToolButtonTextUnderIcon;
}
void tst_KToolBar::testToolButtonStyleNoXmlGui()
{
QFETCH(Qt::ToolButtonStyle, toolButtonStyle);
const Qt::ToolButtonStyle mainToolBarDefaultStyle = Qt::ToolButtonTextBesideIcon; // was TextUnderIcon before KDE-4.4.0
const bool selectedDefaultForMainToolbar = toolButtonStyle == mainToolBarDefaultStyle;
const bool selectedDefaultForOtherToolbar = toolButtonStyle == Qt::ToolButtonTextBesideIcon;
KConfig config(QStringLiteral("tst_KToolBar"));
KConfigGroup group(&config, QStringLiteral("group"));
{
KMainWindow kmw;
KToolBar *mainToolBar = kmw.toolBar(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBar(QStringLiteral("otherToolBar"));
// Default settings (applied by applyAppearanceSettings)
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)mainToolBarDefaultStyle);
QCOMPARE((int)otherToolBar->toolButtonStyle(), (int)Qt::ToolButtonTextBesideIcon); // see r883541
QCOMPARE(kmw.toolBarArea(mainToolBar), Qt::TopToolBarArea);
// Changing settings for a given toolbar, as user
mainToolBar->setToolButtonStyle(toolButtonStyle);
otherToolBar->setToolButtonStyle(toolButtonStyle);
// Save settings
kmw.saveMainWindowSettings(group);
if (selectedDefaultForMainToolbar) {
QCOMPARE(group.groupList().count(), 0); // nothing to save
QVERIFY(!group.group(QStringLiteral("Toolbar mainToolBar")).hasKey("ToolButtonStyle"));
} else {
QCOMPARE(group.groupList().count(), 2); // two subgroups (one for each toolbar)
QVERIFY(group.group(QStringLiteral("Toolbar mainToolBar")).hasKey("ToolButtonStyle"));
}
}
{
// Recreate, load, compare.
KMainWindow kmw;
KToolBar *mainToolBar = kmw.toolBar(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBar(QStringLiteral("otherToolBar"));
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)mainToolBarDefaultStyle);
kmw.applyMainWindowSettings(group);
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)toolButtonStyle);
QCOMPARE((int)otherToolBar->toolButtonStyle(), (int)toolButtonStyle);
#ifdef WITH_QTDBUS // the change notification uses DBus
// Now change KDE-global setting
changeGlobalToolButtonStyleSetting(QStringLiteral("IconOnly"), QStringLiteral("TextOnly"));
if (selectedDefaultForMainToolbar) {
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)Qt::ToolButtonIconOnly);
} else {
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)toolButtonStyle);
}
if (selectedDefaultForOtherToolbar) {
QCOMPARE((int)otherToolBar->toolButtonStyle(), (int)Qt::ToolButtonTextOnly);
} else {
QCOMPARE((int)otherToolBar->toolButtonStyle(), (int)toolButtonStyle);
}
#endif
}
}
void tst_KToolBar::testToolButtonStyleXmlGui_data()
{
QTest::addColumn<Qt::ToolButtonStyle>("toolButtonStyle");
// Expected style after KDE-global is changed to main=IconOnly/other=TextOnly
QTest::addColumn<Qt::ToolButtonStyle>("expectedStyleMainToolbar");
QTest::addColumn<Qt::ToolButtonStyle>("expectedStyleOtherToolbar"); // xml says text-under-icons, user-selected should always win
QTest::addColumn<Qt::ToolButtonStyle>("expectedStyleCleanToolbar"); // should always follow kde-global -> always textonly.
QTest::newRow("Qt::ToolButtonTextUnderIcon") << Qt::ToolButtonTextUnderIcon << Qt::ToolButtonTextUnderIcon << Qt::ToolButtonTextUnderIcon
<< Qt::ToolButtonTextOnly;
QTest::newRow("Qt::ToolButtonTextBesideIcon") << Qt::ToolButtonTextBesideIcon
<< Qt::ToolButtonIconOnly /* was default -> using kde global */ << Qt::ToolButtonTextBesideIcon
<< Qt::ToolButtonTextOnly;
QTest::newRow("Qt::ToolButtonIconOnly") << Qt::ToolButtonIconOnly << Qt::ToolButtonIconOnly << Qt::ToolButtonIconOnly << Qt::ToolButtonTextOnly;
QTest::newRow("Qt::ToolButtonTextOnly") << Qt::ToolButtonTextOnly << Qt::ToolButtonTextOnly << Qt::ToolButtonTextOnly << Qt::ToolButtonTextOnly;
}
void tst_KToolBar::testToolButtonStyleXmlGui()
{
QFETCH(Qt::ToolButtonStyle, toolButtonStyle);
QFETCH(Qt::ToolButtonStyle, expectedStyleMainToolbar);
QFETCH(Qt::ToolButtonStyle, expectedStyleOtherToolbar);
QFETCH(Qt::ToolButtonStyle, expectedStyleCleanToolbar);
const Qt::ToolButtonStyle mainToolBarDefaultStyle = Qt::ToolButtonTextBesideIcon; // was TextUnderIcon before KDE-4.4.0
KConfig config(QStringLiteral("tst_KToolBar"));
KConfigGroup group(&config, QStringLiteral("group"));
{
TestXmlGuiWindow kmw(m_xml, "tst_ktoolbar.rc");
kmw.createActions(QStringList() << QStringLiteral("go_up"));
kmw.createGUI();
KToolBar *mainToolBar = kmw.toolBarByName(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBarByName(QStringLiteral("otherToolBar"));
KToolBar *cleanToolBar = kmw.toolBarByName(QStringLiteral("cleanToolBar"));
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)mainToolBarDefaultStyle);
QCOMPARE((int)otherToolBar->toolButtonStyle(), (int)Qt::ToolButtonTextUnderIcon); // from xml
QCOMPARE((int)cleanToolBar->toolButtonStyle(), (int)Qt::ToolButtonTextBesideIcon);
// Changing settings for a given toolbar, as user
mainToolBar->setToolButtonStyle(toolButtonStyle);
otherToolBar->setToolButtonStyle(toolButtonStyle);
// Save settings
kmw.saveMainWindowSettings(group);
#ifdef WITH_QTDBUS // the change notification uses DBus
// Now change KDE-global setting
changeGlobalToolButtonStyleSetting(QStringLiteral("IconOnly"), QStringLiteral("TextOnly"));
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)expectedStyleMainToolbar);
QCOMPARE((int)otherToolBar->toolButtonStyle(), (int)expectedStyleOtherToolbar);
QCOMPARE((int)cleanToolBar->toolButtonStyle(), (int)expectedStyleCleanToolbar);
#endif
}
}
void tst_KToolBar::changeGlobalToolButtonStyleSetting(const QString &mainToolBar, const QString &otherToolBars)
{
KConfigGroup group(KSharedConfig::openConfig(), QStringLiteral("Toolbar style"));
group.writeEntry("ToolButtonStyle", mainToolBar);
group.writeEntry("ToolButtonStyleOtherToolbars", otherToolBars);
group.sync();
// Same dbus connect as the one in KToolBar. We want our spy to be notified of receiving it.
#ifdef WITH_QTDBUS
QDBusConnection::sessionBus().connect(QString(),
QStringLiteral("/KToolBar"),
QStringLiteral("org.kde.KToolBar"),
QStringLiteral("styleChanged"),
this,
SIGNAL(signalAppearanceChanged()));
QSignalSpy spy(this, &tst_KToolBar::signalAppearanceChanged);
KToolBar::emitToolbarStyleChanged();
spy.wait(2000);
#endif
}
void tst_KToolBar::deleteGlobalToolButtonStyleSetting()
{
KConfigGroup group(KSharedConfig::openConfig(), QStringLiteral("Toolbar style"));
group.deleteEntry("ToolButtonStyle");
group.deleteEntry("ToolButtonStyleOtherToolbars");
KSharedConfig::openConfig()->sync();
}
void tst_KToolBar::testToolBarPosition()
{
TestXmlGuiWindow kmw(m_xml, "tst_ktoolbar.rc");
kmw.createActions(QStringList() << QStringLiteral("go_up"));
kmw.createGUI();
KToolBar *mainToolBar = kmw.toolBarByName(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = kmw.toolBarByName(QStringLiteral("otherToolBar"));
QCOMPARE(kmw.toolBarArea(mainToolBar), Qt::TopToolBarArea);
QCOMPARE(kmw.toolBarArea(otherToolBar), Qt::BottomToolBarArea);
}
void tst_KToolBar::testXmlGuiSwitching()
{
const QByteArray windowXml =
"<?xml version = '1.0'?>\n"
"<!DOCTYPE gui SYSTEM \"kpartgui.dtd\">\n"
"<gui version=\"1\" name=\"foo\" >\n"
"<MenuBar>\n"
"</MenuBar>\n"
"</gui>\n";
TestXmlGuiWindow kmw(windowXml, "tst_ktoolbar.rc");
kmw.createActions(QStringList() << QStringLiteral("go_up"));
kmw.createGUI();
TestGuiClient firstClient(m_xml);
kmw.guiFactory()->addClient(&firstClient);
{
// qDebug() << "Added gui client";
KToolBar *mainToolBar = firstClient.toolBarByName(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = firstClient.toolBarByName(QStringLiteral("otherToolBar"));
KToolBar *bigToolBar = firstClient.toolBarByName(QStringLiteral("bigToolBar"));
KToolBar *hiddenToolBar = firstClient.toolBarByName(QStringLiteral("hiddenToolBar"));
KToolBar *secondHiddenToolBar = firstClient.toolBarByName(QStringLiteral("secondHiddenToolBar"));
QCOMPARE(hiddenToolBar->isHidden(), true);
QCOMPARE(secondHiddenToolBar->isHidden(), true);
// Make (unsaved) changes as user
QMetaObject::invokeMethod(mainToolBar, "slotContextTextRight"); // mainToolBar->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
QMetaObject::invokeMethod(mainToolBar, "slotContextRight"); // kmw.addToolBar(Qt::RightToolBarArea, mainToolBar);
otherToolBar->setIconDimensions(35);
bigToolBar->setIconDimensions(35);
bigToolBar->hide();
hiddenToolBar->show();
}
kmw.guiFactory()->removeClient(&firstClient);
// qDebug() << "Removed gui client";
QVERIFY(!kmw.guiFactory()->container(QStringLiteral("mainToolBar"), &kmw));
QVERIFY(!kmw.guiFactory()->container(QStringLiteral("otherToolBar"), &kmw));
QVERIFY(!kmw.guiFactory()->container(QStringLiteral("bigToolBar"), &kmw));
QVERIFY(!kmw.guiFactory()->container(QStringLiteral("mainToolBar"), &firstClient));
QVERIFY(!kmw.guiFactory()->container(QStringLiteral("otherToolBar"), &firstClient));
QVERIFY(!kmw.guiFactory()->container(QStringLiteral("bigToolBar"), &firstClient));
kmw.guiFactory()->addClient(&firstClient);
// qDebug() << "Re-added gui client";
KToolBar *mainToolBar = firstClient.toolBarByName(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = firstClient.toolBarByName(QStringLiteral("otherToolBar"));
KToolBar *bigToolBar = firstClient.toolBarByName(QStringLiteral("bigToolBar"));
KToolBar *cleanToolBar = firstClient.toolBarByName(QStringLiteral("cleanToolBar"));
KToolBar *hiddenToolBar = firstClient.toolBarByName(QStringLiteral("hiddenToolBar"));
KToolBar *secondHiddenToolBar = firstClient.toolBarByName(QStringLiteral("secondHiddenToolBar"));
QCOMPARE((int)mainToolBar->toolButtonStyle(), (int)Qt::ToolButtonTextBesideIcon);
QCOMPARE(mainToolBar->isHidden(), false);
QCOMPARE(kmw.toolBarArea(mainToolBar), Qt::RightToolBarArea);
QCOMPARE(mainToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::MainToolbar));
QCOMPARE(otherToolBar->iconSize().width(), 35);
QCOMPARE(bigToolBar->iconSize().width(), 35);
QCOMPARE(cleanToolBar->iconSize().width(), KIconLoader::global()->currentSize(KIconLoader::Toolbar));
QCOMPARE(bigToolBar->isHidden(), true);
QCOMPARE(hiddenToolBar->isHidden(), false);
QCOMPARE(secondHiddenToolBar->isHidden(), true);
// Now save, and check what we saved
KConfig config(QStringLiteral("tst_KToolBar"));
KConfigGroup group(&config, QStringLiteral("group"));
kmw.saveMainWindowSettings(group);
QCOMPARE(group.group(QStringLiteral("Toolbar bigToolBar")).readEntry("IconSize", 0), 35);
QCOMPARE(group.group(QStringLiteral("Toolbar otherToolBar")).readEntry("IconSize", 0), 35);
QVERIFY(!group.group(QStringLiteral("Toolbar cleanToolBar")).hasKey("IconSize"));
// QCOMPARE(group.group("Toolbar bigToolBar").readEntry("Hidden", false), true);
// QVERIFY(!group.group("Toolbar cleanToolBar").hasKey("Hidden"));
// QVERIFY(!group.group("Toolbar hiddenToolBar").hasKey("Hidden"));
// Recreate window and apply config; is hidden toolbar shown as expected?
{
TestXmlGuiWindow kmw2(windowXml, "tst_ktoolbar.rc");
kmw2.createActions(QStringList() << QStringLiteral("go_up"));
kmw2.createGUI();
TestGuiClient firstClient(m_xml);
kmw2.guiFactory()->addClient(&firstClient);
KToolBar *mainToolBar = firstClient.toolBarByName(QStringLiteral("mainToolBar"));
KToolBar *otherToolBar = firstClient.toolBarByName(QStringLiteral("otherToolBar"));
KToolBar *bigToolBar = firstClient.toolBarByName(QStringLiteral("bigToolBar"));
KToolBar *hiddenToolBar = firstClient.toolBarByName(QStringLiteral("hiddenToolBar"));
KToolBar *secondHiddenToolBar = firstClient.toolBarByName(QStringLiteral("secondHiddenToolBar"));
QCOMPARE(bigToolBar->isHidden(), false);
QCOMPARE(hiddenToolBar->isHidden(), true);
QCOMPARE(secondHiddenToolBar->isHidden(), true);
kmw2.show();
// Check that secondHiddenToolBar is not shown+hidden immediately?
m_showWasCalled = false;
secondHiddenToolBar->installEventFilter(this);
kmw2.applyMainWindowSettings(group);
QCOMPARE(mainToolBar->isHidden(), false);
QCOMPARE(kmw2.toolBarArea(mainToolBar), Qt::RightToolBarArea);
QCOMPARE(otherToolBar->iconSize().width(), 35);
QCOMPARE(bigToolBar->iconSize().width(), 35);
QCOMPARE(bigToolBar->isHidden(), true);
QCOMPARE(hiddenToolBar->isHidden(), false);
QCOMPARE(secondHiddenToolBar->isHidden(), true);
QVERIFY(!m_showWasCalled);
}
}
void tst_KToolBar::testKAuthorizedDisableToggleAction()
{
TestXmlGuiWindow kmw(m_xml, "tst_ktoolbar.rc");
kmw.createGUI();
const auto toolbars = kmw.toolBars();
for (KToolBar *toolbar : toolbars) {
QVERIFY(!toolbar->toggleViewAction()->isEnabled());
}
}
bool tst_KToolBar::eventFilter(QObject *watched, QEvent *event)
{
Q_UNUSED(watched);
if (event->type() == QEvent::Show) {
m_showWasCalled = true;
return true;
}
return false;
}
#include "ktoolbar_unittest.moc"
|
