1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357
|
#!/usr/bin/env python3
import itertools
import os
import sys
from typing import Any, Callable, Iterable, Iterator, Optional, List, Union, Set # noqa
import pydnstest.augwrap
import pydnstest.matchpart
import pydnstest.scenario
Element = Union["Entry", "Step", pydnstest.scenario.Range]
RCODES = {"NOERROR", "FORMERR", "SERVFAIL", "NXDOMAIN", "NOTIMP", "REFUSED", "YXDOMAIN", "YXRRSET",
"NXRRSET", "NOTAUTH", "NOTZONE", "BADVERS", "BADSIG", "BADKEY", "BADTIME", "BADMODE",
"BADNAME", "BADALG", "BADTRUNC", "BADCOOKIE"}
FLAGS = {"QR", "AA", "TC", "RD", "RA", "AD", "CD"}
SECTIONS = {"question", "answer", "authority", "additional"}
class RplintError(ValueError):
def __init__(self, fails):
msg = ""
for fail in fails:
msg += str(fail) + "\n"
super().__init__(msg)
def get_line_number(file: str, char_number: int) -> int:
pos = 0
with open(file, encoding='utf-8') as f:
for number, line in enumerate(f):
pos += len(line)
if pos >= char_number:
return number + 2
return 0
def is_empty(iterable: Iterator[Any]) -> bool:
try:
next(iterable)
except StopIteration:
return True
return False
class Entry:
def __init__(self, node: pydnstest.augwrap.AugeasNode) -> None:
self.match = {m.value for m in node.match("/match")}
self.adjust = {a.value for a in node.match("/adjust")}
self.answer = list(node.match("/section/answer/record"))
self.authority = list(node.match("/section/authority/record"))
self.additional = list(node.match("/section/additional/record"))
self.reply = {r.value for r in node.match("/reply")}
self.records = list(node.match("/section/*/record"))
self.node = node
class Step:
def __init__(self, node: pydnstest.augwrap.AugeasNode) -> None:
self.node = node
self.type = node["/type"].value
try:
self.entry = Entry(node["/entry"]) # type: Optional[Entry]
except KeyError:
self.entry = None
class RplintFail:
def __init__(self, test: "RplintTest",
element: Optional[Element] = None,
etc: str = "") -> None:
self.path = test.path
self.element = element # type: Optional[Element]
self.line = get_line_number(self.path, element.node.char if element is not None else 0)
self.etc = etc
self.check = None # type: Optional[Callable[[RplintTest], List[RplintFail]]]
def __str__(self):
base_path = os.path.basename(self.path)
if self.etc:
return (
f"{base_path}:{self.line} {self.check.__name__}: "
f"{self.check.__doc__} ({self.etc})"
)
return (
f"{base_path}:{self.line} {self.check.__name__}: "
f"{self.check.__doc__}"
)
class RplintTest:
def __init__(self, path: str) -> None:
aug = pydnstest.augwrap.AugeasWrapper(confpath=os.path.realpath(path),
lens='Deckard',
loadpath=os.path.join(os.path.dirname(__file__),
'pydnstest'))
self.node = aug.tree
self.name = os.path.basename(path)
self.path = path
_, self.config = pydnstest.scenario.parse_file(os.path.realpath(path))
self.range_entries = [Entry(node) for node in self.node.match("/scenario/range/entry")]
self.steps = [Step(node) for node in self.node.match("/scenario/step")]
self.step_entries = [step.entry for step in self.steps if step.entry is not None]
self.entries = self.range_entries + self.step_entries
self.ranges = [pydnstest.scenario.Range(n) for n in self.node.match("/scenario/range")]
self.fails = None # type: Optional[List[RplintFail]]
self.checks = [
entry_more_than_one_rcode,
entry_no_qname_qtype_copy_query,
# Commented out for now until we implement selective turning off of checks
# entry_ns_in_authority,
range_overlapping_ips,
range_shadowing_match_rules,
step_check_answer_no_match,
step_query_match,
step_query_sections,
step_query_qr,
step_section_unchecked,
step_unchecked_match,
step_unchecked_rcode,
scenario_ad_or_rrsig_no_ta,
scenario_timestamp,
config_trust_anchor_trailing_period_missing,
step_duplicate_id,
]
def run_checks(self) -> bool:
"""returns True iff all tests passed"""
self.fails = []
for check in self.checks:
fails = check(self)
for fail in fails:
fail.check = check
self.fails += fails
if self.fails == []:
return True
return False
def print_fails(self) -> None:
if self.fails is None:
raise RuntimeError("Maybe you should run some test first…")
for fail in self.fails:
print(fail)
def config_trust_anchor_trailing_period_missing(test: RplintTest) -> List[RplintFail]:
"""Trust-anchor option in configuration contains domain without trailing period"""
for conf in test.config:
if conf[0] == "trust-anchor":
if conf[1].split()[0][-1] != ".":
return [RplintFail(test, etc=conf[1])]
return []
def scenario_timestamp(test: RplintTest) -> List[RplintFail]:
"""RRSSIG record present in test but no val-override-date or val-override-timestamp in config"""
rrsigs = []
for entry in test.entries:
for record in entry.records:
if record["/type"].value == "RRSIG":
rrsigs.append(RplintFail(test, entry))
if rrsigs:
for k in test.config:
if k[0] == "val-override-date" or k[0] == "val-override-timestamp":
return []
return rrsigs
def entry_no_qname_qtype_copy_query(test: RplintTest) -> List[RplintFail]:
"""ENTRY without qname and qtype in MATCH and without copy_query in ADJUST"""
fails = []
for entry in test.range_entries:
if "question" not in entry.match and ("qname" not in entry.match or
"qtype" not in entry.match):
if "copy_query" not in entry.adjust:
fails.append(RplintFail(test, entry))
return fails
def entry_ns_in_authority(test: RplintTest) -> List[RplintFail]:
"""ENTRY has authority section with NS records, consider using MATCH subdomain"""
fails = []
for entry in test.range_entries:
if entry.authority and "subdomain" not in entry.match:
for record in entry.authority:
if record["/type"].value == "NS":
fails.append(RplintFail(test, entry))
return fails
def entry_more_than_one_rcode(test: RplintTest) -> List[RplintFail]:
"""ENTRY has more than one rcode in MATCH"""
fails = []
for entry in test.entries:
if len(RCODES & entry.reply) > 1:
fails.append(RplintFail(test, entry))
return fails
def scenario_ad_or_rrsig_no_ta(test: RplintTest) -> List[RplintFail]:
"""AD or RRSIG present in test but no trust-anchor present in config"""
dnssec = []
for entry in test.entries:
if "AD" in entry.reply or "AD" in entry.match:
dnssec.append(RplintFail(test, entry))
else:
for record in entry.records:
if record["/type"].value == "RRSIG":
dnssec.append(RplintFail(test, entry))
if dnssec:
for k in test.config:
if k[0] == "trust-anchor":
return []
return dnssec
def step_query_match(test: RplintTest) -> List[RplintFail]:
"""STEP QUERY has a MATCH rule"""
return [RplintFail(test, step) for step in test.steps if step.type == "QUERY" and
step.entry and step.entry.match]
def step_query_sections(test: RplintTest) -> List[RplintFail]:
"""STEP QUERY has some records in sections other than QUESTION"""
return [RplintFail(test, step) for step in test.steps if step.type == "QUERY" and
step.entry and (step.entry.answer or step.entry.authority or step.entry.additional)]
def step_query_qr(test: RplintTest) -> List[RplintFail]:
"""STEP QUERY specified QR=1 flag (i.e. message is an answer)"""
return [RplintFail(test, step) for step in test.steps if step.type == "QUERY" and
step.entry and step.entry.reply and 'QR' in step.entry.reply]
def step_check_answer_no_match(test: RplintTest) -> List[RplintFail]:
"""ENTRY in STEP CHECK_ANSWER has no MATCH rule"""
return [RplintFail(test, step) for step in test.steps if step.type == "CHECK_ANSWER" and
step.entry and not step.entry.match]
def step_unchecked_rcode(test: RplintTest) -> List[RplintFail]:
"""ENTRY specifies rcode but STEP MATCH does not check for it."""
fails = []
for step in test.steps:
if step.type == "CHECK_ANSWER" and step.entry and "all" not in step.entry.match:
if step.entry.reply & RCODES and "rcode" not in step.entry.match:
fails.append(RplintFail(test, step.entry))
return fails
def step_unchecked_match(test: RplintTest) -> List[RplintFail]:
"""ENTRY specifies flags but MATCH does not check for them"""
fails = []
for step in test.steps:
if step.type == "CHECK_ANSWER":
entry = step.entry
if entry and "all" not in entry.match and entry.reply - RCODES and \
"flags" not in entry.match:
fails.append(RplintFail(test, entry, str(entry.reply - RCODES)))
return fails
def step_section_unchecked(test: RplintTest) -> List[RplintFail]:
"""ENTRY has non-empty sections but MATCH does not check for all of them"""
fails = []
for step in test.steps:
if step.type == "CHECK_ANSWER" and step.entry and "all" not in step.entry.match:
for section in SECTIONS:
if not is_empty(step.node.match("/entry/section/" + section + "/*")):
if section not in step.entry.match:
fails.append(RplintFail(test, step.entry, section))
return fails
def range_overlapping_ips(test: RplintTest) -> List[RplintFail]:
"""RANGE has common IPs with some previous overlapping RANGE"""
fails = []
for r1, r2 in itertools.combinations(test.ranges, 2):
# If the ranges overlap
if min(r1.b, r2.b) >= max(r1.a, r2.a):
if r1.addresses & r2.addresses:
info = f"previous range on line {get_line_number(test.path, r1.node.char)}"
fails.append(RplintFail(test, r2, info))
return fails
def range_shadowing_match_rules(test: RplintTest) -> List[RplintFail]:
"""ENTRY has no effect since one of previous entries has the same or broader match rules"""
fails = []
for r in test.ranges:
for e1, e2 in itertools.combinations(r.stored, 2):
try:
e1.match(e2.message)
except ValueError:
pass
else:
info = f"previous entry on line {get_line_number(test.path, e1.node.char)}"
if e1.match_fields > e2.match_fields:
continue
if "subdomain" not in e1.match_fields and "subdomain" in e2.match_fields:
continue
fails.append(RplintFail(test, e2, info))
return fails
def step_duplicate_id(test: RplintTest) -> List[RplintFail]:
"""STEP has the same ID as one of previous ones"""
fails = []
step_numbers = set() # type: Set[int]
for step in test.steps:
if step.node.value in step_numbers:
fails.append(RplintFail(test, step))
else:
step_numbers.add(step.node.value)
return fails
# TODO: This will make sense after we fix how we handle defaults in deckard.aug and scenario.py
# We might just not use defaults altogether as testbound does
# if "copy_id" not in adjust:
# entry_error(test, entry, "copy_id should be in ADJUST")
def test_run_rplint(rpl_path: str) -> None:
t = RplintTest(rpl_path)
passed = t.run_checks()
if not passed:
raise RplintError(t.fails)
def main():
try:
test_path = sys.argv[1]
except IndexError:
print(f"usage: {sys.argv[0]} <path to rpl file>")
sys.exit(2)
if not os.path.isfile(test_path):
print("rplint.py works on single file only.")
print("Use rplint.sh with --scenarios=<directory with rpls> to run on rpls.")
sys.exit(2)
print(f"Linting {test_path}")
t = RplintTest(test_path)
passed = t.run_checks()
t.print_fails()
if passed:
sys.exit(0)
sys.exit(1)
if __name__ == '__main__':
main()
|