1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
|
//@HEADER
// ************************************************************************
//
// Kokkos v. 4.0
// Copyright (2022) National Technology & Engineering
// Solutions of Sandia, LLC (NTESS).
//
// Under the terms of Contract DE-NA0003525 with NTESS,
// the U.S. Government retains certain rights in this software.
//
// Part of Kokkos, under the Apache License v2.0 with LLVM Exceptions.
// See https://kokkos.org/LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//@HEADER
#include <Kokkos_Core.hpp>
#include <thread>
namespace {
#ifdef KOKKOS_COMPILER_NVHPC
#define THREAD_SAFETY_TEST_UNREACHABLE() __builtin_unreachable()
#else
#define THREAD_SAFETY_TEST_UNREACHABLE() static_assert(true)
#endif
#ifdef KOKKOS_ENABLE_OPENMP
template <class Lambda1, class Lambda2>
void run_threaded_test(const Lambda1 l1, const Lambda2 l2) {
if (omp_get_max_threads() < 2)
GTEST_SKIP() << "insufficient number of supported concurrent threads";
#pragma omp parallel num_threads(2)
{
if (omp_get_thread_num() == 0) l1();
if (omp_get_thread_num() == 1) l2();
}
}
// We cannot run the multithreaded test when threads or HPX is enabled because
// we cannot launch a thread from inside another thread
#elif !defined(KOKKOS_ENABLE_THREADS) && !defined(KOKKOS_ENABLE_HPX)
template <class Lambda1, class Lambda2>
void run_threaded_test(const Lambda1 l1, const Lambda2 l2) {
std::thread t1(l1);
std::thread t2(l2);
t1.join();
t2.join();
}
#else
template <class Lambda1, class Lambda2>
void run_threaded_test(const Lambda1 l1, const Lambda2 l2) {
l1();
l2();
}
#endif
// The idea for all of these tests is to access a View from kernels submitted by
// two different threads to the same execution space instance. If the kernels
// are executed concurrently, we expect to count too many increments.
void run_exec_space_thread_safety_range() {
constexpr int N = 10000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_for(
Kokkos::RangePolicy<TEST_EXECSPACE>(exec, 0, 1), KOKKOS_LAMBDA(int) {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N)
Kokkos::atomic_store(error.data(), 1);
});
}
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_range) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
#ifdef KOKKOS_ENABLE_OPENMPTARGET
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail for OpenMPTarget";
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_range();
}
void run_exec_space_thread_safety_mdrange() {
constexpr int N = 1000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_for(
Kokkos::MDRangePolicy<TEST_EXECSPACE, Kokkos::Rank<2>>(exec, {0, 0},
{1, 1}),
KOKKOS_LAMBDA(int, int) {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N)
Kokkos::atomic_store(error.data(), 1);
});
}
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_mdrange) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
#ifdef KOKKOS_ENABLE_OPENMPTARGET
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail for OpenMPTarget";
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_mdrange();
}
void run_exec_space_thread_safety_team_policy() {
constexpr int N = 1000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_for(
Kokkos::TeamPolicy<TEST_EXECSPACE>(exec, 1, 1, 1),
KOKKOS_LAMBDA(const Kokkos::TeamPolicy<TEST_EXECSPACE>::member_type
&team_member) {
Kokkos::single(Kokkos::PerTeam(team_member), [=]() {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N)
Kokkos::atomic_store(error.data(), 1);
});
});
}
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_team_policy) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
// FIXME_OPENMPTARGET
#ifdef KOKKOS_ENABLE_OPENMPTARGET
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping for OpenMPTarget since the test is designed to "
"run with vector_length=1";
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_team_policy();
}
void run_exec_space_thread_safety_range_reduce() {
constexpr int N = 1000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_reduce(
Kokkos::RangePolicy<TEST_EXECSPACE>(exec, 0, 1),
KOKKOS_LAMBDA(int, int &update) {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N) ++update;
},
error);
}
exec.fence();
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_range_reduce) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_range_reduce();
}
void run_exec_space_thread_safety_mdrange_reduce() {
constexpr int N = 1000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_reduce(
Kokkos::MDRangePolicy<TEST_EXECSPACE, Kokkos::Rank<2>>(exec, {0, 0},
{1, 1}),
KOKKOS_LAMBDA(int, int, int &update) {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N) ++update;
},
error);
}
exec.fence();
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_mdrange_reduce) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_mdrange_reduce();
}
void run_exec_space_thread_safety_team_policy_reduce() {
constexpr int N = 1000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_reduce(
Kokkos::TeamPolicy<TEST_EXECSPACE>(exec, 1, 1, 1),
KOKKOS_LAMBDA(const Kokkos::TeamPolicy<TEST_EXECSPACE>::member_type
&team_member,
int &update) {
Kokkos::single(Kokkos::PerTeam(team_member), [=, &update]() {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N) ++update;
});
},
error);
}
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_team_policy_reduce) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
// FIXME_OPENMPTARGET
#ifdef KOKKOS_ENABLE_OPENMPTARGET
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping for OpenMPTarget since the test is designed to "
"run with vector_length=1";
#endif
// FIXME_SYCL
#if defined(KOKKOS_ENABLE_SYCL) && defined(KOKKOS_IMPL_ARCH_NVIDIA_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::SYCL>)
GTEST_SKIP() << "skipping since test is know to fail with SYCL+Cuda";
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_team_policy_reduce();
}
void run_exec_space_thread_safety_range_scan() {
constexpr int N = 1000000;
constexpr int M = 10;
Kokkos::View<int, TEST_EXECSPACE> view("view");
Kokkos::View<int, TEST_EXECSPACE> error("error");
auto lambda = [=]() {
TEST_EXECSPACE exec;
for (int j = 0; j < M; ++j) {
Kokkos::parallel_scan(
Kokkos::RangePolicy<TEST_EXECSPACE>(exec, 0, 1),
KOKKOS_LAMBDA(int, int &, const bool final) {
if (final) {
Kokkos::atomic_store(view.data(), 0);
for (int i = 0; i < N; ++i) Kokkos::atomic_inc(view.data());
if (Kokkos::atomic_load(view.data()) != N)
Kokkos::atomic_store(error.data(), 1);
}
});
}
exec.fence();
};
run_threaded_test(lambda, lambda);
auto host_error =
Kokkos::create_mirror_view_and_copy(Kokkos::HostSpace{}, error);
ASSERT_EQ(host_error(), 0);
}
TEST(TEST_CATEGORY, exec_space_thread_safety_range_scan) {
#ifdef KOKKOS_ENABLE_OPENACC // FIXME_OPENACC
GTEST_SKIP()
<< "skipping OpenACC test since unsupported host-side atomics cause "
"race conditions during shared allocation reference counting";
THREAD_SAFETY_TEST_UNREACHABLE();
#endif
#ifdef KOKKOS_ENABLE_IMPL_SYCL_OUT_OF_ORDER_QUEUES // FIXME_SYCL
GTEST_SKIP()
<< "skipping since tests are known to fail with out-of-order queues";
#endif
run_exec_space_thread_safety_range_scan();
}
} // namespace
|
