1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
|
/*
SPDX-FileCopyrightText: 2007 Bertjan Broeksema <b.broeksema@kdemail.net>
SPDX-License-Identifier: LGPL-2.0-or-later
*/
#include "plasmoidpackagetest.h"
#include "../src/kpackage/config-package.h"
#include "../src/kpackage/private/versionparser.cpp"
#include <KJob>
#include <QDir>
#include <QFile>
#include <QSignalSpy>
#include <QStandardPaths>
#include <kzip.h>
#include <QDebug>
#include <QJsonDocument>
#include <QJsonObject>
#include "packageloader.h"
#include "packagestructures/plasmoidstructure.h"
#include "private/utils.h"
void PlasmoidPackageTest::initTestCase()
{
QStandardPaths::setTestModeEnabled(true);
}
void PlasmoidPackageTest::init()
{
qDebug() << "PlasmoidPackage::init()";
m_package = QStringLiteral("Package");
m_packageRoot = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + "/packageRoot";
m_defaultPackage = KPackage::Package(new KPackage::PlasmoidPackage);
cleanup(); // to prevent previous runs from interfering with this one
}
void PlasmoidPackageTest::cleanup()
{
qDebug() << "cleaning up";
// Clean things up.
QDir(m_packageRoot).removeRecursively();
}
void PlasmoidPackageTest::createTestPackage(const QString &packageName, const QString &version)
{
qDebug() << "Create test package" << m_packageRoot;
QDir pRoot(m_packageRoot);
// Create the root and package dir.
if (!pRoot.exists()) {
QVERIFY(QDir().mkpath(m_packageRoot));
}
// Create the package dir
QVERIFY(QDir().mkpath(m_packageRoot + "/" + packageName));
qDebug() << "Created" << (m_packageRoot + "/" + packageName);
// Create the metadata.json file
QFile file(m_packageRoot + "/" + packageName + "/metadata.json");
QVERIFY(file.open(QIODevice::WriteOnly));
QJsonObject kplugin;
kplugin.insert(QLatin1String("Id"), packageName);
kplugin.insert(QLatin1String("Name"), packageName);
kplugin.insert(QLatin1String("Version"), version);
QJsonObject root{{QLatin1String("KPlugin"), kplugin}};
QTextStream out(&file);
file.write(QJsonDocument(root).toJson());
file.flush();
file.close();
qDebug() << "OUT: " << packageName;
// Create the ui dir.
QVERIFY(QDir().mkpath(m_packageRoot + "/" + packageName + "/contents/ui"));
// Create the main file.
file.setFileName(m_packageRoot + "/" + packageName + "/contents/ui/main.qml");
QVERIFY(file.open(QIODevice::WriteOnly));
out << "THIS IS A PLASMOID SCRIPT.....";
file.flush();
file.close();
qDebug() << "THIS IS A PLASMOID SCRIPT THING";
// Now we have a minimal plasmoid package which is valid. Let's add some
// files to it for test purposes.
// Create the images dir.
QVERIFY(QDir().mkpath(m_packageRoot + "/" + packageName + "/contents/images"));
file.setFileName(m_packageRoot + "/" + packageName + "/contents/images/image-1.svg");
QVERIFY(file.open(QIODevice::WriteOnly));
out << "<svg>This is a test image</svg>";
file.flush();
file.close();
file.setFileName(m_packageRoot + "/" + packageName + "/contents/images/image-2.svg");
QVERIFY(file.open(QIODevice::WriteOnly));
out.setDevice(&file);
out << "<svg>This is another test image</svg>";
file.flush();
file.close();
// Create the scripts dir.
QVERIFY(QDir().mkpath(m_packageRoot + "/" + packageName + "/contents/code"));
// Create 2 js files
file.setFileName(m_packageRoot + "/" + packageName + "/contents/code/script.js");
QVERIFY(file.open(QIODevice::WriteOnly));
out << "THIS IS A SCRIPT.....";
file.flush();
file.close();
}
void PlasmoidPackageTest::isValid()
{
KPackage::Package *p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
#ifndef NDEBUG
qDebug() << "package path is" << p->path();
#endif
// A PlasmoidPackage is valid when:
// - The package root exists.
// - The package root consists an file named "ui/main.qml"
QVERIFY(!p->isValid());
// Create the root and package dir.
QVERIFY(QDir().mkpath(m_packageRoot));
QVERIFY(QDir().mkpath(m_packageRoot + "/" + m_package));
// Should still be invalid.
delete p;
p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
QVERIFY(!p->isValid());
// Create the metadata.json file.
QFile file(m_packageRoot + "/" + m_package + "/metadata.json");
QVERIFY(file.open(QIODevice::WriteOnly));
QTextStream out(&file);
out << "[Desktop Entry]\n";
out << "Name=test\n";
out << "Description=Just a test desktop file";
file.flush();
file.close();
// Create the ui dir.
QVERIFY(QDir().mkpath(m_packageRoot + "/" + m_package + "/contents/ui"));
// No main file yet so should still be invalid.
delete p;
p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
QVERIFY(!p->isValid());
// Create the main file.
file.setFileName(m_packageRoot + "/" + m_package + "/contents/ui/main.qml");
QVERIFY(file.open(QIODevice::WriteOnly));
out.setDevice(&file);
out << "THIS IS A PLASMOID SCRIPT.....\n";
file.flush();
file.close();
file.setPermissions(QFile::ReadUser | QFile::WriteUser);
// Main file exists so should be valid now.
delete p;
p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
QVERIFY(p->isValid());
#if KPACKAGE_ENABLE_DEPRECATED_SINCE(5, 21)
QCOMPARE(p->contentsHash(), QStringLiteral("a41160c6a763ea505c95bee12a7fc87952a61cf1"));
#endif
QCOMPARE(p->cryptographicHash(QCryptographicHash::Sha1), QByteArrayLiteral("a41160c6a763ea505c95bee12a7fc87952a61cf1"));
delete p;
}
void PlasmoidPackageTest::filePath()
{
return;
// Package::filePath() returns
// - {package_root}/{package_name}/path/to/file if the file exists
// - QString() otherwise.
KPackage::Package *p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
QCOMPARE(p->filePath("scripts", QStringLiteral("main")), QString());
QVERIFY(QDir().mkpath(m_packageRoot + "/" + m_package + "/contents/ui/main.qml"));
QFile file(m_packageRoot + "/" + m_package + "/contents/ui/main.qml");
QVERIFY(file.open(QIODevice::WriteOnly));
QTextStream out(&file);
out << "THIS IS A PLASMOID SCRIPT.....";
file.flush();
file.close();
// The package is valid by now so a path for code/main should get returned.
delete p;
p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
const QString path = QFileInfo(m_packageRoot + "/" + m_package + "/contents/ui/main.qml").canonicalFilePath();
// Two ways to get the same info.
// 1. Give the file type which refers to a class of files (a directory) in
// the package structure and the file name.
// 2. Give the file type which refers to a file in the package structure.
//
// NOTE: scripts, main and mainscript are defined in packages.cpp and are
// specific for a PlasmoidPackage.
QCOMPARE(p->filePath("scripts", QStringLiteral("main")), path);
QCOMPARE(p->filePath("mainscript"), path);
delete p;
}
void PlasmoidPackageTest::entryList()
{
// Create a package named @p packageName which is valid and has some images.
createTestPackage(m_package, QStringLiteral("1.1"));
// Create a package object and verify that it is valid.
KPackage::Package *p = new KPackage::Package(m_defaultPackage);
p->setPath(m_packageRoot + '/' + m_package);
QVERIFY(p->isValid());
// Now we have a valid package that should contain the following files in
// given filetypes:
// fileTye - Files
// scripts - {"script.js"}
// images - {"image-1.svg", "image-2.svg"}
QStringList files = p->entryList("scripts");
QCOMPARE(files.size(), 1);
QVERIFY(files.contains(QStringLiteral("script.js")));
files = p->entryList("images");
QCOMPARE(files.size(), 2);
QVERIFY(files.contains(QStringLiteral("image-1.svg")));
QVERIFY(files.contains(QStringLiteral("image-2.svg")));
delete p;
}
void PlasmoidPackageTest::createAndInstallPackage()
{
qDebug() << " ";
qDebug() << " CreateAndInstall ";
createTestPackage(QStringLiteral("plasmoid_to_package"), QStringLiteral("1.1"));
const QString packagePath = m_packageRoot + '/' + "testpackage.plasmoid";
KZip creator(packagePath);
QVERIFY(creator.open(QIODevice::WriteOnly));
creator.addLocalDirectory(m_packageRoot + '/' + "plasmoid_to_package", QStringLiteral("."));
creator.close();
QDir rootDir(m_packageRoot + "/plasmoid_to_package");
rootDir.removeRecursively();
QVERIFY2(QFile::exists(packagePath), qPrintable(packagePath));
KZip package(packagePath);
QVERIFY(package.open(QIODevice::ReadOnly));
const KArchiveDirectory *dir = package.directory();
QVERIFY(dir); //
QVERIFY(dir->entry(QStringLiteral("metadata.json")));
const KArchiveEntry *contentsEntry = dir->entry(QStringLiteral("contents"));
QVERIFY(contentsEntry);
QVERIFY(contentsEntry->isDirectory());
const KArchiveDirectory *contents = static_cast<const KArchiveDirectory *>(contentsEntry);
QVERIFY(contents->entry(QStringLiteral("ui")));
QVERIFY(contents->entry(QStringLiteral("images")));
m_defaultPackageStructure = new KPackage::PackageStructure(this);
KPackage::Package *p = new KPackage::Package(m_defaultPackageStructure);
qDebug() << "Installing " << packagePath;
// const QString packageRoot = "plasma/plasmoids/";
// const QString servicePrefix = "plasma-applet-";
KJob *job = p->install(packagePath, m_packageRoot);
// clang-format off
connect(job, SIGNAL(finished(KJob*)), SLOT(packageInstalled(KJob*)));
QSignalSpy spy(job, SIGNAL(finished(KJob*)));
// clang-format on
QVERIFY(spy.wait(1000));
// is the package instance usable (ie proper path) after the install job has been completed?
QCOMPARE(p->path(), QString(QDir(m_packageRoot % "/plasmoid_to_package").canonicalPath() + QLatin1Char('/')));
cleanupPackage(QStringLiteral("plasmoid_to_package"));
// QVERIFY(p->isValid());
delete p;
}
void PlasmoidPackageTest::noCrashOnAsyncInstall()
{
createTestPackage(QStringLiteral("plasmoid_to_package"), QStringLiteral("1.1"));
const QString packagePath = m_packageRoot + '/' + "testpackage.plasmoid";
KZip creator(packagePath);
QVERIFY(creator.open(QIODevice::WriteOnly));
creator.addLocalDirectory(m_packageRoot + '/' + "plasmoid_to_package", QStringLiteral("."));
creator.close();
QDir rootDir(m_packageRoot + "/plasmoid_to_package");
rootDir.removeRecursively();
KJob *job;
// scope the package so it will get deleted before the install operation finishes
// package is explicitlyshared internally and designed to be used on the stack
// see #370718
{
KPackage::Package package(new KPackage::PackageStructure(this));
job = package.install(packagePath, m_packageRoot);
}
// clang-format off
connect(job, SIGNAL(finished(KJob*)), SLOT(packageInstalled(KJob*)));
QSignalSpy spy(job, SIGNAL(finished(KJob*)));
// clang-format on
QVERIFY(spy.wait(1000));
cleanupPackage(QStringLiteral("plasmoid_to_package"));
}
void PlasmoidPackageTest::createAndUpdatePackage()
{
// does the version number parsing work?
QVERIFY(KPackage::isVersionNewer(QStringLiteral("1.1"), QStringLiteral("1.1.1")));
QVERIFY(!KPackage::isVersionNewer(QStringLiteral("1.1.1"), QStringLiteral("1.1")));
QVERIFY(KPackage::isVersionNewer(QStringLiteral("1.1.1"), QStringLiteral("1.1.2")));
QVERIFY(KPackage::isVersionNewer(QStringLiteral("1.1.2"), QStringLiteral("2.1")));
QVERIFY(KPackage::isVersionNewer(QStringLiteral("0.1.2"), QStringLiteral("2")));
QVERIFY(!KPackage::isVersionNewer(QStringLiteral("1"), QStringLiteral("0.1.2")));
qDebug() << " ";
qDebug() << " CreateAndUpdate ";
createTestPackage(QStringLiteral("plasmoid_to_package"), QStringLiteral("1.1"));
const QString packagePath = m_packageRoot + '/' + "testpackage.plasmoid";
KZip creator(packagePath);
QVERIFY(creator.open(QIODevice::WriteOnly));
creator.addLocalDirectory(m_packageRoot + '/' + "plasmoid_to_package", QStringLiteral("."));
creator.close();
QDir rootDir(m_packageRoot + "/plasmoid_to_package");
rootDir.removeRecursively();
QVERIFY(QFile::exists(packagePath));
KZip package(packagePath);
QVERIFY(package.open(QIODevice::ReadOnly));
const KArchiveDirectory *dir = package.directory();
QVERIFY(dir); //
QVERIFY(dir->entry(QStringLiteral("metadata.json")));
const KArchiveEntry *contentsEntry = dir->entry(QStringLiteral("contents"));
QVERIFY(contentsEntry);
QVERIFY(contentsEntry->isDirectory());
const KArchiveDirectory *contents = static_cast<const KArchiveDirectory *>(contentsEntry);
QVERIFY(contents->entry(QStringLiteral("ui")));
QVERIFY(contents->entry(QStringLiteral("images")));
m_defaultPackageStructure = new KPackage::PackageStructure(this);
KPackage::Package *p = new KPackage::Package(m_defaultPackageStructure);
qDebug() << "Installing " << packagePath;
// const QString packageRoot = "plasma/plasmoids/";
// const QString servicePrefix = "plasma-applet-";
// clang-format off
KJob *job = p->update(packagePath, m_packageRoot);
connect(job, SIGNAL(finished(KJob*)), SLOT(packageInstalled(KJob*)));
QSignalSpy spy(job, SIGNAL(finished(KJob*)));
QVERIFY(spy.wait(1000));
// same version, should fail
job = p->update(packagePath, m_packageRoot);
QSignalSpy spyFail(job, SIGNAL(finished(KJob*)));
QVERIFY(spyFail.wait(1000));
QVERIFY(job->error() == KPackage::Package::JobError::NewerVersionAlreadyInstalledError);
qDebug()<<job->errorText();
// create a new package with higher version
createTestPackage(QStringLiteral("plasmoid_to_package"), QStringLiteral("1.2"));
KZip creator2(packagePath);
QVERIFY(creator2.open(QIODevice::WriteOnly));
creator2.addLocalDirectory(m_packageRoot + '/' + "plasmoid_to_package", QStringLiteral("."));
creator2.close();
QDir rootDir2(m_packageRoot + "/plasmoid_to_package");
rootDir2.removeRecursively();
KJob *job2 = p->update(packagePath, m_packageRoot);
connect(job2, SIGNAL(finished(KJob*)), SLOT(packageInstalled(KJob*)));
QSignalSpy spy2(job2, SIGNAL(finished(KJob*)));
QVERIFY(spy2.wait(1000));
// clang-format on
cleanupPackage(QStringLiteral("plasmoid_to_package"));
// QVERIFY(p->isValid());
delete p;
}
void PlasmoidPackageTest::uncompressPackageWithSubFolder()
{
KPackage::PackageStructure *structure = new KPackage::PackageStructure;
KPackage::Package package(structure);
package.setPath(QFINDTESTDATA("data/customcontent.tar.gz"));
// if metadata is correctly found, servicetypes should be ("SimpleContent", "CustomContent")
QCOMPARE(readKPackageTypes(package.metadata()), QStringList({"SimpleContent", "CustomContent"}));
}
void PlasmoidPackageTest::cleanupPackage(const QString &packageName)
{
KPackage::Package *p = new KPackage::Package(m_defaultPackageStructure);
KJob *jj = p->uninstall(packageName, m_packageRoot);
connect(jj, SIGNAL(finished(KJob *)), SLOT(packageUninstalled(KJob *)));
QSignalSpy spy(jj, &KJob::finished);
QVERIFY(spy.wait(1000));
}
void PlasmoidPackageTest::packageInstalled(KJob *j)
{
QVERIFY2(j->error() == KJob::NoError, qPrintable(j->errorText()));
}
void PlasmoidPackageTest::packageUninstalled(KJob *j)
{
QVERIFY2(j->error() == KJob::NoError, qPrintable(j->errorText()));
}
QTEST_MAIN(PlasmoidPackageTest)
#include "moc_plasmoidpackagetest.cpp"
|