1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
|
/*
SPDX-FileCopyrightText: 2016 Volker Krause <vkrause@kde.org>
SPDX-License-Identifier: MIT
*/
#include <provider.h>
#include <platforminfosource.h>
#include <screeninfosource.h>
#include <startcountsource.h>
#include <QDebug>
#include <QtTest/qtest.h>
#include <QObject>
#include <QSettings>
#include <QSignalSpy>
#include <QStandardPaths>
using namespace KUserFeedback;
class ProviderTest : public QObject
{
Q_OBJECT
private slots:
void initTestCase()
{
QCoreApplication::setOrganizationName(QStringLiteral("KDE"));
QCoreApplication::setOrganizationDomain(QStringLiteral("kde.org"));
QCoreApplication::setApplicationName(QStringLiteral("providertest"));
QStandardPaths::setTestModeEnabled(true);
}
void init()
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
s.remove(QLatin1String("Enabled"));
}
void testProductId()
{
Provider p;
QCOMPARE(p.productIdentifier(), QLatin1String("org.kde.providertest"));
}
void testNoTelemetry()
{
Provider provider;
provider.setProductIdentifier(QStringLiteral("org.kde.UserFeedback.UnitTestProduct"));
provider.addDataSource(new ScreenInfoSource);
provider.addDataSource(new PlatformInfoSource);
provider.setTelemetryMode(Provider::NoTelemetry);
QByteArray b;
QMetaObject::invokeMethod(&provider, "jsonData", Q_RETURN_ARG(QByteArray, b), Q_ARG(KUserFeedback::Provider::TelemetryMode, provider.telemetryMode()));
b.replace('\n', "");
QCOMPARE(b.constData(), "{}");
}
void testLoadStore()
{
{
Provider p;
p.setTelemetryMode(Provider::NoTelemetry);
p.setSurveyInterval(-1);
}
{
Provider p;
QCOMPARE(p.telemetryMode(), Provider::NoTelemetry);
QCOMPARE(p.surveyInterval(), -1);
p.setTelemetryMode(Provider::DetailedSystemInformation);
p.setSurveyInterval(90);
}
{
Provider p;
QCOMPARE(p.telemetryMode(), Provider::DetailedSystemInformation);
QCOMPARE(p.surveyInterval(), 90);
}
}
void testEncouragement()
{
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
}
{
Provider p;
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
QVERIFY(!spy.wait(10));
p.setApplicationStartsUntilEncouragement(0);
p.setApplicationUsageTimeUntilEncouragement(0);
QVERIFY(spy.wait(10));
QCOMPARE(spy.count(), 1);
}
{
Provider p;
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setApplicationUsageTimeUntilEncouragement(0);
QVERIFY(!spy.wait(10));
}
}
void testEncouragementDelay()
{
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
}
{
Provider p;
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(1);
p.setApplicationStartsUntilEncouragement(0);
p.setApplicationUsageTimeUntilEncouragement(0);
QVERIFY(!spy.wait(10));
QVERIFY(spy.wait(1200));
QCOMPARE(spy.count(), 1);
}
}
void testNoEncouragementWithAllFeedbackEnabled()
{
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
}
{
Provider p;
p.addDataSource(new PlatformInfoSource);
p.setSurveyInterval(0);
p.setTelemetryMode(Provider::BasicSystemInformation);
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setApplicationUsageTimeUntilEncouragement(0);
QVERIFY(!spy.wait(10));
QCOMPARE(spy.count(), 0);
}
}
void testEncouragementRepetition()
{
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.setValue(QLatin1String("LastEncouragement"), QDateTime::currentDateTime().addSecs(-24 * 60 * 60 + 1));
}
{
Provider p;
p.setSurveyInterval(-1);
p.setTelemetryMode(Provider::NoTelemetry);
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setEncouragementInterval(1);
QVERIFY(spy.wait(1000));
QCOMPARE(spy.count(), 1);
}
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.setValue(QLatin1String("LastEncouragement"), QDateTime::currentDateTime().addSecs(-24 * 60 * 60 - 1));
}
{
Provider p;
p.setSurveyInterval(90);
p.setTelemetryMode(Provider::BasicSystemInformation);
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setEncouragementInterval(1);
QVERIFY(!spy.wait(10));
}
}
void testGlobalEncouragementCoordination()
{
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
}
{
Provider p;
p.setSurveyInterval(-1);
p.setTelemetryMode(Provider::NoTelemetry);
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setEncouragementInterval(1);
QVERIFY(spy.wait(1000));
QCOMPARE(spy.count(), 1);
}
// would qualify for encouragement, but global coordination should prevent it
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
}
{
Provider p;
p.setSurveyInterval(-1);
p.setTelemetryMode(Provider::NoTelemetry);
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setEncouragementInterval(1);
QVERIFY(!spy.wait(100));
}
}
void testMultipleProviders()
{
{
Provider p0;
p0.setTelemetryMode(Provider::BasicUsageStatistics); // triggers store, so we want to avoid that below
}
int c1 = -1;
{
Provider p1;
auto s1 = new StartCountSource;
s1->setTelemetryMode(Provider:: BasicUsageStatistics);
p1.addDataSource(s1);
c1 = s1->data().toMap().value(QLatin1String("value")).toInt();
int c2 = -1;
{
Provider p2;
auto s2 = new StartCountSource;
s2->setTelemetryMode(Provider::BasicUsageStatistics);
p2.addDataSource(s2);
c2 = s2->data().toMap().value(QLatin1String("value")).toInt();
}
QVERIFY(c2 == c1 + 1);
}
Provider p3;
auto s3 = new StartCountSource;
s3->setTelemetryMode(Provider::BasicUsageStatistics);
p3.addDataSource(s3);
int c3 = s3->data().toMap().value(QLatin1String("value")).toInt();
QVERIFY(c3 == c1 + 2);
}
void testProductIdChange()
{
{
Provider p0;
}
int c1 = -1;
{
Provider p1;
auto s1 = new StartCountSource;
s1->setTelemetryMode(Provider::BasicUsageStatistics);
p1.addDataSource(s1);
p1.setSurveyInterval(90);
const auto c0 = s1->data().toMap().value(QLatin1String("value")).toInt();
p1.setProductIdentifier(QStringLiteral("org.kde.some.other.test"));
p1.setSurveyInterval(-1);
p1.setSurveyInterval(1);
c1 = s1->data().toMap().value(QLatin1String("value")).toInt();
QVERIFY(c0 != c1);
}
{
Provider p2;
auto s2 = new StartCountSource;
s2->setTelemetryMode(Provider::BasicUsageStatistics);
p2.addDataSource(s2);
p2.setProductIdentifier(QStringLiteral("org.kde.some.other.test"));
QCOMPARE(p2.surveyInterval(), 1);
const auto c2 = s2->data().toMap().value(QLatin1String("value")).toInt();
QCOMPARE(c1 + 1, c2);
}
}
void testGlobalKillSwitch()
{
{
Provider p1;
QVERIFY(p1.isEnabled());
p1.setEnabled(false);
QVERIFY(!p1.isEnabled());
}
Provider p2;
QVERIFY(!p2.isEnabled());
// check encouragements are disabled
{
QSettings s(QCoreApplication::organizationName(), QStringLiteral("UserFeedback.org.kde.providertest"));;
s.beginGroup(QLatin1String("UserFeedback"));
s.remove(QLatin1String("LastEncouragement"));
}
{
Provider p;
p.setSurveyInterval(-1);
p.setTelemetryMode(Provider::NoTelemetry);
QSignalSpy spy(&p, SIGNAL(showEncouragementMessage()));
QVERIFY(spy.isValid());
p.setEncouragementDelay(0);
p.setApplicationStartsUntilEncouragement(0);
p.setEncouragementInterval(1);
QVERIFY(!spy.wait(100));
}
}
void testDataSourceLookup()
{
Provider p;
auto screenInfoDataSource = new ScreenInfoSource;
auto screenInfoDataSourceId = screenInfoDataSource->id();
auto platformInfoDataSource = new PlatformInfoSource;
auto platformInfoDataSourceId = platformInfoDataSource->id();
p.addDataSource(screenInfoDataSource);
p.addDataSource(platformInfoDataSource);
QCOMPARE(screenInfoDataSource, p.dataSource(screenInfoDataSourceId));
QCOMPARE(platformInfoDataSource, p.dataSource(platformInfoDataSourceId));
QVERIFY(!p.dataSource(QStringLiteral("SomeInvalidId")));
}
};
QTEST_GUILESS_MAIN(ProviderTest)
#include "providertest.moc"
|
