File: kwsCheckSemicolonSpace.cxx

package info (click to toggle)
kwstyle 1.0.1+git3224cf2-1
  • links: PTS, VCS
  • area: main
  • in suites: bullseye, buster, sid, stretch
  • size: 45,404 kB
  • ctags: 145,645
  • sloc: cpp: 423,059; ansic: 9,347; xml: 588; sh: 102; php: 87; perl: 35; makefile: 7
file content (326 lines) | stat: -rw-r--r-- 9,262 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
/*=========================================================================

  Program:   KWStyle - Kitware Style Checker
  Module:    kwsCheckSemicolonSpace.cxx

  Copyright (c) Kitware, Inc.  All rights reserved.
  See Copyright.txt or http://www.kitware.com/Copyright.htm for details.

     This software is distributed WITHOUT ANY WARRANTY; without even
     the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
     PURPOSE.  See the above copyright notices for more information.

=========================================================================*/
#include "kwsParser.h"

namespace kws {


/** Check the number of space between the end of the declaration
 *  and the semicolon */
bool Parser::CheckSemicolonSpace(unsigned long max)
{
  m_TestsDone[SEMICOLON_SPACE] = true;
  char* val = new char[255];
  sprintf(val,"Semicolons = %ld max spaces",max);
  m_TestsDescription[SEMICOLON_SPACE] = val;
  delete [] val;

  bool hasError = false;
  long int posSemicolon = static_cast<long int>(m_BufferNoComment.find(";",0));
  while(posSemicolon != -1)
    {
    // We try to find the word before that
    long i=posSemicolon-1;
    unsigned long space = 0;
    while(i>=0)
      {
       if(m_BufferNoComment[i] == ' ')
        {
        if(!IsBetweenQuote(i))
          {
          space++;
          }
        }
       else
        {
        if(m_BufferNoComment[i] != '\n' && space > max)
          {
          Error error;
          error.line = this->GetLineNumber(posSemicolon,true);
          error.line2 = error.line;
          error.number = SEMICOLON_SPACE;
          error.description = "Number of spaces before semicolon exceed: ";
          char* localval = new char[10];
          sprintf(localval,"%ld",space);
          error.description += localval;
          error.description += " (max=";
          delete [] localval;
          localval = new char[10];
          sprintf(localval,"%ld",max);
          error.description += localval;
          error.description += ")";
          delete [] localval;
          m_ErrorList.push_back(error);
          hasError = true;

          if(m_FixFile)
            {
            this->ReplaceCharInFixedBuffer(this->GetPositionWithComments(posSemicolon-space),space,"");
            }
          } // space > max
        break;
        }
      i--;
      }
    posSemicolon = static_cast<long int>(m_BufferNoComment.find(";",posSemicolon+1));
    }

  // We also check if we have two or more semicolons following each other
  posSemicolon = static_cast<long int>(m_BufferNoComment.find(";",0));
  while(posSemicolon != -1)
    {
    // We look forward
    unsigned long i=posSemicolon+1;
    while(i<m_BufferNoComment.size())
      {
      if(m_BufferNoComment[i] == ' ' || m_BufferNoComment[i] == '\r' || m_BufferNoComment[i] == '\n')
        {
        // this is normal
        }
      else if(m_BufferNoComment[i] == ';')
        {
        // if we have for ( ;; ) we don't report
        // or ";;"
        if(!this->IsBetweenCharsFast('(',')',i)
           && !this->IsBetweenQuote(i))
          {
          Error error;
          error.line = this->GetLineNumber(i,true);
          error.line2 = error.line;
          error.number = SEMICOLON_SPACE;
          error.description = "Too many semicolons";
          m_ErrorList.push_back(error);
          hasError = true;

          if(m_FixFile)
            {
            this->ReplaceCharInFixedBuffer(this->GetPositionWithComments(i),1,"");
            }
          }
        }
      else
        {
        break;
        }
      i++;
      }
    posSemicolon = static_cast<long int>(m_BufferNoComment.find(";",i+1));
    }


  // We also check if we have unecessary semicolons
  posSemicolon = static_cast<long int>(m_BufferNoComment.find(";",0));
  while(posSemicolon != -1)
    {
    // check if we have a } before
    long int pos = posSemicolon;
    pos--;
    while(pos>0 &&
      (m_BufferNoComment[pos] == ' '
      || m_BufferNoComment[pos] == '\n'
      || m_BufferNoComment[pos] == '\r'))
      {
      pos--;
      }

    if(m_BufferNoComment[pos] == '}')
      {
      bool error = true;
      // We check that this is not a class
      long int openingChar = static_cast<long int>(this->FindOpeningChar('}','{',pos,true));

      long int classPos = static_cast<long int>(m_BufferNoComment.find("class"));
      while(classPos != -1)
        {
        if(classPos != -1 && openingChar!= -1)
          {
          for(unsigned long i=classPos;i<(unsigned long)openingChar+1;i++)
            {
            if(m_BufferNoComment[i] == '{')
              {
              classPos = i;
              break;
              }
            }
          if(openingChar == classPos)
            {
            error = false;
            }
          }
        classPos = static_cast<long int>(m_BufferNoComment.find("class",classPos+1));
        }

      // We check that this is not a enum
      long int enumPos = static_cast<long int>(m_BufferNoComment.find("enum"));
      while(enumPos != -1)
        {
        if(enumPos != -1 && openingChar!= -1)
          {
          for(unsigned long i=enumPos;i<(unsigned long)openingChar+1;i++)
            {
            if(m_BufferNoComment[i] == '{')
              {
              enumPos = i;
              break;
              }
            }
          if(openingChar == enumPos)
            {
            error = false;
            }
          }
        enumPos = static_cast<long int>(m_BufferNoComment.find("enum",enumPos+1));
        }

      std::string word = this->FindPreviousWord(openingChar);
      if(word == "enum")
        {
        error = false;
        }

      // We check that this is not a struct
      long int structPos = static_cast<long int>(m_BufferNoComment.find("struct"));
      while(structPos != -1)
        {
        if(structPos != -1 && openingChar!= -1)
          {
          for(unsigned long i=structPos;i<(unsigned long)openingChar+1;i++)
            {
            if(m_BufferNoComment[i] == '{')
              {
              structPos = i;
              break;
              }
            }
          if(openingChar == structPos)
            {
            error = false;
            }
          }
        structPos = static_cast<long int>(m_BufferNoComment.find("struct",structPos+1));
        }

      word = this->FindPreviousWord(openingChar);
      if(word == "struct")
        {
        error = false;
        }

      // We check that this is not a union
      long int unionPos = static_cast<long int>(m_BufferNoComment.find("union"));
      while(unionPos != -1)
        {
        if(unionPos != -1 && openingChar!= -1)
          {
          for(unsigned long i=unionPos;i<(unsigned long)openingChar+1;i++)
            {
            if(m_BufferNoComment[i] == '{')
              {
              unionPos = i;
              break;
              }
            }
          if(openingChar == unionPos)
            {
            error = false;
            }
          }
        unionPos = static_cast<long int>(m_BufferNoComment.find("union",unionPos+1));
        }

      word = this->FindPreviousWord(openingChar);
      if(word == "union")
        {
        error = false;
        }

      // We check that this is not a static variable
      long int i = pos--;
      while(i>0)
        {
        if(m_BufferNoComment[i]==';'
          || (m_BufferNoComment[i]==')'))
          {
          break;
          }
        i--;
        }
      std::string substring = m_BufferNoComment.substr(i,openingChar-i);
      if(substring.find("static") != std::string::npos)
        {
        error = false;
        }

      // We check that this is not a variable definition
      i = posSemicolon-1;
      while(i>0)
        {
        if(m_BufferNoComment[i]=='}')
          {
          long int localopeningChar = static_cast<long int>(this->FindOpeningChar('}','{',i,true));
          long int j = localopeningChar-1;
          while(j>0 && (m_BufferNoComment[j]==' '
            || m_BufferNoComment[j]=='\n'
            || m_BufferNoComment[j]=='\r')
            )
            {
            j--;
            }

          if(m_BufferNoComment[j]=='=')
            {
            error = false;
            }
          break;
          }
        i--;
        }

      // Check if the {} is empty or not
      if(openingChar!= -1)
        {
        bool empty = true;
        for(unsigned long index=openingChar+1;index<(unsigned long)pos;index++)
          {
          if(m_BufferNoComment[index] != ' ' || m_BufferNoComment[index] != '\r'
            || m_BufferNoComment[index] != '\n')
            {
            empty = false;
            break;
            }
          }
        if(empty)
          {
          error = false;
          }
        }

      if(error)
        {
        Error localerror;
        localerror.line = this->GetLineNumber(posSemicolon,true);
        localerror.line2 = localerror.line;
        localerror.number = SEMICOLON_SPACE;
        localerror.description = "Unnecessary semicolon";
        m_ErrorList.push_back(localerror);
        hasError = true;
        }
      }
    posSemicolon = static_cast<long int>(m_BufferNoComment.find(";",posSemicolon+1));
    }

  return !hasError;
}

} // end namespace kws