1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
|
#include "kactioncollectiontest.h"
#include <QAction>
#include <QPointer>
#include <QSignalSpy>
#include <QtTestWidgets>
#include <KSharedConfig>
#include <KStandardAction>
void tst_KActionCollection::init()
{
collection = new KActionCollection(static_cast<QObject *>(nullptr));
}
void tst_KActionCollection::cleanup()
{
delete collection;
collection = nullptr;
}
void tst_KActionCollection::clear()
{
QPointer<QAction> action1 = collection->add<QAction>(QStringLiteral("test1"));
QPointer<QAction> action2 = collection->add<QAction>(QStringLiteral("test2"));
QPointer<QAction> action3 = collection->add<QAction>(QStringLiteral("test3"));
QPointer<QAction> action4 = collection->add<QAction>(QStringLiteral("test4"));
QPointer<QAction> action5 = collection->add<QAction>(QStringLiteral("test5"));
QPointer<QAction> action6 = collection->add<QAction>(QStringLiteral("test6"));
QPointer<QAction> action7 = collection->add<QAction>(QStringLiteral("test7"));
collection->clear();
QVERIFY(collection->isEmpty());
QVERIFY(action1.isNull());
QVERIFY(action2.isNull());
QVERIFY(action3.isNull());
QVERIFY(action4.isNull());
QVERIFY(action5.isNull());
QVERIFY(action6.isNull());
QVERIFY(action7.isNull());
}
void tst_KActionCollection::addStandardActionFunctorSignal()
{
bool received = false;
QAction *a = collection->addAction(KStandardAction::New, QStringLiteral("test"), this, [&]() {
received = true;
});
a->trigger();
QVERIFY(received);
delete a;
QVERIFY(collection->isEmpty());
}
void tst_KActionCollection::deleted()
{
// Delete action -> automatically removed from collection
QAction *a = collection->add<QAction>(QStringLiteral("test"));
delete a;
QVERIFY(collection->isEmpty());
// Delete action's parent -> automatically removed from collection
QWidget *myWidget = new QWidget(nullptr);
QPointer<QAction> action = new QAction(/*i18n()*/ QStringLiteral("Foo"), myWidget);
collection->addAction(QStringLiteral("foo"), action);
delete myWidget;
QVERIFY(collection->isEmpty());
QVERIFY(action.isNull());
// Delete action's parent, but the action was added to another widget with setAssociatedWidget
// and that widget gets deleted first.
myWidget = new QWidget(nullptr);
QWidget *myAssociatedWidget = new QWidget(myWidget); // child widget
action = new QAction(/*i18n()*/ QStringLiteral("Foo"), myWidget); // child action
collection->addAction(QStringLiteral("foo"), action);
collection->addAssociatedWidget(myAssociatedWidget);
QVERIFY(myAssociatedWidget->actions().contains(action));
delete myAssociatedWidget; // would be done by the line below, but let's make sure it happens first
delete myWidget;
QVERIFY(collection->isEmpty());
QVERIFY(action.isNull());
}
void tst_KActionCollection::take()
{
QAction *a = collection->add<QAction>(QStringLiteral("test"));
collection->takeAction(a);
QVERIFY(collection->isEmpty());
delete a;
}
void tst_KActionCollection::writeSettings()
{
KConfigGroup cfg = clearConfig();
QList<QKeySequence> defaultShortcut;
defaultShortcut << Qt::Key_A << Qt::Key_B;
QList<QKeySequence> temporaryShortcut;
temporaryShortcut << Qt::Key_C << Qt::Key_D;
QAction *actionWithDifferentShortcut = new QAction(this);
collection->setDefaultShortcuts(actionWithDifferentShortcut, defaultShortcut);
actionWithDifferentShortcut->setShortcuts(temporaryShortcut);
collection->addAction(QStringLiteral("actionWithDifferentShortcut"), actionWithDifferentShortcut);
QAction *immutableAction = new QAction(this);
collection->setDefaultShortcuts(immutableAction, defaultShortcut);
immutableAction->setShortcuts(temporaryShortcut);
collection->setShortcutsConfigurable(immutableAction, false);
collection->addAction(QStringLiteral("immutableAction"), immutableAction);
QAction *actionWithSameShortcut = new QAction(this);
collection->setDefaultShortcuts(actionWithSameShortcut, defaultShortcut);
collection->addAction(QStringLiteral("actionWithSameShortcut"), actionWithSameShortcut);
cfg.writeEntry("actionToDelete", QStringLiteral("Foobar"));
QAction *actionToDelete = new QAction(this);
collection->setDefaultShortcuts(actionToDelete, defaultShortcut);
collection->addAction(QStringLiteral("actionToDelete"), actionToDelete);
collection->writeSettings(&cfg);
QCOMPARE(cfg.readEntry("actionWithDifferentShortcut", QString()), QKeySequence::listToString(actionWithDifferentShortcut->shortcuts()));
QCOMPARE(cfg.readEntry("immutableAction", QString()), QString());
QCOMPARE(cfg.readEntry("actionWithSameShortcut", QString()), QString());
QCOMPARE(cfg.readEntry("actionToDelete", QString()), QString());
qDeleteAll(collection->actions());
}
void tst_KActionCollection::readSettings()
{
KConfigGroup cfg = clearConfig();
QList<QKeySequence> defaultShortcut;
defaultShortcut << Qt::Key_A << Qt::Key_B;
QList<QKeySequence> temporaryShortcut;
temporaryShortcut << Qt::Key_C << Qt::Key_D;
cfg.writeEntry("normalAction", QKeySequence::listToString(defaultShortcut));
cfg.writeEntry("immutable", QKeySequence::listToString(defaultShortcut));
cfg.writeEntry("empty", QString());
QAction *normal = new QAction(this);
collection->addAction(QStringLiteral("normalAction"), normal);
QAction *immutable = new QAction(this);
immutable->setShortcuts(temporaryShortcut);
collection->setDefaultShortcuts(immutable, temporaryShortcut);
collection->setShortcutsConfigurable(immutable, false);
collection->addAction(QStringLiteral("immutable"), immutable);
QAction *empty = new QAction(this);
collection->addAction(QStringLiteral("empty"), empty);
collection->setDefaultShortcuts(empty, defaultShortcut);
empty->setShortcuts(temporaryShortcut);
QCOMPARE(QKeySequence::listToString(empty->shortcuts()), QKeySequence::listToString(temporaryShortcut));
collection->readSettings(&cfg);
QCOMPARE(QKeySequence::listToString(normal->shortcuts()), QKeySequence::listToString(defaultShortcut));
QCOMPARE(QKeySequence::listToString(empty->shortcuts()), QKeySequence::listToString(defaultShortcut));
QCOMPARE(QKeySequence::listToString(immutable->shortcuts()), QKeySequence::listToString(temporaryShortcut));
qDeleteAll(collection->actions());
}
void tst_KActionCollection::insertReplaces1()
{
QAction *a = new QAction(nullptr);
QAction *b = new QAction(nullptr);
collection->addAction(QStringLiteral("a"), a);
QVERIFY(collection->actions().contains(a));
QVERIFY(collection->action(QStringLiteral("a")) == a);
collection->addAction(QStringLiteral("a"), b);
QVERIFY(!collection->actions().contains(a));
QVERIFY(collection->actions().contains(b));
QVERIFY(collection->action(QStringLiteral("a")) == b);
delete a;
delete b;
}
/**
* Check that a action added twice under different names only ends up once in
* the collection
*/
void tst_KActionCollection::insertReplaces2()
{
QAction *a = new QAction(nullptr);
collection->addAction(QStringLiteral("a"), a);
QVERIFY(collection->actions().contains(a));
QVERIFY(collection->action(QStringLiteral("a")) == a);
// Simple test: Just add it twice
collection->addAction(QStringLiteral("b"), a);
QVERIFY(collection->actions().contains(a));
QVERIFY(!collection->action(QStringLiteral("a")));
QVERIFY(collection->action(QStringLiteral("b")) == a);
// Complex text: Mesh with the objectname
a->setObjectName(QStringLiteral("c"));
collection->addAction(QStringLiteral("d"), a);
QVERIFY(collection->actions().contains(a));
QVERIFY(!collection->action(QStringLiteral("b")));
QVERIFY(!collection->action(QStringLiteral("c")));
QVERIFY(collection->action(QStringLiteral("d")) == a);
delete a;
}
KConfigGroup tst_KActionCollection::clearConfig()
{
KSharedConfig::Ptr cfg = KSharedConfig::openConfig();
cfg->deleteGroup(collection->configGroup());
return KConfigGroup(cfg, collection->configGroup());
}
void tst_KActionCollection::testSetShortcuts()
{
QAction *action = new QAction(/*i18n*/ (QStringLiteral("Next Unread &Folder")), this);
collection->addAction(QStringLiteral("go_next_unread_folder"), action);
collection->setDefaultShortcut(action, QKeySequence(Qt::ALT | Qt::Key_Plus));
QList<QKeySequence> shortcut = action->shortcuts();
shortcut << QKeySequence(Qt::CTRL | Qt::Key_Plus);
action->setShortcuts(shortcut);
QCOMPARE(QKeySequence::listToString(action->shortcuts()), QStringLiteral("Alt++; Ctrl++"));
// Simpler way:
QList<QKeySequence> shortcut2;
shortcut2 << QKeySequence(Qt::ALT | Qt::Key_Plus) << QKeySequence(Qt::CTRL | Qt::Key_Plus);
QCOMPARE(QKeySequence::listToString(shortcut2), QStringLiteral("Alt++; Ctrl++"));
}
void tst_KActionCollection::implicitStandardActionInsertionUsingCreate()
{
KActionCollection collection(static_cast<QObject *>(nullptr));
QAction *a = KStandardAction::create(KStandardAction::Undo, qApp, &QCoreApplication::quit, &collection);
QVERIFY(a);
QVERIFY(a->parent() == &collection);
QVERIFY(collection.action(QString::fromLatin1(KStandardAction::name(KStandardAction::Undo))) == a);
}
void tst_KActionCollection::implicitStandardActionInsertionUsingCut()
{
KActionCollection collection(static_cast<QObject *>(nullptr));
QAction *cut = KStandardAction::cut(&collection);
QAction *a = collection.action(QString::fromLatin1(KStandardAction::name(KStandardAction::Cut)));
QVERIFY(a);
QVERIFY(a == cut);
}
void tst_KActionCollection::shouldEmitSignals()
{
QAction *a = new QAction(nullptr);
QAction *b = new QAction(nullptr);
QSignalSpy insertedSpy(collection, &KActionCollection::inserted);
QSignalSpy changedSpy(collection, &KActionCollection::changed);
// Insert "first"
collection->addAction(QStringLiteral("first"), a);
QVERIFY(collection->actions().contains(a));
QCOMPARE(insertedSpy.count(), 1);
QCOMPARE(insertedSpy.at(0).at(0).value<QAction *>(), a);
QCOMPARE(changedSpy.count(), 1);
insertedSpy.clear();
changedSpy.clear();
// Replace "first"
collection->addAction(QStringLiteral("first"), b);
QVERIFY(!collection->actions().contains(a));
QVERIFY(collection->actions().contains(b));
QCOMPARE(insertedSpy.count(), 1);
QCOMPARE(insertedSpy.at(0).at(0).value<QAction *>(), b);
QCOMPARE(changedSpy.count(), 2); // once for removing a, once for inserting b
insertedSpy.clear();
changedSpy.clear();
// Insert "second"
collection->addAction(QStringLiteral("second"), a);
QCOMPARE(insertedSpy.count(), 1);
QCOMPARE(insertedSpy.at(0).at(0).value<QAction *>(), a);
QCOMPARE(changedSpy.count(), 1);
insertedSpy.clear();
changedSpy.clear();
// Remove and delete "second" (which is a)
collection->removeAction(a);
QCOMPARE(changedSpy.count(), 1);
changedSpy.clear();
// Delete b directly, should automatically remove it from the collection and emit changed
delete b;
QCOMPARE(changedSpy.count(), 1);
changedSpy.clear();
}
QTEST_MAIN(tst_KActionCollection)
#include "moc_kactioncollectiontest.cpp"
|