File: misc-check-xmlSecGetNodeNsHref-for-possible-NULL-res.patch

package info (click to toggle)
lasso 2.8.1-1%2Bdeb12u1
  • links: PTS
  • area: main
  • in suites: bookworm-proposed-updates
  • size: 21,184 kB
  • sloc: ansic: 38,284; xml: 23,941; python: 5,148; sh: 4,726; makefile: 1,002; php: 495; perl: 117
file content (28 lines) | stat: -rw-r--r-- 1,215 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
From: Benjamin Dauvergne <bdauvergne@entrouvert.com>
Date: Thu, 15 May 2025 15:51:08 +0200
Subject: misc: check xmlSecGetNodeNsHref for possible NULL result (#105693)
Origin: https://git.entrouvert.org/lasso.git/commit/?id=c880cad13732bcb50cbd9fa376ea39edb53e7d68
Bug-Debian-Security: https://security-tracker.debian.org/tracker/CVE-2025-46404

---
 lasso/id-ff/provider.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lasso/id-ff/provider.c b/lasso/id-ff/provider.c
index 1dcd1b02b48c..e3c9dce52421 100644
--- a/lasso/id-ff/provider.c
+++ b/lasso/id-ff/provider.c
@@ -1364,8 +1364,8 @@ lasso_provider_verify_saml_signature(LassoProvider *provider,
 
 	/* ID-FF 1.2 Signatures case */
 	node_ns = xmlSecGetNodeNsHref(signed_node);
-	if ((strcmp((char*)node_ns, LASSO_SAML2_PROTOCOL_HREF) == 0) ||
-			(strcmp((char*)node_ns, LASSO_SAML2_ASSERTION_HREF) == 0)) {
+	if (node_ns && ((strcmp((char*)node_ns, LASSO_SAML2_PROTOCOL_HREF) == 0) ||
+			(strcmp((char*)node_ns, LASSO_SAML2_ASSERTION_HREF) == 0))) {
 		id_attribute_name = "ID";
 	} else if (xmlSecCheckNodeName(signed_node, (xmlChar*)"Request", (xmlChar*)LASSO_SAML_PROTOCOL_HREF)) {
 		id_attribute_name = "RequestID";
-- 
2.51.0