1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491
|
unit ReturnBefore;
{ AFS 10 Jan 2003
Return before
}
{(*}
(*------------------------------------------------------------------------------
Delphi Code formatter source code
The Original Code is ReturnBefore, released May 2003.
The Initial Developer of the Original Code is Anthony Steele.
Portions created by Anthony Steele are Copyright (C) 1999-2008 Anthony Steele.
All Rights Reserved.
Contributor(s): Anthony Steele.
The contents of this file are subject to the Mozilla Public License Version 1.1
(the "License"). you may not use this file except in compliance with the License.
You may obtain a copy of the License at http://www.mozilla.org/NPL/
Software distributed under the License is distributed on an "AS IS" basis,
WITHOUT WARRANTY OF ANY KIND, either express or implied.
See the License for the specific language governing rights and limitations
under the License.
Alternatively, the contents of this file may be used under the terms of
the GNU General Public License Version 2 or later (the "GPL")
See http://www.gnu.org/licenses/gpl.html
------------------------------------------------------------------------------*)
{*)}
{$I JcfGlobal.inc}
interface
uses SwitchableVisitor;
type
TReturnBefore = class(TSwitchableVisitor)
private
fiReturnsBefore, fiNextReturnsBefore: integer;
fiReturnsBeforeProcedure: integer;
protected
procedure InspectSourceToken(const pcToken: TObject); override;
function EnabledVisitSourceToken(const pcToken: TObject): Boolean; override;
public
constructor Create; override;
function IsIncludedInSettings: boolean; override;
end;
implementation
uses
TokenUtils,
SourceToken, Tokens, ParseTreeNode,
ParseTreeNodeType, JcfSettings,
FormatFlags, SettingsTypes;
const
WordsReturnBefore: TTokenTypeSet =
[ttBegin, ttEnd, ttUntil, ttTry, ttFinally, ttExcept
//, ttConditionalCompilationRemoved
];
WordsBlankLineBefore: TTokenTypeSet =
[ttImplementation, ttInitialization, ttFinalization, ttUses];
{
the first token of structured type may have a blank line before it
before class/interface def with body when it's not the first type.
e.g.
type
foo = integer;
TSomeClass = class...
These start with a type name
and have a parent node nTypeDecl, which in turn owns a Restricted type -> Class type
}
function IsStructuredTypeStart(const pt: TSourceToken): Boolean;
var
lcPrev: TSourceToken;
lcParent: TParseTreeNode;
begin
Result := False;
if not IsIdentifier(pt, idStrict) then
exit;
if not pt.HasParentNode(nTypeDecl, 2) then
exit;
lcPrev := pt.PriorSolidToken;
// not if there's an attibute or generic keyword before the identifier
if (lcPrev.TokenType = ttCloseSquareBracket) and (lcPrev.HasParentNode(nAttribute)) or (lcPrev.TokenType = ttGeneric) then
exit;
if (lcPrev <> nil) and (lcPrev.TokenType <> ttType) then
begin
// identifier
lcParent := pt.Parent;
if lcParent.NodeType = nIdentifier then
lcParent := lcParent.Parent
else
lcParent := nil;
if (lcParent <> nil) then
begin
if (lcParent.NodeType = nTypeDecl) and
lcParent.HasChildNode(ObjectTypes, 2) and
lcParent.HasChildNode(ObjectBodies, 3) then
begin
Result := True;
exit;
end;
{ likewise before a record type }
if (lcParent.NodeType = nTypeDecl) and
lcParent.HasChildNode(nRecordType, 2) and
lcParent.HasChildNode(nFieldDeclaration, 3) then
begin
Result := True;
exit;
end;
end;
end;
end;
function StartsAnonymousMethod(const pt: TSourceToken): Boolean;
begin
Result := (pt.TokenType in [ttProcedure, ttFunction]) and
pt.HasParentNode(nAnonymousMethod, 3)
end;
function NeedsBlankLine(const pt: TSourceToken): boolean;
var
lcNext: TSourceToken;
begin
Result := (pt.TokenType in WordsBlankLineBefore);
if Result then
exit;
{ function/proc body needs a blank line
but not in RHSEquals of type defs,
or in an anonymous procedure type
and not in class & interface def,
and not if precedeed by the class specified for class functions
and not if it doesn't have a proc body
IMHO should also have blank line before contained procs
}
if StartsAnonymousMethod(pt) then
exit;
if (pt.TokenType in ProcedureWords) and
(not pt.IsOnRightOf(nTypeDecl, ttEquals)) and
(not pt.HasParentNode(nProcedureType, 2)) and
(not IsClassFunctionOrProperty(pt)) and
(ProcedureHasBody(pt)) and
(not IsIdentifier(pt, idAny)) then
begin
Result := True;
exit;
end;
// form dfm comment
if IsDfmIncludeDirective(pt) or IsGenericResIncludeDirective(pt) then
begin
Result := True;
exit;
end;
{ blank line before the words var, type or const at top level
except for:
type t2 = type integer;
or
var foo: System.&Type; }
if (pt.TokenType in Declarations) and (pt.Nestings.Total = 0) and
(not pt.IsOnRightOf(nTypeDecl, ttEquals)) and
(not pt.HasParentNode(nType)) then
begin
Result := True;
exit;
end;
{ start of class function body }
if (pt.TokenType = ttClass) and
( not pt.HasParentNode([nVarDecl, nConstDecl, nClassDeclarations, nRecordType])) and
(pt.HasParentNode(nFunctionHeading, 1)) then
begin
Result := True;
exit;
end;
{ interface, but not as a typedef }
if (pt.TokenType = ttInterface) and not (pt.HasParentNode(nTypeDecl)) then
begin
Result := True;
exit;
end;
if IsStructuredTypeStart(pt) then
begin
Result := True;
exit;
end;
{ end. where there is no initialization section code,
ie 'end' is the first and only token in the init section }
if (pt.TokenType = ttEnd) and
pt.HasParentNode(nInitSection, 1) and
(pt.Parent.SolidChildCount = 1) then
begin
lcNext := pt.NextSolidToken;
if (lcNext <> nil) and (lcNext.TokenTYpe = ttDot) then
begin
Result := True;
exit;
end;
end;
// attribute before type decl
if (pt.TokenType = ttOpenSquareBracket) and
pt.HasParentNode(nTypeDecl, 2) and
(not pt.HasParentNode([nClassType, nRecordType])) then
begin
Result := True;
exit;
end;
end;
function NeedsReturn(const pt, ptNext: TSourceToken): boolean;
var
lcPrev: TSourceToken;
begin
Result := False;
if pt = nil then
exit;
if pt.HasParentNode(nAsm) then
exit;
if StartsAnonymousMethod(pt) then
exit;
if (pt.TokenType in WordsReturnBefore) then
begin
Result := True;
exit;
end;
if pt.TokenType = ttElse then
begin
lcPrev := pt.PriorSolidToken;
// return before else unless it's end..else and the style forbids it
if (FormattingSettings.Returns.EndElseStyle = eAlways) or
((lcPrev <> nil) and (lcPrev.TokenType <> ttEnd)) then
Result := True;
end;
{ return before compiler directives }
if (pt.CommentStyle = eCompilerDirective) and (CompilerDirectiveLineBreak(pt, True) = eAlways) then
begin
lcPrev := pt.PriorTokenWithExclusions([ttWhiteSpace]);
if (lcPrev <> nil) and (lcPrev.TokenType <> ttConditionalCompilationRemoved) then
begin
Result := True;
exit;
end;
end;
{ there is not always a return before 'type'
e.g.
type TMyInteger = type Integer;
is legal, only a return before the first one
var, const, type but not in parameter list }
if (pt.TokenType in Declarations) and pt.HasParentNode(nTopLevelSections, 1) and
( not pt.IsOnRightOf(nTypeDecl, ttEquals)) then
begin
Result := True;
exit;
end;
{ procedure & function in class def get return but not blank line before }
if (pt.TokenType in ProcedureWords + [ttProperty]) and
(pt.HasParentNode([nClassType])) and
(not IsClassFunctionOrProperty(pt)) then
begin
Result := True;
exit;
end;
{ nested procs and top level procs get it as well }
if (pt.TokenType in ProcedureWords) and
(not IsClassFunctionOrProperty(pt)) and
(not pt.HasParentNode(nType)) and
(not IsIdentifier(pt, idAny)) then
begin
Result := True;
exit;
end;
{ start of class function decl in class }
if (pt.TokenType = ttClass) and pt.HasParentNode([nProcedureDecl, nFunctionDecl, nProperty]) and
pt.HasParentNode(nClassDeclarations) and
( not pt.HasParentNode([nVarDecl, nConstDecl])) then
begin
Result := True;
exit;
end;
{ access specifiying directive (private, public et al) in a class def }
if pt.HasParentNode(nClassType) and IsClassDirective(pt) then
begin
{ no return before the "private" in "strict private" }
if (pt.TokenType in [ttPrivate, ttProtected]) then
begin
lcPrev := pt.PriorSolidToken;
Result := (lcPrev = nil) or (lcPrev.TokenType <> ttStrict);
end
else
Result := True;
exit;
end;
{ return before 'class' in class function }
if (pt.TokenType = ttClass) and pt.HasParentNode(ProcedureHeadings) and
(RoundBracketLevel(pt) < 1) then
begin
Result := True;
exit;
end;
{ "uses UnitName in 'File'" has a blank line before UnitName }
if IsIdentifier(pt, idStrict) and (pt.HasParentNode(nUses)) and (ptNext.TokenType = ttIn) then
begin
Result := True;
exit;
end;
if (pt.TokenType = ttOpenSquareBracket)then
begin
// start of guid in interface
if pt.HasParentNode(nInterfaceTypeGuid, 1) then
begin
Result := True;
exit;
end;
// start of attribute
if pt.HasParentNode(nAttribute) then
begin
Result := True;
exit;
end;
end;
end;
function StartsProcedure(const pcSourceToken: TSourceToken): boolean;
var
lcPrev: TSourceToken;
begin
Result := (pcSourceToken.TokenType in ProcedureWords + [ttClass]) and
pcSourceToken.HasParentNode(ProcedureNodes, 2);
if Result then
begin
lcPrev := pcSourceToken.PriorSolidToken;
// check that it's not "procedure" in "class procedure foo;"
// or "reference to procedure
if (lcPrev <> nil) and (lcPrev.TokenType in [ttClass, ttTo]) then
result := False;
end;
// check that it's not a forward
if Result then
begin
Result := ProcedureHasBody(pcSourceToken);
end;
if Result then
begin
Result := not StartsAnonymousMethod(pcSourceToken);
end;
end;
constructor TReturnBefore.Create;
begin
inherited;
fiReturnsBefore := 0;
fiNextReturnsBefore := 0;
FormatFlags := FormatFlags + [eAddReturn];
// the number of returns is one greater than the number of blank lines
fiReturnsBeforeProcedure := FormattingSettings.Returns.LinesBeforeProcedure + 1;
end;
function TReturnBefore.EnabledVisitSourceToken(const pcToken: TObject): Boolean;
var
lcSourceToken: TSourceToken;
lcNext, lcPrev: TSourceToken;
liReturnsNeeded: integer;
liLoop: integer;
begin
Result := False;
lcSourceToken := TSourceToken(pcToken);
lcNext := lcSourceToken.NextToken;
if lcNext = nil then
exit;
liReturnsNeeded := 0;
if NeedsBlankLine(lcSourceToken) then
liReturnsNeeded := 2
else if NeedsReturn(lcSourceToken, lcNext) then
liReturnsNeeded := 1;
{ returns before a procedure/function/method }
if (fiReturnsBeforeProcedure > 0) and StartsProcedure(lcSourceToken) then
begin
liReturnsNeeded := fiReturnsBeforeProcedure;
end;
{ number to insert = needed - actual }
liReturnsNeeded := liReturnsNeeded - fiReturnsBefore;
if liReturnsNeeded > 0 then
begin
// current token index changed
Result := True;
lcPrev := lcSourceToken.PriorToken;
if lcPrev.TokenType = ttWhiteSpace then
BlankToken(lcPrev);
for liLoop := 0 to liReturnsNeeded - 1 do
begin
InsertTokenBefore(lcSourceToken, NewReturn);
end;
end;
end;
procedure TReturnBefore.InspectSourceToken(const pcToken: TObject);
var
lcSourceToken: TSourceToken;
begin
{
inspect the tokens as they go past
this is a running total, that is affeced by returns & non-white-space chars
A comment line is as good as a blank line for this
if we encounter the tokens <return> <spaces> <word-needing-return before> the flag must be set true
}
fiReturnsBefore := fiNextReturnsBefore;
lcSourceToken := TSourceToken(pcToken);
if (lcSourceToken.TokenType = ttReturn) then
Inc(fiNextReturnsBefore)
else if not (lcSourceToken.TokenType in [ttReturn, ttWhiteSpace, ttComment]) then
fiNextReturnsBefore := 0;
end;
function TReturnBefore.IsIncludedInSettings: boolean;
begin
Result := FormattingSettings.Returns.AddGoodReturns;
end;
end.
|