1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
|
unit WarnCaseNoElse;
{ AFS 20 June 2K
warn of case without a default 'else' case
This is often an error
your program will be more error-proof if every case has an else
if you can't think of anything to put there, put
case
...
else Raise Exception.Create('case had unexpected value');
end;
}
{(*}
(*------------------------------------------------------------------------------
Delphi Code formatter source code
The Original Code is WarnCaseNoElse, released May 2003.
The Initial Developer of the Original Code is Anthony Steele.
Portions created by Anthony Steele are Copyright (C) 1999-2008 Anthony Steele.
All Rights Reserved.
Contributor(s): Anthony Steele.
The contents of this file are subject to the Mozilla Public License Version 1.1
(the "License"). you may not use this file except in compliance with the License.
You may obtain a copy of the License at http://www.mozilla.org/NPL/
Software distributed under the License is distributed on an "AS IS" basis,
WITHOUT WARRANTY OF ANY KIND, either express or implied.
See the License for the specific language governing rights and limitations
under the License.
Alternatively, the contents of this file may be used under the terms of
the GNU General Public License Version 2 or later (the "GPL")
See http://www.gnu.org/licenses/gpl.html
------------------------------------------------------------------------------*)
{*)}
{$I JcfGlobal.inc}
interface
uses Warning;
type
TWarnCaseNoElse = class(TWarning)
public
constructor Create; override;
procedure PreVisitParseTreeNode(const pcNode: TObject); override;
end;
implementation
uses
ParseTreeNode, ParseTreeNodeType;
constructor TWarnCaseNoElse.Create;
begin
inherited;
HasPreVisit := True;
HasPostVisit := False;
HasSourceTokenVisit := True;
end;
procedure TWarnCaseNoElse.PreVisitParseTreeNode(const pcNode: TObject);
var
lcNode: TParseTreeNode;
begin
lcNode := TParseTreeNode(pcNode);
// when we have a case statement, does it have an else?
if (lcNode.NodeType = nCaseStatement) and
( not lcNode.HasChildNode(nElseCase, 1)) then
begin
SendWarning(lcNode, 'Case statement has no else case');
end;
end;
end.
|
