File: equality_in_assert.patch

package info (click to toggle)
libasyncns 0.8-7
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 1,612 kB
  • sloc: sh: 10,150; ansic: 1,261; makefile: 63
file content (27 lines) | stat: -rw-r--r-- 883 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
Author: Myhailo Danylenko <isbear@isbear.org.ua>
Last-Update: 2017-05-14
Bug-Debian: https://bugs.debian.org/862596
Origin: https://bugs.freedesktop.org/show_bug.cgi?id=91859
Description: Replace possibly unwanted assignment by check for equality
FIXME: Needs review

--- a/libasyncns/asyncns.c
+++ b/libasyncns/asyncns.c
@@ -1506,7 +1506,7 @@ int asyncns_isdone(asyncns_t *asyncns, a
 void asyncns_setuserdata(asyncns_t *asyncns, asyncns_query_t *q, void *userdata) {
     assert(q);
     assert(asyncns);
-    assert(q->asyncns = asyncns);
+    assert(q->asyncns == asyncns);
 
     q->userdata = userdata;
 }
@@ -1514,7 +1514,7 @@ void asyncns_setuserdata(asyncns_t *asyn
 void* asyncns_getuserdata(asyncns_t *asyncns, asyncns_query_t *q) {
     assert(q);
     assert(asyncns);
-    assert(q->asyncns = asyncns);
+    assert(q->asyncns == asyncns);
 
     return q->userdata;
 }