1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
|
use strict;
use warnings;
use Test::More;
use Test::Deep;
use lib qw(t/lib);
use DBICTest ':DiffSQL';
my $schema = DBICTest->init_schema();
my $cdrs = $schema->resultset('CD')->search({ 'me.artist' => { '!=', 2 }});
my $cd_data = { map {
$_->cdid => {
siblings => $cdrs->search ({ artist => $_->get_column('artist') })->count - 1,
track_titles => [ sort $_->tracks->get_column('title')->all ],
},
} ( $cdrs->all ) };
my $c_rs = $cdrs->search ({}, {
prefetch => 'tracks',
'+columns' => { sibling_count => $cdrs->search(
{
'siblings.artist' => { -ident => 'me.artist' },
'siblings.cdid' => { '!=' => ['-and', { -ident => 'me.cdid' }, 23414] },
}, { alias => 'siblings' },
)->count_rs->as_query,
},
});
is_same_sql_bind(
$c_rs->as_query,
'(
SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track,
(SELECT COUNT( * )
FROM cd siblings
WHERE me.artist != ?
AND siblings.artist = me.artist
AND siblings.cdid != me.cdid
AND siblings.cdid != ?
),
tracks.trackid, tracks.cd, tracks.position, tracks.title, tracks.last_updated_on, tracks.last_updated_at
FROM cd me
LEFT JOIN track tracks
ON tracks.cd = me.cdid
WHERE me.artist != ?
)',
[
# subselect
[ { sqlt_datatype => 'integer', dbic_colname => 'me.artist' }
=> 2 ],
[ { sqlt_datatype => 'integer', dbic_colname => 'siblings.cdid' }
=> 23414 ],
# outher WHERE
[ { sqlt_datatype => 'integer', dbic_colname => 'me.artist' }
=> 2 ],
],
'Expected SQL on correlated realiased subquery'
);
$schema->is_executed_querycount( sub {
cmp_deeply (
{ map
{ $_->cdid => {
track_titles => [ sort map { $_->title } ($_->tracks->all) ],
siblings => $_->get_column ('sibling_count'),
} }
$c_rs->all
},
$cd_data,
'Proper information retrieved from correlated subquery'
);
}, 1, 'Only 1 query fired to retrieve everything');
# now add an unbalanced select/as pair
$c_rs = $c_rs->search ({}, {
'+select' => $cdrs->search(
{ 'siblings.artist' => { -ident => 'me.artist' } },
{ alias => 'siblings', columns => [
{ first_year => { min => 'year' }},
{ last_year => { max => 'year' }},
]},
)->as_query,
'+as' => [qw/active_from active_to/],
});
is_same_sql_bind(
$c_rs->as_query,
'(
SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track,
(SELECT COUNT( * )
FROM cd siblings
WHERE me.artist != ?
AND siblings.artist = me.artist
AND siblings.cdid != me.cdid
AND siblings.cdid != ?
),
(SELECT MIN( year ), MAX( year )
FROM cd siblings
WHERE me.artist != ?
AND siblings.artist = me.artist
),
tracks.trackid, tracks.cd, tracks.position, tracks.title, tracks.last_updated_on, tracks.last_updated_at
FROM cd me
LEFT JOIN track tracks
ON tracks.cd = me.cdid
WHERE me.artist != ?
)',
[
# first subselect
[ { sqlt_datatype => 'integer', dbic_colname => 'me.artist' }
=> 2 ],
[ { sqlt_datatype => 'integer', dbic_colname => 'siblings.cdid' }
=> 23414 ],
# second subselect
[ { sqlt_datatype => 'integer', dbic_colname => 'me.artist' }
=> 2 ],
# outher WHERE
[ { sqlt_datatype => 'integer', dbic_colname => 'me.artist' }
=> 2 ],
],
'Expected SQL on correlated realiased subquery'
);
$schema->storage->disconnect;
# test for subselect identifier leakage
# NOTE - the hodge-podge mix of literal and regular identifuers is *deliberate*
for my $quote_names (0,1) {
my $schema = DBICTest->init_schema( quote_names => $quote_names );
my ($ql, $qr) = $schema->storage->sql_maker->_quote_chars;
my $art_rs = $schema->resultset('Artist')->search ({}, {
order_by => 'me.artistid',
prefetch => 'cds',
rows => 2,
});
my $inner_lim_bindtype = { sqlt_datatype => 'integer' };
for my $inner_relchain (qw( cds_unordered cds ) ) {
my $stupid_latest_competition_release_query = $schema->resultset('Artist')->search(
{ 'competition.artistid' => { '!=', { -ident => 'me.artistid' } } },
{ alias => 'competition' },
)->search_related( $inner_relchain, {}, {
rows => 1, order_by => 'year', columns => { year => \'year' }, distinct => 1
})->get_column(\'year')->max_rs;
my $final_query = $art_rs->search( {}, {
'+columns' => { max_competition_release => \[
@${ $stupid_latest_competition_release_query->as_query }
]},
});
# we are using cds_unordered explicitly above - do the sorting manually
my @results = sort { $a->{artistid} <=> $b->{artistid} } @{$final_query->all_hri};
@$_ = sort { $a->{cdid} <=> $b->{cdid} } @$_ for map { $_->{cds} } @results;
is_deeply (
\@results,
[
{ artistid => 1, charfield => undef, max_competition_release => 1998, name => "Caterwauler McCrae", rank => 13, cds => [
{ artist => 1, cdid => 1, genreid => 1, single_track => undef, title => "Spoonful of bees", year => 1999 },
{ artist => 1, cdid => 2, genreid => undef, single_track => undef, title => "Forkful of bees", year => 2001 },
{ artist => 1, cdid => 3, genreid => undef, single_track => undef, title => "Caterwaulin' Blues", year => 1997 },
] },
{ artistid => 2, charfield => undef, max_competition_release => 1997, name => "Random Boy Band", rank => 13, cds => [
{ artist => 2, cdid => 4, genreid => undef, single_track => undef, title => "Generic Manufactured Singles", year => 2001 },
] },
],
"Expected result from weird query",
);
# the decomposition to sql/bind is *deliberate* in both instances
# we want to ensure this keeps working for lietral sql, even when
# as_query switches to return an overloaded dq node
my ($sql, @bind) = @${ $final_query->as_query };
my $correlated_sql = qq{ (
SELECT MAX( year )
FROM (
SELECT year
FROM ${ql}artist${qr} ${ql}competition${qr}
JOIN cd ${ql}${inner_relchain}${qr}
ON ${ql}${inner_relchain}${qr}.${ql}artist${qr} = ${ql}competition${qr}.${ql}artistid${qr}
WHERE ${ql}competition${qr}.${ql}artistid${qr} != ${ql}me${qr}.${ql}artistid${qr}
GROUP BY year
ORDER BY MIN( ${ql}year${qr} )
LIMIT ?
) ${ql}${inner_relchain}${qr}
)};
is_same_sql_bind(
$sql,
\@bind,
qq{ (
SELECT ${ql}me${qr}.${ql}artistid${qr}, ${ql}me${qr}.${ql}name${qr}, ${ql}me${qr}.${ql}rank${qr}, ${ql}me${qr}.${ql}charfield${qr},
$correlated_sql,
${ql}cds${qr}.${ql}cdid${qr}, ${ql}cds${qr}.${ql}artist${qr}, ${ql}cds${qr}.${ql}title${qr}, ${ql}cds${qr}.${ql}year${qr}, ${ql}cds${qr}.${ql}genreid${qr}, ${ql}cds${qr}.${ql}single_track${qr}
FROM (
SELECT ${ql}me${qr}.${ql}artistid${qr}, ${ql}me${qr}.${ql}name${qr}, ${ql}me${qr}.${ql}rank${qr}, ${ql}me${qr}.${ql}charfield${qr},
$correlated_sql
FROM ${ql}artist${qr} ${ql}me${qr}
ORDER BY ${ql}me${qr}.${ql}artistid${qr}
LIMIT ?
) ${ql}me${qr}
LEFT JOIN cd ${ql}cds${qr}
ON ${ql}cds${qr}.${ql}artist${qr} = ${ql}me${qr}.${ql}artistid${qr}
ORDER BY ${ql}me${qr}.${ql}artistid${qr}
) },
[
[ $inner_lim_bindtype
=> 1 ],
[ $inner_lim_bindtype
=> 1 ],
[ { sqlt_datatype => 'integer' }
=> 2 ],
],
"No leakage of correlated subquery identifiers (quote_names => $quote_names, inner alias '$inner_relchain')"
);
}
}
done_testing;
|
