1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245
|
use strict;
use warnings;
use Test::More;
use Test::Warn;
use Test::Exception;
use lib qw(t/lib);
use DBICTest;
# Test txn_scope_guard
{
my $schema = DBICTest->init_schema();
is($schema->storage->transaction_depth, 0, "Correct transaction depth");
my $artist_rs = $schema->resultset('Artist');
my $fn = __FILE__;
throws_ok {
my $guard = $schema->txn_scope_guard;
$artist_rs->create({
name => 'Death Cab for Cutie',
made_up_column => 1,
});
$guard->commit;
} qr/No such column 'made_up_column' .*? at .*?\Q$fn\E line \d+/s, "Error propogated okay";
ok(!$artist_rs->find({name => 'Death Cab for Cutie'}), "Artist not created");
my $inner_exception = ''; # set in inner() below
throws_ok (sub {
outer($schema, 1);
}, qr/$inner_exception/, "Nested exceptions propogated");
ok(!$artist_rs->find({name => 'Death Cab for Cutie'}), "Artist not created");
lives_ok (sub {
# this weird assignment is to stop perl <= 5.8.9 leaking $schema on nested sub{}s
my $s = $schema;
warnings_exist ( sub {
# The 0 arg says don't die, just let the scope guard go out of scope
# forcing a txn_rollback to happen
outer($s, 0);
}, qr/A DBIx::Class::Storage::TxnScopeGuard went out of scope without explicit commit or error. Rolling back./, 'Out of scope warning detected');
ok(!$artist_rs->find({name => 'Death Cab for Cutie'}), "Artist not created");
}, 'rollback successful withot exception');
sub outer {
my ($schema, $fatal) = @_;
my $guard = $schema->txn_scope_guard;
$schema->resultset('Artist')->create({
name => 'Death Cab for Cutie',
});
inner($schema, $fatal);
}
sub inner {
my ($schema, $fatal) = @_;
my $inner_guard = $schema->txn_scope_guard;
is($schema->storage->transaction_depth, 2, "Correct transaction depth");
my $artist = $schema->resultset('Artist')->find({ name => 'Death Cab for Cutie' });
eval {
$artist->cds->create({
title => 'Plans',
year => 2005,
$fatal ? ( foo => 'bar' ) : ()
});
};
if ($@) {
# Record what got thrown so we can test it propgates out properly.
$inner_exception = $@;
die $@;
}
# inner guard should commit without consequences
$inner_guard->commit;
}
}
# make sure the guard does not eat exceptions
{
my $schema = DBICTest->init_schema;
no strict 'refs';
no warnings 'redefine';
local *{DBIx::Class::Storage::DBI::txn_rollback} = sub { die 'die die my darling' };
Class::C3->reinitialize() if DBIx::Class::_ENV_::OLD_MRO;
throws_ok (sub {
my $guard = $schema->txn_scope_guard;
$schema->resultset ('Artist')->create ({ name => 'bohhoo'});
# this should freak out the guard rollback
# but it won't work because DBD::SQLite is buggy
# instead just install a toxic rollback above
#$schema->storage->_dbh( $schema->storage->_dbh->clone );
die 'Deliberate exception';
}, ($] >= 5.013008 )
? qr/Deliberate exception/s # temporary until we get the generic exception wrapper rolling
: qr/Deliberate exception.+Rollback failed/s
);
# just to mask off warning since we could not disconnect above
$schema->storage->_dbh->disconnect;
}
# make sure it warns *big* on failed rollbacks
# test with and without a poisoned $@
for my $pre_poison (0,1) {
for my $post_poison (0,1) {
my $schema = DBICTest->init_schema(no_populate => 1);
no strict 'refs';
no warnings 'redefine';
local *{DBIx::Class::Storage::DBI::txn_rollback} = sub { die 'die die my darling' };
Class::C3->reinitialize() if DBIx::Class::_ENV_::OLD_MRO;
#The warn from within a DESTROY callback freaks out Test::Warn, do it old-school
=begin
warnings_exist (
sub {
my $guard = $schema->txn_scope_guard;
$schema->resultset ('Artist')->create ({ name => 'bohhoo'});
# this should freak out the guard rollback
# but it won't work because DBD::SQLite is buggy
# instead just install a toxic rollback above
#$schema->storage->_dbh( $schema->storage->_dbh->clone );
},
[
qr/A DBIx::Class::Storage::TxnScopeGuard went out of scope without explicit commit or error. Rolling back./,
qr/\*+ ROLLBACK FAILED\!\!\! \*+/,
],
'proper warnings generated on out-of-scope+rollback failure'
);
=cut
# delete this once the above works properly (same test)
my @want = (
qr/A DBIx::Class::Storage::TxnScopeGuard went out of scope without explicit commit or error. Rolling back./,
qr/\*+ ROLLBACK FAILED\!\!\! \*+/,
);
my @w;
local $SIG{__WARN__} = sub {
if (grep {$_[0] =~ $_} (@want)) {
push @w, $_[0];
}
else {
warn $_[0];
}
};
{
eval { die 'pre-GIFT!' if $pre_poison };
my $guard = $schema->txn_scope_guard;
eval { die 'post-GIFT!' if $post_poison };
$schema->resultset ('Artist')->create ({ name => 'bohhoo'});
}
local $TODO = 'Do not know how to deal with trapped exceptions occuring after guard instantiation...'
if ( $post_poison and (
# take no chances on installation
( DBICTest::RunMode->is_plain and ($ENV{TRAVIS}||'') ne 'true' )
or
# this always fails
! $pre_poison
or
# I do not understand why but on <= 5.8.8 and on 5.10.0 "$pre_poison && $post_poison" passes...
($] > 5.008008 and $] < 5.010000 ) or $] > 5.010000
));
is (@w, 2, "Both expected warnings found - \$\@ pre-poison: $pre_poison, post-poison: $post_poison" );
# just to mask off warning since we could not disconnect above
$schema->storage->_dbh->disconnect;
}}
# add a TODO to catch when Text::Balanced is finally fixed
# https://rt.cpan.org/Public/Bug/Display.html?id=74994
#
# while it doesn't matter much for DBIC itself, this particular bug
# is a *BANE*, and DBIC is to bump its dep as soon as possible
{
require Text::Balanced;
my @w;
local $SIG{__WARN__} = sub {
$_[0] =~ /External exception class .+? \Qimplements partial (broken) overloading/
? push @w, @_
: warn @_
};
lives_ok {
# this is what poisons $@
Text::Balanced::extract_bracketed( '(foo', '()' );
my $s = DBICTest::Schema->connect('dbi:SQLite::memory:');
my $g = $s->txn_scope_guard;
$g->commit;
} 'Broken Text::Balanced is not screwing up txn_guard';
local $TODO = 'RT#74994 *STILL* not fixed';
is(scalar @w, 0, 'no warnings \o/');
}
# ensure Devel::StackTrace-refcapture-like effects are countered
{
my $s = DBICTest::Schema->connect('dbi:SQLite::memory:');
my $g = $s->txn_scope_guard;
my @arg_capture;
{
local $SIG{__WARN__} = sub {
package DB;
my $frnum;
while (my @f = caller(++$frnum) ) {
push @arg_capture, @DB::args;
}
};
undef $g;
1;
}
warnings_exist
{ @arg_capture = () }
qr/\QPreventing *MULTIPLE* DESTROY() invocations on DBIx::Class::Storage::TxnScopeGuard/
;
}
done_testing;
|