1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815
|
/* This file is part of the dbusmenu-qt library
Copyright 2009 Canonical
Author: Aurelien Gateau <aurelien.gateau@canonical.com>
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License (LGPL) as published by the Free Software Foundation;
either version 2 of the License, or (at your option) any later
version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
*/
// Self
#include "dbusmenuexportertest.h"
// Qt
#include <QDBusConnection>
#include <QDBusInterface>
#include <QDBusReply>
#include <QIcon>
#include <QMenu>
#include <QtTest>
// DBusMenuQt
#include <dbusmenuexporter.h>
#include <dbusmenutypes_p.h>
#include <dbusmenushortcut_p.h>
#include <debug_p.h>
// Local
#include "testutils.h"
QTEST_MAIN(DBusMenuExporterTest)
static const char *TEST_SERVICE = "org.kde.dbusmenu-qt-test";
static const char *TEST_OBJECT_PATH = "/TestMenuBar";
Q_DECLARE_METATYPE(QList<int>)
static DBusMenuLayoutItemList getChildren(QDBusAbstractInterface* iface, int parentId, const QStringList &propertyNames)
{
QDBusPendingReply<uint, DBusMenuLayoutItem> reply = iface->call("GetLayout", parentId, /*recursionDepth=*/ 1, propertyNames);
reply.waitForFinished();
if (!reply.isValid()) {
qFatal("%s", qPrintable(reply.error().message()));
return DBusMenuLayoutItemList();
}
DBusMenuLayoutItem rootItem = reply.argumentAt<1>();
return rootItem.children;
}
void DBusMenuExporterTest::init()
{
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
QCoreApplication::setAttribute(Qt::AA_DontShowIconsInMenus, false);
}
void DBusMenuExporterTest::cleanup()
{
QVERIFY(QDBusConnection::sessionBus().unregisterService(TEST_SERVICE));
}
void DBusMenuExporterTest::testGetSomeProperties_data()
{
QTest::addColumn<QString>("label");
QTest::addColumn<QString>("iconName");
QTest::addColumn<bool>("enabled");
QTest::newRow("label only") << "label" << QString() << true;
QTest::newRow("disabled, label only") << "label" << QString() << false;
QTest::newRow("icon name") << "label" << "edit-undo" << true;
}
void DBusMenuExporterTest::testGetSomeProperties()
{
QFETCH(QString, label);
QFETCH(QString, iconName);
QFETCH(bool, enabled);
// Create an exporter for a menu with one action, defined by the test data
QMenu inputMenu;
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QAction *action = new QAction(label, &inputMenu);
if (!iconName.isEmpty()) {
QIcon icon = QIcon::fromTheme(iconName);
QVERIFY(!icon.isNull());
action->setIcon(icon);
}
action->setEnabled(enabled);
inputMenu.addAction(action);
// Check out exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
// Get exported menu info
QStringList propertyNames = QStringList() << "type" << "enabled" << "label" << "icon-name";
DBusMenuLayoutItemList list = getChildren(&iface, /*parentId=*/0, propertyNames);
DBusMenuLayoutItem item = list.first();
QVERIFY(item.id != 0);
QVERIFY(item.children.isEmpty());
QVERIFY(!item.properties.contains("type"));
QCOMPARE(item.properties.value("label").toString(), label);
if (enabled) {
QVERIFY(!item.properties.contains("enabled"));
} else {
QCOMPARE(item.properties.value("enabled").toBool(), false);
}
if (iconName.isEmpty()) {
QVERIFY(!item.properties.contains("icon-name"));
} else {
QCOMPARE(item.properties.value("icon-name").toString(), iconName);
}
}
void DBusMenuExporterTest::testGetAllProperties()
{
// set of properties which must be returned because their values are not
// the default values
const QSet<QString> a1Properties = QSet<QString>()
<< "label"
;
const QSet<QString> separatorProperties = QSet<QString>()
<< "type";
const QSet<QString> a2Properties = QSet<QString>()
<< "label"
<< "enabled"
<< "icon-name"
<< "icon-data" // Icon data is always provided if the icon is valid.
<< "visible"
;
// Create the menu items
QMenu inputMenu;
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
inputMenu.addAction("a1");
inputMenu.addSeparator();
QAction *a2 = new QAction("a2", &inputMenu);
a2->setEnabled(false);
QIcon icon = QIcon::fromTheme("edit-undo");
QVERIFY(!icon.isNull());
a2->setIcon(icon);
a2->setVisible(false);
inputMenu.addAction(a2);
// Export them
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
// Get children
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 3);
// Check we get the right properties
DBusMenuLayoutItem item = list.takeFirst();
QCOMPARE(QSet<QString>::fromList(item.properties.keys()), a1Properties);
item = list.takeFirst();
QCOMPARE(QSet<QString>::fromList(item.properties.keys()), separatorProperties);
item = list.takeFirst();
QCOMPARE(QSet<QString>::fromList(item.properties.keys()), a2Properties);
}
void DBusMenuExporterTest::testGetNonExistentProperty()
{
const char* NON_EXISTENT_KEY = "i-do-not-exist";
QMenu inputMenu;
inputMenu.addAction("a1");
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList() << NON_EXISTENT_KEY);
QCOMPARE(list.count(), 1);
DBusMenuLayoutItem item = list.takeFirst();
QVERIFY(!item.properties.contains(NON_EXISTENT_KEY));
}
void DBusMenuExporterTest::testClickedEvent()
{
QMenu inputMenu;
QAction *action = inputMenu.addAction("a1");
QSignalSpy spy(action, SIGNAL(triggered()));
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 1);
int id = list.first().id;
QVariant empty = QVariant::fromValue(QDBusVariant(QString()));
uint timestamp = QDateTime::currentDateTime().toTime_t();
iface.call("Event", id, "clicked", empty, timestamp);
QTest::qWait(500);
QCOMPARE(spy.count(), 1);
}
void DBusMenuExporterTest::testSubMenu()
{
QMenu inputMenu;
QMenu *subMenu = inputMenu.addMenu("menu");
QAction *a1 = subMenu->addAction("a1");
QAction *a2 = subMenu->addAction("a2");
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 1);
int id = list.first().id;
list = getChildren(&iface, id, QStringList());
QCOMPARE(list.count(), 2);
DBusMenuLayoutItem item = list.takeFirst();
QVERIFY(item.id != 0);
QCOMPARE(item.properties.value("label").toString(), a1->text());
item = list.takeFirst();
QCOMPARE(item.properties.value("label").toString(), a2->text());
}
void DBusMenuExporterTest::testDynamicSubMenu()
{
// Track LayoutUpdated() signal: we don't want this signal to be emitted
// too often because it causes refreshes
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
ManualSignalSpy layoutUpdatedSpy;
QDBusConnection::sessionBus().connect(TEST_SERVICE, TEST_OBJECT_PATH, "com.canonical.dbusmenu", "LayoutUpdated", "ui", &layoutUpdatedSpy, SLOT(receiveCall(uint, int)));
// Create our test menu
QMenu inputMenu;
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QAction *action = inputMenu.addAction("menu");
QMenu *subMenu = new QMenu(&inputMenu);
action->setMenu(subMenu);
MenuFiller filler(subMenu);
filler.addAction(new QAction("a1", subMenu));
filler.addAction(new QAction("a2", subMenu));
// Get id of submenu
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 1);
int id = list.first().id;
// Nothing for now
QCOMPARE(subMenu->actions().count(), 0);
// LayoutUpdated should be emitted once because inputMenu is filled
QTest::qWait(500);
QCOMPARE(layoutUpdatedSpy.count(), 1);
QCOMPARE(layoutUpdatedSpy.takeFirst().at(1).toInt(), 0);
// Pretend we show the menu
QDBusReply<bool> aboutToShowReply = iface.call("AboutToShow", id);
QVERIFY2(aboutToShowReply.isValid(), qPrintable(aboutToShowReply.error().message()));
QVERIFY(aboutToShowReply.value());
QTest::qWait(500);
QCOMPARE(layoutUpdatedSpy.count(), 1);
QCOMPARE(layoutUpdatedSpy.takeFirst().at(1).toInt(), id);
// Get submenu items
list = getChildren(&iface, id, QStringList());
QVERIFY(subMenu->actions().count() > 0);
QCOMPARE(list.count(), subMenu->actions().count());
for (int pos=0; pos< list.count(); ++pos) {
DBusMenuLayoutItem item = list.at(pos);
QVERIFY(item.id != 0);
QAction *action = subMenu->actions().at(pos);
QVERIFY(action);
QCOMPARE(item.properties.value("label").toString(), action->text());
}
}
void DBusMenuExporterTest::testRadioItems()
{
DBusMenuLayoutItem item;
DBusMenuLayoutItemList list;
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
// Create 2 radio items, check first one
QAction *a1 = inputMenu.addAction("a1");
a1->setCheckable(true);
QAction *a2 = inputMenu.addAction("a1");
a2->setCheckable(true);
QActionGroup group(0);
group.addAction(a1);
group.addAction(a2);
a1->setChecked(true);
QVERIFY(!a2->isChecked());
// Get item ids
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 2);
// Check items are radios and correctly toggled
item = list.takeFirst();
QCOMPARE(item.properties.value("toggle-type").toString(), QString("radio"));
QCOMPARE(item.properties.value("toggle-state").toInt(), 1);
int a1Id = item.id;
item = list.takeFirst();
QCOMPARE(item.properties.value("toggle-type").toString(), QString("radio"));
QCOMPARE(item.properties.value("toggle-state").toInt(), 0);
int a2Id = item.id;
// Click a2
ManualSignalSpy spy;
QDBusConnection::sessionBus().connect(TEST_SERVICE, TEST_OBJECT_PATH, "com.canonical.dbusmenu", "ItemsPropertiesUpdated", "a(ia{sv})a(ias)",
&spy, SLOT(receiveCall(DBusMenuItemList, DBusMenuItemKeysList)));
QVariant empty = QVariant::fromValue(QDBusVariant(QString()));
uint timestamp = QDateTime::currentDateTime().toTime_t();
iface.call("Event", a2Id, "clicked", empty, timestamp);
QTest::qWait(500);
// Check a1 is not checked, but a2 is
list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 2);
item = list.takeFirst();
QCOMPARE(item.properties.value("toggle-state").toInt(), 0);
item = list.takeFirst();
QCOMPARE(item.properties.value("toggle-state").toInt(), 1);
// Did we get notified?
QCOMPARE(spy.count(), 1);
QSet<int> updatedIds;
{
QVariantList lst = spy.takeFirst().at(0).toList();
Q_FOREACH(QVariant variant, lst) {
updatedIds << variant.toInt();
}
}
QSet<int> expectedIds;
expectedIds << a1Id << a2Id;
QCOMPARE(updatedIds, expectedIds);
}
void DBusMenuExporterTest::testNonExclusiveActionGroup()
{
DBusMenuLayoutItem item;
DBusMenuLayoutItemList list;
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
// Create 2 checkable items
QAction *a1 = inputMenu.addAction("a1");
a1->setCheckable(true);
QAction *a2 = inputMenu.addAction("a1");
a2->setCheckable(true);
// Put them into a non exclusive group
QActionGroup group(0);
group.addAction(a1);
group.addAction(a2);
group.setExclusive(false);
// Get item ids
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 2);
// Check items are checkmark, not radio
item = list.takeFirst();
QCOMPARE(item.properties.value("toggle-type").toString(), QString("checkmark"));
int a1Id = item.id;
item = list.takeFirst();
QCOMPARE(item.properties.value("toggle-type").toString(), QString("checkmark"));
int a2Id = item.id;
}
void DBusMenuExporterTest::testClickDeletedAction()
{
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QAction *a1 = inputMenu.addAction("a1");
// Get id
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), 1);
int id = list.takeFirst().id;
// Delete a1, it should not cause a crash when trying to trigger it
delete a1;
// Send a click to deleted a1
QVariant empty = QVariant::fromValue(QDBusVariant(QString()));
uint timestamp = QDateTime::currentDateTime().toTime_t();
iface.call("Event", id, "clicked", empty, timestamp);
QTest::qWait(500);
}
// Reproduce LP BUG 521011
// https://bugs.launchpad.net/bugs/521011
void DBusMenuExporterTest::testDeleteExporterBeforeMenu()
{
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
QAction *a1 = inputMenu.addAction("a1");
delete exporter;
inputMenu.removeAction(a1);
}
void DBusMenuExporterTest::testUpdateAndDeleteSubMenu()
{
// Create a menu with a submenu
QMenu inputMenu;
QMenu *subMenu = inputMenu.addMenu("menu");
QAction *a1 = subMenu->addAction("a1");
// Export it
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
// Update a1 (which is in subMenu) and delete subMenu right after that. If
// DBusMenuExporter is not careful it will crash in the qWait() because it
// tries to send itemUpdated() for a1.
a1->setText("Not a menu anymore");
delete subMenu;
QTest::qWait(500);
}
void DBusMenuExporterTest::testMenuShortcut()
{
// Create a menu containing an action with a shortcut
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
QAction *a1 = inputMenu.addAction("a1");
a1->setShortcut(Qt::CTRL | Qt::Key_A);
QAction *a2 = inputMenu.addAction("a2");
a2->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_A, Qt::ALT | Qt::Key_B));
// No shortcut, to test the property is not added in this case
QAction *a3 = inputMenu.addAction("a3");
QList<QAction*> actionList;
actionList << a1 << a2 << a3;
// Check out exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
// Get exported menu info
QStringList propertyNames = QStringList() << "label" << "shortcut";
DBusMenuLayoutItemList list = getChildren(&iface, 0, propertyNames);
QCOMPARE(list.count(), actionList.count());
Q_FOREACH(const QAction* action, actionList) {
DBusMenuLayoutItem item = list.takeFirst();
if (action->shortcut().isEmpty()) {
QVERIFY(!item.properties.contains("shortcut"));
} else {
QVERIFY(item.properties.contains("shortcut"));
QDBusArgument arg = item.properties.value("shortcut").value<QDBusArgument>();
DBusMenuShortcut shortcut;
arg >> shortcut;
QCOMPARE(shortcut.toKeySequence(), action->shortcut());
}
}
}
void DBusMenuExporterTest::testGetGroupProperties()
{
// Create a menu containing two actions
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
QAction *a1 = inputMenu.addAction("a1");
QAction *a2 = inputMenu.addAction("a2");
// Check exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
// Get item ids
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), inputMenu.actions().count());
int id1 = list.at(0).id;
int id2 = list.at(1).id;
// Get group properties
QList<int> ids = QList<int>() << id1 << id2;
QDBusReply<DBusMenuItemList> reply = iface.call("GetGroupProperties", QVariant::fromValue(ids), QStringList());
QVERIFY2(reply.isValid(), qPrintable(reply.error().message()));
DBusMenuItemList groupPropertiesList = reply.value();
// Check the info we received
QCOMPARE(groupPropertiesList.count(), inputMenu.actions().count());
Q_FOREACH(const QAction* action, inputMenu.actions()) {
DBusMenuItem item = groupPropertiesList.takeFirst();
QCOMPARE(item.properties.value("label").toString(), action->text());
}
}
void DBusMenuExporterTest::testActivateAction()
{
// Create a menu containing two actions
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
QAction *a1 = inputMenu.addAction("a1");
QAction *a2 = inputMenu.addAction("a2");
// Check exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
ManualSignalSpy spy;
QDBusConnection::sessionBus().connect(TEST_SERVICE, TEST_OBJECT_PATH, "com.canonical.dbusmenu", "ItemActivationRequested", "iu", &spy, SLOT(receiveCall(int, uint)));
// Get item ids
DBusMenuLayoutItemList list = getChildren(&iface, 0, QStringList());
QCOMPARE(list.count(), inputMenu.actions().count());
int id1 = list.at(0).id;
int id2 = list.at(1).id;
// Trigger actions
exporter->activateAction(a1);
exporter->activateAction(a2);
// Check we received the signals in the correct order
QTest::qWait(500);
QCOMPARE(spy.count(), 2);
QCOMPARE(spy.takeFirst().at(0).toInt(), id1);
QCOMPARE(spy.takeFirst().at(0).toInt(), id2);
}
static int trackCount(QMenu* menu)
{
QList<QObject*> lst = menu->findChildren<QObject*>();
int count = 0;
Q_FOREACH(QObject* child, lst) {
if (qstrcmp(child->metaObject()->className(), "DBusMenu") == 0) {
++count;
}
}
return count;
}
// Check we do not create more than one DBusMenu object for each menu
// See KDE bug 254066
void DBusMenuExporterTest::testTrackActionsOnlyOnce()
{
// Create a menu with a submenu, unplug the submenu and plug it back. The
// submenu should not have more than one DBusMenu child object.
QMenu mainMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &mainMenu);
QMenu* subMenu = new QMenu("File");
subMenu->addAction("a1");
mainMenu.addAction(subMenu->menuAction());
QTest::qWait(500);
QCOMPARE(trackCount(subMenu), 1);
mainMenu.removeAction(subMenu->menuAction());
mainMenu.addAction(subMenu->menuAction());
QTest::qWait(500);
QCOMPARE(trackCount(subMenu), 1);
}
// If desktop does not want icon in menus, check we do not export them
void DBusMenuExporterTest::testHonorDontShowIconsInMenusAttribute()
{
QCoreApplication::setAttribute(Qt::AA_DontShowIconsInMenus, true);
QMenu inputMenu;
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
QAction *action = new QAction("Undo", &inputMenu);
QIcon icon = QIcon::fromTheme("edit-undo");
QVERIFY(!icon.isNull());
action->setIcon(icon);
inputMenu.addAction(action);
// Check out exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
// Get exported menu info
QStringList propertyNames = QStringList() << "icon-name";
DBusMenuLayoutItemList list = getChildren(&iface, /*parentId=*/0, propertyNames);
DBusMenuLayoutItem item = list.first();
QVERIFY(item.id != 0);
QVERIFY(!item.properties.contains("icon-name"));
}
static bool hasInternalDBusMenuObject(QMenu* menu)
{
Q_FOREACH(QObject* obj, menu->children()) {
if (obj->inherits("DBusMenu")) {
return true;
}
}
return false;
}
// DBusMenuExporter adds an instance of an internal class named "DBusMenu" to
// any QMenu it tracks. Check they go away when the exporter is deleted.
void DBusMenuExporterTest::testDBusMenuObjectIsDeletedWhenExporterIsDeleted()
{
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
QAction *a1 = inputMenu.addAction("a1");
QVERIFY2(hasInternalDBusMenuObject(&inputMenu), "Test setup failed");
delete exporter;
QVERIFY(!hasInternalDBusMenuObject(&inputMenu));
}
void DBusMenuExporterTest::testSeparatorCollapsing_data()
{
QTest::addColumn<QString>("input");
QTest::addColumn<QString>("expected");
QTest::newRow("one-separator") << "a-b" << "a-b";
QTest::newRow("two-separators") << "a-b-c" << "a-b-c";
QTest::newRow("middle-separators") << "a--b" << "a-b";
QTest::newRow("separators-at-begin") << "--a-b" << "a-b";
QTest::newRow("separators-at-end") << "a-b--" << "a-b";
QTest::newRow("separators-everywhere") << "--a---bc--d--" << "a-bc-d";
QTest::newRow("empty-menu") << "" << "";
QTest::newRow("separators-only") << "---" << "";
}
void DBusMenuExporterTest::testSeparatorCollapsing()
{
QFETCH(QString, input);
QFETCH(QString, expected);
// Create menu from menu string
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
if (input.isEmpty()) {
// Pretend there was an action so that doEmitLayoutUpdated() is called
// even if the new menu is empty. If we don't do this we don't test
// DBusMenuExporterPrivate::collapseSeparators() for empty menus.
delete inputMenu.addAction("dummy");
}
Q_FOREACH(QChar ch, input) {
if (ch == '-') {
inputMenu.addSeparator();
} else {
inputMenu.addAction(ch);
}
}
QTest::qWait(500);
// Check out exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
// Get exported menu info
QStringList propertyNames = QStringList();
DBusMenuLayoutItemList list = getChildren(&iface, /*parentId=*/0, propertyNames);
// Recreate a menu string from the item list
QString output;
Q_FOREACH(const DBusMenuLayoutItem& item, list) {
QVariantMap properties = item.properties;
if (properties.contains("visible") && !properties.value("visible").toBool()) {
continue;
}
QString type = properties.value("type").toString();
if (type == "separator") {
output += '-';
} else {
output += properties.value("label").toString();
}
}
// Check it matches
QCOMPARE(output, expected);
}
static void checkPropertiesChangedArgs(const QVariantList& args, const QString& name, const QVariant& value)
{
QCOMPARE(args[0].toString(), QString("com.canonical.dbusmenu"));
QVariantMap map;
map.insert(name, value);
QCOMPARE(args[1].toMap(), map);
QCOMPARE(args[2].toStringList(), QStringList());
}
void DBusMenuExporterTest::testSetStatus()
{
QMenu inputMenu;
QVERIFY(QDBusConnection::sessionBus().registerService(TEST_SERVICE));
DBusMenuExporter *exporter = new DBusMenuExporter(TEST_OBJECT_PATH, &inputMenu);
ManualSignalSpy spy;
QDBusConnection::sessionBus().connect(TEST_SERVICE, TEST_OBJECT_PATH, "org.freedesktop.DBus.Properties", "PropertiesChanged", "sa{sv}as", &spy, SLOT(receiveCall(QString, QVariantMap, QStringList)));
QTest::qWait(500);
// Check our exporter is on DBus
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
QVERIFY2(iface.isValid(), qPrintable(iface.lastError().message()));
QCOMPARE(exporter->status(), QString("normal"));
// Change status, a DBus signal should be emitted
exporter->setStatus("notice");
QCOMPARE(exporter->status(), QString("notice"));
QTest::qWait(500);
QCOMPARE(spy.count(), 1);
checkPropertiesChangedArgs(spy.takeFirst(), "Status", "notice");
// Same status => no signal
exporter->setStatus("notice");
QTest::qWait(500);
QCOMPARE(spy.count(), 0);
// Change status, a DBus signal should be emitted
exporter->setStatus("normal");
QTest::qWait(500);
QCOMPARE(spy.count(), 1);
checkPropertiesChangedArgs(spy.takeFirst(), "Status", "normal");
}
void DBusMenuExporterTest::testGetIconDataProperty()
{
// Create an icon
QImage img(16, 16, QImage::Format_ARGB32);
{
QPainter painter(&img);
painter.setCompositionMode(QPainter::CompositionMode_Source);
QRect rect = img.rect();
painter.fillRect(rect, Qt::transparent);
rect.adjust(2, 2, -2, -2);
painter.fillRect(rect, Qt::red);
rect.adjust(2, 2, -2, -2);
painter.fillRect(rect, Qt::green);
}
QIcon icon(QPixmap::fromImage(img));
// Create a menu with the icon and export it
QMenu inputMenu;
QAction* a1 = inputMenu.addAction("a1");
a1->setIcon(icon);
DBusMenuExporter exporter(TEST_OBJECT_PATH, &inputMenu);
// Get properties
QDBusInterface iface(TEST_SERVICE, TEST_OBJECT_PATH);
DBusMenuLayoutItemList layoutItemlist = getChildren(&iface, 0, QStringList());
QCOMPARE(layoutItemlist.count(), 1);
QList<int> ids = QList<int>() << layoutItemlist[0].id;
QDBusReply<DBusMenuItemList> reply = iface.call("GetGroupProperties", QVariant::fromValue(ids), QStringList());
DBusMenuItemList itemlist = reply.value();
QCOMPARE(itemlist.count(), 1);
// Check we have the right property
DBusMenuItem item = itemlist.takeFirst();
QVERIFY(!item.properties.contains("icon-name"));
QVERIFY(item.properties.contains("icon-data"));
// Check saved image is the same
QByteArray data = item.properties.value("icon-data").toByteArray();
QVERIFY(!data.isEmpty());
QImage result;
QVERIFY(result.loadFromData(data, "PNG"));
QCOMPARE(result, img);
}
#include "dbusmenuexportertest.moc"
|