1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
package Module::CPANTS::Kwalitee::BrokenInstaller;
use warnings;
use strict;
use File::Find;
use File::Spec::Functions qw(catdir catfile abs2rel);
use File::stat;
sub order { 100 }
sub analyse {
my $class = shift;
my $me = shift;
my $distdir = $me->distdir;
# inc/Module/Install.pm file
my $mi = catfile($distdir, 'inc', 'Module', 'Install.pm');
# Must be okay if not using Module::Install
if (not -f $mi) {
$me->d->{broken_module_install} = 0;
return;
}
open my $ih, '<', $mi
or die "Could not open file '$mi' for checking the bad_installer metric: $!";
my $buf;
read $ih, $buf, 100000 or die $!;
close $ih;
if ($buf =~ /VERSION\s*=\s*("|'|)(\d+|\d*\.\d+(?:_\d+)?)\1/m) {
my $version = $2;
my $non_devel = $version;
$non_devel =~ s/_\d+$//;
if ($non_devel < 0.61) {
$me->d->{broken_module_install} = $version;
}
elsif ($non_devel < 0.89) {
$me->d->{broken_module_install} = 0;
my $makefilepl = catfile($distdir, 'Makefile.PL');
return if not -f $makefilepl;
open my $ih, '<', $makefilepl
or die "Could not open file '$makefilepl' for checking the bad_installer metric: $!";
local $/ = undef;
my $mftext = <$ih>;
close $ih;
return if not defined $mftext;
if ($non_devel < 0.61) {
$me->d->{broken_module_install} = $version;
return;
}
if ($mftext =~ /auto_install/) {
$me->d->{mi_auto_install_used} = 1;
} else {
return;
}
if ($non_devel < 0.64) {
$me->d->{broken_module_install} = $version;
}
}
else {
$me->d->{broken_module_install} = 0;
}
}
else {
# Unknown version (parsing $VERSION failed)
$me->d->{broken_module_install} = 1;
}
return;
}
sub kwalitee_indicators {
return [
{
name=>'has_working_buildtool',
error=>q{This package uses an obsolete version of Module::Install. Versions of Module::Install prior to 0.61 might not work on some systems at all. Additionally if your Makefile.PL uses the 'auto_install()' feature, you need at least version 0.64.},
remedy=>q{Upgrade the bundled version of Module::Install to at least 0.61, but preferably to the most current release. Alternatively, you can switch to another build system / installer that does not suffer from this problem. (ExtUtils::MakeMaker, Module::Build both of which have their own set of problems.)},
code=>sub {
shift->{broken_module_install} ? 0 : 1 },
},
{
name=>'has_better_auto_install',
error=>q{This package uses an old version of Module::Install. Versions of Module::Install prior to 0.89 Does not detect correcty that CPAN/CPANPLUS shell is used.},
remedy=>q{Upgrade the bundled version of Module::Install to at least 0.89, but preferably to the most current release. Alternatively, you can switch to another build system / installer that does not suffer from this problem. (ExtUtils::MakeMaker, Module::Build both of which have their own set of problems.)},
code=>sub {
shift->{mi_auto_install_used} ? 0 : 1 },
},
];
}
1
__END__
=encoding UTF-8
=head1 NAME
Module::CPANTS::Kwalitee::BrokenInstaller - Check for broken Module::Install
=head1 SYNOPSIS
Find out whether the distribution uses an outdaten version of Module::Install.
=head1 DESCRIPTION
=head2 Methods
=head3 order
Defines the order in which Kwalitee tests should be run.
Returns C<100>, as data generated by this should not be
used by any other tests.
=head3 analyse
C<MCK::BrokenInstaller> checks whether the distribution uses Module::Install
and if so whether it uses a reasonably current version of it (0.61 or later).
It also checks whether the F<Makefile.PL> uses the C<auto_install> feature.
If so, C<Module::Install> should be at least version 0.64.
=head3 kwalitee_indicators
Returns the Kwalitee Indicators datastructure.
=over
=item * uses_broken_installer
=back
=head1 SEE ALSO
L<Module::CPANTS::Analyse>
=head1 AUTHOR
L<Steffen Müller|https://metacpan.org/author/smueller>
L<Thomas Klausner|https://metacpan.org/author/domm>
=head1 COPYRIGHT AND LICENSE
Copyright © 2003–2009 L<Thomas Klausner|https://metacpan.org/author/domm>
Copyright © 2006 L<Steffen Müller|https://metacpan.org/author/smueller>
You may use and distribute this module according to the same terms
that Perl is distributed under.
|
