1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
|
/*
* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @summary tests for module declarations
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* @build toolbox.ToolBox toolbox.JavacTask ModuleTestBase
* @run main ExportsUnexported
*/
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import toolbox.JavacTask;
import toolbox.Task;
public class ExportsUnexported extends ModuleTestBase {
public static void main(String... args) throws Exception {
ExportsUnexported t = new ExportsUnexported();
t.runTests();
}
@Test
public void testLocations(Path base) throws Exception {
String warningsTest = "package api;\n" +
"import impl.impl.*;\n" +
"@impl.impl^.DocAnn\n" +
"public abstract class Api<T extends impl.impl^.Cls&impl.impl^.Intf> extends impl.impl^.Cls implements impl.impl^.Intf, impl.impl^.NonDocAnn, impl.impl^.DocAnn {\n" +
" public static <E extends impl.impl^.Cls&impl.impl^.Intf> impl.impl^.Cls m(impl.impl^.Intf i, impl.impl^.Cls c) throws impl.impl^.Exc { return null; }\n" +
" public static impl.impl^.Cls f;\n" +
"}";
String noWarningsTest = "package api;\n" +
"import impl.impl.*;\n" +
"@impl.impl.NonDocAnn\n" +
"public abstract class Api {\n" +
" private static abstract class I <T extends impl.impl.Cls&impl.impl.Intf> extends impl.impl.Cls implements impl.impl.Intf, impl.impl.NonDocAnn, impl.impl.DocAnn {\n" +
" public static abstract class II <T extends impl.impl.Cls&impl.impl.Intf> extends impl.impl.Cls implements impl.impl.Intf, impl.impl.NonDocAnn, impl.impl.DocAnn { }\n" +
" public static <E extends impl.impl.Cls&impl.impl.Intf> impl.impl.Cls m(impl.impl.Intf i, impl.impl.Cls c) throws impl.impl.Exc { return null; }\n" +
" public static impl.impl.Cls f;\n" +
" }\n" +
" private static <E extends impl.impl.Cls&impl.impl.Intf> impl.impl.Cls m(impl.impl.Intf i, impl.impl.Cls c) throws impl.impl.Exc { return null; }\n" +
" private static impl.impl.Cls f1;\n" +
" public static void m() { new impl.impl.Cls(); }\n" +
" public static Object f2 = new impl.impl.Cls();\n" +
"}";
for (String genericTest : new String[] {warningsTest, noWarningsTest}) {
for (String test : new String[] {genericTest, genericTest.replaceAll("impl\\.impl\\^.([A-Za-z])", "^$1").replaceAll("impl\\.impl\\.([A-Za-z])", "$1")}) {
System.err.println("testing: " + test);
Path src = base.resolve("src");
Path src_m1 = src.resolve("m1x");
StringBuilder testCode = new StringBuilder();
List<String> expectedLog = new ArrayList<>();
int line = 1;
int col = 1;
for (int i = 0; i < test.length(); i++) {
char c = test.charAt(i);
if (c == '^') {
StringBuilder typeName = new StringBuilder();
for (int j = i + 1 + (test.charAt(i + 1) == '.' ? 1 : 0);
j < test.length() && Character.isJavaIdentifierPart(test.charAt(j));
j++) {
typeName.append(test.charAt(j));
}
String kindName;
switch (typeName.toString()) {
case "Exc": case "DocAnn": case "NonDocAnn":
case "Cls": kindName = "kindname.class"; break;
case "Intf": kindName = "kindname.interface"; break;
default:
throw new AssertionError(typeName.toString());
}
expectedLog.add("Api.java:" + line + ":" + col
+ ": compiler.warn.leaks.not.accessible.unexported: "
+ kindName + ", impl.impl." + typeName + ", m1x");
continue;
}
if (c == '\n') {
line++;
col = 0;
}
testCode.append(c);
col++;
}
if (!expectedLog.isEmpty()) {
expectedLog.add("" + expectedLog.size() + " warning" + (expectedLog.size() == 1 ? "" : "s"));
expectedLog.add("- compiler.err.warnings.and.werror");
expectedLog.add("1 error");
}
Collections.sort(expectedLog);
tb.writeJavaFiles(src_m1,
"module m1x { exports api; }",
testCode.toString(),
"package impl.impl; public class Cls { }",
"package impl.impl; public class Exc extends Exception { }",
"package impl.impl; public interface Intf { }",
"package impl.impl; @java.lang.annotation.Documented public @interface DocAnn { }",
"package impl.impl; public @interface NonDocAnn { }");
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log = new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Werror",
"--module-source-path", src.toString(),
"-Xlint:exports")
.outdir(classes)
.files(findJavaFiles(src))
.run(expectedLog.isEmpty() ? Task.Expect.SUCCESS : Task.Expect.FAIL)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
log = new ArrayList<>(log);
Collections.sort(log);
if (expectedLog.isEmpty() ? !log.equals(Arrays.asList("")) : !log.equals(expectedLog)) {
throw new Exception("expected output not found in: " + log + "; " + expectedLog);
}
}
}
}
@Test
public void testAccessibleToSpecificOrAll(Path base) throws Exception {
Path src = base.resolve("src");
Path src_lib1 = src.resolve("lib1x");
tb.writeJavaFiles(src_lib1,
"module lib1x { exports lib1; }",
"package lib1; public class Lib1 {}");
Path src_lib2 = src.resolve("lib2x");
tb.writeJavaFiles(src_lib2,
"module lib2x { exports lib2; }",
"package lib2; public class Lib2 {}");
Path src_api = src.resolve("api");
tb.writeJavaFiles(src_api,
"module api {\n" +
" exports api;\n" +
" exports qapi1 to qual1x;\n" +
" exports qapi2 to qual1x, qual2x;\n" +
" requires transitive lib1x;\n" +
" requires lib2x;\n" +
"}\n",
"package api;\n" +
"public class Api {\n" +
" public lib1.Lib1 lib1;\n" +
" public lib2.Lib2 lib2;\n" +
" public qapi1.QApi1 qapi1;\n" +
" public impl.Impl impl;\n" +
"}",
"package qapi1;\n" +
"public class QApi1 {\n" +
" public qapi2.QApi2 qapi2;\n" +
"}",
"package qapi2;\n" +
"public class QApi2 {\n" +
" public qapi1.QApi1 qapi1;\n" +
"}",
"package impl;\n" +
"public class Impl {\n" +
"}");
Path src_qual1 = src.resolve("qual1x");
tb.writeJavaFiles(src_qual1, "module qual1x { }");
Path src_qual2 = src.resolve("qual2x");
tb.writeJavaFiles(src_qual2, "module qual2x { }");
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log = new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Werror",
"--module-source-path", src.toString(),
"-Xlint:exports")
.outdir(classes)
.files(findJavaFiles(src))
.run(Task.Expect.FAIL)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
List<String> expected = Arrays.asList(
"Api.java:4:16: compiler.warn.leaks.not.accessible.not.required.transitive: kindname.class, lib2.Lib2, lib2x",
"Api.java:5:17: compiler.warn.leaks.not.accessible.unexported.qualified: kindname.class, qapi1.QApi1, api",
"Api.java:6:16: compiler.warn.leaks.not.accessible.unexported: kindname.class, impl.Impl, api",
"- compiler.err.warnings.and.werror",
"1 error",
"3 warnings"
);
if (!log.equals(expected))
throw new Exception("expected output not found");
}
@Test
public void testNestedClasses(Path base) throws Exception {
Path src = base.resolve("src");
Path src_api = src.resolve("api");
tb.writeJavaFiles(src_api,
"module api {\n" +
" exports api;\n" +
"}\n",
"package api;\n" +
"import impl.Impl.Nested;\n" +
"public class Api {\n" +
" public impl.Impl impl1;\n" +
" public impl.Impl.Nested impl2;\n" +
" public Nested impl3;\n" +
"}",
"package impl;\n" +
"public class Impl {\n" +
" public static class Nested {\n" +
" }\n" +
"}");
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log = new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Werror",
"--module-source-path", src.toString(),
"-Xlint:exports")
.outdir(classes)
.files(findJavaFiles(src))
.run(Task.Expect.FAIL)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
List<String> expected = Arrays.asList(
"Api.java:4:16: compiler.warn.leaks.not.accessible.unexported: kindname.class, impl.Impl, api",
"Api.java:5:16: compiler.warn.leaks.not.accessible.unexported: kindname.class, impl.Impl, api",
"Api.java:6:12: compiler.warn.leaks.not.accessible.unexported: kindname.class, impl.Impl.Nested, api",
"- compiler.err.warnings.and.werror",
"1 error",
"3 warnings"
);
if (!log.equals(expected))
throw new Exception("expected output not found");
}
@Test
public void testProtectedAndInaccessible(Path base) throws Exception {
Path src = base.resolve("src");
Path src_api = src.resolve("api");
tb.writeJavaFiles(src_api,
"module api {\n" +
" exports api;\n" +
"}\n",
"package api;\n" +
"public class Api extends PackagePrivateClass<PackagePrivateInterface> implements PackagePrivateInterface<PackagePrivateClass> {\n" +
" protected PackagePrivateClass<?> f1;\n" +
" protected PackagePrivateInterface<?> f2;\n" +
" protected Inner f3;\n" +
" protected PrivateInner f4;\n" +
" protected impl.Impl f5;\n" +
" public static class InnerClass extends PrivateInner {}\n" +
" protected static class Inner {}\n" +
" private static class PrivateInner {}\n" +
"}\n" +
"class PackagePrivateClass<T> {}\n" +
"interface PackagePrivateInterface<T> {}",
"package impl;\n" +
"public class Impl {\n" +
"}");
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log = new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Werror",
"--module-source-path", src.toString(),
"-Xlint:exports")
.outdir(classes)
.files(findJavaFiles(src))
.run(Task.Expect.FAIL)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
List<String> expected = Arrays.asList(
"Api.java:2:46: compiler.warn.leaks.not.accessible: kindname.interface, api.PackagePrivateInterface, api",
"Api.java:2:106: compiler.warn.leaks.not.accessible: kindname.class, api.PackagePrivateClass, api",
"Api.java:3:15: compiler.warn.leaks.not.accessible: kindname.class, api.PackagePrivateClass, api",
"Api.java:4:15: compiler.warn.leaks.not.accessible: kindname.interface, api.PackagePrivateInterface, api",
"Api.java:6:15: compiler.warn.leaks.not.accessible: kindname.class, api.Api.PrivateInner, api",
"Api.java:7:19: compiler.warn.leaks.not.accessible.unexported: kindname.class, impl.Impl, api",
"- compiler.err.warnings.and.werror",
"1 error",
"6 warnings"
);
if (!log.equals(expected))
throw new Exception("expected output not found");
}
@Test
public void testSuppressResetProperly(Path base) throws Exception {
Path src = base.resolve("src");
Path src_api = src.resolve("api");
tb.writeJavaFiles(src_api,
"module api {\n" +
" exports api;\n" +
"}\n",
"package api;\n" +
"public class Api {\n" +
" @SuppressWarnings(\"exports\")\n" +
" public PackagePrivateClass f1;\n" +
" public PackagePrivateClass f2;\n" +
" @SuppressWarnings(\"exports\")\n" +
" public void t() {}\n" +
" public PackagePrivateClass f3;\n" +
" @SuppressWarnings(\"exports\")\n" +
" public static class C {\n" +
" public PackagePrivateClass f4;\n" +
" }\n" +
" public PackagePrivateClass f5;\n" +
"}\n" +
"class PackagePrivateClass<T> {}\n");
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log = new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Werror",
"--module-source-path", src.toString(),
"-Xlint:exports")
.outdir(classes)
.files(findJavaFiles(src))
.run(Task.Expect.FAIL)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
List<String> expected = Arrays.asList(
"Api.java:5:12: compiler.warn.leaks.not.accessible: kindname.class, api.PackagePrivateClass, api",
"Api.java:8:12: compiler.warn.leaks.not.accessible: kindname.class, api.PackagePrivateClass, api",
"Api.java:13:12: compiler.warn.leaks.not.accessible: kindname.class, api.PackagePrivateClass, api",
"- compiler.err.warnings.and.werror",
"1 error",
"3 warnings"
);
if (!log.equals(expected))
throw new Exception("expected output not found");
}
}
|
