1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
|
/*
* Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8176327
* @summary javac produces wrong module-info
* @library /tools/lib
* @modules
* jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* @build toolbox.ToolBox toolbox.JavacTask ModuleTestBase
* @run main SourcePathTest
*/
import java.io.IOException;
import java.nio.file.FileVisitResult;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.SimpleFileVisitor;
import java.nio.file.attribute.BasicFileAttributes;
import java.util.ArrayList;
import java.util.List;
import toolbox.JavacTask;
import toolbox.Task;
public class SourcePathTest extends ModuleTestBase {
public static void main(String... args) throws Exception {
SourcePathTest t = new SourcePathTest();
t.runTests();
}
@Test
public void test_unnamedModuleOnSourcePath_fileNotOnPath(Path base) throws IOException {
Path src = base.resolve("src");
tb.writeJavaFiles(src, "package p; public class A { }");
Path otherSrc = base.resolve("otherSrc");
tb.writeJavaFiles(otherSrc, "package p2; public class B { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
new JavacTask(tb)
.options("-sourcepath", src.toString())
.outdir(classes)
.files(findJavaFiles(otherSrc))
.run()
.writeAll();
showFiles(classes);
}
@Test
public void test_unnamedModuleOnSourcePath_fileOnPath(Path base) throws IOException {
Path src = base.resolve("src");
tb.writeJavaFiles(src, "package p; public class A { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
new JavacTask(tb)
.options("-sourcepath", src.toString())
.outdir(classes)
.files(findJavaFiles(src))
.run()
.writeAll();
showFiles(classes);
}
@Test
public void test_namedModuleOnSourcePath_fileNotOnPath_1(Path base) throws Exception {
Path src = base.resolve("src");
tb.writeFile(src.resolve("module-info.java"), "module m { exports p; }");
tb.writeJavaFiles(src, "package p; public class A { }");
Path otherSrc = base.resolve("otherSrc");
tb.writeJavaFiles(otherSrc, "package p2; public class B { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true", "-sourcepath", src.toString())
.outdir(classes)
.files(findJavaFiles(otherSrc))
.run(Task.Expect.FAIL)
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
checkOutputContains(log,
"B.java:1:1: compiler.err.file.sb.on.source.or.patch.path.for.module");
}
@Test
public void test_namedModuleOnSourcePath_fileNotOnPath_2(Path base) throws Exception {
// This is the original test case:
// the source path contains one module, but the file to be compiled appears to be
// in another module.
Path src = base.resolve("src");
Path src_mA = src.resolve("mA");
tb.writeJavaFiles(src_mA,
"module mA { exports p; }",
"package p; public class A { }");
Path src_mB = src.resolve("mB");
tb.writeJavaFiles(src_mB,
"module mA { exports p2; }",
"package p2; public class B { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true", "-sourcepath", src_mA.toString())
.outdir(classes)
.files(findJavaFiles(src_mB.resolve("p2")))
.run(Task.Expect.FAIL)
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
checkOutputContains(log,
"B.java:1:1: compiler.err.file.sb.on.source.or.patch.path.for.module");
}
@Test
public void test_namedModuleOnSourcePath_fileOnPath(Path base) throws Exception {
Path src = base.resolve("src");
tb.writeFile(src.resolve("module-info.java"), "module m { exports p; }");
tb.writeJavaFiles(src, "package p; public class A { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true", "-sourcepath", src.toString())
.outdir(classes)
.files(findJavaFiles(src.resolve("p")))
.run()
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
}
@Test
public void test_namedModuleOnSourcePath_fileOnPatchPath(Path base) throws Exception {
// similar to test_namedModuleOnSourcePath_fileNotOnPath_1
// except that other src directory is not put on the patch path
Path src = base.resolve("src");
tb.writeFile(src.resolve("module-info.java"), "module m { exports p; }");
tb.writeJavaFiles(src, "package p; public class A { }");
Path otherSrc = base.resolve("otherSrc");
tb.writeJavaFiles(otherSrc, "package p2; public class B { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true",
"-sourcepath", src.toString(),
"--patch-module", "m=" + otherSrc)
.outdir(classes)
.files(findJavaFiles(otherSrc))
.run()
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
}
/*
* The following tests are not for the source path, but they exercise similar test
* cases for the module source path.
*/
@Test
public void test_moduleSourcePath_fileNotOnPath(Path base) throws Exception {
Path src = base.resolve("src");
Path src_mA = src.resolve("mA");
tb.writeJavaFiles(src_mA,
"module mA { exports p; }",
"package p; public class A { }");
Path src_mB = src.resolve("mB");
tb.writeJavaFiles(src_mB,
"module mB { exports p2; }",
"package p2; public class B { }");
Path otherSrc = base.resolve("otherSrc");
tb.writeJavaFiles(otherSrc, "package p3; public class C { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true",
"--module-source-path", src.toString())
.outdir(classes)
.files(findJavaFiles(otherSrc))
.run(Task.Expect.FAIL)
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
checkOutputContains(log,
"C.java:1:1: compiler.err.not.in.module.on.module.source.path");
}
@Test
public void test_moduleSourcePath_fileOnPath(Path base) throws Exception {
Path src = base.resolve("src");
Path src_mA = src.resolve("mA");
tb.writeJavaFiles(src_mA,
"module mA { exports p; }",
"package p; public class A { }");
Path src_mB = src.resolve("mB");
tb.writeJavaFiles(src_mB,
"module mB { exports p2; }",
"package p2; public class B { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true",
"--module-source-path", src.toString())
.outdir(classes)
.files(findJavaFiles(src_mB.resolve("p2")))
.run()
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
}
@Test
public void test_moduleSourcePath_fileOnPatchPath(Path base) throws Exception {
// similar to test_moduleSourcePath_fileNotOnPath
// except that other src directory is not put on the patch path
Path src = base.resolve("src");
Path src_mA = src.resolve("mA");
tb.writeJavaFiles(src_mA,
"module mA { exports p; }",
"package p; public class A { }");
Path src_mB = src.resolve("mB");
tb.writeJavaFiles(src_mB,
"module mB { exports p2; }",
"package p2; public class B { }");
Path otherSrc = base.resolve("otherSrc");
tb.writeJavaFiles(otherSrc, "package p3; public class C { }");
Path classes = base.resolve("classes");
Files.createDirectories(classes);
String log = new JavacTask(tb)
.options("-XDrawDiagnostics=true",
"--module-source-path", src.toString(),
"--patch-module", "mA=" + otherSrc)
.outdir(classes)
.files(findJavaFiles(otherSrc))
.run()
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
showFiles(classes);
}
/**
* This method is primarily used to give visual confirmation that a test case
* generated files when the compilation succeeds and so generates no other output,
* such as error messages.
*/
List<Path> showFiles(Path dir) throws IOException {
List<Path> files = new ArrayList<>();
Files.walkFileTree(dir, new SimpleFileVisitor<Path>() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes attrs)
throws IOException {
if (Files.isRegularFile(file)) {
out.println("Found " + file);
files.add(file);
}
return FileVisitResult.CONTINUE;
}
});
return files;
}
}
|
