1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289
|
/*
* Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8000612
* @summary need test program to validate javadoc resource bundles
* @modules jdk.javadoc/jdk.javadoc.internal.tool
* jdk.javadoc/jdk.javadoc.internal.doclets.formats.html.resources:open
* jdk.javadoc/jdk.javadoc.internal.doclets.toolkit.resources:open
* jdk.javadoc/jdk.javadoc.internal.tool.resources:open
* jdk.jdeps/com.sun.tools.classfile
*/
import java.io.*;
import java.util.*;
import javax.tools.*;
import com.sun.tools.classfile.*;
/**
* Compare string constants in javadoc classes against keys in javadoc resource bundles.
*/
public class CheckResourceKeys {
/**
* Main program.
* Options:
* -finddeadkeys
* look for keys in resource bundles that are no longer required
* -findmissingkeys
* look for keys in resource bundles that are missing
*
* @throws Exception if invoked by jtreg and errors occur
*/
public static void main(String... args) throws Exception {
CheckResourceKeys c = new CheckResourceKeys();
if (c.run(args))
return;
if (is_jtreg())
throw new Exception(c.errors + " errors occurred");
else
System.exit(1);
}
static boolean is_jtreg() {
return (System.getProperty("test.src") != null);
}
/**
* Main entry point.
*/
boolean run(String... args) throws Exception {
boolean findDeadKeys = false;
boolean findMissingKeys = false;
if (args.length == 0) {
if (is_jtreg()) {
findDeadKeys = true;
findMissingKeys = true;
} else {
System.err.println("Usage: java CheckResourceKeys <options>");
System.err.println("where options include");
System.err.println(" -finddeadkeys find keys in resource bundles which are no longer required");
System.err.println(" -findmissingkeys find keys in resource bundles that are required but missing");
return true;
}
} else {
for (String arg: args) {
if (arg.equalsIgnoreCase("-finddeadkeys"))
findDeadKeys = true;
else if (arg.equalsIgnoreCase("-findmissingkeys"))
findMissingKeys = true;
else
error("bad option: " + arg);
}
}
if (errors > 0)
return false;
Set<String> codeKeys = getCodeKeys();
Set<String> resourceKeys = getResourceKeys();
System.err.println("found " + codeKeys.size() + " keys in code");
System.err.println("found " + resourceKeys.size() + " keys in resource bundles");
if (findDeadKeys)
findDeadKeys(codeKeys, resourceKeys);
if (findMissingKeys)
findMissingKeys(codeKeys, resourceKeys);
usageTests(false);
usageTests(true);
return (errors == 0);
}
void usageTests(boolean xflag) {
String[] argarray = { xflag ? "-X" : "-help" };
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
if (jdk.javadoc.internal.tool.Main.execute(argarray, pw) == 0) {
pw.flush();
String s = sw.toString();
if (s.isEmpty()) {
error("no javadoc output ?");
return;
}
if (sw.toString().contains("<MISSING KEY>")) {
System.out.println(s);
error("missing resources in output ?");
}
} else {
error("failed to execute javadoc");
}
}
/**
* Find keys in resource bundles which are probably no longer required.
* A key is required if there is a string in the code that is a resource key,
* or if the key is well-known according to various pragmatic rules.
*/
void findDeadKeys(Set<String> codeKeys, Set<String> resourceKeys) {
for (String rk: resourceKeys) {
// ignore these synthesized keys, tested by usageTests
if (rk.startsWith("doclet.usage.") || rk.startsWith("doclet.xusage"))
continue;
// ignore these synthesized keys, tested by usageTests
if (rk.matches("main\\.opt\\..*\\.(arg|desc)"))
continue;
if (codeKeys.contains(rk))
continue;
error("Resource key not found in code: '" + rk + '"');
}
}
/**
* For all strings in the code that look like they might be
* a resource key, verify that a key exists.
*/
void findMissingKeys(Set<String> codeKeys, Set<String> resourceKeys) {
for (String ck: codeKeys) {
// ignore these synthesized keys, tested by usageTests
if (ck.startsWith("doclet.usage.") || ck.startsWith("doclet.xusage."))
continue;
// ignore this partial key, tested by usageTests
if (ck.equals("main.opt."))
continue;
if (resourceKeys.contains(ck))
continue;
error("No resource for \"" + ck + "\"");
}
}
/**
* Get the set of strings from (most of) the javadoc classfiles.
*/
Set<String> getCodeKeys() throws IOException {
Set<String> results = new TreeSet<String>();
JavaCompiler c = ToolProvider.getSystemJavaCompiler();
try (JavaFileManager fm = c.getStandardFileManager(null, null, null)) {
JavaFileManager.Location javadocLoc = findJavadocLocation(fm);
String[] pkgs = {
"jdk.javadoc.internal.doclets",
"jdk.javadoc.internal.tool"
};
for (String pkg: pkgs) {
for (JavaFileObject fo: fm.list(javadocLoc,
pkg, EnumSet.of(JavaFileObject.Kind.CLASS), true)) {
String name = fo.getName();
// ignore resource files
if (name.matches(".*resources.[A-Za-z_0-9]+\\.class.*"))
continue;
scan(fo, results);
}
}
// special handling for code strings synthesized in
// com.sun.tools.doclets.internal.toolkit.util.Util.getTypeName
String[] extras = {
"AnnotationType", "Class", "Enum", "Error", "Exception", "Interface"
};
for (String s: extras) {
if (results.contains("doclet." + s))
results.add("doclet." + s.toLowerCase());
}
// special handling for code strings synthesized in
// com.sun.tools.javadoc.Messager
results.add("javadoc.error.msg");
results.add("javadoc.note.msg");
results.add("javadoc.note.pos.msg");
results.add("javadoc.warning.msg");
return results;
}
}
// depending on how the test is run, javadoc may be on bootclasspath or classpath
JavaFileManager.Location findJavadocLocation(JavaFileManager fm) {
JavaFileManager.Location[] locns =
{ StandardLocation.PLATFORM_CLASS_PATH, StandardLocation.CLASS_PATH };
try {
for (JavaFileManager.Location l: locns) {
JavaFileObject fo = fm.getJavaFileForInput(l,
"jdk.javadoc.internal.tool.Main", JavaFileObject.Kind.CLASS);
if (fo != null) {
System.err.println("found javadoc in " + l);
return l;
}
}
} catch (IOException e) {
throw new Error(e);
}
throw new IllegalStateException("Cannot find javadoc");
}
/**
* Get the set of strings from a class file.
* Only strings that look like they might be a resource key are returned.
*/
void scan(JavaFileObject fo, Set<String> results) throws IOException {
//System.err.println("scan " + fo.getName());
InputStream in = fo.openInputStream();
try {
ClassFile cf = ClassFile.read(in);
for (ConstantPool.CPInfo cpinfo: cf.constant_pool.entries()) {
if (cpinfo.getTag() == ConstantPool.CONSTANT_Utf8) {
String v = ((ConstantPool.CONSTANT_Utf8_info) cpinfo).value;
if (v.matches("(doclet|main|javadoc|tag)\\.[A-Za-z0-9-_.]+"))
results.add(v);
}
}
} catch (ConstantPoolException ignore) {
} finally {
in.close();
}
}
/**
* Get the set of keys from the javadoc resource bundles.
*/
Set<String> getResourceKeys() {
Module jdk_javadoc = ModuleLayer.boot().findModule("jdk.javadoc").get();
String[] names = {
"jdk.javadoc.internal.doclets.formats.html.resources.standard",
"jdk.javadoc.internal.doclets.toolkit.resources.doclets",
"jdk.javadoc.internal.tool.resources.javadoc",
};
Set<String> results = new TreeSet<String>();
for (String name : names) {
ResourceBundle b = ResourceBundle.getBundle(name, jdk_javadoc);
results.addAll(b.keySet());
}
return results;
}
/**
* Report an error.
*/
void error(String msg) {
System.err.println("Error: " + msg);
errors++;
}
int errors;
}
|