1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test 8167643 8129559
* @summary Tests for modifiers
* @build KullaTesting TestingInputStream ExpectedDiagnostic
* @run testng ModifiersTest
*/
import java.util.ArrayList;
import java.util.List;
import java.util.function.Consumer;
import javax.tools.Diagnostic;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
@Test
public class ModifiersTest extends KullaTesting {
@DataProvider(name = "ignoredModifiers")
public Object[][] getTestCases() {
List<Object[]> testCases = new ArrayList<>();
String[] ignoredModifiers = new String[] {
"static", "final"
};
String[] silentlyIgnoredModifiers = new String[] {
"public", "protected", "private"
};
String[] before = new String[] {
"strictfp", "abstract", "@X", "@X(value=9)"
};
String context = "@interface X { int value() default 0; }";
Consumer<String> eval = this::assertEval;
Consumer<String> evalWarn = s -> assertDeclareWarn1(s, "jdk.eval.warn.illegal.modifiers");
for (String ignoredModifier : ignoredModifiers) {
for (ClassType classType : ClassType.values()) {
testCases.add(new Object[] { ignoredModifier, classType, evalWarn, "", null });
}
}
for (String ignoredModifier : ignoredModifiers) {
for (String preface : before) {
testCases.add(new Object[] { ignoredModifier, ClassType.CLASS, evalWarn, preface, context});
}
}
for (String ignoredModifier : silentlyIgnoredModifiers) {
for (ClassType classType : ClassType.values()) {
testCases.add(new Object[] { ignoredModifier, classType, eval, "", null });
}
}
for (String ignoredModifier : silentlyIgnoredModifiers) {
for (String preface : before) {
testCases.add(new Object[] { ignoredModifier, ClassType.CLASS, eval, preface, context});
}
}
return testCases.toArray(new Object[testCases.size()][]);
}
@Test(dataProvider = "ignoredModifiers")
public void ignoredModifiers(String modifier, ClassType classType,
Consumer<String> eval, String preface, String context) {
if (context != null) {
assertEval(context);
}
String decl = String.format("%s %s %s A {}", preface, modifier, classType);
eval.accept(decl);
if (context != null) {
assertNumberOfActiveClasses(2);
assertClasses(clazz(ClassType.ANNOTATION, "X"), clazz(classType, "A"));
} else {
assertNumberOfActiveClasses(1);
assertClasses(clazz(classType, "A"));
}
assertActiveKeys();
}
public void accessToStaticFieldsOfClass() {
assertEval("class A {" +
"int x = 14;" +
"static int y = 18;" +
" }");
assertDeclareFail("A.x;",
new ExpectedDiagnostic("compiler.err.non-static.cant.be.ref", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertEval("A.y;", "18");
assertEval("new A().x;", "14");
assertEval("A.y = 88;", "88");
assertActiveKeys();
}
public void accessToStaticMethodsOfClass() {
assertEval("class A {" +
"void x() {}" +
"static void y() {}" +
" }");
assertDeclareFail("A.x();",
new ExpectedDiagnostic("compiler.err.non-static.cant.be.ref", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertEval("A.y();");
assertActiveKeys();
}
public void accessToStaticFieldsOfInterface() {
assertEval("interface A {" +
"int x = 14;" +
"static int y = 18;" +
" }");
assertEval("A.x;", "14");
assertEval("A.y;", "18");
assertDeclareFail("A.x = 18;",
new ExpectedDiagnostic("compiler.err.cant.assign.val.to.final.var", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertDeclareFail("A.y = 88;",
new ExpectedDiagnostic("compiler.err.cant.assign.val.to.final.var", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
public void accessToStaticMethodsOfInterface() {
assertEval("interface A { static void x() {} }");
assertEval("A.x();");
assertActiveKeys();
}
public void finalMethod() {
assertEval("class A { final void f() {} }");
assertDeclareFail("class B extends A { void f() {} }",
new ExpectedDiagnostic("compiler.err.override.meth", 20, 31, 25, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
//TODO: is this the right semantics?
public void finalConstructor() {
assertDeclareFail("class A { final A() {} }",
new ExpectedDiagnostic("compiler.err.mod.not.allowed.here", 10, 22, 16, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
//TODO: is this the right semantics?
public void finalDefaultMethod() {
assertDeclareFail("interface A { final default void a() {} }",
new ExpectedDiagnostic("compiler.err.mod.not.allowed.here", 14, 39, 33, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
}
|
