1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
|
/*
* Copyright (c) 2013, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8009649 8129962
* @summary Lambda back-end should generate invokespecial for method handles referring to private instance methods
* @library /tools/javac/lib
* @modules jdk.jdeps/com.sun.tools.classfile
* jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.code
* jdk.compiler/com.sun.tools.javac.comp
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.tree
* jdk.compiler/com.sun.tools.javac.util
* @build combo.ComboTestHelper
* @run main TestLambdaBytecode
*/
import com.sun.tools.classfile.Attribute;
import com.sun.tools.classfile.BootstrapMethods_attribute;
import com.sun.tools.classfile.ClassFile;
import com.sun.tools.classfile.Code_attribute;
import com.sun.tools.classfile.ConstantPool.*;
import com.sun.tools.classfile.Instruction;
import com.sun.tools.classfile.Method;
import java.io.IOException;
import java.io.InputStream;
import combo.ComboInstance;
import combo.ComboParameter;
import combo.ComboTask.Result;
import combo.ComboTestHelper;
import javax.tools.JavaFileObject;
public class TestLambdaBytecode extends ComboInstance<TestLambdaBytecode> {
static final int MF_ARITY = 3;
static final String MH_SIG = "()V";
enum ClassKind implements ComboParameter {
CLASS("class"),
INTERFACE("interface");
String classStr;
ClassKind(String classStr) {
this.classStr = classStr;
}
@Override
public String expand(String optParameter) {
return classStr;
}
}
enum AccessKind implements ComboParameter {
PUBLIC("public"),
PRIVATE("private");
String accessStr;
AccessKind(String accessStr) {
this.accessStr = accessStr;
}
@Override
public String expand(String optParameter) {
return accessStr;
}
}
enum StaticKind implements ComboParameter {
STATIC("static"),
INSTANCE("");
String staticStr;
StaticKind(String staticStr) {
this.staticStr = staticStr;
}
@Override
public String expand(String optParameter) {
return staticStr;
}
}
enum DefaultKind implements ComboParameter {
DEFAULT("default"),
NO_DEFAULT("");
String defaultStr;
DefaultKind(String defaultStr) {
this.defaultStr = defaultStr;
}
@Override
public String expand(String optParameter) {
return defaultStr;
}
}
static class MethodKind {
ClassKind ck;
AccessKind ak;
StaticKind sk;
DefaultKind dk;
MethodKind(ClassKind ck, AccessKind ak, StaticKind sk, DefaultKind dk) {
this.ck = ck;
this.ak = ak;
this.sk = sk;
this.dk = dk;
}
boolean inInterface() {
return ck == ClassKind.INTERFACE;
}
boolean isPrivate() {
return ak == AccessKind.PRIVATE;
}
boolean isStatic() {
return sk == StaticKind.STATIC;
}
boolean isDefault() {
return dk == DefaultKind.DEFAULT;
}
boolean isOK() {
if (isDefault() && (!inInterface() || isStatic())) {
return false;
} else if (inInterface() &&
((!isStatic() && !isDefault()) || isPrivate())) {
return false;
} else {
return true;
}
}
}
public static void main(String... args) throws Exception {
new ComboTestHelper<TestLambdaBytecode>()
.withDimension("CLASSKIND", (x, ck) -> x.ck = ck, ClassKind.values())
.withArrayDimension("ACCESS", (x, acc, idx) -> x.accessKinds[idx] = acc, 2, AccessKind.values())
.withArrayDimension("STATIC", (x, sk, idx) -> x.staticKinds[idx] = sk, 2, StaticKind.values())
.withArrayDimension("DEFAULT", (x, dk, idx) -> x.defaultKinds[idx] = dk, 2, DefaultKind.values())
.run(TestLambdaBytecode::new, TestLambdaBytecode::init);
}
ClassKind ck;
AccessKind[] accessKinds = new AccessKind[2];
StaticKind[] staticKinds = new StaticKind[2];
DefaultKind[] defaultKinds = new DefaultKind[2];
MethodKind mk1, mk2;
void init() {
mk1 = new MethodKind(ck, accessKinds[0], staticKinds[0], defaultKinds[0]);
mk2 = new MethodKind(ck, accessKinds[1], staticKinds[1], defaultKinds[1]);
}
String source_template =
"#{CLASSKIND} Test {\n" +
" #{ACCESS[0]} #{STATIC[0]} #{DEFAULT[0]} void test() { Runnable r = ()->{ target(); }; }\n" +
" #{ACCESS[1]} #{STATIC[1]} #{DEFAULT[1]} void target() { }\n" +
"}\n";
@Override
public void doWork() throws IOException {
verifyBytecode(newCompilationTask()
.withSourceFromTemplate(source_template)
.generate());
}
void verifyBytecode(Result<Iterable<? extends JavaFileObject>> res) {
if (res.hasErrors()) {
boolean errorExpected = !mk1.isOK() || !mk2.isOK();
errorExpected |= mk1.isStatic() && !mk2.isStatic();
if (!errorExpected) {
fail("Diags found when compiling instance; " + res.compilationInfo());
}
return;
}
try (InputStream is = res.get().iterator().next().openInputStream()) {
ClassFile cf = ClassFile.read(is);
Method testMethod = null;
for (Method m : cf.methods) {
if (m.getName(cf.constant_pool).equals("test")) {
testMethod = m;
break;
}
}
if (testMethod == null) {
fail("Test method not found");
return;
}
Code_attribute ea =
(Code_attribute)testMethod.attributes.get(Attribute.Code);
if (testMethod == null) {
fail("Code attribute for test() method not found");
return;
}
int bsmIdx = -1;
for (Instruction i : ea.getInstructions()) {
if (i.getMnemonic().equals("invokedynamic")) {
CONSTANT_InvokeDynamic_info indyInfo =
(CONSTANT_InvokeDynamic_info)cf
.constant_pool.get(i.getShort(1));
bsmIdx = indyInfo.bootstrap_method_attr_index;
if (!indyInfo.getNameAndTypeInfo().getType().equals(makeIndyType())) {
fail("type mismatch for CONSTANT_InvokeDynamic_info " +
res.compilationInfo() + "\n" + indyInfo.getNameAndTypeInfo().getType() +
"\n" + makeIndyType());
return;
}
}
}
if (bsmIdx == -1) {
fail("Missing invokedynamic in generated code");
return;
}
BootstrapMethods_attribute bsm_attr =
(BootstrapMethods_attribute)cf
.getAttribute(Attribute.BootstrapMethods);
if (bsm_attr.bootstrap_method_specifiers.length != 1) {
fail("Bad number of method specifiers " +
"in BootstrapMethods attribute");
return;
}
BootstrapMethods_attribute.BootstrapMethodSpecifier bsm_spec =
bsm_attr.bootstrap_method_specifiers[0];
if (bsm_spec.bootstrap_arguments.length != MF_ARITY) {
fail("Bad number of static invokedynamic args " +
"in BootstrapMethod attribute");
return;
}
CONSTANT_MethodHandle_info mh =
(CONSTANT_MethodHandle_info)cf.constant_pool.get(bsm_spec.bootstrap_arguments[1]);
boolean kindOK;
switch (mh.reference_kind) {
case REF_invokeStatic: kindOK = mk2.isStatic(); break;
case REF_invokeSpecial: kindOK = !mk2.isStatic(); break;
case REF_invokeInterface: kindOK = mk2.inInterface(); break;
default:
kindOK = false;
}
if (!kindOK) {
fail("Bad invoke kind in implementation method handle");
return;
}
if (!mh.getCPRefInfo().getNameAndTypeInfo().getType().toString().equals(MH_SIG)) {
fail("Type mismatch in implementation method handle");
return;
}
} catch (Exception e) {
e.printStackTrace();
fail("error reading " + res.compilationInfo() + ": " + e);
}
}
String makeIndyType() {
StringBuilder buf = new StringBuilder();
buf.append("(");
if (!mk2.isStatic()) {
buf.append("LTest;");
}
buf.append(")Ljava/lang/Runnable;");
return buf.toString();
}
}
|