File: MODTools.cpp

package info (click to toggle)
libopenmpt 0.8.4-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid
  • size: 9,844 kB
  • sloc: cpp: 129,441; sh: 4,695; ansic: 1,107; makefile: 712
file content (516 lines) | stat: -rw-r--r-- 18,134 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
/*
 * MODTools.cpp
 * ------------
 * Purpose: Definition of MOD file structures (shared between several SoundTracker-/ProTracker-like formats) and helper functions
 * Notes  : (currently none)
 * Authors: OpenMPT Devs
 * The OpenMPT source code is released under the BSD license. Read LICENSE for more details.
 */


#include "stdafx.h"
#include "Loaders.h"
#include "MODTools.h"
#include "Tables.h"

OPENMPT_NAMESPACE_BEGIN

void CSoundFile::ConvertModCommand(ModCommand &m, const uint8 command, const uint8 param)
{
	static constexpr EffectCommand effTrans[] =
	{
		// MOD effects
		CMD_ARPEGGIO,     CMD_PORTAMENTOUP,     CMD_PORTAMENTODOWN, CMD_TONEPORTAMENTO,  // 0123
		CMD_VIBRATO,      CMD_TONEPORTAVOL,     CMD_VIBRATOVOL,     CMD_TREMOLO,         // 4567
		CMD_PANNING8,     CMD_OFFSET,           CMD_VOLUMESLIDE,    CMD_POSITIONJUMP,    // 89AB
		CMD_VOLUME,       CMD_PATTERNBREAK,     CMD_MODCMDEX,       CMD_TEMPO,           // CDEF
		// XM extended effects
		CMD_GLOBALVOLUME, CMD_GLOBALVOLSLIDE,   CMD_NONE,      CMD_NONE,    // GHIJ
		CMD_KEYOFF,       CMD_SETENVPOSITION,   CMD_NONE,      CMD_NONE,    // KLMN
		CMD_NONE,         CMD_PANNINGSLIDE,     CMD_NONE,      CMD_RETRIG,  // OPQR
		CMD_NONE,         CMD_TREMOR,           CMD_NONE,      CMD_NONE,    // STUV
		CMD_DUMMY,        CMD_XFINEPORTAUPDOWN, CMD_PANBRELLO, CMD_MIDI,    // WXYZ
		CMD_SMOOTHMIDI,   CMD_SMOOTHMIDI,       CMD_XPARAM,                 // \\# (BeRoTracker uses command 37 instead of 36 for smooth MIDI macros; in old OpenMPT versions this was reserved for the unimplemented "velocity" command)
	};

	m.command = CMD_NONE;
	m.param = param;
	if(command == 0x00 && param == 0x00)
	{
		m.command = CMD_NONE;
	} else if(command == 0x0F && param < 0x20)
	{
		// For a very long time (until OpenMPT 1.25.02.02), this code also imported 0x20 as CMD_SPEED for MOD files,
		// but this seems to contradict pretty much the majority of other MOD player out there.
		// 0x20 is Speed: Impulse Tracker, Scream Tracker, old ModPlug
		// 0x20 is Tempo: ProTracker, XMPlay, Imago Orpheus, Cubic Player, ChibiTracker, BeRoTracker, DigiTrakker, DigiTrekker, Disorder Tracker 2, DMP, Extreme's Tracker, ...
		m.command = CMD_SPEED;
	} else if(command < std::size(effTrans))
	{
		m.command = effTrans[command];
		if(m.command == CMD_PATTERNBREAK)
			m.param = static_cast<ModCommand::PARAM>(((m.param >> 4) * 10) + (m.param & 0x0F));
	}
}

#ifndef MODPLUG_NO_FILESAVE

void CSoundFile::ModSaveCommand(const ModCommand &source, uint8 &command, uint8 &param, const bool toXM, const bool compatibilityExport) const
{
	command = 0;
	param = source.param;
	switch(source.command)
	{
	case CMD_NONE:     command = param = 0; break;
	case CMD_ARPEGGIO: command = 0; break;
	case CMD_PORTAMENTOUP:
		command = 0x01;
		if(UseCombinedPortamentoCommands() && param >= 0xE0)
		{
			command = 0x0E;
			if(param < 0xF0)
				param = ((param & 0x0F) >> 2) | 0x10;
			else
				param = (param & 0x0F) | 0x10;
		}
		break;
	case CMD_PORTAMENTODOWN:
		command = 0x02;
		if(UseCombinedPortamentoCommands() && param >= 0xE0)
		{
			command = 0x0E;
			if(param < 0xF0)
				param = ((param & 0x0F) >> 2) | 0x20;
			else
				param = (param & 0x0F) | 0x20;
		}
		break;
	case CMD_TONEPORTAMENTO: command = 0x03; break;
	case CMD_VIBRATO:        command = 0x04; break;
	case CMD_TONEPORTAVOL:   command = 0x05; break;
	case CMD_VIBRATOVOL:     command = 0x06; break;
	case CMD_TREMOLO:        command = 0x07; break;
	case CMD_PANNING8:
		command = 0x08;
		if(GetType() & MOD_TYPE_S3M)
		{
			if(param <= 0x80)
			{
				param = mpt::saturate_cast<uint8>(param * 2);
			} else if(param == 0xA4)  // Surround
			{
				if(compatibilityExport || !toXM)
				{
					command = param = 0;
				} else
				{
					command = 'X' - 55;
					param = 91;
				}
			}
		}
		break;
	case CMD_OFFSETPERCENTAGE:
	case CMD_OFFSET:       command = 0x09; break;
	case CMD_VOLUMESLIDE:  command = 0x0A; break;
	case CMD_POSITIONJUMP: command = 0x0B; break;
	case CMD_VOLUME:       command = 0x0C; break;
	case CMD_PATTERNBREAK:
		command = 0x0D;
		param = ((param / 10) << 4) | (param % 10);
		break;
	case CMD_MODCMDEX: command = 0x0E; break;
	case CMD_SPEED:
		command = 0x0F;
		param = std::min(param, uint8(0x1F));
		break;
	case CMD_TEMPO:
		command = 0x0F;
		param = std::max(param, uint8(0x20));
		break;
	case CMD_GLOBALVOLUME:   command = 'G' - 55; break;
	case CMD_GLOBALVOLSLIDE: command = 'H' - 55; break;
	case CMD_KEYOFF:         command = 'K' - 55; break;
	case CMD_SETENVPOSITION: command = 'L' - 55; break;
	case CMD_PANNINGSLIDE:   command = 'P' - 55; break;
	case CMD_RETRIG:         command = 'R' - 55; break;
	case CMD_TREMOR:         command = 'T' - 55; break;
	case CMD_DUMMY:          command = 'W' - 55; break;
	case CMD_XFINEPORTAUPDOWN:
		command = 'X' - 55;
		if(compatibilityExport && param >= 0x30)  // X1x and X2x are legit, everything above are MPT extensions, which don't belong here.
			param = 0;                            // Don't set command to 0 to indicate that there *was* some X command here...
		break;
	case CMD_PANBRELLO:
		if(compatibilityExport)
			command = param = 0;
		else
			command = 'Y' - 55;
		break;
	case CMD_MIDI:
		if(compatibilityExport)
			command = param = 0;
		else
			command = 'Z' - 55;
		break;
	case CMD_SMOOTHMIDI:
		if(compatibilityExport)
			command = param = 0;
		else
			command = '\\' - 56;
		break;
	case CMD_XPARAM:
		if(compatibilityExport)
			command = param = 0;
		else
			command = '#' + 3;
		break;
	case CMD_S3MCMDEX:
		{
			ModCommand mConv;
			mConv.command = CMD_S3MCMDEX;
			mConv.param = param;
			mConv.ExtendedS3MtoMODEffect();
			ModSaveCommand(mConv, command, param, toXM, compatibilityExport);
		}
		return;
	case CMD_VOLUME8:
		command = 0x0C;
		param = static_cast<uint8>((param + 3u) / 4u);
		break;
	default:
		command = param = 0;
	}

	// Don't even think about saving XM effects in MODs...
	if(command > 0x0F && !toXM)
	{
		command = param = 0;
	}
}

#endif  // MODPLUG_NO_FILESAVE


// Convert an MOD sample header to OpenMPT's internal sample header.
void MODSampleHeader::ConvertToMPT(ModSample &mptSmp, bool is4Chn) const
{
	mptSmp.Initialize(MOD_TYPE_MOD);
	mptSmp.nLength = length * 2;
	mptSmp.nFineTune = MOD2XMFineTune(finetune & 0x0F);
	mptSmp.nVolume = 4u * std::min(volume.get(), uint8(64));

	SmpLength lStart = loopStart * 2;
	SmpLength lLength = loopLength * 2;
	// See if loop start is incorrect as words, but correct as bytes (like in Soundtracker modules)
	if(lLength > 2 && (lStart + lLength > mptSmp.nLength)
		&& (lStart / 2 + lLength <= mptSmp.nLength))
	{
		lStart /= 2;
	}

	if(mptSmp.nLength == 2)
	{
		mptSmp.nLength = 0;
	}

	if(mptSmp.nLength)
	{
		mptSmp.nLoopStart = lStart;
		mptSmp.nLoopEnd = lStart + lLength;

		if(mptSmp.nLoopStart >= mptSmp.nLength)
		{
			mptSmp.nLoopStart = mptSmp.nLength - 1;
		}
		if(mptSmp.nLoopStart > mptSmp.nLoopEnd || mptSmp.nLoopEnd < 4 || mptSmp.nLoopEnd - mptSmp.nLoopStart < 4)
		{
			mptSmp.nLoopStart = 0;
			mptSmp.nLoopEnd = 0;
		}

		// Fix for most likely broken sample loops. This fixes super_sufm_-_new_life.mod (M.K.) which has a long sample which is looped from 0 to 4.
		// This module also has notes outside of the Amiga frequency range, so we cannot say that it should be played using ProTracker one-shot loops.
		// On the other hand, "Crew Generation" by Necros (6CHN) has a sample with a similar loop, which is supposed to be played.
		// To be able to correctly play both modules, we will draw a somewhat arbitrary line here and trust the loop points in MODs with more than
		// 4 channels, even if they are tiny and at the very beginning of the sample.
		if(mptSmp.nLoopEnd <= 8 && mptSmp.nLoopStart == 0 && mptSmp.nLength > mptSmp.nLoopEnd && is4Chn)
		{
			mptSmp.nLoopEnd = 0;
		}
		if(mptSmp.nLoopEnd > mptSmp.nLoopStart)
		{
			mptSmp.uFlags.set(CHN_LOOP);
		}
	}
}


// Convert OpenMPT's internal sample header to a MOD sample header.
SmpLength MODSampleHeader::ConvertToMOD(const ModSample &mptSmp)
{
	SmpLength writeLength = mptSmp.HasSampleData() ? mptSmp.nLength : 0;
	// If the sample size is odd, we have to add a padding byte, as all sample sizes in MODs are even.
	if((writeLength % 2u) != 0)
	{
		writeLength++;
	}
	LimitMax(writeLength, SmpLength(0x1FFFE));

	length = static_cast<uint16>(writeLength / 2u);

	if(mptSmp.RelativeTone < 0)
	{
		finetune = 0x08;
	} else if(mptSmp.RelativeTone > 0)
	{
		finetune = 0x07;
	} else
	{
		finetune = XM2MODFineTune(mptSmp.nFineTune);
	}
	volume = static_cast<uint8>(mptSmp.nVolume / 4u);

	loopStart = 0;
	loopLength = 1;
	if(mptSmp.uFlags[CHN_LOOP] && (mptSmp.nLoopStart + 2u) < writeLength)
	{
		const SmpLength loopEnd = Clamp(mptSmp.nLoopEnd, (mptSmp.nLoopStart & ~1) + 2u, writeLength) & ~1;
		loopStart = static_cast<uint16>(mptSmp.nLoopStart / 2u);
		loopLength = static_cast<uint16>((loopEnd - (mptSmp.nLoopStart & ~1)) / 2u);
	}

	return writeLength;
}


// Compute a "rating" of this sample header by counting invalid header data to ultimately reject garbage files.
uint32 MODSampleHeader::GetInvalidByteScore() const
{
	return ((volume > 64) ? 1 : 0)
	    + ((finetune > 15) ? 1 : 0)
	    + ((loopStart > length * 2) ? 1 : 0);
}


bool MODSampleHeader::HasDiskName() const
{
	return (!memcmp(name, "st-", 3) || !memcmp(name, "ST-", 3)) && name[5] == ':';
}


uint32 ReadMODSample(const MODSampleHeader &sampleHeader, ModSample &sample, mpt::charbuf<MAX_SAMPLENAME> &sampleName, bool is4Chn)
{
	sampleHeader.ConvertToMPT(sample, is4Chn);
	sampleName = mpt::String::ReadBuf(mpt::String::spacePadded, sampleHeader.name);
	// Get rid of weird characters in sample names.
	for(auto &c : sampleName.buf)
	{
		if(c > 0 && c < ' ')
		{
			c = ' ';
		}
	}
	// Check for invalid values
	return sampleHeader.GetInvalidByteScore();
}


// Check if a name string is valid (i.e. doesn't contain binary garbage data)
uint32 CountInvalidChars(const mpt::span<const char> name) noexcept
{
	uint32 invalidChars = 0;
	for(int8 c : name)  // char can be signed or unsigned
	{
		// Check for any Extended ASCII and control characters
		if(c != 0 && c < ' ')
			invalidChars++;
	}
	return invalidChars;
}


// Check if a name is a valid null-terminated ASCII string with no garbage after the null terminator, or if it's empty
NameClassification ClassifyName(const mpt::span<const char> name) noexcept
{
	bool foundNull = false, foundNormal = false;
	for(int8 c : name)
	{
		if(c != 0 && c < ' ')
			return NameClassification::Invalid;
		if(c == 0)
			foundNull = true;
		else if(foundNull)
			return NameClassification::Invalid;
		else
			foundNormal = true;
	}
	if(!foundNull)
		return NameClassification::Invalid;
	return foundNormal ? NameClassification::ValidASCII : NameClassification::Empty;
}


// Count malformed bytes in MOD pattern data
uint32 CountMalformedMODPatternData(const MODPatternData &patternData, const bool extendedFormat)
{
	const uint8 mask = extendedFormat ? 0xE0 : 0xF0;
	uint32 malformedBytes = 0;
	for(const auto &row : patternData)
	{
		for(const auto &data : row)
		{
			if(data[0] & mask)
				malformedBytes++;
			if(!extendedFormat)
			{
				const uint16 period = (((static_cast<uint16>(data[0]) & 0x0F) << 8) | data[1]);
				if(period && period != 0xFFF)
				{
					// Allow periods to deviate by +/-1 as found in some files
					const auto CompareFunc = [](uint16 l, uint16 r) { return l > (r + 1); };
					const auto PeriodTable = mpt::as_span(ProTrackerPeriodTable).subspan(24, 36);
					if(!std::binary_search(PeriodTable.begin(), PeriodTable.end(), period, CompareFunc))
						malformedBytes += 2;
				}
			}
		}
	}
	return malformedBytes;
}


// Parse the order list to determine how many patterns are used in the file.
PATTERNINDEX GetNumPatterns(FileReader &file, CSoundFile &sndFile, ORDERINDEX numOrders, SmpLength totalSampleLen, SmpLength wowSampleLen, bool validateHiddenPatterns)
{
	ModSequence &Order = sndFile.Order();
	PATTERNINDEX numPatterns = 0;         // Total number of patterns in file (determined by going through the whole order list) with pattern number < 128
	PATTERNINDEX officialPatterns = 0;    // Number of patterns only found in the "official" part of the order list (i.e. order positions < claimed order length)
	PATTERNINDEX numPatternsIllegal = 0;  // Total number of patterns in file, also counting in "invalid" pattern indexes >= 128

	for(ORDERINDEX ord = 0; ord < 128; ord++)
	{
		PATTERNINDEX pat = Order[ord];
		if(pat < 128 && numPatterns <= pat)
		{
			numPatterns = pat + 1;
			if(ord < numOrders)
			{
				officialPatterns = numPatterns;
			}
		}
		if(pat >= numPatternsIllegal)
		{
			numPatternsIllegal = pat + 1;
		}
	}

	// Remove the garbage patterns past the official order end now that we don't need them anymore.
	Order.resize(numOrders);

	const size_t patternStartOffset = file.GetPosition();
	const size_t sizeWithoutPatterns = totalSampleLen + patternStartOffset;
	const size_t sizeWithOfficialPatterns = sizeWithoutPatterns + officialPatterns * sndFile.GetNumChannels() * 256;
	// There are some WOW files with an extra byte at the end, and also a MOD file (idntmind.mod, MD5 a3af5c3e1af269e32dfb6677c41c8453, SHA1 4884717c298575f9884b2211c762bb1725f73743)
	// where only the "official" patterns should be counted but the file also has an extra byte at the end.
	// Since MOD files can technically not have an odd file size, we just always round the actual file size down.
	const auto fileSize = mpt::align_down(file.GetLength(), FileReader::pos_type{2});

	if(wowSampleLen && (wowSampleLen + patternStartOffset) + numPatterns * 8 * 256 == fileSize)
	{
		// Check if this is a Mod's Grave WOW file... WOW files use the M.K. magic but are actually 8CHN files.
		// We do a simple pattern validation as well for regular MOD files that have non-module data attached at the end
		// (e.g. ponylips.mod, MD5 c039af363b1d99a492dafc5b5f9dd949, SHA1 1bee1941c47bc6f913735ce0cf1880b248b8fc93)
		file.Seek(patternStartOffset + numPatterns * 4 * 256);
		if(ValidateMODPatternData(file, 16, true))
			sndFile.ChnSettings.resize(8);
		file.Seek(patternStartOffset);
	} else if(numPatterns != officialPatterns && (validateHiddenPatterns || sizeWithOfficialPatterns == fileSize))
	{
		// 15-sample SoundTracker specifics:
		// Fix SoundTracker modules where "hidden" patterns should be ignored.
		// razor-1911.mod (MD5 b75f0f471b0ae400185585ca05bf7fe8, SHA1 4de31af234229faec00f1e85e1e8f78f405d454b)
		// and captain_fizz.mod (MD5 55bd89fe5a8e345df65438dbfc2df94e, SHA1 9e0e8b7dc67939885435ea8d3ff4be7704207a43)
		// seem to have the "correct" file size when only taking the "official" patterns into account,
		// but they only play correctly when also loading the inofficial patterns.
		// On the other hand, the SoundTracker module
		// wolf1.mod (MD5 a4983d7a432d324ce8261b019257f4ed, SHA1 aa6b399d02546bcb6baf9ec56a8081730dea3f44),
		// wolf3.mod (MD5 af60840815aa9eef43820a7a04417fa6, SHA1 24d6c2e38894f78f6c5c6a4b693a016af8fa037b)
		// and jean_baudlot_-_bad_dudes_vs_dragonninja-dragonf.mod (MD5 fa48e0f805b36bdc1833f6b82d22d936, SHA1 39f2f8319f4847fe928b9d88eee19d79310b9f91)
		// only play correctly if we ignore the hidden patterns.
		// Hence, we have a peek at the first hidden pattern and check if it contains a lot of illegal data.
		// If that is the case, we assume it's part of the sample data and only consider the "official" patterns.

		// 31-sample NoiseTracker / ProTracker specifics:
		// Interestingly, (broken) variants of the ProTracker modules
		// "killing butterfly" (MD5 bd676358b1dbb40d40f25435e845cf6b, SHA1 9df4ae21214ff753802756b616a0cafaeced8021),
		// "quartex" by Reflex (MD5 35526bef0fb21cb96394838d94c14bab, SHA1 116756c68c7b6598dcfbad75a043477fcc54c96c),
		// seem to have the "correct" file size when only taking the "official" patterns into account, but they only play
		// correctly when also loading the inofficial patterns.
		// On the other hand, "Shofixti Ditty.mod" from Star Control 2 (MD5 62b7b0819123400e4d5a7813eef7fc7d, SHA1 8330cd595c61f51c37a3b6f2a8559cf3fcaaa6e8)
		// doesn't sound correct when taking the second "inofficial" pattern into account.
		file.Seek(patternStartOffset + officialPatterns * sndFile.GetNumChannels() * 256);
		if(!ValidateMODPatternData(file, 64, true))
			numPatterns = officialPatterns;
		file.Seek(patternStartOffset);
	}

	if(numPatternsIllegal > numPatterns && sizeWithoutPatterns + numPatternsIllegal * sndFile.GetNumChannels() * 256 == fileSize)
	{
		// Even those illegal pattern indexes (> 128) appear to be valid... What a weird file!
		// e.g. NIETNU.MOD, where the end of the order list is filled with FF rather than 00, and the file actually contains 256 patterns.
		numPatterns = numPatternsIllegal;
	} else if(numPatternsIllegal >= 0xFF)
	{
		// Patterns FE and FF are used with S3M semantics (e.g. some MODs written with old OpenMPT versions)
		Order.Replace(0xFE, PATTERNINDEX_SKIP);
		Order.Replace(0xFF, PATTERNINDEX_INVALID);
	}

	return numPatterns;
}


std::pair<uint8, uint8> CSoundFile::ReadMODPatternEntry(FileReader &file, ModCommand &m)
{
	return ReadMODPatternEntry(file.ReadArray<uint8, 4>(), m);
}


std::pair<uint8, uint8> CSoundFile::ReadMODPatternEntry(const std::array<uint8, 4> data, ModCommand &m)
{
	// Read Period
	uint16 period = (((static_cast<uint16>(data[0]) & 0x0F) << 8) | data[1]);
	size_t note = NOTE_NONE;
	if(period > 0 && period != 0xFFF)
	{
		note = std::size(ProTrackerPeriodTable) + 23 + NOTE_MIN;
		for(size_t i = 0; i < std::size(ProTrackerPeriodTable); i++)
		{
			if(period >= ProTrackerPeriodTable[i])
			{
				if(period != ProTrackerPeriodTable[i] && i != 0)
				{
					uint16 p1 = ProTrackerPeriodTable[i - 1];
					uint16 p2 = ProTrackerPeriodTable[i];
					if(p1 - period < (period - p2))
					{
						note = i + 23 + NOTE_MIN;
						break;
					}
				}
				note = i + 24 + NOTE_MIN;
				break;
			}
		}
	}
	m.note = static_cast<ModCommand::NOTE>(note);
	// Read Instrument
	m.instr = (data[2] >> 4) | (data[0] & 0x10);
	// Read Effect
	m.command = CMD_NONE;
	uint8 command = data[2] & 0x0F, param = data[3];
	return {command, param};
}

OPENMPT_NAMESPACE_END