1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
|
#include "catch.hpp"
#include "utils.hpp"
#include <osmium/io/file.hpp>
#include <osmium/io/xml_input.hpp>
#include <osmium/osm/relation.hpp>
#include <osmium/relations/relations_manager.hpp>
#include <osmium/visitor.hpp>
#include <cstdlib>
#include <iterator>
struct EmptyRM : public osmium::relations::RelationsManager<EmptyRM, true, true, true> {
};
struct TestRM : public osmium::relations::RelationsManager<TestRM, true, true, true> {
std::size_t count_new_rels = 0;
std::size_t count_new_members = 0;
std::size_t count_complete_rels = 0;
std::size_t count_before = 0;
std::size_t count_not_in_any = 0;
std::size_t count_after = 0;
bool new_relation(const osmium::Relation& /*relation*/) noexcept {
++count_new_rels;
return true;
}
bool new_member(const osmium::Relation& /*relation*/, const osmium::RelationMember& /*member*/, std::size_t /*n*/) noexcept {
++count_new_members;
return true;
}
void complete_relation(const osmium::Relation& /*relation*/) noexcept {
++count_complete_rels;
}
void before_node(const osmium::Node& /*node*/) noexcept {
++count_before;
}
void node_not_in_any_relation(const osmium::Node& /*node*/) noexcept {
++count_not_in_any;
}
void after_node(const osmium::Node& /*node*/) noexcept {
++count_after;
}
void before_way(const osmium::Way& /*way*/) noexcept {
++count_before;
}
void way_not_in_any_relation(const osmium::Way& /*way*/) noexcept {
++count_not_in_any;
}
void after_way(const osmium::Way& /*way*/) noexcept {
++count_after;
}
void before_relation(const osmium::Relation& /*relation*/) noexcept {
++count_before;
}
void relation_not_in_any_relation(const osmium::Relation& /*relation*/) noexcept {
++count_not_in_any;
}
void after_relation(const osmium::Relation& /*relation*/) noexcept {
++count_after;
}
};
struct CallbackRM : public osmium::relations::RelationsManager<CallbackRM, true, false, false> {
std::size_t count_nodes = 0;
static bool new_relation(const osmium::Relation& /*relation*/) noexcept {
return true;
}
static bool new_member(const osmium::Relation& /*relation*/, const osmium::RelationMember& member, std::size_t /*n*/) noexcept {
return member.type() == osmium::item_type::node;
}
void complete_relation(const osmium::Relation& relation) {
for (const auto& member : relation.members()) {
if (member.type() == osmium::item_type::node) {
++count_nodes;
const auto* node = get_member_node(member.ref());
REQUIRE(node);
buffer().add_item(*node);
buffer().commit();
}
}
}
};
struct AnyRM : public osmium::relations::RelationsManager<AnyRM, true, true, true> {
static bool new_relation(const osmium::Relation& /*relation*/) noexcept {
return true;
}
static bool new_member(const osmium::Relation& /*relation*/, const osmium::RelationMember& /*member*/, std::size_t /*n*/) noexcept {
return true;
}
};
TEST_CASE("Use RelationsManager without any overloaded functions in derived class") {
const osmium::io::File file{with_data_dir("t/relations/data.osm")};
EmptyRM manager;
osmium::relations::read_relations(file, manager);
REQUIRE(manager.member_nodes_database().size() == 2);
REQUIRE(manager.member_ways_database().size() == 2);
REQUIRE(manager.member_relations_database().size() == 1);
REQUIRE(manager.member_database(osmium::item_type::node).size() == 2);
REQUIRE(manager.member_database(osmium::item_type::way).size() == 2);
REQUIRE(manager.member_database(osmium::item_type::relation).size() == 1);
const auto& m = manager;
REQUIRE(m.member_database(osmium::item_type::node).size() == 2);
REQUIRE(m.member_database(osmium::item_type::way).size() == 2);
REQUIRE(m.member_database(osmium::item_type::relation).size() == 1);
osmium::io::Reader reader{file};
osmium::apply(reader, manager.handler());
reader.close();
}
TEST_CASE("Relations manager derived class") {
const osmium::io::File file{with_data_dir("t/relations/data.osm")};
TestRM manager;
osmium::relations::read_relations(file, manager);
REQUIRE(manager.member_nodes_database().size() == 2);
REQUIRE(manager.member_ways_database().size() == 2);
REQUIRE(manager.member_relations_database().size() == 1);
bool callback_called = false;
osmium::io::Reader reader{file};
osmium::apply(reader, manager.handler([&](osmium::memory::Buffer&& /*unused*/) {
callback_called = true;
}));
reader.close();
REQUIRE_FALSE(callback_called);
REQUIRE(manager.count_new_rels == 3);
REQUIRE(manager.count_new_members == 5);
REQUIRE(manager.count_complete_rels == 2);
REQUIRE(manager.count_before == 10);
REQUIRE(manager.count_not_in_any == 6);
REQUIRE(manager.count_after == 10);
int n = 0;
manager.for_each_incomplete_relation([&](const osmium::relations::RelationHandle& handle){
++n;
REQUIRE(handle->id() == 31);
for (const auto& member : handle->members()) {
const auto* obj = manager.get_member_object(member);
if (member.ref() == 22) {
REQUIRE_FALSE(obj);
} else {
REQUIRE(obj);
}
}
});
REQUIRE(n == 1);
}
TEST_CASE("Relations manager with callback") {
const osmium::io::File file{with_data_dir("t/relations/data.osm")};
CallbackRM manager;
osmium::relations::read_relations(file, manager);
REQUIRE(manager.member_nodes_database().size() == 2);
REQUIRE(manager.member_ways_database().size() == 0);
REQUIRE(manager.member_relations_database().size() == 0);
bool callback_called = false;
osmium::io::Reader reader{file};
osmium::apply(reader, manager.handler([&](osmium::memory::Buffer&& buffer) {
callback_called = true;
REQUIRE(std::distance(buffer.begin(), buffer.end()) == 2);
}));
reader.close();
REQUIRE(manager.count_nodes == 2);
REQUIRE(callback_called);
}
TEST_CASE("Relations manager reading buffer without callback") {
const osmium::io::File file{with_data_dir("t/relations/data.osm")};
CallbackRM manager;
osmium::relations::read_relations(file, manager);
REQUIRE(manager.member_nodes_database().size() == 2);
REQUIRE(manager.member_ways_database().size() == 0);
REQUIRE(manager.member_relations_database().size() == 0);
osmium::io::Reader reader{file};
osmium::apply(reader, manager.handler());
reader.close();
auto buffer = manager.read();
REQUIRE(std::distance(buffer.begin(), buffer.end()) == 2);
REQUIRE(manager.count_nodes == 2);
}
TEST_CASE("Access members via RelationsManager") {
EmptyRM manager;
manager.prepare_for_lookup();
REQUIRE(nullptr == manager.get_member_node(0));
REQUIRE(nullptr == manager.get_member_way(0));
REQUIRE(nullptr == manager.get_member_relation(0));
REQUIRE(nullptr == manager.get_member_node(17));
REQUIRE(nullptr == manager.get_member_way(17));
REQUIRE(nullptr == manager.get_member_relation(17));
}
TEST_CASE("Handle duplicate members correctly") {
const osmium::io::File file{with_data_dir("t/relations/dupl_member.osm")};
TestRM manager;
osmium::relations::read_relations(file, manager);
auto c = manager.member_nodes_database().count();
REQUIRE(c.tracked == 5);
REQUIRE(c.available == 0);
REQUIRE(c.removed == 0);
osmium::io::Reader reader{file};
osmium::apply(reader, manager.handler());
reader.close();
c = manager.member_nodes_database().count();
REQUIRE(c.tracked == 0);
REQUIRE(c.available == 0);
REQUIRE(c.removed == 5);
REQUIRE(manager.count_new_rels == 2);
REQUIRE(manager.count_new_members == 5);
REQUIRE(manager.count_complete_rels == 2);
REQUIRE(manager.count_not_in_any == 2); // 2 relations
}
TEST_CASE("Check handling of missing members") {
const osmium::io::File file{with_data_dir("t/relations/missing_members.osm")};
AnyRM manager;
osmium::relations::read_relations(file, manager);
osmium::io::Reader reader{file};
osmium::apply(reader, manager.handler());
reader.close();
size_t nodes = 0;
size_t ways = 0;
size_t relations = 0;
size_t missing_nodes = 0;
size_t missing_ways = 0;
size_t missing_relations = 0;
manager.for_each_incomplete_relation([&](const osmium::relations::RelationHandle& handle){
if (handle->id() != 31) {
// count relation 31 only
return;
}
for (const auto& member : handle->members()) {
// RelationMember::ref() is supposed to returns 0 if we are interested in the member.
// RelationsManagerBase::get_member_object() is supposed to return a nullptr if the
// member is not available (missing in the input file).
const osmium::OSMObject* object = manager.get_member_object(member);
switch (member.type()) {
case osmium::item_type::node :
++nodes;
if (member.ref() != 0 && !object) {
++missing_nodes;
}
break;
case osmium::item_type::way :
++ways;
if (member.ref() != 0 && !object) {
++missing_ways;
}
break;
case osmium::item_type::relation :
++relations;
if (member.ref() != 0 && !object) {
++missing_relations;
}
break;
default:
break;
}
}
});
REQUIRE(nodes == 2);
REQUIRE(ways == 3);
REQUIRE(relations == 3);
REQUIRE(missing_nodes == 1);
REQUIRE(missing_ways == 1);
REQUIRE(missing_relations == 2);
}
|
