1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
|
## name Assignment and op-assignment
## failures 3
## cut
@bar = map {$_ = 1} @foo;
@bar = map {$_ *= 2} @foo;
@bar = map {$_++} @foo;
#-----------------------------------------------------------------------------
## name ++ and -- operators
## failures 2
## cut
@bar = map {++$_} @foo;
@bar = map {--$_} @foo;
#-----------------------------------------------------------------------------
## name Explicit regexes
## failures 3
## cut
@bar = map {$_ =~ s/f/g/} @foo;
@bar = map {$_ =~ tr/f/g/} @foo;
@bar = map {$_ =~ y/f/g/} @foo;
#-----------------------------------------------------------------------------
## name Simple implicit regexps
## failures 3
## cut
@bar = map {s/f/g/} @foo;
@bar = map {tr/f/g/} @foo;
@bar = map {y/f/g/} @foo;
#-----------------------------------------------------------------------------
## name "Hidden" implicit regexps
## failures 3
## cut
@bar = map {my $c = s/f/g/g; $c} @foo;
@bar = map {my $c = tr/f/g/g; $c} @foo;
@bar = map {my $c = y/f/g/g; $c} @foo;
#-----------------------------------------------------------------------------
## name Implicit chomp-ish builtins
## failures 2
## cut
@bar = map {chop} @foo;
@bar = map {chomp} @foo;
@bar = map {undef} @foo;
#-----------------------------------------------------------------------------
## name Explicit chomp-ish builtins
## failures 3
## cut
@bar = map {chop $_} @foo;
@bar = map {chomp $_} @foo;
@bar = map {undef $_} @foo;
#-----------------------------------------------------------------------------
## name substr
## failures 1
## cut
@bar = map {substr $_, 0, 1, 'f'} @foo;
#-----------------------------------------------------------------------------
## name Non-mutators
## failures 0
## cut
@bar = map {$_} @foo;
@bar = map {$_ => 1} @foo;
@bar = map {m/4/} @foo;
@bar = map {my $s=$_; chomp $s; $s} @foo;
#-----------------------------------------------------------------------------
## name Value given for list_funcs passing
## failures 0
## parms {list_funcs => ' foo bar '}
## cut
@bar = map {$_=1} @foo;
@bar = foo {$_} @foo;
@bar = baz {$_=1} @foo;
#-----------------------------------------------------------------------------
## name Value given for list_funcs failure
## failures 1
## parms {list_funcs => ' foo bar '}
## cut
@bar = foo {$_=1} @foo;
#-----------------------------------------------------------------------------
## name Value given for add_list_funcs
## failures 2
## parms {add_list_funcs => ' foo bar '}
## cut
@bar = map {$_=1} @foo;
@bar = foo {$_=1} @foo;
#-----------------------------------------------------------------------------
##############################################################################
# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/t/ControlStructures/ProhibitMutatingListFunctions.run $
# $Date: 2008-03-16 17:40:45 -0500 (Sun, 16 Mar 2008) $
# $Author: clonezone $
# $Revision: 2187 $
##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
