1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
|
## name Basic failure
## failures 6
## cut
do_something() if $condition;
do_something() while $condition;
do_something() until $condition;
do_something() unless $condition;
do_something() for @list;
do_something() foreach @list;
#-----------------------------------------------------------------------------
## name Configured to allow all
## failures 0
## parms {allow => 'if while until unless for foreach'}
## cut
do_something() if $condition;
do_something() while $condition;
do_something() until $condition;
do_something() unless $condition;
do_something() for @list;
do_something() foreach @list;
#-----------------------------------------------------------------------------
## name Configured to allow all, all regular control structures
## failures 0
## parms {allow => 'if unless until while'}
## cut
if($condition){ do_something() }
while($condition){ do_something() }
until($condition){ do_something() }
unless($condition){ do_something() }
#-----------------------------------------------------------------------------
## name Regular for loops
## failures 0
## cut
#PPI versions < 1.03 had problems with this
for my $element (@list){ do_something() }
for (@list){ do_something_else() }
foreach my $element (@list){ do_something() }
foreach (@list){ do_something_else() }
#-----------------------------------------------------------------------------
## name Legal postfix usage
## failures 0
## cut
use Carp;
while ($condition) {
next if $condition;
last if $condition;
redo if $condition;
return if $condition;
goto HELL if $condition;
exit if $condition;
}
die 'message' if $condition;
die if $condition;
warn 'message' if $condition;
warn if $condition;
carp 'message' if $condition;
carp if $condition;
croak 'message' if $condition;
croak if $condition;
cluck 'message' if $condition;
cluck if $condition;
confess 'message' if $condition;
confess if $condition;
exit 0 if $condition;
exit if $condition;
#-----------------------------------------------------------------------------
## name override exempt flowcontrols
## failures 0
## parms {flowcontrol => 'assert'}
## cut
use Carp::Assert;
assert $something if $condition;
#-----------------------------------------------------------------------------
## name overriding exempt flowcontrols restores the defaults
## failures 8
## parms {flowcontrol => 'assert'}
## cut
use Carp::Assert;
warn $something if $condition;
die $something if $condition;
carp $something if $condition;
croak $something if $condition;
cluck $something if $condition;
confess $something if $condition;
exit $something if $condition;
do_something() if $condition;
#-----------------------------------------------------------------------------
## name Individual "keyword" hash assignment
## failures 0
## cut
my %hash;
$hash{if} = 1;
$hash{unless} = 1;
$hash{until} = 1;
$hash{while} = 1;
$hash{for} = 1;
$hash{foreach} = 1;
#-----------------------------------------------------------------------------
## name "Keyword"-list hash assignment
## failures 0
## cut
my %hash = (
if => 1,
unless => 1,
until => 1,
while => 1,
for => 1,
foreach => 1,
);
#-----------------------------------------------------------------------------
##############################################################################
# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/t/ControlStructures/ProhibitPostfixControls.run $
# $Date: 2008-03-16 17:40:45 -0500 (Sun, 16 Mar 2008) $
# $Author: clonezone $
# $Revision: 2187 $
##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
