1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
|
##############################################################################
# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/t/Subroutines/RequireArgUnpacking.run $
# $Date: 2008-03-16 17:40:45 -0500 (Sun, 16 Mar 2008) $
# $Author: clonezone $
# $Revision: 2187 $
##############################################################################
## name basic passes
## failures 0
## cut
sub forward;
sub foo {
my ($self, $bar) = @_;
print $bar;
return;
}
sub fu {
my $self = shift;
my $bar = shift;
print $bar;
return;
}
#-----------------------------------------------------------------------------
## name prototype passes
## failures 0
## cut
sub foo() {
print $bar;
return;
}
#-----------------------------------------------------------------------------
## name scheduled subs
## failures 0
## cut
BEGIN {
print 1;
print 2;
print 3;
}
INIT {
print 1;
print 2;
print 3;
}
CHECK {
print 1;
print 2;
print 3;
}
END {
print 1;
print 2;
print 3;
}
#-----------------------------------------------------------------------------
## name passes - no arguments
## failures 0
## cut
sub few { }
sub phu { 1; }
sub phoo { return; }
#-----------------------------------------------------------------------------
## name failure - not idiomatic enough
## failures 2
## cut
sub quux {
my $self = shift @_;
print $self;
}
sub cwux {
my ($self) = ($_[0]);
print $self;
}
#-----------------------------------------------------------------------------
## name basic failures
## failures 2
## cut
sub bar {
print $_[0];
print $_[1];
print $_[2];
print $_[3];
}
sub barr {
print $_[1];
}
#-----------------------------------------------------------------------------
## name failure in an anonymous sub
## failures 1
## TODO PPI v1.118 doesn't recognize anonymous subroutines
## cut
my $x = bar {
print $_[0];
print $_[1];
print $_[2];
print $_[3];
}
#-----------------------------------------------------------------------------
## name basic failures, set config higher
## failures 1
## parms {short_subroutine_statements => 1}
## cut
sub bar {
print $_[0];
print $_[1];
print $_[2];
print $_[3];
}
sub barr {
print $_[1];
}
#-----------------------------------------------------------------------------
## name mixed failures
## failures 2
## cut
sub baz {
my $self = shift;
print $_[0];
print $_[1];
print $_[2];
print $_[3];
}
sub baaz {
my ($self) = @_;
print $_[0];
print $_[1];
print $_[2];
print $_[3];
}
#-----------------------------------------------------------------------------
## name nested anon sub
## failures 0
## cut
sub baz {
print "here\n";
return sub {
my ($self) = @_;
print $self->{bar};
};
}
#-----------------------------------------------------------------------------
## name nested name sub
## failures 0
## cut
sub baz {
print "here\n";
sub bar {
my ($self) = @_;
print $self->{bar};
}
$x->bar();
}
#-----------------------------------------------------------------------------
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
