1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
## name Basic failures
## failures 15
## cut
our $var1 = 'foo';
our (%var2, %var3) = 'foo';
our (%VAR4, $var5) = ();
$Package::foo;
@Package::list = ('nuts');
%Package::hash = ('nuts');
$::foo = $bar;
@::foo = ($bar);
%::foo = ();
use vars qw($fooBar $baz);
use vars qw($fooBar @EXPORT);
use vars '$fooBar', "$baz";
use vars '$fooBar', '@EXPORT';
use vars ('$fooBar', '$baz');
use vars ('$fooBar', '@EXPORT');
#-----------------------------------------------------------------------------
## name Basic passes - our
## failures 0
## cut
our $VAR1 = 'foo';
our (%VAR2, %VAR3) = ();
our $VERSION = '1.0';
our @EXPORT = qw(some symbols);
#-----------------------------------------------------------------------------
## name Basic passes - use vars
## failures 0
## cut
use vars qw($VERSION @EXPORT);
use vars ('$VERSION, '@EXPORT');
use vars '$VERSION, '@EXPORT';
use vars '+foo'; #Illegal, but not a violaton
#-----------------------------------------------------------------------------
## name Basic passes - symbols
## failures 0
## cut
#local $Foo::bar;
#local @This::that;
#local %This::that;
#local $This::that{ 'key' };
#local $This::that[ 1 ];
#local (@Baz::bar, %Baz::foo);
$Package::VERSION = '1.2';
%Package::VAR = ('nuts');
@Package::EXPORT = ();
$::VERSION = '1.2';
%::VAR = ('nuts');
@::EXPORT = ();
&Package::my_sub();
&::my_sub();
*foo::glob = $code_ref;
#-----------------------------------------------------------------------------
## name Lexicals should pass
## failures 0
## cut
my $var1 = 'foo';
my %var2 = 'foo';
my ($foo, $bar) = ();
#-----------------------------------------------------------------------------
## name Default package exceptions
## failures 0
## cut
use File::Find;
print $File::Find::dir;
use Data::Dumper;
$Data::Dumper::Indent = 1;
use File::Spec::Functions qw< catdir >;
use lib catdir( $FindBin::Bin, qw< .. lib perl5 > );
local $Log::Log4perl::caller_depth = $Log::Log4perl::caller_depth + 1;
#-----------------------------------------------------------------------------
## name Add to default exceptions
## parms {add_packages => 'Addl::Package'}
## failures 3
## cut
use File::Find;
print $File::Find::dir;
$Addl::Package::bar = 27;
$Addl::Other::wango = 9;
$Addl::Other::tango = 9;
$Addl::Other::bango = 9;
#-----------------------------------------------------------------------------
## name Override default package exceptions
## parms {add_packages => 'Incorrect::Override::Package'}
## failures 2
## cut
use File::Find;
print $File::Find::dir;
$Override::Defaults::wango = $x;
$Override::Defaults::tango = 47;
#-----------------------------------------------------------------------------
## name Override default package exceptions, null package
## parms {add_packages => 'Incorrect::Override::Package'}
## failures 1
## cut
$::foo = 1;
#-----------------------------------------------------------------------------
##############################################################################
# $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/distributions/Perl-Critic/t/Variables/ProhibitPackageVars.run $
# $Date: 2009-02-21 13:12:42 -0600 (Sat, 21 Feb 2009) $
# $Author: clonezone $
# $Revision: 3150 $
##############################################################################
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 78
# indent-tabs-mode: nil
# c-indentation-style: bsd
# End:
# ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :
|
